Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
9c300fd9
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
9c300fd9
编写于
9月 14, 2017
作者:
B
Bob Van Landuyt
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Use the new query-recorder features as a PoC
上级
6dbd21ab
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
5 addition
and
5 deletion
+5
-5
spec/features/milestones/show_spec.rb
spec/features/milestones/show_spec.rb
+2
-2
spec/requests/api/projects_spec.rb
spec/requests/api/projects_spec.rb
+3
-3
未找到文件。
spec/features/milestones/show_spec.rb
浏览文件 @
9c300fd9
...
@@ -18,9 +18,9 @@ describe 'Milestone show' do
...
@@ -18,9 +18,9 @@ describe 'Milestone show' do
it
'avoids N+1 database queries'
do
it
'avoids N+1 database queries'
do
create
(
:labeled_issue
,
issue_params
)
create
(
:labeled_issue
,
issue_params
)
control
_count
=
ActiveRecord
::
QueryRecorder
.
new
{
visit_milestone
}.
count
control
=
ActiveRecord
::
QueryRecorder
.
new
{
visit_milestone
}
create_list
(
:labeled_issue
,
10
,
issue_params
)
create_list
(
:labeled_issue
,
10
,
issue_params
)
expect
{
visit_milestone
}.
not_to
exceed_query_limit
(
control
_count
)
expect
{
visit_milestone
}.
not_to
exceed_query_limit
(
control
)
end
end
end
end
spec/requests/api/projects_spec.rb
浏览文件 @
9c300fd9
...
@@ -54,9 +54,9 @@ describe API::Projects do
...
@@ -54,9 +54,9 @@ describe API::Projects do
shared_examples_for
'projects response without N + 1 queries'
do
shared_examples_for
'projects response without N + 1 queries'
do
it
'avoids N + 1 queries'
do
it
'avoids N + 1 queries'
do
control
_count
=
ActiveRecord
::
QueryRecorder
.
new
do
control
=
ActiveRecord
::
QueryRecorder
.
new
do
get
api
(
'/projects'
,
current_user
)
get
api
(
'/projects'
,
current_user
)
end
.
count
end
if
defined?
(
additional_project
)
if
defined?
(
additional_project
)
additional_project
additional_project
...
@@ -66,7 +66,7 @@ describe API::Projects do
...
@@ -66,7 +66,7 @@ describe API::Projects do
expect
do
expect
do
get
api
(
'/projects'
,
current_user
)
get
api
(
'/projects'
,
current_user
)
end
.
not_to
exceed_query_limit
(
control
_count
+
8
)
end
.
not_to
exceed_query_limit
(
control
).
with_threshold
(
8
)
end
end
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录