Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
97ca4f5d
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
97ca4f5d
编写于
6月 15, 2012
作者:
R
Robb Kidd
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Deliver issue mails.
It helps to actually deliver messages.
上级
dfb5da9d
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
19 addition
and
7 deletion
+19
-7
app/models/issue_observer.rb
app/models/issue_observer.rb
+2
-2
spec/models/issue_observer_spec.rb
spec/models/issue_observer_spec.rb
+17
-5
未找到文件。
app/models/issue_observer.rb
浏览文件 @
97ca4f5d
...
...
@@ -2,7 +2,7 @@ class IssueObserver < ActiveRecord::Observer
cattr_accessor
:current_user
def
after_create
(
issue
)
Notify
.
new_issue_email
(
issue
.
id
)
if
issue
.
assignee
!=
current_user
Notify
.
new_issue_email
(
issue
.
id
)
.
deliver
if
issue
.
assignee
!=
current_user
end
def
after_update
(
issue
)
...
...
@@ -15,7 +15,7 @@ class IssueObserver < ActiveRecord::Observer
recipient_ids
=
[
issue
.
assignee_id
,
issue
.
assignee_id_was
].
keep_if
{
|
id
|
id
!=
current_user
.
id
}
recipient_ids
.
each
do
|
recipient_id
|
Notify
.
reassigned_issue_email
(
recipient_id
,
issue
.
id
,
issue
.
assignee_id_was
)
Notify
.
reassigned_issue_email
(
recipient_id
,
issue
.
id
,
issue
.
assignee_id_was
)
.
deliver
end
end
end
spec/models/issue_observer_spec.rb
浏览文件 @
97ca4f5d
...
...
@@ -20,7 +20,8 @@ describe IssueObserver do
end
it
'sends an email to the assignee'
do
Notify
.
should_receive
(
:new_issue_email
).
with
(
issue
.
id
)
Notify
.
should_receive
(
:new_issue_email
).
with
(
issue
.
id
).
and_return
(
double
(
:deliver
=>
true
))
subject
.
after_create
(
issue
)
end
...
...
@@ -107,9 +108,18 @@ describe IssueObserver do
issue
.
stub
(
:assignee_id_was
).
and_return
(
previous_assignee
.
id
)
end
def
it_sends_a_reassigned_email_to
(
recipient
)
Notify
.
should_receive
(
:reassigned_issue_email
).
with
(
recipient
,
issue
.
id
,
previous_assignee
.
id
).
and_return
(
double
(
:deliver
=>
true
))
end
def
it_does_not_send_a_reassigned_email_to
(
recipient
)
Notify
.
should_not_receive
(
:reassigned_issue_email
).
with
(
recipient
,
issue
.
id
,
previous_assignee
.
id
)
end
it
'sends a reassigned email to the previous and current assignees'
do
Notify
.
should_receive
(
:reassigned_issue_email
).
with
(
assignee
.
id
,
issue
.
id
,
previous_assignee
.
id
)
Notify
.
should_receive
(
:reassigned_issue_email
).
with
(
previous_assignee
.
id
,
issue
.
id
,
previous_assignee
.
id
)
it_sends_a_reassigned_email_to
assignee
.
id
it_sends_a_reassigned_email_to
previous_assignee
.
id
subject
.
send_reassigned_email
(
issue
)
end
...
...
@@ -117,13 +127,15 @@ describe IssueObserver do
context
'does not send an email to the user who made the reassignment'
do
it
'if the user is the assignee'
do
subject
.
stub
(
:current_user
).
and_return
(
assignee
)
Notify
.
should_not_receive
(
:reassigned_issue_email
).
with
(
assignee
.
id
,
issue
.
id
,
previous_assignee
.
id
)
it_sends_a_reassigned_email_to
previous_assignee
.
id
it_does_not_send_a_reassigned_email_to
assignee
.
id
subject
.
send_reassigned_email
(
issue
)
end
it
'if the user is the previous assignee'
do
subject
.
stub
(
:current_user
).
and_return
(
previous_assignee
)
Notify
.
should_not_receive
(
:reassigned_issue_email
).
with
(
previous_assignee
.
id
,
issue
.
id
,
previous_assignee
.
id
)
it_sends_a_reassigned_email_to
assignee
.
id
it_does_not_send_a_reassigned_email_to
previous_assignee
.
id
subject
.
send_reassigned_email
(
issue
)
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录