Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
934e9497
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
934e9497
编写于
4月 01, 2017
作者:
S
Shinya Maeda
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix rubocop issues. Use add_concurrent_foreign_key.
上级
62480461
变更
6
隐藏空白更改
内联
并排
Showing
6 changed file
with
15 addition
and
18 deletion
+15
-18
app/validators/cron_validator.rb
app/validators/cron_validator.rb
+0
-1
db/migrate/20170329095325_add_ref_to_triggers.rb
db/migrate/20170329095325_add_ref_to_triggers.rb
+0
-4
db/migrate/20170329095907_create_ci_trigger_schedules.rb
db/migrate/20170329095907_create_ci_trigger_schedules.rb
+9
-6
db/schema.rb
db/schema.rb
+1
-1
lib/ci/cron_parser.rb
lib/ci/cron_parser.rb
+5
-5
spec/models/ci/trigger_schedule_spec.rb
spec/models/ci/trigger_schedule_spec.rb
+0
-1
未找到文件。
app/validators/cron_validator.rb
浏览文件 @
934e9497
...
...
@@ -5,7 +5,6 @@ class CronValidator < ActiveModel::EachValidator
def
validate_each
(
record
,
attribute
,
value
)
cron_parser
=
Ci
::
CronParser
.
new
(
record
.
cron
,
record
.
cron_time_zone
)
is_valid_cron
,
is_valid_cron_time_zone
=
cron_parser
.
validation
next_time
=
cron_parser
.
next_time_from
(
Time
.
now
)
if
!
is_valid_cron
record
.
errors
.
add
(
:cron
,
" is invalid syntax"
)
...
...
db/migrate/20170329095325_add_ref_to_triggers.rb
浏览文件 @
934e9497
# See http://doc.gitlab.com/ce/development/migration_style_guide.html
# for more information on how to write migrations for GitLab.
class
AddRefToTriggers
<
ActiveRecord
::
Migration
include
Gitlab
::
Database
::
MigrationHelpers
# Set this constant to true if this migration requires downtime.
DOWNTIME
=
false
def
change
...
...
db/migrate/20170329095907_create_ci_trigger_schedules.rb
浏览文件 @
934e9497
# See http://doc.gitlab.com/ce/development/migration_style_guide.html
# for more information on how to write migrations for GitLab.
class
CreateCiTriggerSchedules
<
ActiveRecord
::
Migration
include
Gitlab
::
Database
::
MigrationHelpers
# Set this constant to true if this migration requires downtime.
DOWNTIME
=
false
def
change
disable_ddl_transaction!
def
up
create_table
:ci_trigger_schedules
do
|
t
|
t
.
integer
"project_id"
t
.
integer
"trigger_id"
,
null:
false
...
...
@@ -21,6 +19,11 @@ class CreateCiTriggerSchedules < ActiveRecord::Migration
add_index
:ci_trigger_schedules
,
[
"next_run_at"
],
name:
"index_ci_trigger_schedules_on_next_run_at"
,
using: :btree
add_index
:ci_trigger_schedules
,
[
"project_id"
],
name:
"index_ci_trigger_schedules_on_project_id"
,
using: :btree
add_foreign_key
:ci_trigger_schedules
,
:ci_triggers
,
column: :trigger_id
,
on_delete: :cascade
add_concurrent_foreign_key
:ci_trigger_schedules
,
:ci_triggers
,
column: :trigger_id
,
on_delete: :cascade
end
def
down
remove_foreign_key
:ci_trigger_schedules
,
column: :trigger_id
drop_table
:ci_trigger_schedules
end
end
db/schema.rb
浏览文件 @
934e9497
...
...
@@ -1313,7 +1313,7 @@ ActiveRecord::Schema.define(version: 20170405080720) do
add_foreign_key
"boards"
,
"projects"
add_foreign_key
"chat_teams"
,
"namespaces"
,
on_delete: :cascade
add_foreign_key
"ci_trigger_schedules"
,
"ci_triggers"
,
column:
"trigger_id"
,
on_delete: :cascade
add_foreign_key
"ci_trigger_schedules"
,
"ci_triggers"
,
column:
"trigger_id"
,
name:
"fk_90a406cc94"
,
on_delete: :cascade
add_foreign_key
"ci_triggers"
,
"users"
,
column:
"owner_id"
,
name:
"fk_e8e10d1964"
,
on_delete: :cascade
add_foreign_key
"issue_metrics"
,
"issues"
,
on_delete: :cascade
add_foreign_key
"label_priorities"
,
"labels"
,
on_delete: :cascade
...
...
lib/ci/cron_parser.rb
浏览文件 @
934e9497
module
Ci
class
CronParser
VALID_SYNTAX_SAMPLE_TIME_ZONE
=
'UTC'
VALID_SYNTAX_SAMPLE_CRON
=
'* * * * *'
VALID_SYNTAX_SAMPLE_TIME_ZONE
=
'UTC'
.
freeze
VALID_SYNTAX_SAMPLE_CRON
=
'* * * * *'
.
freeze
def
initialize
(
cron
,
cron_time_zone
=
'UTC'
)
@cron
=
cron
...
...
@@ -9,9 +9,9 @@ module Ci
end
def
next_time_from
(
time
)
cron
L
ine
=
try_parse_cron
(
@cron
,
@cron_time_zone
)
if
cron
L
ine
.
present?
cron
L
ine
.
next_time
(
time
).
in_time_zone
(
Time
.
zone
)
cron
_l
ine
=
try_parse_cron
(
@cron
,
@cron_time_zone
)
if
cron
_l
ine
.
present?
cron
_l
ine
.
next_time
(
time
).
in_time_zone
(
Time
.
zone
)
else
nil
end
...
...
spec/models/ci/trigger_schedule_spec.rb
浏览文件 @
934e9497
require
'spec_helper'
describe
Ci
::
TriggerSchedule
,
models:
true
do
it
{
is_expected
.
to
belong_to
(
:project
)
}
it
{
is_expected
.
to
belong_to
(
:trigger
)
}
it
{
is_expected
.
to
respond_to
:ref
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录