Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
91c1dc57
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
91c1dc57
编写于
1月 18, 2019
作者:
S
Shinya Maeda
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix runner eternal loop when update job result
Add spec Add changelog
上级
35c3cb7c
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
31 addition
and
1 deletion
+31
-1
app/models/ci/build.rb
app/models/ci/build.rb
+8
-1
changelogs/unreleased/fix-runner-eternal-loop-when-update-job-result.yml
...leased/fix-runner-eternal-loop-when-update-job-result.yml
+5
-0
spec/models/ci/build_spec.rb
spec/models/ci/build_spec.rb
+18
-0
未找到文件。
app/models/ci/build.rb
浏览文件 @
91c1dc57
...
...
@@ -224,8 +224,15 @@ module Ci
before_transition
any
=>
[
:failed
]
do
|
build
|
next
unless
build
.
project
next
unless
build
.
deployment
build
.
deployment
&
.
drop
begin
build
.
deployment
.
drop!
rescue
=>
e
Gitlab
::
Sentry
.
track_exception
(
e
,
extra:
{
build_id:
build
.
id
})
end
true
end
after_transition
any
=>
[
:failed
]
do
|
build
|
...
...
changelogs/unreleased/fix-runner-eternal-loop-when-update-job-result.yml
0 → 100644
浏览文件 @
91c1dc57
---
title
:
Fix runner eternal loop when update job result
merge_request
:
24481
author
:
type
:
fixed
spec/models/ci/build_spec.rb
浏览文件 @
91c1dc57
...
...
@@ -3028,6 +3028,24 @@ describe Ci::Build do
subject
.
drop!
end
end
context
'when associated deployment failed to update its status'
do
let
(
:build
)
{
create
(
:ci_build
,
:running
,
pipeline:
pipeline
)
}
let!
(
:deployment
)
{
create
(
:deployment
,
deployable:
build
)
}
before
do
allow_any_instance_of
(
Deployment
)
.
to
receive
(
:drop!
).
and_raise
(
'Unexpected error'
)
end
it
'can drop the build'
do
expect
(
Gitlab
::
Sentry
).
to
receive
(
:track_exception
)
expect
{
build
.
drop!
}.
not_to
raise_error
expect
(
build
).
to
be_failed
end
end
end
describe
'.matches_tag_ids'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录