Merge branch 'replace_milestone.feature' into 'master'

Replace the 'project/milestone.feature' spinach test with an rspec analog

See merge request !14171

changelogs/unreleased/replace_milestone-feature.yml

+---
+title: Replace the project/milestone.feature spinach test with an rspec analog
+merge_request: 14171
+author: Vitaliy @blackst0ne Klachkov
+type: other

features/project/milestone.feature

-Feature: Project Milestone
-  Background:
-    Given I sign in as a user
-    And I own project "Shop"
-    And project "Shop" has labels: "bug", "feature", "enhancement"
-    And project "Shop" has milestone "v2.2"
-    And milestone has issue "Bugfix1" with labels: "bug", "feature"
-    And milestone has issue "Bugfix2" with labels: "bug", "enhancement"
-
-  @javascript
-  Scenario: Listing labels from labels tab
-    Given I visit project "Shop" milestones page
-    And I click link "v2.2"
-    And I click link "Labels"
-    Then I should see the list of labels
-    And I should see the labels "bug", "enhancement" and "feature"

features/steps/project/project_milestone.rb

-class Spinach::Features::ProjectMilestone < Spinach::FeatureSteps
-  include SharedAuthentication
-  include SharedProject
-  include SharedPaths
-  include WaitForRequests
-
-  step 'milestone has issue "Bugfix1" with labels: "bug", "feature"' do
-    project = Project.find_by(name: "Shop")
-    milestone = project.milestones.find_by(title: 'v2.2')
-    issue = create(:issue, title: "Bugfix1", project: project, milestone: milestone)
-    issue.labels << project.labels.find_by(title: 'bug')
-    issue.labels << project.labels.find_by(title: 'feature')
-  end
-
-  step 'milestone has issue "Bugfix2" with labels: "bug", "enhancement"' do
-    project = Project.find_by(name: "Shop")
-    milestone = project.milestones.find_by(title: 'v2.2')
-    issue = create(:issue, title: "Bugfix2", project: project, milestone: milestone)
-    issue.labels << project.labels.find_by(title: 'bug')
-    issue.labels << project.labels.find_by(title: 'enhancement')
-  end
-
-  step 'project "Shop" has milestone "v2.2"' do
-    project = Project.find_by(name: "Shop")
-    milestone = create(:milestone,
-                       title: "v2.2",
-                       project: project,
-                       description: "# Description header"
-                      )
-    3.times { create(:issue, project: project, milestone: milestone) }
-  end
-
-  step 'I should see the list of labels' do
-    expect(page).to have_selector('ul.manage-labels-list')
-  end
-
-  step 'I should see the labels "bug", "enhancement" and "feature"' do
-    wait_for_requests
-
-    page.within('#tab-issues') do
-      expect(page).to have_content 'bug'
-      expect(page).to have_content 'enhancement'
-      expect(page).to have_content 'feature'
-    end
-  end
-
-  step 'I should see the "bug" label listed only once' do
-    page.within('#tab-labels') do
-      expect(page).to have_content('bug', count: 1)
-    end
-  end
-
-  step 'I click link "v2.2"' do
-    click_link "v2.2"
-  end
-
-  step 'I click link "Labels"' do
-    page.within('.nav-sidebar') do
-      page.find(:xpath, "//a[@href='#tab-labels']").click
-    end
-  end
-end

spec/features/projects/milestones/user_interacts_with_labels_spec.rb

+require 'spec_helper'
+
+describe 'User interacts with labels' do
+  let(:user) { create(:user) }
+  let(:project) { create(:project, namespace: user.namespace) }
+  let(:milestone) { create(:milestone, project: project, title: 'v2.2', description: '# Description header') }
+  let(:issue1) { create(:issue, project: project, title: 'Bugfix1', milestone: milestone) }
+  let(:issue2) { create(:issue, project: project, title: 'Bugfix2', milestone: milestone) }
+  let(:label_bug) { create(:label, project: project, title: 'bug') }
+  let(:label_feature) { create(:label, project: project, title: 'feature') }
+  let(:label_enhancement) { create(:label, project: project, title: 'enhancement') }
+
+  before do
+    project.add_master(user)
+    sign_in(user)
+
+    issue1.labels << [label_bug, label_feature]
+    issue2.labels << [label_bug, label_enhancement]
+
+    visit(project_milestones_path(project))
+  end
+
+  it 'shows the list of labels', :js do
+    click_link('v2.2')
+
+    page.within('.nav-sidebar') do
+      page.find(:xpath, "//a[@href='#tab-labels']").click
+    end
+
+    expect(page).to have_selector('ul.manage-labels-list')
+
+    wait_for_requests
+
+    page.within('#tab-labels') do
+      expect(page).to have_content(label_bug.title)
+      expect(page).to have_content(label_enhancement.title)
+      expect(page).to have_content(label_feature.title)
+    end
+  end
+end