Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
8624a4ed
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
8624a4ed
编写于
5月 08, 2018
作者:
G
Grzegorz Bizon
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove orphaned builds without project / pipeline reference
上级
d8d0067b
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
8 addition
and
3 deletion
+8
-3
db/migrate/20180420010016_add_pipeline_build_foreign_key.rb
db/migrate/20180420010016_add_pipeline_build_foreign_key.rb
+5
-2
spec/migrations/add_pipeline_build_foreign_key_spec.rb
spec/migrations/add_pipeline_build_foreign_key_spec.rb
+3
-1
未找到文件。
db/migrate/20180420010016_add_pipeline_build_foreign_key.rb
浏览文件 @
8624a4ed
...
@@ -6,13 +6,16 @@ class AddPipelineBuildForeignKey < ActiveRecord::Migration
...
@@ -6,13 +6,16 @@ class AddPipelineBuildForeignKey < ActiveRecord::Migration
disable_ddl_transaction!
disable_ddl_transaction!
def
up
def
up
execute
<<~
SQL
DELETE FROM ci_builds WHERE project_id IS NULL OR commit_id IS NULL
SQL
execute
<<~
SQL
execute
<<~
SQL
DELETE FROM ci_builds WHERE NOT EXISTS
DELETE FROM ci_builds WHERE NOT EXISTS
(SELECT true FROM ci_pipelines WHERE ci_pipelines.id = ci_builds.commit_id)
(SELECT true FROM ci_pipelines WHERE ci_pipelines.id = ci_builds.commit_id)
AND commit_id IS NOT NULL
SQL
SQL
return
if
foreign_key_exists?
(
:ci_builds
,
:ci_pipelines
,
column: :commit_id
)
add_concurrent_foreign_key
(
:ci_builds
,
:ci_pipelines
,
column: :commit_id
)
add_concurrent_foreign_key
(
:ci_builds
,
:ci_pipelines
,
column: :commit_id
)
end
end
...
...
spec/migrations/add_pipeline_build_foreign_key_spec.rb
浏览文件 @
8624a4ed
...
@@ -16,10 +16,12 @@ describe AddPipelineBuildForeignKey, :migration do
...
@@ -16,10 +16,12 @@ describe AddPipelineBuildForeignKey, :migration do
builds
.
create!
(
id:
102
,
commit_id:
222
,
project_id:
11
)
builds
.
create!
(
id:
102
,
commit_id:
222
,
project_id:
11
)
builds
.
create!
(
id:
103
,
commit_id:
333
,
project_id:
11
)
builds
.
create!
(
id:
103
,
commit_id:
333
,
project_id:
11
)
builds
.
create!
(
id:
104
,
commit_id:
12
,
project_id:
11
)
builds
.
create!
(
id:
104
,
commit_id:
12
,
project_id:
11
)
builds
.
create!
(
id:
106
,
commit_id:
nil
,
project_id:
11
)
builds
.
create!
(
id:
107
,
commit_id:
12
,
project_id:
nil
)
end
end
it
'adds foreign key after removing orphans'
do
it
'adds foreign key after removing orphans'
do
expect
(
builds
.
all
.
count
).
to
eq
4
expect
(
builds
.
all
.
count
).
to
eq
6
expect
(
foreign_key_exists?
(
:ci_builds
,
:ci_pipelines
,
column: :commit_id
)).
to
be_falsey
expect
(
foreign_key_exists?
(
:ci_builds
,
:ci_pipelines
,
column: :commit_id
)).
to
be_falsey
migrate!
migrate!
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录