Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
71ae01fe
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
71ae01fe
编写于
11月 11, 2016
作者:
L
Lin Jen-Shin
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add more tests and fix write to project check
上级
38fbcb99
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
36 addition
and
8 deletion
+36
-8
app/models/deploy_key.rb
app/models/deploy_key.rb
+4
-0
lib/gitlab/git_access.rb
lib/gitlab/git_access.rb
+1
-1
spec/lib/gitlab/git_access_spec.rb
spec/lib/gitlab/git_access_spec.rb
+31
-7
未找到文件。
app/models/deploy_key.rb
浏览文件 @
71ae01fe
...
...
@@ -20,4 +20,8 @@ class DeployKey < Key
def
destroyed_when_orphaned?
self
.
private?
end
def
can_push_to?
(
project
)
can_push?
&&
projects
.
include?
(
project
)
end
end
lib/gitlab/git_access.rb
浏览文件 @
71ae01fe
...
...
@@ -89,7 +89,7 @@ module Gitlab
end
def
deploy_key_push_access_check
(
changes
)
if
deploy_key
.
can_push
?
if
deploy_key
.
can_push
_to?
(
project
)
check_repository_existence!
check_change_access!
(
changes
)
if
user
else
...
...
spec/lib/gitlab/git_access_spec.rb
浏览文件 @
71ae01fe
...
...
@@ -353,13 +353,13 @@ describe Gitlab::GitAccess, lib: true do
end
end
shared_examples
'
can not push code'
do
shared_examples
'
pushing code'
do
|
can
|
subject
{
access
.
check
(
'git-receive-pack'
,
'_any'
)
}
context
'when project is authorized'
do
before
{
authorize
}
it
{
expect
(
subject
).
not_to
be_allowed
}
it
{
expect
(
subject
).
public_send
(
can
,
be_allowed
)
}
end
context
'when unauthorized'
do
...
...
@@ -383,10 +383,20 @@ describe Gitlab::GitAccess, lib: true do
end
end
describe
'full authentication abilities'
do
let
(
:authentication_abilities
)
{
full_authentication_abilities
}
it_behaves_like
'pushing code'
,
:to
do
def
authorize
project
.
team
<<
[
user
,
:developer
]
end
end
end
describe
'build authentication abilities'
do
let
(
:authentication_abilities
)
{
build_authentication_abilities
}
it_behaves_like
'
can not push code'
do
it_behaves_like
'
pushing code'
,
:not_to
do
def
authorize
project
.
team
<<
[
user
,
:reporter
]
end
...
...
@@ -394,12 +404,26 @@ describe Gitlab::GitAccess, lib: true do
end
describe
'deploy key permissions'
do
let
(
:key
)
{
create
(
:deploy_key
)
}
let
(
:key
)
{
create
(
:deploy_key
,
can_push:
can_push
)
}
let
(
:actor
)
{
key
}
it_behaves_like
'can not push code'
do
def
authorize
key
.
projects
<<
project
context
'when deploy_key can push'
do
let
(
:can_push
)
{
true
}
it_behaves_like
'pushing code'
,
:to
do
def
authorize
key
.
projects
<<
project
end
end
end
context
'when deploy_key cannot push'
do
let
(
:can_push
)
{
false
}
it_behaves_like
'pushing code'
,
:not_to
do
def
authorize
key
.
projects
<<
project
end
end
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录