Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
68faad16
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
68faad16
编写于
2月 27, 2017
作者:
D
Douwe Maan
提交者:
Dmitriy Zaporozhets
2月 28, 2017
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Don't allow a project to be shared with an ancestor of the group it is in
上级
71fbbc9d
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
25 addition
and
3 deletion
+25
-3
app/models/project_group_link.rb
app/models/project_group_link.rb
+9
-2
spec/models/project_group_link_spec.rb
spec/models/project_group_link_spec.rb
+16
-1
未找到文件。
app/models/project_group_link.rb
浏览文件 @
68faad16
...
...
@@ -33,8 +33,15 @@ class ProjectGroupLink < ActiveRecord::Base
private
def
different_group
if
self
.
group
&&
self
.
project
&&
self
.
project
.
group
==
self
.
group
errors
.
add
(
:base
,
"Project cannot be shared with the project it is in."
)
return
unless
self
.
group
&&
self
.
project
project_group
=
self
.
project
.
group
return
unless
project_group
group_ids
=
project_group
.
ancestors
.
map
(
&
:id
).
push
(
project_group
.
id
)
if
group_ids
.
include?
(
self
.
group
.
id
)
errors
.
add
(
:base
,
"Project cannot be shared with the group it is in or one of its ancestors."
)
end
end
...
...
spec/models/project_group_link_spec.rb
浏览文件 @
68faad16
...
...
@@ -7,12 +7,27 @@ describe ProjectGroupLink do
end
describe
"Validation"
do
let!
(
:project_group_link
)
{
create
(
:project_group_link
)
}
let
(
:parent_group
)
{
create
(
:group
)
}
let
(
:group
)
{
create
(
:group
,
parent:
parent_group
)
}
let
(
:project
)
{
create
(
:project
,
group:
group
)
}
let!
(
:project_group_link
)
{
create
(
:project_group_link
,
project:
project
)
}
it
{
should
validate_presence_of
(
:project_id
)
}
it
{
should
validate_uniqueness_of
(
:group_id
).
scoped_to
(
:project_id
).
with_message
(
/already shared/
)
}
it
{
should
validate_presence_of
(
:group
)
}
it
{
should
validate_presence_of
(
:group_access
)
}
it
"doesn't allow a project to be shared with the group it is in"
do
project_group_link
.
group
=
group
expect
(
project_group_link
).
not_to
be_valid
end
it
"doesn't allow a project to be shared with an ancestor of the group it is in"
do
project_group_link
.
group
=
parent_group
expect
(
project_group_link
).
not_to
be_valid
end
end
describe
"destroying a record"
,
truncate:
true
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录