Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
68cea38e
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
68cea38e
编写于
8月 11, 2016
作者:
E
Elliot
提交者:
Rémy Coutable
8月 11, 2016
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix front-end for branches that happen to contain urlencoding escape characters (e.g. %)
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
3a46eac1
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
18 addition
and
4 deletion
+18
-4
CHANGELOG
CHANGELOG
+1
-0
lib/extracts_path.rb
lib/extracts_path.rb
+1
-1
spec/lib/extracts_path_spec.rb
spec/lib/extracts_path_spec.rb
+16
-3
未找到文件。
CHANGELOG
浏览文件 @
68cea38e
...
...
@@ -5,6 +5,7 @@ v 8.11.0 (unreleased)
- Fix rename `add_users_into_project` and `projects_ids`. !20512 (herminiotorres)
- Fix the title of the toggle dropdown button. !5515 (herminiotorres)
- Improve diff performance by eliminating redundant checks for text blobs
- Ensure that branch names containing escapable characters (e.g. %20) aren't unescaped indiscriminately. !5770 (ewiltshi)
- Convert switch icon into icon font (ClemMakesApps)
- API: Endpoints for enabling and disabling deploy keys
- Use long options for curl examples in documentation !5703 (winniehell)
...
...
lib/extracts_path.rb
浏览文件 @
68cea38e
...
...
@@ -94,7 +94,7 @@ module ExtractsPath
@options
=
params
.
select
{
|
key
,
value
|
allowed_options
.
include?
(
key
)
&&
!
value
.
blank?
}
@options
=
HashWithIndifferentAccess
.
new
(
@options
)
@id
=
Addressable
::
URI
.
unescape
(
get_id
)
@id
=
Addressable
::
URI
.
normalize_component
(
get_id
)
@ref
,
@path
=
extract_ref
(
@id
)
@repo
=
@project
.
repository
if
@options
[
:extended_sha1
].
blank?
...
...
spec/lib/extracts_path_spec.rb
浏览文件 @
68cea38e
...
...
@@ -30,15 +30,28 @@ describe ExtractsPath, lib: true do
expect
(
@logs_path
).
to
eq
(
"/
#{
@project
.
path_with_namespace
}
/refs/
#{
ref
}
/logs_tree/files/ruby/popen.rb"
)
end
context
'escaped s
equences
in ref'
do
let
(
:ref
)
{
"improve%2Fawesome"
}
context
'escaped s
lash character
in ref'
do
let
(
:ref
)
{
'improve%2Fawesome'
}
it
"id has no escape sequences"
do
it
'has no escape sequences in @ref or @logs_path'
do
assign_ref_vars
expect
(
@ref
).
to
eq
(
'improve/awesome'
)
expect
(
@logs_path
).
to
eq
(
"/
#{
@project
.
path_with_namespace
}
/refs/
#{
ref
}
/logs_tree/files/ruby/popen.rb"
)
end
end
context
'ref contains %20'
do
let
(
:ref
)
{
'foo%20bar'
}
it
'is not converted to a space in @id'
do
@project
.
repository
.
add_branch
(
@project
.
owner
,
'foo%20bar'
,
'master'
)
assign_ref_vars
expect
(
@id
).
to
start_with
(
'foo%20bar/'
)
end
end
end
describe
'#extract_ref'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录