Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
66f4af5c
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
66f4af5c
编写于
6月 16, 2017
作者:
F
Fatih Acet
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
IssueNotesRefactor: Refactor toggle to work with delegated handler.
上级
c77b2649
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
16 addition
and
12 deletion
+16
-12
app/assets/javascripts/notes/components/issue_discussion.vue
app/assets/javascripts/notes/components/issue_discussion.vue
+8
-1
app/assets/javascripts/notes/components/issue_note_header.vue
...assets/javascripts/notes/components/issue_note_header.vue
+3
-10
app/assets/javascripts/notes/stores/issue_notes_store.js
app/assets/javascripts/notes/stores/issue_notes_store.js
+5
-1
未找到文件。
app/assets/javascripts/notes/components/issue_discussion.vue
浏览文件 @
66f4af5c
...
...
@@ -43,6 +43,13 @@ export default {
this
.
signInLink
=
signInLink
.
getAttribute
(
'
href
'
);
}
},
methods
:
{
toggleDiscussion
()
{
this
.
$store
.
commit
(
'
toggleDiscussion
'
,
{
discussionId
:
this
.
note
.
id
,
});
}
},
};
</
script
>
...
...
@@ -64,7 +71,7 @@ export default {
:createdAt=
"discussion.created_at"
:notePath=
"discussion.path"
:includeToggle=
"true"
:
discussionId=
"note.id
"
:
toggleHandler=
"toggleDiscussion
"
actionText=
"started a discussion"
/>
<issue-note-edited-text
v-if=
"note.last_updated_by"
...
...
app/assets/javascripts/notes/components/issue_note_header.vue
浏览文件 @
66f4af5c
...
...
@@ -30,21 +30,14 @@ export default {
required
:
false
,
default
:
false
,
},
discussionId
:
{
type
:
String
,
toggleHandler
:
{
type
:
Function
,
required
:
false
,
},
},
components
:
{
TimeAgoTooltip
,
},
methods
:
{
toggle
()
{
this
.
$store
.
commit
(
'
toggleDiscussion
'
,
{
discussionId
:
this
.
discussionId
,
});
},
},
};
</
script
>
...
...
@@ -78,7 +71,7 @@ export default {
v-if=
"includeToggle"
class=
"discussion-actions"
>
<button
@
click=
"toggle"
@
click=
"toggle
Handler
"
class=
"note-action-button discussion-toggle-button js-toggle-button"
type=
"button"
>
<i
...
...
app/assets/javascripts/notes/stores/issue_notes_store.js
浏览文件 @
66f4af5c
...
...
@@ -3,6 +3,10 @@
import
service
from
'
../services/issue_notes_service
'
;
const
findNoteObjectById
=
(
notes
,
id
)
=>
{
return
notes
.
filter
(
n
=>
n
.
id
===
id
)[
0
];
};
const
state
=
{
notes
:
[],
};
...
...
@@ -18,7 +22,7 @@ const mutations = {
storeState
.
notes
=
notes
;
},
toggleDiscussion
(
storeState
,
{
discussionId
})
{
const
[
discussion
]
=
storeState
.
notes
.
filter
(
note
=>
note
.
id
===
discussionId
);
const
discussion
=
findNoteObjectById
(
storeState
.
notes
,
discussionId
);
discussion
.
expanded
=
!
discussion
.
expanded
;
},
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录