Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
65eb988d
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
65eb988d
编写于
1月 14, 2019
作者:
H
Heinrich Lee Yu
提交者:
Yorick Peterse
1月 31, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Use common error for unauthenticated users
Removes special error message when creating new issues
上级
219d24fe
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
7 addition
and
10 deletion
+7
-10
app/controllers/projects/issues_controller.rb
app/controllers/projects/issues_controller.rb
+1
-9
changelogs/unreleased/security-fix-new-issues-login-message.yml
...logs/unreleased/security-fix-new-issues-login-message.yml
+5
-0
spec/controllers/projects/issues_controller_spec.rb
spec/controllers/projects/issues_controller_spec.rb
+1
-1
未找到文件。
app/controllers/projects/issues_controller.rb
浏览文件 @
65eb988d
...
...
@@ -19,7 +19,7 @@ class Projects::IssuesController < Projects::ApplicationController
prepend_before_action
(
only:
[
:index
])
{
authenticate_sessionless_user!
(
:rss
)
}
prepend_before_action
(
only:
[
:calendar
])
{
authenticate_sessionless_user!
(
:ics
)
}
prepend_before_action
:authenticate_
new_issue
!
,
only:
[
:new
]
prepend_before_action
:authenticate_
user
!
,
only:
[
:new
]
prepend_before_action
:store_uri
,
only:
[
:new
,
:show
]
before_action
:whitelist_query_limiting
,
only:
[
:create
,
:create_merge_request
,
:move
,
:bulk_update
]
...
...
@@ -249,14 +249,6 @@ class Projects::IssuesController < Projects::ApplicationController
]
+
[{
label_ids:
[],
assignee_ids:
[]
}]
end
def
authenticate_new_issue!
return
if
current_user
notice
=
"Please sign in to create the new issue."
redirect_to
new_user_session_path
,
notice:
notice
end
def
store_uri
if
request
.
get?
&&
!
request
.
xhr?
store_location_for
:user
,
request
.
fullpath
...
...
changelogs/unreleased/security-fix-new-issues-login-message.yml
0 → 100644
浏览文件 @
65eb988d
---
title
:
Use common error for unauthenticated users when creating issues
merge_request
:
author
:
type
:
security
spec/controllers/projects/issues_controller_spec.rb
浏览文件 @
65eb988d
...
...
@@ -133,7 +133,7 @@ describe Projects::IssuesController do
it
'redirects to signin if not logged in'
do
get
:new
,
params:
{
namespace_id:
project
.
namespace
,
project_id:
project
}
expect
(
flash
[
:
notice
]).
to
eq
'Please sign in to create the new issue
.'
expect
(
flash
[
:
alert
]).
to
eq
'You need to sign in or sign up before continuing
.'
expect
(
response
).
to
redirect_to
(
new_user_session_path
)
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录