Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
633ddc9e
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
633ddc9e
编写于
11月 15, 2016
作者:
J
James Lopez
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fix authorization of builds and added relevant spec
上级
f93607a3
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
30 addition
and
2 deletion
+30
-2
app/controllers/projects/cycle_analytics/events_controller.rb
...controllers/projects/cycle_analytics/events_controller.rb
+5
-1
spec/requests/projects/cycle_analytics_events_spec.rb
spec/requests/projects/cycle_analytics_events_spec.rb
+25
-1
未找到文件。
app/controllers/projects/cycle_analytics/events_controller.rb
浏览文件 @
633ddc9e
...
...
@@ -2,7 +2,7 @@ class Projects::CycleAnalytics::EventsController < Projects::ApplicationControll
include
CycleAnalyticsParams
before_action
:authorize_read_cycle_analytics!
before_action
:authorize_
read_
builds!
,
only:
[
:test
,
:staging
]
before_action
:authorize_builds!
,
only:
[
:test
,
:staging
]
def
issue
render_events
(
events
.
issue_events
)
...
...
@@ -56,4 +56,8 @@ class Projects::CycleAnalytics::EventsController < Projects::ApplicationControll
params
[
:events
].
slice
(
:start_date
,
:branch_name
)
end
def
authorize_builds!
return
access_denied!
unless
current_user
.
can?
(
:read_build
,
project
)
end
end
spec/requests/projects/cycle_analytics_events_spec.rb
浏览文件 @
633ddc9e
...
...
@@ -39,7 +39,7 @@ describe 'cycle analytics events' do
newest_sha
=
commits
.
sort_by
{
|
k
|
k
[
'date'
]
}.
first
[
:sha
][
0
...
8
]
expect
(
json_response
[
'events'
].
first
[
'sha'
]).
to
eq
(
newest_sha
)
expect
(
json_response
[
'events'
].
first
[
'sh
ort_sh
a'
]).
to
eq
(
newest_sha
)
end
it
'lists the code events'
do
...
...
@@ -99,6 +99,30 @@ describe 'cycle analytics events' do
expect
(
json_response
[
'events'
].
first
[
'date'
]).
not_to
be_empty
end
end
context
'with private project and builds'
do
before
do
ProjectMember
.
first
.
update
(
access_level:
Gitlab
::
Access
::
GUEST
)
end
it
'does not list the test events'
do
get
namespace_project_cycle_analytics_test_path
(
project
.
namespace
,
project
,
format: :json
)
expect
(
response
).
to
have_http_status
(
:not_found
)
end
it
'does not list the staging events'
do
get
namespace_project_cycle_analytics_staging_path
(
project
.
namespace
,
project
,
format: :json
)
expect
(
response
).
to
have_http_status
(
:not_found
)
end
it
'lists the issue events'
do
get
namespace_project_cycle_analytics_issue_path
(
project
.
namespace
,
project
,
format: :json
)
expect
(
response
).
to
have_http_status
(
:ok
)
end
end
end
def
json_response
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录