Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
5fa9d6a1
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
5fa9d6a1
编写于
6月 27, 2017
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Rename FLippable to FeatureGate and make `flipper_group` and `user` mutually exclusive
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
b4d325c8
变更
6
隐藏空白更改
内联
并排
Showing
6 changed file
with
24 addition
and
16 deletion
+24
-16
app/models/concerns/feature_gate.rb
app/models/concerns/feature_gate.rb
+1
-1
app/models/user.rb
app/models/user.rb
+1
-1
doc/api/features.md
doc/api/features.md
+2
-0
lib/api/features.rb
lib/api/features.rb
+1
-0
spec/models/concerns/feature_gate_spec.rb
spec/models/concerns/feature_gate_spec.rb
+19
-0
spec/models/user_spec.rb
spec/models/user_spec.rb
+0
-14
未找到文件。
app/models/concerns/f
lippabl
e.rb
→
app/models/concerns/f
eature_gat
e.rb
浏览文件 @
5fa9d6a1
module
F
lippabl
e
module
F
eatureGat
e
def
flipper_id
return
nil
if
new_record?
...
...
app/models/user.rb
浏览文件 @
5fa9d6a1
...
...
@@ -11,7 +11,7 @@ class User < ActiveRecord::Base
include
CaseSensitivity
include
TokenAuthenticatable
include
IgnorableColumn
include
F
lippabl
e
include
F
eatureGat
e
DEFAULT_NOTIFICATION_LEVEL
=
:participating
...
...
doc/api/features.md
浏览文件 @
5fa9d6a1
...
...
@@ -61,6 +61,8 @@ POST /features/:name
|
`flipper_group`
| string | no | A Flipper group name |
|
`user`
| string | no | A GitLab username |
Note that
`flipper_group`
and
`user`
are mutually exclusive.
```
bash
curl
--data
"value=30"
--header
"PRIVATE-TOKEN: 9koXpg98eAheJpvBs5tK"
https://gitlab.example.com/api/v4/features/new_library
```
...
...
lib/api/features.rb
浏览文件 @
5fa9d6a1
...
...
@@ -42,6 +42,7 @@ module API
requires
:value
,
type:
String
,
desc:
'`true` or `false` to enable/disable, an integer for percentage of time'
optional
:flipper_group
,
type:
String
,
desc:
'A Flipper group name'
optional
:user
,
type:
String
,
desc:
'A GitLab username'
mutually_exclusive
:flipper_group
,
:user
end
post
':name'
do
feature
=
Feature
.
get
(
params
[
:name
])
...
...
spec/models/concerns/feature_gate_spec.rb
0 → 100644
浏览文件 @
5fa9d6a1
require
'spec_helper'
describe
FeatureGate
do
describe
'User'
do
describe
'#flipper_id'
do
context
'when user is not persisted'
do
let
(
:user
)
{
build
(
:user
)
}
it
{
expect
(
user
.
flipper_id
).
to
be_nil
}
end
context
'when user is persisted'
do
let
(
:user
)
{
create
(
:user
)
}
it
{
expect
(
user
.
flipper_id
).
to
eq
"User:
#{
user
.
id
}
"
}
end
end
end
end
spec/models/user_spec.rb
浏览文件 @
5fa9d6a1
...
...
@@ -430,20 +430,6 @@ describe User, models: true do
end
end
describe
'#flipper_id'
do
context
'when user is not persisted'
do
let
(
:user
)
{
build
(
:user
)
}
it
{
expect
(
user
.
flipper_id
).
to
be_nil
}
end
context
'when user is persisted'
do
let
(
:user
)
{
create
(
:user
)
}
it
{
expect
(
user
.
flipper_id
).
to
eq
"User:
#{
user
.
id
}
"
}
end
end
describe
'#generate_password'
do
it
"does not generate password by default"
do
user
=
create
(
:user
,
password:
'abcdefghe'
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录