Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
52ca9bf6
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
52ca9bf6
编写于
10月 07, 2016
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix typo and add he MWBS accronym for "Merge When Build Succeeds"
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
2f7e28d1
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
4 addition
and
4 deletion
+4
-4
doc/development/code_review.md
doc/development/code_review.md
+4
-4
未找到文件。
doc/development/code_review.md
浏览文件 @
52ca9bf6
...
...
@@ -35,7 +35,7 @@ request is up to one of our merge request "endbosses", denoted on the
## Having your code reviewed
Please keep in mind that code review is a process that can take multiple
iterations, and reviewer may spot things later that they may not have seen the
iterations, and reviewer
s
may spot things later that they may not have seen the
first time.
-
The first reviewer of your code is _you_. Before you perform that first push
...
...
@@ -69,9 +69,9 @@ experience, refactors the existing code). Then:
someone else would be confused by it as well.
-
After a round of line notes, it can be helpful to post a summary note such as
"LGTM :thumbsup:", or "Just a couple things to address."
-
Avoid accepting a merge request before the build succeeds
("Merge when build
succeeds" is fine)
.
-
If you set the MR to "Merge
when build s
ucceeds", you should take over
-
Avoid accepting a merge request before the build succeeds
. Of course, "Merge
When Build Succeeds" (MWBS) is fine
.
-
If you set the MR to "Merge
When Build S
ucceeds", you should take over
subsequent revisions for anything that would be spotted after that.
## Credits
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录