Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
50491d32
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
50491d32
编写于
2月 14, 2019
作者:
L
Lin Jen-Shin
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Instead of returning all or nothing, return whichever passed
And add tests
上级
30918929
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
70 addition
and
13 deletion
+70
-13
lib/gitlab/graphql/authorize/instrumentation.rb
lib/gitlab/graphql/authorize/instrumentation.rb
+6
-9
spec/lib/gitlab/graphql/authorize/instrumentation_spec.rb
spec/lib/gitlab/graphql/authorize/instrumentation_spec.rb
+28
-4
spec/requests/api/graphql/project/issues_spec.rb
spec/requests/api/graphql/project/issues_spec.rb
+36
-0
未找到文件。
lib/gitlab/graphql/authorize/instrumentation.rb
浏览文件 @
50491d32
...
...
@@ -45,15 +45,12 @@ module Gitlab
end
end
checked
=
case
value
when
Array
value
.
all?
(
&
check
)
else
check
.
call
(
value
)
end
value
if
checked
case
value
when
Array
value
.
select
(
&
check
)
else
value
if
check
.
call
(
value
)
end
end
end
end
...
...
spec/lib/gitlab/graphql/authorize/instrumentation_spec.rb
浏览文件 @
50491d32
...
...
@@ -15,7 +15,7 @@ describe Gitlab::Graphql::Authorize::Instrumentation do
object
=
double
(
:object
)
abilities
.
each
do
|
ability
|
spy_ability_check_for
(
ability
,
object
)
spy_ability_check_for
(
ability
,
object
,
passed:
true
)
end
expect
(
checker
.
call
(
object
)).
to
eq
(
object
)
...
...
@@ -26,18 +26,42 @@ describe Gitlab::Graphql::Authorize::Instrumentation do
abilities
.
each
do
|
ability
|
objects
.
each
do
|
object
|
spy_ability_check_for
(
ability
,
object
)
spy_ability_check_for
(
ability
,
object
,
passed:
true
)
end
end
expect
(
checker
.
call
(
objects
)).
to
eq
(
objects
)
end
def
spy_ability_check_for
(
ability
,
object
)
context
'when some objects would not pass the check'
do
it
'returns nil when it is single object'
do
disallowed
=
double
(
:object
)
spy_ability_check_for
(
abilities
.
first
,
disallowed
,
passed:
false
)
expect
(
checker
.
call
(
disallowed
)).
to
be_nil
end
it
'returns only objects which passed when there are more than one'
do
allowed
=
double
(
:allowed
)
disallowed
=
double
(
:disallowed
)
spy_ability_check_for
(
abilities
.
first
,
disallowed
,
passed:
false
)
abilities
.
each
do
|
ability
|
spy_ability_check_for
(
ability
,
allowed
,
passed:
true
)
end
expect
(
checker
.
call
([
disallowed
,
allowed
]))
.
to
contain_exactly
(
allowed
)
end
end
def
spy_ability_check_for
(
ability
,
object
,
passed:
true
)
expect
(
Ability
)
.
to
receive
(
:allowed?
)
.
with
(
current_user
,
ability
,
object
)
.
and_return
(
true
)
.
and_return
(
passed
)
end
end
end
spec/requests/api/graphql/project/issues_spec.rb
浏览文件 @
50491d32
...
...
@@ -56,4 +56,40 @@ describe 'getting an issue list for a project' do
expect
(
issues_data
).
to
eq
[]
end
end
context
'when there is a confidential issue'
do
let!
(
:confidential_issue
)
do
create
(
:issue
,
:confidential
,
project:
project
)
end
context
'when the user cannot see confidential issues'
do
it
'returns issues without confidential issues'
do
post_graphql
(
query
,
current_user:
current_user
)
expect
(
issues_data
.
size
).
to
eq
(
2
)
issues_data
.
each
do
|
issue
|
expect
(
issue
.
dig
(
'node'
,
'confidential'
)).
to
eq
(
false
)
end
end
end
context
'when the user can see confidential issues'
do
before
do
project
.
add_developer
(
current_user
)
end
it
'returns issues with confidential issues'
do
post_graphql
(
query
,
current_user:
current_user
)
expect
(
issues_data
.
size
).
to
eq
(
3
)
confidentials
=
issues_data
.
map
do
|
issue
|
issue
.
dig
(
'node'
,
'confidential'
)
end
expect
(
confidentials
).
to
eq
([
true
,
false
,
false
])
end
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录