Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
4e40d72a
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
4e40d72a
编写于
1月 25, 2019
作者:
B
Brett Walker
提交者:
Fatih Acet
1月 30, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Added changelog and danger fixes
上级
dfeb412d
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
11 addition
and
4 deletion
+11
-4
changelogs/unreleased/19745-forms-with-task-lists-can-be-overwritten-when-editing-simultaneously.yml
...-lists-can-be-overwritten-when-editing-simultaneously.yml
+5
-0
spec/services/issues/update_service_spec.rb
spec/services/issues/update_service_spec.rb
+4
-4
spec/services/task_list_toggle_service_spec.rb
spec/services/task_list_toggle_service_spec.rb
+2
-0
未找到文件。
changelogs/unreleased/19745-forms-with-task-lists-can-be-overwritten-when-editing-simultaneously.yml
0 → 100644
浏览文件 @
4e40d72a
---
title
:
Increase reliability and performance of clicking task items
merge_request
:
23938
author
:
type
:
fixed
spec/services/issues/update_service_spec.rb
浏览文件 @
4e40d72a
...
...
@@ -552,7 +552,7 @@ describe Issues::UpdateService, :mailer do
context
'when a task is marked as completed'
do
before
do
update_issue
(
update_task:
{
index:
1
,
checked:
true
,
line_source:
'- [ ] Task 1'
,
line_number:
1
})
update_issue
(
update_task:
{
index:
1
,
checked:
true
,
line_source:
'- [ ] Task 1'
,
line_number:
1
})
end
it
'creates system note about task status change'
do
...
...
@@ -568,7 +568,7 @@ describe Issues::UpdateService, :mailer do
context
'when a task is marked as incomplete'
do
before
do
update_issue
(
description:
"- [x] Task 1
\n
- [X] Task 2"
)
update_issue
(
update_task:
{
index:
2
,
checked:
false
,
line_source:
'- [X] Task 2'
,
line_number:
2
})
update_issue
(
update_task:
{
index:
2
,
checked:
false
,
line_source:
'- [X] Task 2'
,
line_number:
2
})
end
it
'creates system note about task status change'
do
...
...
@@ -589,7 +589,7 @@ describe Issues::UpdateService, :mailer do
it
'raises an exception'
do
expect
(
Note
.
count
).
to
eq
(
2
)
expect
do
update_issue
(
update_task:
{
index:
2
,
checked:
true
,
line_source:
'- [ ] Task 2'
,
line_number:
2
})
update_issue
(
update_task:
{
index:
2
,
checked:
true
,
line_source:
'- [ ] Task 2'
,
line_number:
2
})
end
.
to
raise_error
(
ActiveRecord
::
StaleObjectError
)
expect
(
Note
.
count
).
to
eq
(
2
)
end
...
...
@@ -599,7 +599,7 @@ describe Issues::UpdateService, :mailer do
before
do
update_issue
(
description:
"Paragraph
\n\n
- [ ] Task 1
\n
- [x] Task 2"
)
update_issue
(
description:
"Paragraph with more words
\n\n
- [ ] Task 1
\n
- [x] Task 2"
)
update_issue
(
update_task:
{
index:
2
,
checked:
false
,
line_source:
'- [x] Task 2'
,
line_number:
4
})
update_issue
(
update_task:
{
index:
2
,
checked:
false
,
line_source:
'- [x] Task 2'
,
line_number:
4
})
end
it
'creates system note about task status change'
do
...
...
spec/services/task_list_toggle_service_spec.rb
浏览文件 @
4e40d72a
# frozen_string_literal: true
require
'spec_helper'
describe
TaskListToggleService
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录