Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
49336710
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
49336710
编写于
10月 19, 2016
作者:
P
Paco Guzman
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Use MergeRequestsClosingIssues cache data on Issue#closed_by_merge_requests method
上级
c08435e3
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
16 addition
and
2 deletion
+16
-2
CHANGELOG.md
CHANGELOG.md
+2
-0
app/models/issue.rb
app/models/issue.rb
+7
-1
spec/models/issue_spec.rb
spec/models/issue_spec.rb
+7
-1
未找到文件。
CHANGELOG.md
浏览文件 @
49336710
...
...
@@ -2,6 +2,8 @@ Please view this file on the master branch, on stable branches it's out of date.
## 8.14.0 (2016-11-22)
-
Use MergeRequestsClosingIssues cache data on Issue#closed_by_merge_requests method
## 8.13.0 (2016-10-22)
-
Fix save button on project pipeline settings page. (!6955)
...
...
app/models/issue.rb
浏览文件 @
49336710
...
...
@@ -211,7 +211,13 @@ class Issue < ActiveRecord::Base
note
.
all_references
(
current_user
,
extractor:
ext
)
end
ext
.
merge_requests
.
select
{
|
mr
|
mr
.
open?
&&
mr
.
closes_issue?
(
self
)
}
merge_requests
=
ext
.
merge_requests
.
select
(
&
:
open
?)
if
merge_requests
.
any?
ids
=
MergeRequestsClosingIssues
.
where
(
merge_request_id:
merge_requests
.
map
(
&
:id
),
issue_id:
id
).
pluck
(:
merge_request_id
)
merge_requests
.
select
{
|
mr
|
mr
.
id
.
in?
(
ids
)
}
else
[]
end
end
def
moved?
...
...
spec/models/issue_spec.rb
浏览文件 @
49336710
...
...
@@ -100,11 +100,17 @@ describe Issue, models: true do
end
it
'returns the merge request to close this issue'
do
allow
(
mr
).
to
receive
(
:closes_issue?
).
with
(
issue
).
and_return
(
true
)
mr
expect
(
issue
.
closed_by_merge_requests
).
to
eq
([
mr
])
end
it
"returns an empty array when the merge request is closed already"
do
closed_mr
expect
(
issue
.
closed_by_merge_requests
).
to
eq
([])
end
it
"returns an empty array when the current issue is closed already"
do
expect
(
closed_issue
.
closed_by_merge_requests
).
to
eq
([])
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录