Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
43ac2a96
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
43ac2a96
编写于
2月 26, 2019
作者:
S
Stan Hu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add pagination spec and improve filtering of null values
上级
7765e6ec
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
23 addition
and
2 deletion
+23
-2
app/assets/javascripts/environments/mixins/environments_mixin.js
...ets/javascripts/environments/mixins/environments_mixin.js
+6
-2
spec/features/projects/environments/environments_spec.rb
spec/features/projects/environments/environments_spec.rb
+17
-0
未找到文件。
app/assets/javascripts/environments/mixins/environments_mixin.js
浏览文件 @
43ac2a96
...
...
@@ -44,8 +44,8 @@ export default {
this
.
isLoading
=
false
;
// Prevent the absence of the nested flag from causing mismatches
const
response
=
_
.
omit
(
resp
.
config
.
params
,
_
.
isUndefined
);
const
request
=
_
.
omit
(
this
.
requestData
,
_
.
isUndefined
);
const
response
=
this
.
filterNilValues
(
resp
.
config
.
params
);
const
request
=
this
.
filterNilValues
(
this
.
requestData
);
if
(
_
.
isEqual
(
response
,
request
))
{
this
.
store
.
storeAvailableCount
(
resp
.
data
.
available_count
);
...
...
@@ -55,6 +55,10 @@ export default {
}
},
filterNilValues
(
obj
)
{
return
_
.
omit
(
obj
,
value
=>
_
.
isUndefined
(
value
)
||
_
.
isNull
(
value
));
},
/**
* Handles URL and query parameter changes.
* When the user uses the pagination or the tabs,
...
...
spec/features/projects/environments/environments_spec.rb
浏览文件 @
43ac2a96
...
...
@@ -38,6 +38,23 @@ describe 'Environments page', :js do
end
end
describe
'with environments spanning multiple pages'
,
:js
do
before
do
allow
(
Kaminari
.
config
).
to
receive
(
:default_per_page
).
and_return
(
3
)
create_list
(
:environment
,
4
,
project:
project
,
state: :available
)
end
it
'should render second page of pipelines'
do
visit_environments
(
project
,
scope:
'available'
)
find
(
'.js-next-button'
).
click
wait_for_requests
expect
(
page
).
to
have_selector
(
'.gl-pagination .page'
,
count:
2
)
expect
(
find
(
'.gl-pagination .page-item.active .page-link'
).
text
).
to
eq
(
"2"
)
end
end
describe
'in stopped tab page'
do
it
'should show no environments'
do
visit_environments
(
project
,
scope:
'stopped'
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录