Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
41af40d4
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
41af40d4
编写于
3月 20, 2019
作者:
M
Małgorzata Ksionek
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Disallow changing namespace of a project in update method
上级
bcd4e1f5
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
30 addition
and
5 deletion
+30
-5
app/controllers/projects_controller.rb
app/controllers/projects_controller.rb
+8
-5
changelogs/unreleased/security-mass-assignment-on-project-update.yml
...unreleased/security-mass-assignment-on-project-update.yml
+5
-0
spec/controllers/projects_controller_spec.rb
spec/controllers/projects_controller_spec.rb
+17
-0
未找到文件。
app/controllers/projects_controller.rb
浏览文件 @
41af40d4
...
...
@@ -46,7 +46,7 @@ class ProjectsController < Projects::ApplicationController
end
def
create
@project
=
::
Projects
::
CreateService
.
new
(
current_user
,
project_params
).
execute
@project
=
::
Projects
::
CreateService
.
new
(
current_user
,
project_params
(
attributes:
project_params_create_attributes
)
).
execute
if
@project
.
saved?
cookies
[
:issue_board_welcome_hidden
]
=
{
path:
project_path
(
@project
),
value:
nil
,
expires:
Time
.
at
(
0
)
}
...
...
@@ -327,9 +327,9 @@ class ProjectsController < Projects::ApplicationController
end
# rubocop: enable CodeReuse/ActiveRecord
def
project_params
def
project_params
(
attributes:
project_params_attributes
)
params
.
require
(
:project
)
.
permit
(
project_params_
attributes
)
.
permit
(
attributes
)
end
def
project_params_attributes
...
...
@@ -348,11 +348,10 @@ class ProjectsController < Projects::ApplicationController
:last_activity_at
,
:lfs_enabled
,
:name
,
:namespace_id
,
:only_allow_merge_if_all_discussions_are_resolved
,
:only_allow_merge_if_pipeline_succeeds
,
:printing_merge_request_link_enabled
,
:path
,
:printing_merge_request_link_enabled
,
:public_builds
,
:request_access_enabled
,
:runners_token
,
...
...
@@ -374,6 +373,10 @@ class ProjectsController < Projects::ApplicationController
]
end
def
project_params_create_attributes
project_params_attributes
<<
:namespace_id
end
def
custom_import_params
{}
end
...
...
changelogs/unreleased/security-mass-assignment-on-project-update.yml
0 → 100644
浏览文件 @
41af40d4
---
title
:
Disallow updating namespace during updating project
merge_request
:
author
:
type
:
security
spec/controllers/projects_controller_spec.rb
浏览文件 @
41af40d4
...
...
@@ -369,6 +369,23 @@ describe ProjectsController do
end
end
it
'does not update namespace'
do
controller
.
instance_variable_set
(
:@project
,
project
)
params
=
{
namespace_id:
'test'
}
expect
do
put
:update
,
params:
{
namespace_id:
project
.
namespace
,
id:
project
.
id
,
project:
params
}
end
.
not_to
change
{
project
.
namespace
}
end
def
update_project
(
**
parameters
)
put
:update
,
params:
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录