Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
413778b6
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
413778b6
编写于
10月 13, 2012
作者:
R
Riyad Preukschas
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Rename NoteObserver methods and clarify things
上级
853c69c4
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
51 addition
and
27 deletion
+51
-27
app/observers/note_observer.rb
app/observers/note_observer.rb
+13
-8
spec/observers/note_observer_spec.rb
spec/observers/note_observer_spec.rb
+38
-19
未找到文件。
app/observers/note_observer.rb
浏览文件 @
413778b6
class
NoteObserver
<
ActiveRecord
::
Observer
def
after_create
(
note
)
send_notify_mails
(
note
)
end
protected
def
send_notify_mails
(
note
)
if
note
.
notify
# Notify whole team except author of note
notify_team_of_new_note
(
note
)
notify_team
(
note
)
elsif
note
.
notify_author
# Notify only author of resource
Notify
.
note_commit_email
(
note
.
commit_author
.
id
,
note
.
id
).
deliver
...
...
@@ -13,15 +18,15 @@ class NoteObserver < ActiveRecord::Observer
end
end
protected
def
notify_team_of_new_note
(
note
)
note
_is_on
=
note
.
noteable_type
||
'Wall'
notify_method
=
'note_'
+
note_is_on
.
underscore
+
'_email'
# Notifies the whole team except the author of note
def
notify_team
(
note
)
# Note: wall posts are not "attached" to anything, so fall back to "Wall"
note
able_type
=
note
.
noteable_type
||
"Wall"
notify_method
=
"note_
#{
noteable_type
.
underscore
}
_email"
.
to_sym
if
Notify
.
respond_to?
notify_method
team_without_note_author
(
note
).
map
do
|
u
|
Notify
.
send
(
notify_method
.
to_sym
,
u
.
id
,
note
.
id
).
deliver
Notify
.
send
(
notify_method
,
u
.
id
,
note
.
id
).
deliver
end
end
end
...
...
spec/observers/note_observer_spec.rb
浏览文件 @
413778b6
...
...
@@ -3,8 +3,11 @@ require 'spec_helper'
describe
NoteObserver
do
subject
{
NoteObserver
.
instance
}
let
(
:team_without_author
)
{
(
1
..
2
).
map
{
|
n
|
double
:user
,
id:
n
}
}
let
(
:delivery_success
)
{
double
deliver:
true
}
describe
'#after_create'
do
let
(
:note
)
{
double
:note
,
notify:
false
,
notify_author:
false
}
let
(
:note
)
{
double
:note
}
it
'is called after a note is created'
do
subject
.
should_receive
:after_create
...
...
@@ -14,40 +17,51 @@ describe NoteObserver do
end
end
it
'sends out notifications'
do
subject
.
should_receive
(
:send_notify_mails
).
with
(
note
)
subject
.
after_create
(
note
)
end
end
describe
"#send_notify_mails"
do
let
(
:note
)
{
double
:note
,
notify:
false
,
notify_author:
false
}
it
'notifies team of new note when flagged to notify'
do
note
.
stub
(
:notify
).
and_return
(
true
)
subject
.
should_receive
(
:notify_team
_of_new_note
).
with
(
note
)
subject
.
should_receive
(
:notify_team
).
with
(
note
)
subject
.
after_create
(
note
)
end
it
'does not notify team of new note when not flagged to notify'
do
subject
.
should_not_receive
(
:notify_team
_of_new_note
).
with
(
note
)
subject
.
should_not_receive
(
:notify_team
).
with
(
note
)
subject
.
after_create
(
note
)
end
it
'notifies the author of a commit when flagged to notify the author'
do
note
.
stub
(
:notify_author
).
and_return
(
true
)
note
.
stub
(
:id
).
and_return
(
42
)
author
=
double
:user
,
id:
1
note
.
stub
(
:commit_author
).
and_return
(
author
)
Notify
.
should_receive
(
:note_commit_email
).
and_return
(
d
ouble
(
deliver:
true
)
)
Notify
.
should_receive
(
:note_commit_email
).
and_return
(
d
elivery_success
)
subject
.
after_create
(
note
)
end
it
'does not notify the author of a commit when not flagged to notify the author'
do
Notify
.
should_not_receive
(
:note_commit_email
)
subject
.
after_create
(
note
)
end
it
'does nothing if no notify flags are set'
do
subject
.
after_create
(
note
).
should
be_nil
end
end
let
(
:team_without_author
)
{
(
1
..
2
).
map
{
|
n
|
double
:user
,
id:
n
}
}
describe
'#notify_team_of_new_note'
do
describe
'#notify_team'
do
let
(
:note
)
{
double
:note
,
id:
1
}
before
:each
do
...
...
@@ -57,40 +71,45 @@ describe NoteObserver do
context
'notifies team of a new note on'
do
it
'a commit'
do
note
.
stub
(
:noteable_type
).
and_return
(
'Commit'
)
Notify
.
should_receive
(
:note_commit_email
).
twice
.
and_return
(
d
ouble
(
deliver:
true
)
)
Notify
.
should_receive
(
:note_commit_email
).
twice
.
and_return
(
d
elivery_success
)
subject
.
send
(
:notify_team
_of_new_note
,
note
)
subject
.
send
(
:notify_team
,
note
)
end
it
'an issue'
do
note
.
stub
(
:noteable_type
).
and_return
(
'Issue'
)
Notify
.
should_receive
(
:note_issue_email
).
twice
.
and_return
(
d
ouble
(
deliver:
true
)
)
Notify
.
should_receive
(
:note_issue_email
).
twice
.
and_return
(
d
elivery_success
)
subject
.
send
(
:notify_team
_of_new_note
,
note
)
subject
.
send
(
:notify_team
,
note
)
end
it
'a wiki page'
do
note
.
stub
(
:noteable_type
).
and_return
(
'Wiki'
)
Notify
.
should_receive
(
:note_wiki_email
).
twice
.
and_return
(
d
ouble
(
deliver:
true
)
)
Notify
.
should_receive
(
:note_wiki_email
).
twice
.
and_return
(
d
elivery_success
)
subject
.
send
(
:notify_team
_of_new_note
,
note
)
subject
.
send
(
:notify_team
,
note
)
end
it
'a merge request'
do
note
.
stub
(
:noteable_type
).
and_return
(
'MergeRequest'
)
Notify
.
should_receive
(
:note_merge_request_email
).
twice
.
and_return
(
d
ouble
(
deliver:
true
)
)
Notify
.
should_receive
(
:note_merge_request_email
).
twice
.
and_return
(
d
elivery_success
)
subject
.
send
(
:notify_team
_of_new_note
,
note
)
subject
.
send
(
:notify_team
,
note
)
end
it
'a wall'
do
# Note: wall posts have #noteable_type of nil
note
.
stub
(
:noteable_type
).
and_return
(
nil
)
Notify
.
should_receive
(
:note_wall_email
).
twice
.
and_return
(
d
ouble
(
deliver:
true
)
)
Notify
.
should_receive
(
:note_wall_email
).
twice
.
and_return
(
d
elivery_success
)
subject
.
send
(
:notify_team
_of_new_note
,
note
)
subject
.
send
(
:notify_team
,
note
)
end
end
it
'does nothing for a new note on a snippet'
do
note
.
stub
(
:noteable_type
).
and_return
(
'Snippet'
)
subject
.
send
(
:notify_team
_of_new_note
,
note
).
should
be_nil
subject
.
send
(
:notify_team
,
note
).
should
be_nil
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录