Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
38c29f87
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
38c29f87
编写于
5月 04, 2017
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.md
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
cb87903c
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
11 addition
and
17 deletion
+11
-17
CONTRIBUTING.md
CONTRIBUTING.md
+10
-13
PROCESS.md
PROCESS.md
+1
-1
doc/development/code_review.md
doc/development/code_review.md
+0
-3
未找到文件。
CONTRIBUTING.md
浏览文件 @
38c29f87
...
...
@@ -136,7 +136,7 @@ and ~"direction".
A number of type labels have a priority assigned to them, which automatically
makes them float to the top, depending on their importance.
Type labels are always lowercase,
but
can have any color, besides blue (which is
Type labels are always lowercase,
and
can have any color, besides blue (which is
already reserved for subject labels).
The descriptions on the
[
labels page
][
labels-page
]
explain what falls under each type label.
...
...
@@ -153,7 +153,7 @@ issue is labelled with a subject label corresponding to your expertise.
Examples of subject labels are ~wiki, ~"container registry", ~ldap, ~api,
~issues, ~"merge requests", ~labels, and ~"container registry".
Subject labels are always
colored blue and
all-lowercase.
Subject labels are always all-lowercase.
### Team labels (~CI, ~Discussion, ~Edge, ~Frontend, ~Platform, etc.)
...
...
@@ -167,8 +167,8 @@ The current team labels are ~Build, ~CI, ~Discussion, ~Documentation, ~Edge,
The descriptions on the
[
labels page
][
labels-page
]
explain what falls under the
responsibility of each team.
Team labels are always c
olored aqua, and are capitalized so that they show up as
the first label for
any issue.
Team labels are always c
apitalized so that they show up as the first label for
any issue.
### Priority labels (~Deliverable and ~Stretch)
...
...
@@ -255,12 +255,9 @@ every quarter.
The most important thing is making sure valid issues receive feedback from the
development team. Therefore the priority is mentioning developers that can help
on those issues. Please select someone with relevant experience from
[
GitLab team
][
team
]
. If there is nobody mentioned with that expertise
look in the commit history for the affected files to find someone. Avoid
mentioning the lead developer, this is the person that is least likely to give a
timely response. If the involvement of the lead developer is needed the other
core team members will mention this person.
on those issues. Please select someone with relevant experience from the
[
GitLab team
][
team
]
. If there is nobody mentioned with that expertise look in
the commit history for the affected files to find someone.
[
described in our handbook
]:
https://about.gitlab.com/handbook/engineering/issues/issue-triage-policies/
[
issue bash events
]:
https://gitlab.com/gitlab-org/gitlab-ce/issues/17815
...
...
@@ -535,11 +532,11 @@ the feature you contribute through all of these steps.
1.
[
Unit and system tests
][
testing
]
that pass on the CI server
1.
Performance/scalability implications have been considered, addressed, and tested
1.
[
Documented
][
doc-styleguide
]
in the
`/doc`
directory
1.
[
Changelog entry added
][
changelog
]
1.
[
Changelog entry added
][
changelog
]
, if necessary
1.
Reviewed and any concerns are addressed
1.
Merged by a project maintainer
1.
Added to the release blog article if relevant
1.
Added to
[
the website
](
https://gitlab.com/gitlab-com/www-gitlab-com/
)
if relevant
1.
Added to the release blog article
,
if relevant
1.
Added to
[
the website
](
https://gitlab.com/gitlab-com/www-gitlab-com/
)
,
if relevant
1.
Community questions answered
1.
Answers to questions radiated (in docs/wiki/support etc.)
...
...
PROCESS.md
浏览文件 @
38c29f87
## GitLab Core Team & GitLab Inc.
Team Contributing
Process
## GitLab Core Team & GitLab Inc.
Contribution
Process
---
...
...
doc/development/code_review.md
浏览文件 @
38c29f87
...
...
@@ -95,8 +95,6 @@ experience, refactors the existing code). Then:
"LGTM :thumbsup:", or "Just a couple things to address."
-
Assign the merge request to the author if changes are required following your
review.
-
You should try to resolve merge conflicts yourself, using the
[
merge conflict
resolution
][
conflict-resolution
]
tool.
-
Set the milestone before merging a merge request.
-
Avoid accepting a merge request before the job succeeds. Of course, "Merge
When Pipeline Succeeds" (MWPS) is fine.
...
...
@@ -105,7 +103,6 @@ experience, refactors the existing code). Then:
-
Consider using the
[
Squash and
merge
][
squash-and-merge
]
feature when the merge request has a lot of commits.
[
conflict-resolution
]:
https://docs.gitlab.com/ce/user/project/merge_requests/resolve_conflicts.html#merge-conflict-resolution
[
squash-and-merge
]:
https://docs.gitlab.com/ee/user/project/merge_requests/squash_and_merge.html#squash-and-merge
### The right balance
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录