提交 2fba2ade 编写于 作者: W Walmyr 提交者: Ramya Authappan

Remove unnecessary comments from login tests

The comments were TODOs but there were no explanation of what
needed to be done.

Also, I think the expectation describes very well how it checks
that the user is logged in.

Finally, as Robert C. Martin said once:
"After you check in a TODO comment it turns into a DON'T DO"
上级 10bf3bbc
......@@ -7,16 +7,12 @@ module QA
Runtime::Browser.visit(:gitlab, Page::Main::Login)
Page::Main::Login.act { sign_in_using_credentials }
# TODO, since `Signed in successfully` message was removed
# this is the only way to tell if user is signed in correctly.
#
Page::Main::Menu.perform do |menu|
expect(menu).to have_personal_area
end
Page::Main::Menu.perform do |menu|
menu.sign_out
expect(menu).not_to have_personal_area
end
Page::Main::Login.perform do |form|
......
......@@ -7,9 +7,6 @@ module QA
Runtime::Browser.visit(:gitlab, Page::Main::Login)
Page::Main::Login.act { sign_in_using_credentials }
# TODO, since `Signed in successfully` message was removed
# this is the only way to tell if user is signed in correctly.
#
Page::Main::Menu.perform do |menu|
expect(menu).to have_personal_area
end
......
......@@ -7,9 +7,6 @@ module QA
Resource::User.fabricate_via_browser_ui!
# TODO, since `Signed in successfully` message was removed
# this is the only way to tell if user is signed in correctly.
#
Page::Main::Menu.perform do |menu|
expect(menu).to have_personal_area
end
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册