Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
28097398
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
28097398
编写于
2月 22, 2016
作者:
D
Douglas Barbosa Alexandre
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Does not raise an error when Todo is already marked as done
上级
f5be5671
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
9 addition
and
29 deletion
+9
-29
app/controllers/dashboard/todos_controller.rb
app/controllers/dashboard/todos_controller.rb
+1
-1
app/models/todo.rb
app/models/todo.rb
+1
-1
spec/models/todo_spec.rb
spec/models/todo_spec.rb
+7
-27
未找到文件。
app/controllers/dashboard/todos_controller.rb
浏览文件 @
28097398
...
...
@@ -15,7 +15,7 @@ class Dashboard::TodosController < Dashboard::ApplicationController
end
def
destroy_all
@todos
.
each
(
&
:done
)
@todos
.
each
(
&
:done
!
)
respond_to
do
|
format
|
format
.
html
{
redirect_to
dashboard_todos_path
,
notice:
'All todos were marked as done.'
}
...
...
app/models/todo.rb
浏览文件 @
28097398
...
...
@@ -36,7 +36,7 @@ class Todo < ActiveRecord::Base
state_machine
:state
,
initial: :pending
do
event
:done
do
transition
pending:
:done
transition
[
:pending
,
:done
]
=>
:done
end
state
:pending
...
...
spec/models/todo_spec.rb
.rb
→
spec/models/todo_spec.rb
浏览文件 @
28097398
...
...
@@ -37,20 +37,6 @@ describe Todo, models: true do
it
{
is_expected
.
to
validate_presence_of
(
:user
)
}
end
describe
'#action_name'
do
it
'returns proper message when action is an assigment'
do
subject
.
action
=
Todo
::
ASSIGNED
expect
(
subject
.
action_name
).
to
eq
'assigned'
end
it
'returns proper message when action is a mention'
do
subject
.
action
=
Todo
::
MENTIONED
expect
(
subject
.
action_name
).
to
eq
'mentioned you on'
end
end
describe
'#body'
do
before
do
subject
.
target
=
build
(
:issue
,
title:
'Bugfix'
)
...
...
@@ -69,21 +55,15 @@ describe Todo, models: true do
end
end
describe
'#target_iid'
do
let
(
:issue
)
{
build
(
:issue
,
id:
1
,
iid:
5
)
}
before
do
subject
.
target
=
issue
end
it
'returns target.iid when target respond to iid'
do
expect
(
subject
.
target_iid
).
to
eq
5
describe
'#done!'
do
it
'changes state to done'
do
todo
=
create
(
:todo
,
state: :pending
)
expect
{
todo
.
done!
}.
to
change
(
todo
,
:state
).
from
(
'pending'
).
to
(
'done'
)
end
it
'returns target_id when target does not respond to iid'
do
allow
(
issue
).
to
receive
(
:respond_to?
).
with
(
:iid
).
and_return
(
false
)
expect
(
subject
.
target_iid
).
to
eq
1
it
'does not raise error when is already done'
do
todo
=
create
(
:todo
,
state: :done
)
expect
{
todo
.
done!
}.
not_to
raise_error
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录