Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
277fac40
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
277fac40
编写于
3月 12, 2018
作者:
P
Phil Hughes
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix removes source branch text being rendered in merged state
上级
bd26e012
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
40 addition
and
1 deletion
+40
-1
app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
...javascripts/vue_merge_request_widget/mr_widget_options.js
+2
-1
app/assets/javascripts/vue_merge_request_widget/stores/mr_widget_store.js
...cripts/vue_merge_request_widget/stores/mr_widget_store.js
+4
-0
app/assets/javascripts/vue_merge_request_widget/stores/state_maps.js
...javascripts/vue_merge_request_widget/stores/state_maps.js
+1
-0
spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
+33
-0
未找到文件。
app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
浏览文件 @
277fac40
...
...
@@ -71,7 +71,8 @@ export default {
return
this
.
mr
.
deployments
.
length
;
},
shouldRenderSourceBranchRemovalStatus
()
{
return
!
this
.
mr
.
canRemoveSourceBranch
&&
this
.
mr
.
shouldRemoveSourceBranch
;
return
!
this
.
mr
.
canRemoveSourceBranch
&&
this
.
mr
.
shouldRemoveSourceBranch
&&
(
!
this
.
mr
.
isNothingToMergeState
&&
!
this
.
mr
.
isMergedState
);
},
},
methods
:
{
...
...
app/assets/javascripts/vue_merge_request_widget/stores/mr_widget_store.js
浏览文件 @
277fac40
...
...
@@ -125,6 +125,10 @@ export default class MergeRequestStore {
return
this
.
state
===
stateKey
.
nothingToMerge
;
}
get
isMergedState
()
{
return
this
.
state
===
stateKey
.
merged
;
}
initRebase
(
data
)
{
this
.
canPushToSourceBranch
=
data
.
can_push_to_source_branch
;
this
.
rebaseInProgress
=
data
.
rebase_in_progress
;
...
...
app/assets/javascripts/vue_merge_request_widget/stores/state_maps.js
浏览文件 @
277fac40
...
...
@@ -49,6 +49,7 @@ export const stateKey = {
notAllowedToMerge
:
'
notAllowedToMerge
'
,
readyToMerge
:
'
readyToMerge
'
,
rebase
:
'
rebase
'
,
merged
:
'
merged
'
,
};
export
default
{
...
...
spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
浏览文件 @
277fac40
...
...
@@ -82,6 +82,10 @@ describe('mrWidgetOptions', () => {
});
describe
(
'
shouldRenderSourceBranchRemovalStatus
'
,
()
=>
{
beforeEach
(()
=>
{
vm
.
mr
.
state
=
'
readyToMerge
'
;
});
it
(
'
should return true when cannot remove source branch and branch will be removed
'
,
()
=>
{
vm
.
mr
.
canRemoveSourceBranch
=
false
;
vm
.
mr
.
shouldRemoveSourceBranch
=
true
;
...
...
@@ -102,6 +106,22 @@ describe('mrWidgetOptions', () => {
expect
(
vm
.
shouldRenderSourceBranchRemovalStatus
).
toEqual
(
false
);
});
it
(
'
should return false when in merged state
'
,
()
=>
{
vm
.
mr
.
canRemoveSourceBranch
=
false
;
vm
.
mr
.
shouldRemoveSourceBranch
=
true
;
vm
.
mr
.
state
=
'
merged
'
;
expect
(
vm
.
shouldRenderSourceBranchRemovalStatus
).
toEqual
(
false
);
});
it
(
'
should return false when in nothing to merge state
'
,
()
=>
{
vm
.
mr
.
canRemoveSourceBranch
=
false
;
vm
.
mr
.
shouldRemoveSourceBranch
=
true
;
vm
.
mr
.
state
=
'
nothingToMerge
'
;
expect
(
vm
.
shouldRenderSourceBranchRemovalStatus
).
toEqual
(
false
);
});
});
describe
(
'
shouldRenderDeployments
'
,
()
=>
{
...
...
@@ -419,5 +439,18 @@ describe('mrWidgetOptions', () => {
done
();
});
});
it
(
'
does not render in merged state
'
,
(
done
)
=>
{
vm
.
mr
.
canRemoveSourceBranch
=
false
;
vm
.
mr
.
shouldRemoveSourceBranch
=
true
;
vm
.
mr
.
state
=
'
merged
'
;
vm
.
$nextTick
(()
=>
{
expect
(
vm
.
$el
.
textContent
).
toContain
(
'
The source branch has been removed
'
);
expect
(
vm
.
$el
.
textContent
).
not
.
toContain
(
'
Removes source branch
'
);
done
();
});
});
});
});
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录