Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
23da356d
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
23da356d
编写于
8月 23, 2019
作者:
V
Vitali Tatarintev
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Refactor BeSuccessMatcher specs
上级
e1b8b932
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
25 addition
and
36 deletion
+25
-36
spec/rubocop/cop/rspec/be_success_matcher_spec.rb
spec/rubocop/cop/rspec/be_success_matcher_spec.rb
+25
-36
未找到文件。
spec/rubocop/cop/rspec/be_success_matcher_spec.rb
浏览文件 @
23da356d
...
@@ -10,10 +10,16 @@ require_relative '../../../../rubocop/cop/rspec/be_success_matcher'
...
@@ -10,10 +10,16 @@ require_relative '../../../../rubocop/cop/rspec/be_success_matcher'
describe
RuboCop
::
Cop
::
RSpec
::
BeSuccessMatcher
do
describe
RuboCop
::
Cop
::
RSpec
::
BeSuccessMatcher
do
include
CopHelper
include
CopHelper
OFFENSE_CALL_EXPECT_TO_BE_SUCCESS
=
%(expect(response).to be_success)
.
freeze
CODE_EXAMPLES
=
[
OFFENSE_CALL_IS_EXPECTED_TO_BE_SUCCESS
=
%(is_expected.to be_success)
.
freeze
{
CALL_EXPECT_TO_BE_SUCCESSFUL
=
%(expect(response).to be_successful)
.
freeze
bad:
%(expect(response).to be_success)
.
freeze
,
CALL_IS_EXPECTED_TO_BE_SUCCESSFUL
=
%(is_expected.to be_successful)
.
freeze
good:
%(expect(response).to be_successful)
.
freeze
},
{
bad:
%(is_expected.to be_success)
.
freeze
,
good:
%(is_expected.to be_successful)
.
freeze
}
]
let
(
:source_file
)
{
'spec/foo_spec.rb'
}
let
(
:source_file
)
{
'spec/foo_spec.rb'
}
...
@@ -42,47 +48,30 @@ describe RuboCop::Cop::RSpec::BeSuccessMatcher do
...
@@ -42,47 +48,30 @@ describe RuboCop::Cop::RSpec::BeSuccessMatcher do
allow
(
cop
).
to
receive
(
:in_controller_spec?
).
and_return
(
true
)
allow
(
cop
).
to
receive
(
:in_controller_spec?
).
and_return
(
true
)
end
end
context
'using expect(response).to be_success call'
do
CODE_EXAMPLES
.
each
do
|
code_example
|
it_behaves_like
'an offensive be_success call'
,
OFFENSE_CALL_EXPECT_TO_BE_SUCCESS
context
"using
#{
code_example
[
:bad
]
}
call"
do
it_behaves_like
'an autocorrected be_success call'
,
OFFENSE_CALL_EXPECT_TO_BE_SUCCESS
,
CALL_EXPECT_TO_BE_SUCCESSFUL
it_behaves_like
'an offensive be_success call'
,
code_example
[
:bad
]
end
it_behaves_like
'an autocorrected be_success call'
,
code_example
[
:bad
],
code_example
[
:good
]
context
'using is_expected.to be_success call'
do
it_behaves_like
'an offensive be_success call'
,
OFFENSE_CALL_IS_EXPECTED_TO_BE_SUCCESS
it_behaves_like
'an autocorrected be_success call'
,
OFFENSE_CALL_IS_EXPECTED_TO_BE_SUCCESS
,
CALL_IS_EXPECTED_TO_BE_SUCCESSFUL
end
context
'using expect(response).to be_successful'
do
it
"does not register an offense"
do
inspect_source
(
CALL_EXPECT_TO_BE_SUCCESSFUL
)
expect
(
cop
.
offenses
.
size
).
to
eq
(
0
)
end
end
end
context
'using is_expected.to be_successful'
do
context
"using
#{
code_example
[
:good
]
}
call"
do
it
'does not register an offense'
do
it
"does not register an offense"
do
inspect_source
(
CALL_IS_EXPECTED_TO_BE_SUCCESSFUL
)
inspect_source
(
code_example
[
:good
]
)
expect
(
cop
.
offenses
.
size
).
to
eq
(
0
)
expect
(
cop
.
offenses
.
size
).
to
eq
(
0
)
end
end
end
end
end
end
end
context
'outside of a controller spec file'
do
context
'outside of a controller spec file'
do
context
'using expect(response).to be_success call'
do
CODE_EXAMPLES
.
each
do
|
code_example
|
it
'does not register an offense'
do
context
"using
#{
code_example
[
:bad
]
}
call"
do
inspect_source
(
OFFENSE_CALL_EXPECT_TO_BE_SUCCESS
)
it
'does not register an offense'
do
inspect_source
(
code_example
[
:bad
])
expect
(
cop
.
offenses
.
size
).
to
eq
(
0
)
end
end
context
'using is_expected.to be_success call'
do
it
'does not register an offense'
do
inspect_source
(
OFFENSE_CALL_IS_EXPECTED_TO_BE_SUCCESS
)
expect
(
cop
.
offenses
.
size
).
to
eq
(
0
)
expect
(
cop
.
offenses
.
size
).
to
eq
(
0
)
end
end
end
end
end
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录