Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
1b530f96
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
1b530f96
编写于
5月 18, 2018
作者:
A
Alex
提交者:
Robert Speicher
5月 18, 2018
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix double brackets being linkified in wiki markdown
上级
076ab2e8
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
37 addition
and
0 deletion
+37
-0
changelogs/unreleased/18524-fix-double-brackets-in-wiki-markdown.yml
...unreleased/18524-fix-double-brackets-in-wiki-markdown.yml
+5
-0
lib/banzai/filter/gollum_tags_filter.rb
lib/banzai/filter/gollum_tags_filter.rb
+3
-0
spec/features/projects/wiki/markdown_preview_spec.rb
spec/features/projects/wiki/markdown_preview_spec.rb
+23
-0
spec/lib/banzai/filter/gollum_tags_filter_spec.rb
spec/lib/banzai/filter/gollum_tags_filter_spec.rb
+6
-0
未找到文件。
changelogs/unreleased/18524-fix-double-brackets-in-wiki-markdown.yml
0 → 100644
浏览文件 @
1b530f96
---
title
:
Fix double-brackets being linkified in wiki markdown
merge_request
:
18524
author
:
brewingcode
type
:
fixed
lib/banzai/filter/gollum_tags_filter.rb
浏览文件 @
1b530f96
...
...
@@ -58,6 +58,9 @@ module Banzai
def
call
doc
.
search
(
".//text()"
).
each
do
|
node
|
# Do not perform linking inside <code> blocks
next
unless
node
.
ancestors
(
'code'
).
empty?
# A Gollum ToC tag is `[[_TOC_]]`, but due to MarkdownFilter running
# before this one, it will be converted into `[[<em>TOC</em>]]`, so it
# needs special-case handling
...
...
spec/features/projects/wiki/markdown_preview_spec.rb
浏览文件 @
1b530f96
...
...
@@ -155,4 +155,27 @@ feature 'Projects > Wiki > User previews markdown changes', :js do
end
end
end
it
"does not linkify double brackets inside code blocks as expected"
do
click_link
'New page'
page
.
within
'#modal-new-wiki'
do
fill_in
:new_wiki_path
,
with:
'linkify_test'
click_button
'Create page'
end
page
.
within
'.wiki-form'
do
fill_in
:wiki_content
,
with:
<<-
HEREDOC
`[[do_not_linkify]]`
```
[[also_do_not_linkify]]
```
HEREDOC
click_on
"Preview"
end
expect
(
page
).
to
have_content
(
"do_not_linkify"
)
expect
(
page
.
html
).
to
include
(
'[[do_not_linkify]]'
)
expect
(
page
.
html
).
to
include
(
'[[also_do_not_linkify]]'
)
end
end
spec/lib/banzai/filter/gollum_tags_filter_spec.rb
浏览文件 @
1b530f96
...
...
@@ -91,6 +91,12 @@ describe Banzai::Filter::GollumTagsFilter do
expect
(
doc
.
at_css
(
'a'
).
text
).
to
eq
'link-text'
expect
(
doc
.
at_css
(
'a'
)[
'href'
]).
to
eq
expected_path
end
it
"inside back ticks will be exempt from linkification"
do
doc
=
filter
(
'<code>[[link-in-backticks]]</code>'
,
project_wiki:
project_wiki
)
expect
(
doc
.
at_css
(
'code'
).
text
).
to
eq
'[[link-in-backticks]]'
end
end
context
'table of contents'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录