Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
0b3ff726
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
0b3ff726
编写于
8月 07, 2018
作者:
C
Constance Okoghenun
提交者:
Mike Greiling
8月 07, 2018
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Resolve "Board label edit drop down is showing incorrect selected labels summary"
上级
821f1a64
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
34 addition
and
6 deletion
+34
-6
app/assets/javascripts/boards/components/board_sidebar.js
app/assets/javascripts/boards/components/board_sidebar.js
+10
-0
app/assets/javascripts/gl_dropdown.js
app/assets/javascripts/gl_dropdown.js
+5
-1
app/assets/javascripts/labels_select.js
app/assets/javascripts/labels_select.js
+12
-4
app/views/shared/boards/components/sidebar/_labels.html.haml
app/views/shared/boards/components/sidebar/_labels.html.haml
+2
-1
changelogs/unreleased/44127-board-label-edit-drop-down-is-showing-incorrect-selected-labels-summary.yml
...rop-down-is-showing-incorrect-selected-labels-summary.yml
+5
-0
未找到文件。
app/assets/javascripts/boards/components/board_sidebar.js
浏览文件 @
0b3ff726
...
...
@@ -51,6 +51,16 @@ gl.issueBoards.BoardSidebar = Vue.extend({
canRemove
()
{
return
!
this
.
list
.
preset
;
},
hasLabels
()
{
return
this
.
issue
.
labels
&&
this
.
issue
.
labels
.
length
;
},
labelDropdownTitle
()
{
return
this
.
hasLabels
?
`
${
this
.
issue
.
labels
[
0
].
title
}
${
this
.
issue
.
labels
.
length
-
1
}
+ more`
:
'
Label
'
;
},
selectedLabels
()
{
return
this
.
hasLabels
?
this
.
issue
.
labels
.
map
(
l
=>
l
.
title
).
join
(
'
,
'
)
:
''
;
}
},
watch
:
{
detail
:
{
...
...
app/assets/javascripts/gl_dropdown.js
浏览文件 @
0b3ff726
...
...
@@ -616,7 +616,11 @@ GitLabDropdown = (function() {
}
if
(
this
.
options
.
opened
)
{
this
.
options
.
opened
.
call
(
this
,
e
);
if
(
this
.
options
.
preserveContext
)
{
this
.
options
.
opened
(
e
);
}
else
{
this
.
options
.
opened
.
call
(
this
,
e
);
}
}
return
this
.
dropdown
.
trigger
(
'
shown.gl.dropdown
'
);
...
...
app/assets/javascripts/labels_select.js
浏览文件 @
0b3ff726
...
...
@@ -39,7 +39,7 @@ export default class LabelsSelect {
showNo
=
$dropdown
.
data
(
'
showNo
'
);
showAny
=
$dropdown
.
data
(
'
showAny
'
);
showMenuAbove
=
$dropdown
.
data
(
'
showMenuAbove
'
);
defaultLabel
=
$dropdown
.
data
(
'
defaultLabel
'
);
defaultLabel
=
$dropdown
.
data
(
'
defaultLabel
'
)
||
'
Label
'
;
abilityName
=
$dropdown
.
data
(
'
abilityName
'
);
$selectbox
=
$dropdown
.
closest
(
'
.selectbox
'
);
$block
=
$selectbox
.
closest
(
'
.block
'
);
...
...
@@ -244,21 +244,21 @@ export default class LabelsSelect {
var
$dropdownInputField
=
$dropdownParent
.
find
(
'
.dropdown-input-field
'
);
var
isSelected
=
el
!==
null
?
el
.
hasClass
(
'
is-active
'
)
:
false
;
var
{
title
}
=
selected
;
var
title
=
selected
?
selected
.
title
:
null
;
var
selectedLabels
=
this
.
selected
;
if
(
$dropdownInputField
.
length
&&
$dropdownInputField
.
val
().
length
)
{
$dropdownParent
.
find
(
'
.dropdown-input-clear
'
).
trigger
(
'
click
'
);
}
if
(
selected
.
id
===
0
)
{
if
(
selected
&&
selected
.
id
===
0
)
{
this
.
selected
=
[];
return
'
No Label
'
;
}
else
if
(
isSelected
)
{
this
.
selected
.
push
(
title
);
}
else
{
else
if
(
!
isSelected
&&
title
)
{
var
index
=
this
.
selected
.
indexOf
(
title
);
this
.
selected
.
splice
(
index
,
1
);
}
...
...
@@ -409,6 +409,14 @@ export default class LabelsSelect {
}
}
},
opened
:
function
(
e
)
{
if
(
$dropdown
.
hasClass
(
'
js-issue-board-sidebar
'
))
{
const
previousSelection
=
$dropdown
.
attr
(
'
data-selected
'
);
this
.
selected
=
previousSelection
?
previousSelection
.
split
(
'
,
'
)
:
[];
$dropdown
.
data
(
'
glDropdown
'
).
updateLabel
();
}
},
preserveContext
:
true
,
});
// Set dropdown data
...
...
app/views/shared/boards/components/sidebar/_labels.html.haml
浏览文件 @
0b3ff726
...
...
@@ -19,6 +19,7 @@
":value"
=>
"label.id"
}
.dropdown
%button
.dropdown-menu-toggle.js-label-select.js-multiselect.js-issue-board-sidebar
{
type:
"button"
,
"v-bind:data-selected"
=>
"selectedLabels"
,
data:
{
toggle:
"dropdown"
,
field_name:
"issue[label_names][]"
,
show_no:
"true"
,
...
...
@@ -28,7 +29,7 @@
namespace_path:
@namespace_path
,
project_path:
@project
.
try
(
:path
)
}
}
%span
.dropdown-toggle-text
=
_
(
"Label"
)
{{ labelDropdownTitle }}
=
icon
(
'chevron-down'
)
.dropdown-menu.dropdown-select.dropdown-menu-paging.dropdown-menu-labels.dropdown-menu-selectable
=
render
partial:
"shared/issuable/label_page_default"
...
...
changelogs/unreleased/44127-board-label-edit-drop-down-is-showing-incorrect-selected-labels-summary.yml
0 → 100644
浏览文件 @
0b3ff726
---
title
:
Board label edit dropdown shows incorrect selected labels summary
merge_request
:
20673
author
:
type
:
fixed
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录