Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
0a0f66c8
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
0a0f66c8
编写于
5月 22, 2017
作者:
M
Michael Kozono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Refactor to remove a special case
上级
7d469cf1
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
29 addition
and
7 deletion
+29
-7
lib/gitlab/ci_access.rb
lib/gitlab/ci_access.rb
+9
-0
lib/gitlab/git_access.rb
lib/gitlab/git_access.rb
+5
-7
spec/lib/gitlab/ci_access_spec.rb
spec/lib/gitlab/ci_access_spec.rb
+15
-0
未找到文件。
lib/gitlab/ci_access.rb
0 → 100644
浏览文件 @
0a0f66c8
module
Gitlab
# For backwards compatibility, generic CI (which is a build without a user) is
# allowed to :build_download_code without any other checks.
class
CiAccess
def
can_do_action?
(
action
)
action
==
:build_download_code
end
end
end
lib/gitlab/git_access.rb
浏览文件 @
0a0f66c8
...
...
@@ -29,7 +29,11 @@ module Gitlab
@project
=
project
@protocol
=
protocol
@authentication_abilities
=
authentication_abilities
@user_access
=
UserAccess
.
new
(
user
,
project:
project
)
@user_access
=
if
ci?
CiAccess
.
new
else
UserAccess
.
new
(
user
,
project:
project
)
end
end
def
check
(
cmd
,
changes
)
...
...
@@ -62,11 +66,6 @@ module Gitlab
authentication_abilities
.
include?
(
:build_download_code
)
&&
user_access
.
can_do_action?
(
:build_download_code
)
end
# Allow generic CI (build without a user) for backwards compatibility
def
ci_can_download_code?
authentication_abilities
.
include?
(
:build_download_code
)
&&
ci?
end
def
protocol_allowed?
Gitlab
::
ProtocolAccess
.
allowed?
(
protocol
)
end
...
...
@@ -129,7 +128,6 @@ module Gitlab
return
if
deploy_key?
passed
=
user_can_download_code?
||
ci_can_download_code?
||
build_can_download_code?
||
guest_can_download_code?
...
...
spec/lib/gitlab/ci_access_spec.rb
0 → 100644
浏览文件 @
0a0f66c8
require
'spec_helper'
describe
Gitlab
::
CiAccess
,
lib:
true
do
let
(
:access
)
{
Gitlab
::
CiAccess
.
new
}
describe
'#can_do_action?'
do
context
'when action is :build_download_code'
do
it
{
expect
(
access
.
can_do_action?
(
:build_download_code
)).
to
be_truthy
}
end
context
'when action is not :build_download_code'
do
it
{
expect
(
access
.
can_do_action?
(
:download_code
)).
to
be_falsey
}
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录