Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
01d8c1f6
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
01d8c1f6
编写于
10月 31, 2018
作者:
D
Douglas Barbosa Alexandre
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Whitelist none method from ActiveRecord::Querying
上级
fc892db6
变更
14
隐藏空白更改
内联
并排
Showing
14 changed file
with
0 addition
and
31 deletion
+0
-31
app/finders/autocomplete/users_finder.rb
app/finders/autocomplete/users_finder.rb
+0
-2
app/finders/concerns/finder_with_cross_project_access.rb
app/finders/concerns/finder_with_cross_project_access.rb
+0
-2
app/finders/group_descendants_finder.rb
app/finders/group_descendants_finder.rb
+0
-2
app/finders/groups_finder.rb
app/finders/groups_finder.rb
+0
-4
app/finders/issuable_finder.rb
app/finders/issuable_finder.rb
+0
-4
app/finders/issues_finder.rb
app/finders/issues_finder.rb
+0
-2
app/finders/labels_finder.rb
app/finders/labels_finder.rb
+0
-2
app/finders/milestones_finder.rb
app/finders/milestones_finder.rb
+0
-2
app/finders/pipelines_finder.rb
app/finders/pipelines_finder.rb
+0
-2
app/finders/projects_finder.rb
app/finders/projects_finder.rb
+0
-2
app/finders/snippets_finder.rb
app/finders/snippets_finder.rb
+0
-2
app/services/search/group_service.rb
app/services/search/group_service.rb
+0
-2
lib/gitlab/user_extractor.rb
lib/gitlab/user_extractor.rb
+0
-2
rubocop/cop/code_reuse/active_record.rb
rubocop/cop/code_reuse/active_record.rb
+0
-1
未找到文件。
app/finders/autocomplete/users_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -72,7 +72,6 @@ module Autocomplete
author_id
.
present?
&&
current_user
end
# rubocop: disable CodeReuse/ActiveRecord
def
find_users
if
project
project
.
authorized_users
.
union_with_user
(
author_id
)
...
...
@@ -84,6 +83,5 @@ module Autocomplete
User
.
none
end
end
# rubocop: enable CodeReuse/ActiveRecord
end
end
app/finders/concerns/finder_with_cross_project_access.rb
浏览文件 @
01d8c1f6
...
...
@@ -16,7 +16,6 @@ module FinderWithCrossProjectAccess
end
override
:execute
# rubocop: disable CodeReuse/ActiveRecord
def
execute
(
*
args
)
check
=
Gitlab
::
CrossProjectAccess
.
find_check
(
self
)
original
=
super
...
...
@@ -30,7 +29,6 @@ module FinderWithCrossProjectAccess
original
end
end
# rubocop: enable CodeReuse/ActiveRecord
# We can skip the cross project check for finding indivitual records.
# this would be handled by the `can?(:read_*, result)` call in `FinderMethods`
...
...
app/finders/group_descendants_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -131,7 +131,6 @@ class GroupDescendantsFinder
.
with_selects_for_list
(
archived:
params
[
:archived
])
end
# rubocop: disable CodeReuse/ActiveRecord
def
subgroups
return
Group
.
none
unless
Group
.
supports_nested_groups?
...
...
@@ -145,7 +144,6 @@ class GroupDescendantsFinder
groups
.
with_selects_for_list
(
archived:
params
[
:archived
]).
order_by
(
sort
)
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/Finder
def
direct_child_projects
...
...
app/finders/groups_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -40,7 +40,6 @@ class GroupsFinder < UnionFinder
attr_reader
:current_user
,
:params
# rubocop: disable CodeReuse/ActiveRecord
def
all_groups
return
[
owned_groups
]
if
params
[
:owned
]
return
[
groups_with_min_access_level
]
if
min_access_level?
...
...
@@ -52,7 +51,6 @@ class GroupsFinder < UnionFinder
groups
<<
Group
.
none
if
groups
.
empty?
groups
end
# rubocop: enable CodeReuse/ActiveRecord
def
groups_for_ancestors
current_user
.
authorized_groups
...
...
@@ -82,11 +80,9 @@ class GroupsFinder < UnionFinder
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def
owned_groups
current_user
&
.
owned_groups
||
Group
.
none
end
# rubocop: enable CodeReuse/ActiveRecord
def
include_public_groups?
current_user
.
nil?
||
all_available?
...
...
app/finders/issuable_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -196,7 +196,6 @@ class IssuableFinder
milestones?
&&
params
[
:milestone_title
]
==
Milestone
::
None
.
title
end
# rubocop: disable CodeReuse/ActiveRecord
def
milestones
return
@milestones
if
defined?
(
@milestones
)
...
...
@@ -217,7 +216,6 @@ class IssuableFinder
Milestone
.
none
end
end
# rubocop: enable CodeReuse/ActiveRecord
def
labels?
params
[
:label_name
].
present?
...
...
@@ -227,7 +225,6 @@ class IssuableFinder
labels?
&&
params
[
:label_name
].
include?
(
Label
::
None
.
title
)
end
# rubocop: disable CodeReuse/ActiveRecord
def
labels
return
@labels
if
defined?
(
@labels
)
...
...
@@ -238,7 +235,6 @@ class IssuableFinder
Label
.
none
end
end
# rubocop: enable CodeReuse/ActiveRecord
def
assignee_id?
params
[
:assignee_id
].
present?
...
...
app/finders/issues_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -135,7 +135,6 @@ class IssuesFinder < IssuableFinder
current_user
.
blank?
end
# rubocop: disable CodeReuse/ActiveRecord
def
by_assignee
(
items
)
if
filter_by_no_assignee?
items
.
unassigned
...
...
@@ -149,5 +148,4 @@ class IssuesFinder < IssuableFinder
items
end
end
# rubocop: enable CodeReuse/ActiveRecord
end
app/finders/labels_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -12,7 +12,6 @@ class LabelsFinder < UnionFinder
@params
=
params
end
# rubocop: disable CodeReuse/ActiveRecord
def
execute
(
skip_authorization:
false
)
@skip_authorization
=
skip_authorization
items
=
find_union
(
label_ids
,
Label
)
||
Label
.
none
...
...
@@ -21,7 +20,6 @@ class LabelsFinder < UnionFinder
items
=
by_search
(
items
)
sort
(
items
)
end
# rubocop: enable CodeReuse/ActiveRecord
private
...
...
app/finders/milestones_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -20,7 +20,6 @@ class MilestonesFinder
@params
=
params
end
# rubocop: disable CodeReuse/ActiveRecord
def
execute
return
Milestone
.
none
if
project_ids
.
empty?
&&
group_ids
.
empty?
...
...
@@ -31,7 +30,6 @@ class MilestonesFinder
order
(
items
)
end
# rubocop: enable CodeReuse/ActiveRecord
private
...
...
app/finders/pipelines_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -12,7 +12,6 @@ class PipelinesFinder
@params
=
params
end
# rubocop: disable CodeReuse/ActiveRecord
def
execute
unless
Ability
.
allowed?
(
current_user
,
:read_pipeline
,
project
)
return
Ci
::
Pipeline
.
none
...
...
@@ -28,7 +27,6 @@ class PipelinesFinder
items
=
by_yaml_errors
(
items
)
sort_items
(
items
)
end
# rubocop: enable CodeReuse/ActiveRecord
private
...
...
app/finders/projects_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -88,7 +88,6 @@ class ProjectsFinder < UnionFinder
# rubocop: enable CodeReuse/ActiveRecord
# Builds a collection for an anonymous user.
# rubocop: disable CodeReuse/ActiveRecord
def
collection_without_user
if
private_only?
||
owned_projects?
||
min_access_level?
Project
.
none
...
...
@@ -96,7 +95,6 @@ class ProjectsFinder < UnionFinder
Project
.
public_to_user
end
end
# rubocop: enable CodeReuse/ActiveRecord
def
owned_projects?
params
[
:owned
].
present?
...
...
app/finders/snippets_finder.rb
浏览文件 @
01d8c1f6
...
...
@@ -43,7 +43,6 @@ class SnippetsFinder < UnionFinder
end
end
# rubocop: disable CodeReuse/ActiveRecord
def
authorized_snippets_from_project
if
can?
(
current_user
,
:read_project_snippet
,
project
)
if
project
.
team
.
member?
(
current_user
)
...
...
@@ -55,7 +54,6 @@ class SnippetsFinder < UnionFinder
Snippet
.
none
end
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def
authorized_snippets
...
...
app/services/search/group_service.rb
浏览文件 @
01d8c1f6
...
...
@@ -11,13 +11,11 @@ module Search
@group
=
group
end
# rubocop: disable CodeReuse/ActiveRecord
def
projects
return
Project
.
none
unless
group
return
@projects
if
defined?
@projects
@projects
=
super
.
inside_path
(
group
.
full_path
)
end
# rubocop: enable CodeReuse/ActiveRecord
end
end
lib/gitlab/user_extractor.rb
浏览文件 @
01d8c1f6
...
...
@@ -14,13 +14,11 @@ module Gitlab
@text
=
text
end
# rubocop: disable CodeReuse/ActiveRecord
def
users
return
User
.
none
unless
@text
.
present?
@users
||=
User
.
from_union
(
union_relations
)
end
# rubocop: enable CodeReuse/ActiveRecord
def
usernames
matches
[
:usernames
]
...
...
rubocop/cop/code_reuse/active_record.rb
浏览文件 @
01d8c1f6
...
...
@@ -49,7 +49,6 @@ module RuboCop
limit:
true
,
lock:
false
,
many?:
false
,
none:
false
,
offset:
true
,
order:
true
,
pluck:
true
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录