Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
01240a18
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
01240a18
编写于
11月 09, 2017
作者:
T
Tim Zallmann
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fixed Function + Test based on MR
上级
fb1b88de
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
9 addition
and
12 deletion
+9
-12
app/helpers/icons_helper.rb
app/helpers/icons_helper.rb
+2
-3
spec/helpers/icons_helper_spec.rb
spec/helpers/icons_helper_spec.rb
+7
-9
未找到文件。
app/helpers/icons_helper.rb
浏览文件 @
01240a18
module
IconsHelper
extend
self
include
Gitlab
::
CurrentSettings
include
FontAwesome
::
Rails
::
IconHelper
# Creates an icon tag given icon name(s) and possible icon modifiers.
...
...
@@ -27,14 +26,14 @@ module IconsHelper
def
sprite_icon_path
# SVG Sprites currently don't work across domains, so in the case of a CDN
# we have to set the current path deliberately to prevent addition of asset_host
sprite_base_url
=
ActionController
::
Base
.
asset_host
.
present?
?
Gitlab
.
config
.
gitlab
.
url
:
nil
sprite_base_url
=
Gitlab
.
config
.
gitlab
.
url
if
ActionController
::
Base
.
asset_host
ActionController
::
Base
.
helpers
.
image_path
(
'icons.svg'
,
host:
sprite_base_url
)
end
def
sprite_icon
(
icon_name
,
size:
nil
,
css_class:
nil
)
css_classes
=
size
?
"s
#{
size
}
"
:
""
css_classes
<<
"
#{
css_class
}
"
unless
css_class
.
blank?
content_tag
(
:svg
,
content_tag
(
:use
,
""
,
{
"xlink:href"
=>
"
#{
sprite_icon_path
()
}
#
#{
icon_name
}
"
}
),
class:
css_classes
.
empty?
?
nil
:
css_classes
)
content_tag
(
:svg
,
content_tag
(
:use
,
""
,
{
"xlink:href"
=>
"
#{
sprite_icon_path
}
#
#{
icon_name
}
"
}
),
class:
css_classes
.
empty?
?
nil
:
css_classes
)
end
def
audit_icon
(
names
,
options
=
{})
...
...
spec/helpers/icons_helper_spec.rb
浏览文件 @
01240a18
require
'spec_helper'
describe
IconsHelper
do
let
(
:icons_path
)
{
ActionController
::
Base
.
helpers
.
image_path
(
"icons.svg"
)
}
describe
'icon'
do
it
'returns aria-hidden by default'
do
star
=
icon
(
'star'
)
...
...
@@ -18,8 +20,8 @@ describe IconsHelper do
describe
'sprite_icon_path'
do
it
'returns relative path'
do
expect
(
sprite_icon_path
()
)
.
to
eq
icons_path
()
expect
(
sprite_icon_path
)
.
to
eq
icons_path
end
context
'when an asset_host is set in the config it will return an absolute local URL'
do
...
...
@@ -41,17 +43,17 @@ describe IconsHelper do
it
'returns svg icon html'
do
expect
(
sprite_icon
(
icon_name
).
to_s
)
.
to
eq
"<svg><use xlink:href=
\"
#{
icons_path
()
}
#
#{
icon_name
}
\"
></use></svg>"
.
to
eq
"<svg><use xlink:href=
\"
#{
icons_path
}
#
#{
icon_name
}
\"
></use></svg>"
end
it
'returns svg icon html + size classes'
do
expect
(
sprite_icon
(
icon_name
,
size:
72
).
to_s
)
.
to
eq
"<svg class=
\"
s72
\"
><use xlink:href=
\"
#{
icons_path
()
}
#
#{
icon_name
}
\"
></use></svg>"
.
to
eq
"<svg class=
\"
s72
\"
><use xlink:href=
\"
#{
icons_path
}
#
#{
icon_name
}
\"
></use></svg>"
end
it
'returns svg icon html + size classes + additional class'
do
expect
(
sprite_icon
(
icon_name
,
size:
72
,
css_class:
'icon-danger'
).
to_s
)
.
to
eq
"<svg class=
\"
s72 icon-danger
\"
><use xlink:href=
\"
#{
icons_path
()
}
#{
icon_name
}
\"
></use></svg>"
.
to
eq
"<svg class=
\"
s72 icon-danger
\"
><use xlink:href=
\"
#{
icons_path
}
#
#{
icon_name
}
\"
></use></svg>"
end
end
...
...
@@ -160,8 +162,4 @@ describe IconsHelper do
expect
(
file_type_icon_class
(
'file'
,
0
,
'CHANGELOG'
)).
to
eq
'file-text-o'
end
end
def
icons_path
ActionController
::
Base
.
helpers
.
image_path
(
"icons.svg"
)
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录