create_pipeline_service_spec.rb 33.3 KB
Newer Older
1 2
# frozen_string_literal: true

3 4
require 'spec_helper'

5
describe Ci::CreatePipelineService do
B
Bob Van Landuyt 已提交
6 7
  include ProjectForksHelper

8
  set(:project) { create(:project, :repository) }
9
  let(:user) { create(:admin) }
10
  let(:ref_name) { 'refs/heads/master' }
11 12

  before do
13
    stub_repository_ci_yaml_file(sha: anything)
14 15 16
  end

  describe '#execute' do
17
    # rubocop:disable Metrics/ParameterLists
18 19 20 21 22
    def execute_service(
      source: :push,
      after: project.commit.id,
      message: 'Message',
      ref: ref_name,
23
      trigger_request: nil,
S
Shinya Maeda 已提交
24
      variables_attributes: nil,
25
      merge_request: nil,
26 27 28
      push_options: nil,
      source_sha: nil,
      target_sha: nil)
29 30 31
      params = { ref: ref,
                 before: '00000000',
                 after: after,
32
                 commits: [{ message: message }],
33
                 variables_attributes: variables_attributes,
34 35 36
                 push_options: push_options,
                 source_sha: source_sha,
                 target_sha: target_sha }
37

38
      described_class.new(project, user, params).execute(
S
Shinya Maeda 已提交
39
        source, trigger_request: trigger_request, merge_request: merge_request)
40
    end
41
    # rubocop:enable Metrics/ParameterLists
42

43 44 45
    context 'valid params' do
      let(:pipeline) { execute_service }

46 47 48 49 50 51
      let(:pipeline_on_previous_commit) do
        execute_service(
          after: previous_commit_sha_from_ref('master')
        )
      end

52 53 54
      it 'creates a pipeline' do
        expect(pipeline).to be_kind_of(Ci::Pipeline)
        expect(pipeline).to be_valid
55
        expect(pipeline).to be_persisted
56
        expect(pipeline).to be_push
57
        expect(pipeline).to eq(project.ci_pipelines.last)
58 59
        expect(pipeline).to have_attributes(user: user)
        expect(pipeline).to have_attributes(status: 'pending')
60
        expect(pipeline.repository_source?).to be true
61 62
        expect(pipeline.builds.first).to be_kind_of(Ci::Build)
      end
63

64 65
      it 'increments the prometheus counter' do
        expect(Gitlab::Metrics).to receive(:counter)
B
Ben Kochie 已提交
66
          .with(:pipelines_created_total, "Counter of pipelines created")
67 68 69 70 71
          .and_call_original

        pipeline
      end

72
      context 'when merge requests already exist for this source branch' do
73
        let(:merge_request_1) do
S
Shinya Maeda 已提交
74
          create(:merge_request, source_branch: 'feature', target_branch: "master", source_project: project)
75 76
        end
        let(:merge_request_2) do
S
Shinya Maeda 已提交
77
          create(:merge_request, source_branch: 'feature', target_branch: "v1.1.0", source_project: project)
78
        end
79

80 81 82 83 84 85 86 87 88 89 90 91
        context 'when related merge request is already merged' do
          let!(:merged_merge_request) do
            create(:merge_request, source_branch: 'master', target_branch: "branch_2", source_project: project, state: 'merged')
          end

          it 'does not schedule update head pipeline job' do
            expect(UpdateHeadPipelineForMergeRequestWorker).not_to receive(:perform_async).with(merged_merge_request.id)

            execute_service
          end
        end

92 93 94 95 96
        context 'when the head pipeline sha equals merge request sha' do
          it 'updates head pipeline of each merge request' do
            merge_request_1
            merge_request_2

S
Shinya Maeda 已提交
97
            head_pipeline = execute_service(ref: 'feature', after: nil)
98

99 100 101 102 103 104
            expect(merge_request_1.reload.head_pipeline).to eq(head_pipeline)
            expect(merge_request_2.reload.head_pipeline).to eq(head_pipeline)
          end
        end

        context 'when the head pipeline sha does not equal merge request sha' do
105
          it 'does not update the head piepeline of MRs' do
106 107 108 109
            merge_request_1
            merge_request_2

            allow_any_instance_of(Ci::Pipeline).to receive(:latest?).and_return(true)
110

111
            expect { execute_service(after: 'ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }.not_to raise_error
112 113 114 115 116 117

            last_pipeline = Ci::Pipeline.last

            expect(merge_request_1.reload.head_pipeline).not_to eq(last_pipeline)
            expect(merge_request_2.reload.head_pipeline).not_to eq(last_pipeline)
          end
118 119 120 121
        end

        context 'when there is no pipeline for source branch' do
          it "does not update merge request head pipeline" do
122 123 124
            merge_request = create(:merge_request, source_branch: 'feature',
                                                   target_branch: "branch_1",
                                                   source_project: project)
125

126
            head_pipeline = execute_service
127 128 129 130 131 132

            expect(merge_request.reload.head_pipeline).not_to eq(head_pipeline)
          end
        end

        context 'when merge request target project is different from source project' do
B
Bob Van Landuyt 已提交
133
          let!(:project) { fork_project(target_project, nil, repository: true) }
134
          let!(:target_project) { create(:project, :repository) }
135

136
          it 'updates head pipeline for merge request' do
S
Shinya Maeda 已提交
137 138
            merge_request = create(:merge_request, source_branch: 'feature',
                                                   target_branch: "master",
139 140
                                                   source_project: project,
                                                   target_project: target_project)
141

S
Shinya Maeda 已提交
142
            head_pipeline = execute_service(ref: 'feature', after: nil)
143 144 145 146

            expect(merge_request.reload.head_pipeline).to eq(head_pipeline)
          end
        end
147

148
        context 'when the pipeline is not the latest for the branch' do
149
          it 'does not update merge request head pipeline' do
150 151 152
            merge_request = create(:merge_request, source_branch: 'master',
                                                   target_branch: "branch_1",
                                                   source_project: project)
153

154 155
            allow_any_instance_of(MergeRequest)
              .to receive(:find_actual_head_pipeline) { }
156

157
            execute_service
158 159 160 161

            expect(merge_request.reload.head_pipeline).to be_nil
          end
        end
162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179

        context 'when pipeline has errors' do
          before do
            stub_ci_pipeline_yaml_file('some invalid syntax')
          end

          it 'updates merge request head pipeline reference' do
            merge_request = create(:merge_request, source_branch: 'master',
                                                   target_branch: 'feature',
                                                   source_project: project)

            head_pipeline = execute_service

            expect(head_pipeline).to be_persisted
            expect(head_pipeline.yaml_errors).to be_present
            expect(merge_request.reload.head_pipeline).to eq head_pipeline
          end
        end
180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199

        context 'when pipeline has been skipped' do
          before do
            allow_any_instance_of(Ci::Pipeline)
              .to receive(:git_commit_message)
              .and_return('some commit [ci skip]')
          end

          it 'updates merge request head pipeline' do
            merge_request = create(:merge_request, source_branch: 'master',
                                                   target_branch: 'feature',
                                                   source_project: project)

            head_pipeline = execute_service

            expect(head_pipeline).to be_skipped
            expect(head_pipeline).to be_persisted
            expect(merge_request.reload.head_pipeline).to eq head_pipeline
          end
        end
200 201
      end

202 203 204 205 206
      context 'auto-cancel enabled' do
        before do
          project.update(auto_cancel_pending_pipelines: 'enabled')
        end

207 208
        it 'does not cancel HEAD pipeline' do
          pipeline
R
Rydkin Maxim 已提交
209
          pipeline_on_previous_commit
210

R
Rydkin Maxim 已提交
211
          expect(pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil)
212
        end
213 214

        it 'auto cancel pending non-HEAD pipelines' do
R
Rydkin Maxim 已提交
215
          pipeline_on_previous_commit
216 217
          pipeline

R
Rydkin Maxim 已提交
218
          expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: pipeline.id)
219 220 221
        end

        it 'does not cancel running outdated pipelines' do
R
Rydkin Maxim 已提交
222
          pipeline_on_previous_commit.run
223 224
          execute_service

R
Rydkin Maxim 已提交
225
          expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'running', auto_canceled_by_id: nil)
226 227 228
        end

        it 'cancel created outdated pipelines' do
R
Rydkin Maxim 已提交
229
          pipeline_on_previous_commit.update(status: 'created')
230 231
          pipeline

R
Rydkin Maxim 已提交
232
          expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: pipeline.id)
233 234 235 236 237 238 239 240 241
        end

        it 'does not cancel pipelines from the other branches' do
          pending_pipeline = execute_service(
            ref: 'refs/heads/feature',
            after: previous_commit_sha_from_ref('feature')
          )
          pipeline

242
          expect(pending_pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil)
243 244
        end
      end
245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262

      context 'auto-cancel disabled' do
        before do
          project.update(auto_cancel_pending_pipelines: 'disabled')
        end

        it 'does not auto cancel pending non-HEAD pipelines' do
          pipeline_on_previous_commit
          pipeline

          expect(pipeline_on_previous_commit.reload)
            .to have_attributes(status: 'pending', auto_canceled_by_id: nil)
        end
      end

      def previous_commit_sha_from_ref(ref)
        project.commit(ref).parent.sha
      end
263 264
    end

265 266
    context "skip tag if there is no build for it" do
      it "creates commit if there is appropriate job" do
267
        expect(execute_service).to be_persisted
268 269 270 271 272 273
      end

      it "creates commit if there is no appropriate job but deploy job has right ref setting" do
        config = YAML.dump({ deploy: { script: "ls", only: ["master"] } })
        stub_ci_pipeline_yaml_file(config)

274
        expect(execute_service).to be_persisted
275 276 277 278 279 280
      end
    end

    it 'skips creating pipeline for refs without .gitlab-ci.yml' do
      stub_ci_pipeline_yaml_file(nil)

281
      expect(execute_service).not_to be_persisted
282 283 284
      expect(Ci::Pipeline.count).to eq(0)
    end

285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310
    shared_examples 'a failed pipeline' do
      it 'creates failed pipeline' do
        stub_ci_pipeline_yaml_file(ci_yaml)

        pipeline = execute_service(message: message)

        expect(pipeline).to be_persisted
        expect(pipeline.builds.any?).to be false
        expect(pipeline.status).to eq('failed')
        expect(pipeline.yaml_errors).not_to be_nil
      end
    end

    context 'when yaml is invalid' do
      let(:ci_yaml) { 'invalid: file: fiile' }
      let(:message) { 'Message' }

      it_behaves_like 'a failed pipeline'

      context 'when receive git commit' do
        before do
          allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { message }
        end

        it_behaves_like 'a failed pipeline'
      end
311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360

      context 'when config has ports' do
        context 'in the main image' do
          let(:ci_yaml) do
            <<-EOS
              image:
                name: ruby:2.2
                ports:
                  - 80
            EOS
          end

          it_behaves_like 'a failed pipeline'
        end

        context 'in the job image' do
          let(:ci_yaml) do
            <<-EOS
              image: ruby:2.2

              test:
                script: rspec
                image:
                  name: ruby:2.2
                  ports:
                    - 80
            EOS
          end

          it_behaves_like 'a failed pipeline'
        end

        context 'in the service' do
          let(:ci_yaml) do
            <<-EOS
              image: ruby:2.2

              test:
                script: rspec
                image: ruby:2.2
                services:
                  - name: test
                    ports:
                      - 80
            EOS
          end

          it_behaves_like 'a failed pipeline'
        end
      end
361 362 363 364
    end

    context 'when commit contains a [ci skip] directive' do
      let(:message) { "some message[ci skip]" }
365 366 367 368 369 370 371 372 373 374 375

      ci_messages = [
        "some message[ci skip]",
        "some message[skip ci]",
        "some message[CI SKIP]",
        "some message[SKIP CI]",
        "some message[ci_skip]",
        "some message[skip_ci]",
        "some message[ci-skip]",
        "some message[skip-ci]"
      ]
376 377 378 379 380

      before do
        allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { message }
      end

381 382
      ci_messages.each do |ci_message|
        it "skips builds creation if the commit message is #{ci_message}" do
383
          pipeline = execute_service(message: ci_message)
384 385 386 387 388

          expect(pipeline).to be_persisted
          expect(pipeline.builds.any?).to be false
          expect(pipeline.status).to eq("skipped")
        end
389 390
      end

391
      shared_examples 'creating a pipeline' do
R
Rydkin Maxim 已提交
392
        it 'does not skip pipeline creation' do
393
          allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { commit_message }
394

395
          pipeline = execute_service(message: commit_message)
396

397 398 399
          expect(pipeline).to be_persisted
          expect(pipeline.builds.first.name).to eq("rspec")
        end
400 401
      end

402 403
      context 'when commit message does not contain [ci skip] nor [skip ci]' do
        let(:commit_message) { 'some message' }
404

405
        it_behaves_like 'creating a pipeline'
406 407
      end

408 409
      context 'when commit message is nil' do
        let(:commit_message) { nil }
410

411
        it_behaves_like 'creating a pipeline'
412 413
      end

414 415 416 417 418
      context 'when there is [ci skip] tag in commit message and yaml is invalid' do
        let(:ci_yaml) { 'invalid: file: fiile' }

        it_behaves_like 'a failed pipeline'
      end
419 420
    end

421 422
    context 'when push options contain ci.skip' do
      let(:push_options) do
423
        { 'ci' => { 'skip' => true } }
424 425 426 427 428 429 430 431 432 433 434 435
      end

      it 'creates a pipline in the skipped state' do
        pipeline = execute_service(push_options: push_options)

        # TODO: DRY these up with "skips builds creation if the commit message"
        expect(pipeline).to be_persisted
        expect(pipeline.builds.any?).to be false
        expect(pipeline.status).to eq("skipped")
      end
    end

436 437 438 439 440 441 442
    context 'when there are no jobs for this pipeline' do
      before do
        config = YAML.dump({ test: { script: 'ls', only: ['feature'] } })
        stub_ci_pipeline_yaml_file(config)
      end

      it 'does not create a new pipeline' do
443
        result = execute_service
444 445 446 447 448 449 450 451 452 453 454 455 456 457

        expect(result).not_to be_persisted
        expect(Ci::Build.all).to be_empty
        expect(Ci::Pipeline.count).to eq(0)
      end
    end

    context 'with manual actions' do
      before do
        config = YAML.dump({ deploy: { script: 'ls', when: 'manual' } })
        stub_ci_pipeline_yaml_file(config)
      end

      it 'does not create a new pipeline' do
458
        result = execute_service
459 460 461 462 463

        expect(result).to be_persisted
        expect(result.manual_actions).not_to be_empty
      end
    end
464 465 466

    context 'with environment' do
      before do
K
Kamil Trzciński 已提交
467 468 469 470 471 472 473
        config = YAML.dump(
          deploy: {
            environment: { name: "review/$CI_COMMIT_REF_NAME" },
            script: 'ls',
            tags: ['hello']
          })

474 475 476
        stub_ci_pipeline_yaml_file(config)
      end

K
Kamil Trzciński 已提交
477
      it 'creates the environment with tags' do
478
        result = execute_service
479 480

        expect(result).to be_persisted
481
        expect(Environment.find_by(name: "review/master")).to be_present
K
Kamil Trzciński 已提交
482
        expect(result.builds.first.tag_list).to contain_exactly('hello')
K
Kamil Trzciński 已提交
483 484
        expect(result.builds.first.deployment).to be_persisted
        expect(result.builds.first.deployment.deployable).to be_a(Ci::Build)
K
Kamil Trzciński 已提交
485
      end
486 487 488 489 490 491 492
    end

    context 'with environment name including persisted variables' do
      before do
        config = YAML.dump(
          deploy: {
            environment: { name: "review/id1$CI_PIPELINE_ID/id2$CI_BUILD_ID" },
493 494
            script: 'ls'
          }
495 496 497 498 499 500 501 502 503 504
        )

        stub_ci_pipeline_yaml_file(config)
      end

      it 'skipps persisted variables in environment name' do
        result = execute_service

        expect(result).to be_persisted
        expect(Environment.find_by(name: "review/id1/id2")).to be_present
505 506
      end
    end
507 508 509 510 511 512 513 514 515 516 517 518 519 520 521

    context 'when environment with invalid name' do
      before do
        config = YAML.dump(deploy: { environment: { name: 'name,with,commas' }, script: 'ls' })
        stub_ci_pipeline_yaml_file(config)
      end

      it 'does not create an environment' do
        expect do
          result = execute_service

          expect(result).to be_persisted
        end.not_to change { Environment.count }
      end
    end
522

523
    context 'when builds with auto-retries are configured' do
524 525 526 527 528 529 530 531 532 533 534 535 536
      context 'as an integer' do
        before do
          config = YAML.dump(rspec: { script: 'rspec', retry: 2 })
          stub_ci_pipeline_yaml_file(config)
        end

        it 'correctly creates builds with auto-retry value configured' do
          pipeline = execute_service

          expect(pipeline).to be_persisted
          expect(pipeline.builds.find_by(name: 'rspec').retries_max).to eq 2
          expect(pipeline.builds.find_by(name: 'rspec').retry_when).to eq ['always']
        end
537 538
      end

539 540 541 542 543
      context 'as hash' do
        before do
          config = YAML.dump(rspec: { script: 'rspec', retry: { max: 2, when: 'runner_system_failure' } })
          stub_ci_pipeline_yaml_file(config)
        end
544

545 546 547 548 549 550 551
        it 'correctly creates builds with auto-retry value configured' do
          pipeline = execute_service

          expect(pipeline).to be_persisted
          expect(pipeline.builds.find_by(name: 'rspec').retries_max).to eq 2
          expect(pipeline.builds.find_by(name: 'rspec').retry_when).to eq ['runner_system_failure']
        end
552 553
      end
    end
554

555 556 557 558 559 560 561 562 563 564 565 566 567 568
    shared_examples 'when ref is protected' do
      let(:user) { create(:user) }

      context 'when user is developer' do
        before do
          project.add_developer(user)
        end

        it 'does not create a pipeline' do
          expect(execute_service).not_to be_persisted
          expect(Ci::Pipeline.count).to eq(0)
        end
      end

569
      context 'when user is maintainer' do
S
Shinya Maeda 已提交
570 571
        let(:pipeline) { execute_service }

572
        before do
573
          project.add_maintainer(user)
574 575
        end

S
Shinya Maeda 已提交
576 577 578
        it 'creates a protected pipeline' do
          expect(pipeline).to be_persisted
          expect(pipeline).to be_protected
579 580 581
          expect(Ci::Pipeline.count).to eq(1)
        end
      end
582 583 584 585 586 587 588 589 590 591 592 593 594

      context 'when trigger belongs to no one' do
        let(:user) {}
        let(:trigger_request) { create(:ci_trigger_request) }

        it 'does not create a pipeline' do
          expect(execute_service(trigger_request: trigger_request))
            .not_to be_persisted
          expect(Ci::Pipeline.count).to eq(0)
        end
      end

      context 'when trigger belongs to a developer' do
S
Shinya Maeda 已提交
595 596 597
        let(:user) { create(:user) }
        let(:trigger) { create(:ci_trigger, owner: user) }
        let(:trigger_request) { create(:ci_trigger_request, trigger: trigger) }
598

S
Shinya Maeda 已提交
599 600
        before do
          project.add_developer(user)
601 602 603 604 605 606 607 608 609
        end

        it 'does not create a pipeline' do
          expect(execute_service(trigger_request: trigger_request))
            .not_to be_persisted
          expect(Ci::Pipeline.count).to eq(0)
        end
      end

610
      context 'when trigger belongs to a maintainer' do
S
Shinya Maeda 已提交
611 612 613
        let(:user) { create(:user) }
        let(:trigger) { create(:ci_trigger, owner: user) }
        let(:trigger_request) { create(:ci_trigger_request, trigger: trigger) }
614

S
Shinya Maeda 已提交
615
        before do
616
          project.add_maintainer(user)
617 618
        end

S
Shinya Maeda 已提交
619
        it 'creates a pipeline' do
620 621 622 623 624
          expect(execute_service(trigger_request: trigger_request))
            .to be_persisted
          expect(Ci::Pipeline.count).to eq(1)
        end
      end
625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643
    end

    context 'when ref is a protected branch' do
      before do
        create(:protected_branch, project: project, name: 'master')
      end

      it_behaves_like 'when ref is protected'
    end

    context 'when ref is a protected tag' do
      let(:ref_name) { 'refs/tags/v1.0.0' }

      before do
        create(:protected_tag, project: project, name: '*')
      end

      it_behaves_like 'when ref is protected'
    end
644 645 646 647

    context 'when ref is not protected' do
      context 'when trigger belongs to no one' do
        let(:user) {}
648 649
        let(:trigger) { create(:ci_trigger, owner: nil) }
        let(:trigger_request) { create(:ci_trigger_request, trigger: trigger) }
S
Shinya Maeda 已提交
650
        let(:pipeline) { execute_service(trigger_request: trigger_request) }
651

S
Shinya Maeda 已提交
652 653 654
        it 'creates an unprotected pipeline' do
          expect(pipeline).to be_persisted
          expect(pipeline).not_to be_protected
655
          expect(Ci::Pipeline.count).to eq(1)
656 657 658
        end
      end
    end
659

K
Kamil Trzcinski 已提交
660
    context 'when pipeline is running for a tag' do
661 662
      before do
        config = YAML.dump(test: { script: 'test', only: ['branches'] },
K
Kamil Trzcinski 已提交
663
                           deploy: { script: 'deploy', only: ['tags'] })
664 665 666 667 668

        stub_ci_pipeline_yaml_file(config)
      end

      it 'creates a tagged pipeline' do
K
Kamil Trzcinski 已提交
669
        pipeline = execute_service(ref: 'v1.0.0')
670 671 672 673

        expect(pipeline.tag?).to be true
      end
    end
674 675

    context 'when pipeline variables are specified' do
676
      let(:variables_attributes) do
677 678 679 680
        [{ key: 'first', secret_value: 'world' },
         { key: 'second', secret_value: 'second_world' }]
      end

681
      subject { execute_service(variables_attributes: variables_attributes) }
682 683

      it 'creates a pipeline with specified variables' do
M
Matija Čupić 已提交
684 685
        expect(subject.variables.map { |var| var.slice(:key, :secret_value) })
          .to eq variables_attributes.map(&:with_indifferent_access)
686 687
      end
    end
688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735

    context 'when pipeline has a job with environment' do
      let(:pipeline) { execute_service }

      before do
        stub_ci_pipeline_yaml_file(YAML.dump(config))
      end

      context 'when environment name is valid' do
        let(:config) do
          {
            review_app: {
              script: 'deploy',
              environment: {
                name: 'review/${CI_COMMIT_REF_NAME}',
                url: 'http://${CI_COMMIT_REF_SLUG}-staging.example.com'
              }
            }
          }
        end

        it 'has a job with environment' do
          expect(pipeline.builds.count).to eq(1)
          expect(pipeline.builds.first.persisted_environment.name).to eq('review/master')
          expect(pipeline.builds.first.deployment).to be_created
        end
      end

      context 'when environment name is invalid' do
        let(:config) do
          {
            'job:deploy-to-test-site': {
              script: 'deploy',
              environment: {
                name: '${CI_JOB_NAME}',
                url: 'https://$APP_URL'
              }
            }
          }
        end

        it 'has a job without environment' do
          expect(pipeline.builds.count).to eq(1)
          expect(pipeline.builds.first.persisted_environment).to be_nil
          expect(pipeline.builds.first.deployment).to be_nil
        end
      end
    end
S
Shinya Maeda 已提交
736 737 738

    describe 'Merge request pipelines' do
      let(:pipeline) do
739 740 741 742 743
        execute_service(source: source,
                        merge_request: merge_request,
                        ref: ref_name,
                        source_sha: source_sha,
                        target_sha: target_sha)
S
Shinya Maeda 已提交
744 745 746 747 748 749
      end

      before do
        stub_ci_pipeline_yaml_file(YAML.dump(config))
      end

750
      let(:ref_name) { 'refs/heads/feature' }
751 752
      let(:source_sha) { project.commit(ref_name).id }
      let(:target_sha) { nil }
S
Shinya Maeda 已提交
753 754

      context 'when source is merge request' do
755
        let(:source) { :merge_request_event }
S
Shinya Maeda 已提交
756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780

        context "when config has merge_requests keywords" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo'
              },
              test: {
                stage: 'test',
                script: 'echo',
                only: ['merge_requests']
              },
              pages: {
                stage: 'deploy',
                script: 'echo',
                except: ['merge_requests']
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
781
                source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
782 783 784 785 786 787
                target_project: project,
                target_branch: 'master')
            end

            it 'creates a merge request pipeline' do
              expect(pipeline).to be_persisted
788
              expect(pipeline).to be_merge_request_event
S
Shinya Maeda 已提交
789 790 791 792
              expect(pipeline.merge_request).to eq(merge_request)
              expect(pipeline.builds.order(:stage_id).map(&:name)).to eq(%w[test])
            end

793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808
            it 'persists the specified source sha' do
              expect(pipeline.source_sha).to eq(source_sha)
            end

            it 'does not persist target sha for detached merge request pipeline' do
              expect(pipeline.target_sha).to be_nil
            end

            context 'when target sha is specified' do
              let(:target_sha) { merge_request.target_branch_sha }

              it 'persists the target sha' do
                expect(pipeline.target_sha).to eq(target_sha)
              end
            end

S
Shinya Maeda 已提交
809
            context 'when ref is tag' do
810
              let(:ref_name) { 'refs/tags/v1.1.0' }
S
Shinya Maeda 已提交
811 812 813 814 815 816 817 818 819 820 821

              it 'does not create a merge request pipeline' do
                expect(pipeline).not_to be_persisted
                expect(pipeline.errors[:tag]).to eq(["is not included in the list"])
              end
            end

            context 'when merge request is created from a forked project' do
              let(:merge_request) do
                create(:merge_request,
                  source_project: project,
822
                  source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
823 824 825 826 827 828 829 830 831
                  target_project: target_project,
                  target_branch: 'master')
              end

              let!(:project) { fork_project(target_project, nil, repository: true) }
              let!(:target_project) { create(:project, :repository) }

              it 'creates a merge request pipeline in the forked project' do
                expect(pipeline).to be_persisted
832 833
                expect(project.ci_pipelines).to eq([pipeline])
                expect(target_project.ci_pipelines).to be_empty
S
Shinya Maeda 已提交
834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886
              end
            end

            context "when there are no matched jobs" do
              let(:config) do
                {
                  test: {
                    stage: 'test',
                    script: 'echo',
                    except: ['merge_requests']
                  }
                }
              end

              it 'does not create a merge request pipeline' do
                expect(pipeline).not_to be_persisted
                expect(pipeline.errors[:base]).to eq(["No stages / jobs for this pipeline."])
              end
            end
          end

          context 'when merge request is not specified' do
            let(:merge_request) { nil }

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted
              expect(pipeline.errors[:merge_request]).to eq(["can't be blank"])
            end
          end
        end

        context "when config does not have merge_requests keywords" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo'
              },
              test: {
                stage: 'test',
                script: 'echo'
              },
              pages: {
                stage: 'deploy',
                script: 'echo'
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
887
                source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end

          context 'when merge request is not specified' do
            let(:merge_request) { nil }

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end
S
Shinya Maeda 已提交
911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940

        context "when config uses regular expression for only keyword" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo',
                only: ["/^#{ref_name}$/"]
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
                source_branch: ref_name,
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end

941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971
        context "when config uses variables for only keyword" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo',
                only: {
                  variables: %w($CI)
                }
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
                source_branch: ref_name,
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end

S
Shinya Maeda 已提交
972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999
        context "when config has 'except: [tags]'" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo',
                except: ['tags']
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
                source_branch: ref_name,
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end
S
Shinya Maeda 已提交
1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
      end

      context 'when source is web' do
        let(:source) { :web }

        context "when config has merge_requests keywords" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo'
              },
              test: {
                stage: 'test',
                script: 'echo',
                only: ['merge_requests']
              },
              pages: {
                stage: 'deploy',
                script: 'echo',
                except: ['merge_requests']
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
1029
                source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted
              expect(pipeline.errors[:merge_request]).to eq(["must be blank"])
            end
          end

          context 'when merge request is not specified' do
            let(:merge_request) { nil }

            it 'creates a branch pipeline' do
              expect(pipeline).to be_persisted
              expect(pipeline).to be_web
              expect(pipeline.merge_request).to be_nil
              expect(pipeline.builds.order(:stage_id).map(&:name)).to eq(%w[build pages])
            end
          end
        end
      end
    end
1053
  end
S
Shinya Maeda 已提交
1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086

  describe '#execute!' do
    subject { service.execute!(*args) }

    let(:service) { described_class.new(project, user, ref: ref_name) }
    let(:args) { [:push] }

    context 'when user has a permission to create a pipeline' do
      let(:user) { create(:user) }

      before do
        project.add_developer(user)
      end

      it 'does not raise an error' do
        expect { subject }.not_to raise_error
      end

      it 'creates a pipeline' do
        expect { subject }.to change { Ci::Pipeline.count }.by(1)
      end
    end

    context 'when user does not have a permission to create a pipeline' do
      let(:user) { create(:user) }

      it 'raises an error' do
        expect { subject }
          .to raise_error(described_class::CreateError)
          .with_message('Insufficient permissions to create a new pipeline')
      end
    end
  end
1087
end