user_spec.rb 19.8 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2 3 4
# == Schema Information
#
# Table name: users
#
D
Dmitriy Zaporozhets 已提交
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51
#  id                            :integer          not null, primary key
#  email                         :string(255)      default(""), not null
#  encrypted_password            :string(255)      default(""), not null
#  reset_password_token          :string(255)
#  reset_password_sent_at        :datetime
#  remember_created_at           :datetime
#  sign_in_count                 :integer          default(0)
#  current_sign_in_at            :datetime
#  last_sign_in_at               :datetime
#  current_sign_in_ip            :string(255)
#  last_sign_in_ip               :string(255)
#  created_at                    :datetime
#  updated_at                    :datetime
#  name                          :string(255)
#  admin                         :boolean          default(FALSE), not null
#  projects_limit                :integer          default(10)
#  skype                         :string(255)      default(""), not null
#  linkedin                      :string(255)      default(""), not null
#  twitter                       :string(255)      default(""), not null
#  authentication_token          :string(255)
#  theme_id                      :integer          default(1), not null
#  bio                           :string(255)
#  failed_attempts               :integer          default(0)
#  locked_at                     :datetime
#  username                      :string(255)
#  can_create_group              :boolean          default(TRUE), not null
#  can_create_team               :boolean          default(TRUE), not null
#  state                         :string(255)
#  color_scheme_id               :integer          default(1), not null
#  notification_level            :integer          default(1), not null
#  password_expires_at           :datetime
#  created_by_id                 :integer
#  last_credential_check_at      :datetime
#  avatar                        :string(255)
#  confirmation_token            :string(255)
#  confirmed_at                  :datetime
#  confirmation_sent_at          :datetime
#  unconfirmed_email             :string(255)
#  hide_no_ssh_key               :boolean          default(FALSE)
#  website_url                   :string(255)      default(""), not null
#  github_access_token           :string(255)
#  gitlab_access_token           :string(255)
#  notification_email            :string(255)
#  hide_no_password              :boolean          default(FALSE)
#  password_automatically_set    :boolean          default(FALSE)
#  bitbucket_access_token        :string(255)
#  bitbucket_access_token_secret :string(255)
D
Dmitriy Zaporozhets 已提交
52 53
#

G
gitlabhq 已提交
54 55 56
require 'spec_helper'

describe User do
57 58
  include Gitlab::CurrentSettings

G
gitlabhq 已提交
59
  describe "Associations" do
60 61 62 63 64 65 66 67 68 69 70 71 72
    it { is_expected.to have_one(:namespace) }
    it { is_expected.to have_many(:snippets).class_name('Snippet').dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
    it { is_expected.to have_many(:events).class_name('Event').dependent(:destroy) }
    it { is_expected.to have_many(:recent_events).class_name('Event') }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:assigned_issues).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:assigned_merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
73 74
  end

75 76 77
  describe "Mass assignment" do
  end

78
  describe 'validations' do
79 80 81 82 83
    it { is_expected.to validate_presence_of(:username) }
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
84

85
    it { is_expected.to ensure_length_of(:bio).is_within(0..255) }
86 87 88 89 90 91

    describe 'email' do
      it 'accepts info@example.com' do
        user = build(:user, email: 'info@example.com')
        expect(user).to be_valid
      end
92

93 94 95 96 97
      it 'accepts info+test@example.com' do
        user = build(:user, email: 'info+test@example.com')
        expect(user).to be_valid
      end

98 99 100 101 102
      it "accepts o'reilly@example.com" do
        user = build(:user, email: "o'reilly@example.com")
        expect(user).to be_valid
      end

103 104 105 106 107 108 109 110 111
      it 'rejects test@test@example.com' do
        user = build(:user, email: 'test@test@example.com')
        expect(user).to be_invalid
      end

      it 'rejects mailto:test@example.com' do
        user = build(:user, email: 'mailto:test@example.com')
        expect(user).to be_invalid
      end
112 113 114 115 116

      it "rejects lol!'+=?><#$%^&*()@gmail.com" do
        user = build(:user, email: "lol!'+=?><#$%^&*()@gmail.com")
        expect(user).to be_invalid
      end
117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161

      context 'when no signup domains listed' do
        before { allow(current_application_settings).to receive(:restricted_signup_domains).and_return([]) }
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

      context 'when a signup domain is listed and subdomains are allowed' do
        before { allow(current_application_settings).to receive(:restricted_signup_domains).and_return(['example.com', '*.example.com']) }
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

      context 'when a signup domain is listed and subdomains are not allowed' do
        before { allow(current_application_settings).to receive(:restricted_signup_domains).and_return(['example.com']) }

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end
162
    end
G
gitlabhq 已提交
163 164 165
  end

  describe "Respond to" do
166 167 168
    it { is_expected.to respond_to(:is_admin?) }
    it { is_expected.to respond_to(:name) }
    it { is_expected.to respond_to(:private_token) }
G
gitlabhq 已提交
169 170
  end

171 172 173
  describe '#generate_password' do
    it "should execute callback when force_random_password specified" do
      user = build(:user, force_random_password: true)
174
      expect(user).to receive(:generate_password)
175 176 177 178
      user.save
    end

    it "should not generate password by default" do
179
      user = create(:user, password: 'abcdefghe')
180
      expect(user.password).to eq('abcdefghe')
181
    end
182

183
    it "should generate password when forcing random password" do
184
      allow(Devise).to receive(:friendly_token).and_return('123456789')
185
      user = create(:user, password: 'abcdefg', force_random_password: true)
186
      expect(user.password).to eq('12345678')
187
    end
188 189
  end

190 191
  describe 'authentication token' do
    it "should have authentication token" do
192
      user = create(:user)
193
      expect(user.authentication_token).not_to be_blank
194
    end
N
Nihad Abbasov 已提交
195
  end
196 197 198 199 200

  describe 'projects' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
D
Dmitriy Zaporozhets 已提交
201 202
      @project_2 = create :project, group: create(:group) # Grant MASTER access to the user
      @project_3 = create :project, group: create(:group) # Grant DEVELOPER access to the user
203

204 205
      @project_2.team << [@user, :master]
      @project_3.team << [@user, :developer]
206 207
    end

208 209 210 211 212 213 214 215 216
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
217 218 219 220 221
  end

  describe 'groups' do
    before do
      @user = create :user
222 223
      @group = create :group
      @group.add_owner(@user)
224 225
    end

226 227 228
    it { expect(@user.several_namespaces?).to be_truthy }
    it { expect(@user.authorized_groups).to eq([@group]) }
    it { expect(@user.owned_groups).to eq([@group]) }
229 230
  end

231 232 233 234
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
235 236
      @group = create :group
      @group.add_owner(@user)
237

238
      @group.add_user(@user2, GroupMember::OWNER)
239 240
    end

241
    it { expect(@user2.several_namespaces?).to be_truthy }
242 243
  end

244 245 246 247 248 249
  describe 'namespaced' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
    end

250
    it { expect(@user.several_namespaces?).to be_falsey }
251 252 253 254 255 256 257
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

    it "should block user" do
      user.block
258
      expect(user.blocked?).to be_truthy
259 260 261 262 263
    end
  end

  describe 'filter' do
    before do
264
      User.delete_all
265 266
      @user = create :user
      @admin = create :user, admin: true
267
      @blocked = create :user, state: :blocked
268 269
    end

270 271 272 273
    it { expect(User.filter("admins")).to eq([@admin]) }
    it { expect(User.filter("blocked")).to eq([@blocked]) }
    it { expect(User.filter("wop")).to include(@user, @admin, @blocked) }
    it { expect(User.filter(nil)).to include(@user, @admin) }
274 275 276 277
  end

  describe :not_in_project do
    before do
278
      User.delete_all
279 280 281 282
      @user = create :user
      @project = create :project
    end

283
    it { expect(User.not_in_project(@project)).to include(@user, @project.owner) }
284
  end
D
Dmitriy Zaporozhets 已提交
285

286 287 288
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
289

290 291 292 293 294
      it { expect(user.is_admin?).to be_falsey }
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
295
    end
296

D
Dmitriy Zaporozhets 已提交
297
    describe 'with defaults' do
298
      let(:user) { User.new }
D
Dmitriy Zaporozhets 已提交
299

D
Dmitriy Zaporozhets 已提交
300
      it "should apply defaults to user" do
301 302 303
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
304 305 306
      end
    end

D
Dmitriy Zaporozhets 已提交
307 308
    describe 'with default overrides' do
      let(:user) { User.new(projects_limit: 123, can_create_group: false, can_create_team: true, theme_id: Gitlab::Theme::BASIC) }
D
Dmitriy Zaporozhets 已提交
309

D
Dmitriy Zaporozhets 已提交
310
      it "should apply defaults to user" do
311 312 313
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
        expect(user.theme_id).to eq(Gitlab::Theme::BASIC)
314
      end
315 316
    end
  end
317

M
Marin Jankovski 已提交
318 319 320 321 322
  describe 'search' do
    let(:user1) { create(:user, username: 'James', email: 'james@testing.com') }
    let(:user2) { create(:user, username: 'jameson', email: 'jameson@example.com') }

    it "should be case insensitive" do
323 324 325 326 327 328
      expect(User.search(user1.username.upcase).to_a).to eq([user1])
      expect(User.search(user1.username.downcase).to_a).to eq([user1])
      expect(User.search(user2.username.upcase).to_a).to eq([user2])
      expect(User.search(user2.username.downcase).to_a).to eq([user2])
      expect(User.search(user1.username.downcase).to_a.count).to eq(2)
      expect(User.search(user2.username.downcase).to_a.count).to eq(1)
M
Marin Jankovski 已提交
329 330 331
    end
  end

332
  describe 'by_username_or_id' do
D
Dmitriy Zaporozhets 已提交
333 334
    let(:user1) { create(:user, username: 'foo') }

335
    it "should get the correct user" do
336 337 338 339
      expect(User.by_username_or_id(user1.id)).to eq(user1)
      expect(User.by_username_or_id('foo')).to eq(user1)
      expect(User.by_username_or_id(-1)).to be_nil
      expect(User.by_username_or_id('bar')).to be_nil
340 341
    end
  end
G
GitLab 已提交
342

343 344 345 346 347 348 349 350 351 352 353 354 355 356
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

    it 'should get the correct user' do
      expect(User.by_login(user.email.upcase)).to eq user
      expect(User.by_login(user.email)).to eq user
      expect(User.by_login(username.downcase)).to eq user
      expect(User.by_login(username)).to eq user
      expect(User.by_login(nil)).to be_nil
      expect(User.by_login('')).to be_nil
    end
  end

G
GitLab 已提交
357
  describe 'all_ssh_keys' do
358
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
359 360 361 362 363

    it "should have all ssh keys" do
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

364
      expect(user.all_ssh_keys).to include(key.key)
G
GitLab 已提交
365
    end
G
GitLab 已提交
366
  end
367

D
Dmitriy Zaporozhets 已提交
368 369 370 371 372
  describe :avatar_type do
    let(:user) { create(:user) }

    it "should be true if avatar is image" do
      user.update_attribute(:avatar, 'uploads/avatar.png')
373
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
374 375 376 377
    end

    it "should be false if avatar is html page" do
      user.update_attribute(:avatar, 'uploads/avatar.html')
378
      expect(user.avatar_type).to eq(["only images allowed"])
D
Dmitriy Zaporozhets 已提交
379 380
    end
  end
J
Jerome Dalbert 已提交
381

382 383 384
  describe :requires_ldap_check? do
    let(:user) { User.new }

385 386 387 388
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
      user.stub(ldap_user?: true)
      user.last_credential_check_at = nil
389
      expect(user.requires_ldap_check?).to be_falsey
390 391
    end

392 393
    context 'when LDAP is enabled' do
      before { Gitlab.config.ldap.stub(enabled: true) }
394

395 396
      it 'is false for non-LDAP users' do
        user.stub(ldap_user?: false)
397
        expect(user.requires_ldap_check?).to be_falsey
398 399
      end

400 401 402 403 404
      context 'and when the user is an LDAP user' do
        before { user.stub(ldap_user?: true) }

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
405
          expect(user.requires_ldap_check?).to be_truthy
406 407 408 409
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
410
          expect(user.requires_ldap_check?).to be_truthy
411
        end
412 413 414 415
      end
    end
  end

416 417
  describe :ldap_user? do
    it "is true if provider name starts with ldap" do
418
      user = create(:omniauth_user, provider: 'ldapmain')
419
      expect( user.ldap_user? ).to be_truthy
420 421 422
    end

    it "is false for other providers" do
423
      user = create(:omniauth_user, provider: 'other-provider')
424
      expect( user.ldap_user? ).to be_falsey
425 426 427
    end

    it "is false if no extern_uid is provided" do
428
      user = create(:omniauth_user, extern_uid: nil)
429
      expect( user.ldap_user? ).to be_falsey
430 431 432
    end
  end

433 434 435
  describe :ldap_identity do
    it "returns ldap identity" do
      user = create :omniauth_user
436
      expect(user.ldap_identity.provider).not_to be_empty
437 438 439
    end
  end

J
Jerome Dalbert 已提交
440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
479

J
Jerome Dalbert 已提交
480 481
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
482
  end
C
Ciro Santilli 已提交
483

484 485 486 487 488 489
  describe "#starred?" do
    it "determines if user starred a project" do
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

490 491
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
492 493

      star1 = UsersStarProject.create!(project: project1, user: user)
494 495
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
496 497

      star2 = UsersStarProject.create!(project: project2, user: user)
498 499
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
500 501

      star1.destroy
502 503
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
504 505

      star2.destroy
506 507
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
508 509 510
    end
  end

C
Ciro Santilli 已提交
511 512 513 514 515
  describe "#toggle_star" do
    it "toggles stars" do
      user = create :user
      project = create :project, :public

516
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
517
      user.toggle_star(project)
518
      expect(user.starred?(project)).to be_truthy
C
Ciro Santilli 已提交
519
      user.toggle_star(project)
520
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
521 522
    end
  end
V
Valery Sizov 已提交
523 524 525 526 527 528 529

  describe "#sort" do
    before do
      User.delete_all
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
    end
530

V
Valery Sizov 已提交
531
    it "sorts users as recently_signed_in" do
532
      expect(User.sort('recent_sign_in').first).to eq(@user)
V
Valery Sizov 已提交
533 534 535
    end

    it "sorts users as late_signed_in" do
536
      expect(User.sort('oldest_sign_in').first).to eq(@user1)
V
Valery Sizov 已提交
537 538 539
    end

    it "sorts users as recently_created" do
540
      expect(User.sort('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
541 542 543
    end

    it "sorts users as late_created" do
544
      expect(User.sort('created_asc').first).to eq(@user1)
V
Valery Sizov 已提交
545 546 547
    end

    it "sorts users by name when nil is passed" do
548
      expect(User.sort(nil).first).to eq(@user)
V
Valery Sizov 已提交
549 550
    end
  end
551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578

  describe "#contributed_projects_ids" do

    subject { create(:user) }
    let!(:project1) { create(:project) }
    let!(:project2) { create(:project, forked_from_project: project3) }
    let!(:project3) { create(:project) }
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
    let!(:push_event) { create(:event, action: Event::PUSHED, project: project1, target: project1, author: subject) }
    let!(:merge_event) { create(:event, action: Event::CREATED, project: project3, target: merge_request, author: subject) }

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes IDs for projects the user has pushed to" do
      expect(subject.contributed_projects_ids).to include(project1.id)
    end

    it "includes IDs for projects the user has had merge requests merged into" do
      expect(subject.contributed_projects_ids).to include(project3.id)
    end

    it "doesn't include IDs for unrelated projects" do
      expect(subject.contributed_projects_ids).not_to include(project2.id)
    end
  end
G
gitlabhq 已提交
579
end