note_spec.rb 4.4 KB
Newer Older
G
gitlabhq 已提交
1 2 3 4 5
require 'spec_helper'

describe Note do
  describe "Associations" do
    it { should belong_to(:project) }
6 7
    it { should belong_to(:noteable) }
    it { should belong_to(:author).class_name('User') }
G
gitlabhq 已提交
8 9
  end

10 11 12 13 14
  describe "Mass assignment" do
    it { should_not allow_mass_assignment_of(:author) }
    it { should_not allow_mass_assignment_of(:author_id) }
  end

G
gitlabhq 已提交
15 16 17 18 19
  describe "Validation" do
    it { should validate_presence_of(:note) }
    it { should validate_presence_of(:project) }
  end

D
Drew 已提交
20 21 22 23 24
  describe "Scopes" do
    it "should have a today named scope that returns ..." do
      Note.today.where_values.should == ["created_at >= '#{Date.today}'"]
    end
  end
D
Dmitriy Zaporozhets 已提交
25

26 27 28 29
  describe "Voting score" do
    let(:project) { Factory(:project) }

    it "recognizes a neutral note" do
30
      note = Factory(:note, note: "This is not a +1 note")
31
      note.should_not be_upvote
32 33 34 35 36 37 38
      note.should_not be_downvote
    end

    it "recognizes a neutral emoji note" do
      note = build(:note, note: "I would :+1: this, but I don't want to")
      note.should_not be_upvote
      note.should_not be_downvote
39 40 41
    end

    it "recognizes a +1 note" do
42
      note = Factory(:note, note: "+1 for this")
43 44 45
      note.should be_upvote
    end

46 47 48 49 50
    it "recognizes a +1 emoji as a vote" do
      note = build(:note, note: ":+1: for this")
      note.should be_upvote
    end

51 52 53 54 55 56 57 58
    it "recognizes a -1 note" do
      note = Factory(:note, note: "-1 for this")
      note.should be_downvote
    end

    it "recognizes a -1 emoji as a vote" do
      note = build(:note, note: ":-1: for this")
      note.should be_downvote
59
    end
60 61
  end

62 63
  let(:project) { create(:project) }
  let(:commit) { project.commit }
64

65
  describe "Commit notes" do
66
    before do
D
Dmitriy Zaporozhets 已提交
67
      @note = Factory :note,
68 69
        noteable_id: commit.id,
        noteable_type: "Commit"
D
Dmitriy Zaporozhets 已提交
70 71 72 73 74 75 76 77
    end

    it "should save a valid note" do
      @note.noteable_id.should == commit.id
      @note.target.id.should == commit.id
    end
  end

78 79
  describe "Pre-line commit notes" do
    before do
D
Dmitriy Zaporozhets 已提交
80
      @note = Factory :note,
81 82 83
        noteable_id: commit.id,
        noteable_type: "Commit",
        line_code: "0_16_1"
D
Dmitriy Zaporozhets 已提交
84 85 86 87 88 89 90 91
    end

    it "should save a valid note" do
      @note.noteable_id.should == commit.id
      @note.target.id.should == commit.id
    end
  end

92 93
  describe '#create_status_change_note' do
    let(:project)  { Factory.create(:project) }
94
    let(:thing)    { Factory.create(:issue, project: project) }
95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110
    let(:author)   { Factory(:user) }
    let(:status)   { 'new_status' }

    subject { Note.create_status_change_note(thing, author, status) }

    it 'creates and saves a Note' do
      should be_a Note
      subject.id.should_not be_nil
    end

    its(:noteable) { should == thing }
    its(:project)  { should == thing.project }
    its(:author)   { should == author }
    its(:note)     { should =~ /Status changed to #{status}/ }
  end

N
Nihad Abbasov 已提交
111 112
  describe :authorization do
    before do
113 114
      @p1 = create(:project)
      @p2 = Factory :project
G
gitlabhq 已提交
115 116 117 118 119 120 121
      @u1 = Factory :user
      @u2 = Factory :user
      @u3 = Factory :user
      @abilities = Six.new
      @abilities << Ability
    end

N
Nihad Abbasov 已提交
122 123
    describe :read do
      before do
124 125
        @p1.users_projects.create(user: @u2, project_access: UsersProject::GUEST)
        @p2.users_projects.create(user: @u3, project_access: UsersProject::GUEST)
G
gitlabhq 已提交
126 127 128 129 130 131 132
      end

      it { @abilities.allowed?(@u1, :read_note, @p1).should be_false }
      it { @abilities.allowed?(@u2, :read_note, @p1).should be_true }
      it { @abilities.allowed?(@u3, :read_note, @p1).should be_false }
    end

N
Nihad Abbasov 已提交
133 134
    describe :write do
      before do
135 136
        @p1.users_projects.create(user: @u2, project_access: UsersProject::DEVELOPER)
        @p2.users_projects.create(user: @u3, project_access: UsersProject::DEVELOPER)
G
gitlabhq 已提交
137 138 139 140 141 142 143
      end

      it { @abilities.allowed?(@u1, :write_note, @p1).should be_false }
      it { @abilities.allowed?(@u2, :write_note, @p1).should be_true }
      it { @abilities.allowed?(@u3, :write_note, @p1).should be_false }
    end

N
Nihad Abbasov 已提交
144 145
    describe :admin do
      before do
146 147 148
        @p1.users_projects.create(user: @u1, project_access: UsersProject::REPORTER)
        @p1.users_projects.create(user: @u2, project_access: UsersProject::MASTER)
        @p2.users_projects.create(user: @u3, project_access: UsersProject::MASTER)
G
gitlabhq 已提交
149 150 151 152 153 154 155 156
      end

      it { @abilities.allowed?(@u1, :admin_note, @p1).should be_false }
      it { @abilities.allowed?(@u2, :admin_note, @p1).should be_true }
      it { @abilities.allowed?(@u3, :admin_note, @p1).should be_false }
    end
  end
end