note_spec.rb 4.8 KB
Newer Older
1 2
require 'spec_helper'

3
describe Gitlab::DataBuilder::Note do
4
  let(:project) { create(:project, :repository) }
5
  let(:user) { create(:user) }
L
Lin Jen-Shin 已提交
6
  let(:data) { described_class.build(note, user) }
7 8
  let(:fixed_time) { Time.at(1425600000) } # Avoid time precision errors

9
  before do
10 11
    expect(data).to have_key(:object_attributes)
    expect(data[:object_attributes]).to have_key(:url)
12 13
    expect(data[:object_attributes][:url])
      .to eq(Gitlab::UrlBuilder.build(note))
14 15 16 17 18
    expect(data[:object_kind]).to eq('note')
    expect(data[:user]).to eq(user.hook_attrs)
  end

  describe 'When asking for a note on commit' do
19
    let(:note) { create(:note_on_commit, project: project) }
20 21 22 23

    it 'returns the note and commit-specific data' do
      expect(data).to have_key(:commit)
    end
24 25 26

    include_examples 'project hook data'
    include_examples 'deprecated repository hook data'
27 28 29
  end

  describe 'When asking for a note on commit diff' do
D
Douwe Maan 已提交
30
    let(:note) { create(:diff_note_on_commit, project: project) }
31 32 33 34

    it 'returns the note and commit-specific data' do
      expect(data).to have_key(:commit)
    end
35 36 37

    include_examples 'project hook data'
    include_examples 'deprecated repository hook data'
38 39 40
  end

  describe 'When asking for a note on issue' do
41 42
    let(:label) { create(:label, project: project) }

43
    let(:issue) do
44 45
      create(:labeled_issue, created_at: fixed_time, updated_at: fixed_time,
             project: project, labels: [label])
46 47 48
    end

    let(:note) do
G
Grzegorz Bizon 已提交
49
      create(:note_on_issue, noteable: issue, project: project)
50
    end
51 52

    it 'returns the note and issue-specific data' do
53 54 55
      without_timestamps = lambda { |label| label.except('created_at', 'updated_at') }
      hook_attrs = issue.reload.hook_attrs

56
      expect(data).to have_key(:issue)
57 58
      expect(data[:issue].except('updated_at', 'labels'))
        .to eq(hook_attrs.except('updated_at', 'labels'))
59
      expect(data[:issue]['updated_at'])
60 61 62
        .to be >= hook_attrs['updated_at']
      expect(data[:issue]['labels'].map(&without_timestamps))
        .to eq(hook_attrs['labels'].map(&without_timestamps))
63
    end
64

65 66 67 68 69 70 71 72
    context 'with confidential issue' do
      let(:issue) { create(:issue, project: project, confidential: true) }

      it 'sets event_type to confidential_note' do
        expect(data[:event_type]).to eq('confidential_note')
      end
    end

73 74
    include_examples 'project hook data'
    include_examples 'deprecated repository hook data'
75 76 77
  end

  describe 'When asking for a note on merge request' do
78 79 80 81 82 83 84
    let(:merge_request) do
      create(:merge_request, created_at: fixed_time,
                             updated_at: fixed_time,
                             source_project: project)
    end

    let(:note) do
G
Grzegorz Bizon 已提交
85
      create(:note_on_merge_request, noteable: merge_request,
86 87
                                     project: project)
    end
88 89 90

    it 'returns the note and merge request data' do
      expect(data).to have_key(:merge_request)
91
      expect(data[:merge_request].except('updated_at'))
G
Grzegorz Bizon 已提交
92
        .to eq(merge_request.reload.hook_attrs.except('updated_at'))
93
      expect(data[:merge_request]['updated_at'])
94
        .to be >= merge_request.hook_attrs['updated_at']
95
    end
96 97 98

    include_examples 'project hook data'
    include_examples 'deprecated repository hook data'
99 100 101
  end

  describe 'When asking for a note on merge request diff' do
102 103 104 105 106 107
    let(:merge_request) do
      create(:merge_request, created_at: fixed_time, updated_at: fixed_time,
                             source_project: project)
    end

    let(:note) do
D
Douwe Maan 已提交
108
      create(:diff_note_on_merge_request, noteable: merge_request,
109 110
                                          project: project)
    end
111 112 113

    it 'returns the note and merge request diff data' do
      expect(data).to have_key(:merge_request)
114
      expect(data[:merge_request].except('updated_at'))
G
Grzegorz Bizon 已提交
115
        .to eq(merge_request.reload.hook_attrs.except('updated_at'))
116
      expect(data[:merge_request]['updated_at'])
117
        .to be >= merge_request.hook_attrs['updated_at']
118
    end
119 120 121

    include_examples 'project hook data'
    include_examples 'deprecated repository hook data'
122 123 124
  end

  describe 'When asking for a note on project snippet' do
125 126 127 128 129 130
    let!(:snippet) do
      create(:project_snippet, created_at: fixed_time, updated_at: fixed_time,
                               project: project)
    end

    let!(:note) do
G
Grzegorz Bizon 已提交
131
      create(:note_on_project_snippet, noteable: snippet,
132 133
                                       project: project)
    end
134 135 136

    it 'returns the note and project snippet data' do
      expect(data).to have_key(:snippet)
137
      expect(data[:snippet].except('updated_at'))
G
Grzegorz Bizon 已提交
138
        .to eq(snippet.reload.hook_attrs.except('updated_at'))
139
      expect(data[:snippet]['updated_at'])
140
        .to be >= snippet.hook_attrs['updated_at']
141
    end
142 143 144

    include_examples 'project hook data'
    include_examples 'deprecated repository hook data'
145 146
  end
end