create_pipeline_service_spec.rb 33.3 KB
Newer Older
1 2
require 'spec_helper'

3
describe Ci::CreatePipelineService do
B
Bob Van Landuyt 已提交
4 5
  include ProjectForksHelper

6
  set(:project) { create(:project, :repository) }
7
  let(:user) { create(:admin) }
8
  let(:ref_name) { 'refs/heads/master' }
9 10

  before do
11
    stub_repository_ci_yaml_file(sha: anything)
12 13 14
  end

  describe '#execute' do
15
    # rubocop:disable Metrics/ParameterLists
16 17 18 19 20
    def execute_service(
      source: :push,
      after: project.commit.id,
      message: 'Message',
      ref: ref_name,
21
      trigger_request: nil,
S
Shinya Maeda 已提交
22
      variables_attributes: nil,
23
      merge_request: nil,
24 25 26
      push_options: nil,
      source_sha: nil,
      target_sha: nil)
27 28 29
      params = { ref: ref,
                 before: '00000000',
                 after: after,
30
                 commits: [{ message: message }],
31
                 variables_attributes: variables_attributes,
32 33 34
                 push_options: push_options,
                 source_sha: source_sha,
                 target_sha: target_sha }
35

36
      described_class.new(project, user, params).execute(
S
Shinya Maeda 已提交
37
        source, trigger_request: trigger_request, merge_request: merge_request)
38
    end
39
    # rubocop:enable Metrics/ParameterLists
40

41 42 43
    context 'valid params' do
      let(:pipeline) { execute_service }

44 45 46 47 48 49
      let(:pipeline_on_previous_commit) do
        execute_service(
          after: previous_commit_sha_from_ref('master')
        )
      end

50 51 52
      it 'creates a pipeline' do
        expect(pipeline).to be_kind_of(Ci::Pipeline)
        expect(pipeline).to be_valid
53
        expect(pipeline).to be_persisted
54
        expect(pipeline).to be_push
55
        expect(pipeline).to eq(project.ci_pipelines.last)
56 57
        expect(pipeline).to have_attributes(user: user)
        expect(pipeline).to have_attributes(status: 'pending')
58
        expect(pipeline.repository_source?).to be true
59 60
        expect(pipeline.builds.first).to be_kind_of(Ci::Build)
      end
61

62 63
      it 'increments the prometheus counter' do
        expect(Gitlab::Metrics).to receive(:counter)
B
Ben Kochie 已提交
64
          .with(:pipelines_created_total, "Counter of pipelines created")
65 66 67 68 69
          .and_call_original

        pipeline
      end

70
      context 'when merge requests already exist for this source branch' do
71
        let(:merge_request_1) do
S
Shinya Maeda 已提交
72
          create(:merge_request, source_branch: 'feature', target_branch: "master", source_project: project)
73 74
        end
        let(:merge_request_2) do
S
Shinya Maeda 已提交
75
          create(:merge_request, source_branch: 'feature', target_branch: "v1.1.0", source_project: project)
76
        end
77

78 79 80 81 82 83 84 85 86 87 88 89
        context 'when related merge request is already merged' do
          let!(:merged_merge_request) do
            create(:merge_request, source_branch: 'master', target_branch: "branch_2", source_project: project, state: 'merged')
          end

          it 'does not schedule update head pipeline job' do
            expect(UpdateHeadPipelineForMergeRequestWorker).not_to receive(:perform_async).with(merged_merge_request.id)

            execute_service
          end
        end

90 91 92 93 94
        context 'when the head pipeline sha equals merge request sha' do
          it 'updates head pipeline of each merge request' do
            merge_request_1
            merge_request_2

S
Shinya Maeda 已提交
95
            head_pipeline = execute_service(ref: 'feature', after: nil)
96

97 98 99 100 101 102
            expect(merge_request_1.reload.head_pipeline).to eq(head_pipeline)
            expect(merge_request_2.reload.head_pipeline).to eq(head_pipeline)
          end
        end

        context 'when the head pipeline sha does not equal merge request sha' do
103
          it 'does not update the head piepeline of MRs' do
104 105 106 107
            merge_request_1
            merge_request_2

            allow_any_instance_of(Ci::Pipeline).to receive(:latest?).and_return(true)
108

109
            expect { execute_service(after: 'ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }.not_to raise_error
110 111 112 113 114 115

            last_pipeline = Ci::Pipeline.last

            expect(merge_request_1.reload.head_pipeline).not_to eq(last_pipeline)
            expect(merge_request_2.reload.head_pipeline).not_to eq(last_pipeline)
          end
116 117 118 119
        end

        context 'when there is no pipeline for source branch' do
          it "does not update merge request head pipeline" do
120 121 122
            merge_request = create(:merge_request, source_branch: 'feature',
                                                   target_branch: "branch_1",
                                                   source_project: project)
123

124
            head_pipeline = execute_service
125 126 127 128 129 130

            expect(merge_request.reload.head_pipeline).not_to eq(head_pipeline)
          end
        end

        context 'when merge request target project is different from source project' do
B
Bob Van Landuyt 已提交
131
          let!(:project) { fork_project(target_project, nil, repository: true) }
132
          let!(:target_project) { create(:project, :repository) }
133

134
          it 'updates head pipeline for merge request' do
S
Shinya Maeda 已提交
135 136
            merge_request = create(:merge_request, source_branch: 'feature',
                                                   target_branch: "master",
137 138
                                                   source_project: project,
                                                   target_project: target_project)
139

S
Shinya Maeda 已提交
140
            head_pipeline = execute_service(ref: 'feature', after: nil)
141 142 143 144

            expect(merge_request.reload.head_pipeline).to eq(head_pipeline)
          end
        end
145

146
        context 'when the pipeline is not the latest for the branch' do
147
          it 'does not update merge request head pipeline' do
148 149 150
            merge_request = create(:merge_request, source_branch: 'master',
                                                   target_branch: "branch_1",
                                                   source_project: project)
151

152 153
            allow_any_instance_of(MergeRequest)
              .to receive(:find_actual_head_pipeline) { }
154

155
            execute_service
156 157 158 159

            expect(merge_request.reload.head_pipeline).to be_nil
          end
        end
160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177

        context 'when pipeline has errors' do
          before do
            stub_ci_pipeline_yaml_file('some invalid syntax')
          end

          it 'updates merge request head pipeline reference' do
            merge_request = create(:merge_request, source_branch: 'master',
                                                   target_branch: 'feature',
                                                   source_project: project)

            head_pipeline = execute_service

            expect(head_pipeline).to be_persisted
            expect(head_pipeline.yaml_errors).to be_present
            expect(merge_request.reload.head_pipeline).to eq head_pipeline
          end
        end
178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197

        context 'when pipeline has been skipped' do
          before do
            allow_any_instance_of(Ci::Pipeline)
              .to receive(:git_commit_message)
              .and_return('some commit [ci skip]')
          end

          it 'updates merge request head pipeline' do
            merge_request = create(:merge_request, source_branch: 'master',
                                                   target_branch: 'feature',
                                                   source_project: project)

            head_pipeline = execute_service

            expect(head_pipeline).to be_skipped
            expect(head_pipeline).to be_persisted
            expect(merge_request.reload.head_pipeline).to eq head_pipeline
          end
        end
198 199
      end

200 201 202 203 204
      context 'auto-cancel enabled' do
        before do
          project.update(auto_cancel_pending_pipelines: 'enabled')
        end

205 206
        it 'does not cancel HEAD pipeline' do
          pipeline
R
Rydkin Maxim 已提交
207
          pipeline_on_previous_commit
208

R
Rydkin Maxim 已提交
209
          expect(pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil)
210
        end
211 212

        it 'auto cancel pending non-HEAD pipelines' do
R
Rydkin Maxim 已提交
213
          pipeline_on_previous_commit
214 215
          pipeline

R
Rydkin Maxim 已提交
216
          expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: pipeline.id)
217 218 219
        end

        it 'does not cancel running outdated pipelines' do
R
Rydkin Maxim 已提交
220
          pipeline_on_previous_commit.run
221 222
          execute_service

R
Rydkin Maxim 已提交
223
          expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'running', auto_canceled_by_id: nil)
224 225 226
        end

        it 'cancel created outdated pipelines' do
R
Rydkin Maxim 已提交
227
          pipeline_on_previous_commit.update(status: 'created')
228 229
          pipeline

R
Rydkin Maxim 已提交
230
          expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: pipeline.id)
231 232 233 234 235 236 237 238 239
        end

        it 'does not cancel pipelines from the other branches' do
          pending_pipeline = execute_service(
            ref: 'refs/heads/feature',
            after: previous_commit_sha_from_ref('feature')
          )
          pipeline

240
          expect(pending_pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil)
241 242
        end
      end
243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260

      context 'auto-cancel disabled' do
        before do
          project.update(auto_cancel_pending_pipelines: 'disabled')
        end

        it 'does not auto cancel pending non-HEAD pipelines' do
          pipeline_on_previous_commit
          pipeline

          expect(pipeline_on_previous_commit.reload)
            .to have_attributes(status: 'pending', auto_canceled_by_id: nil)
        end
      end

      def previous_commit_sha_from_ref(ref)
        project.commit(ref).parent.sha
      end
261 262
    end

263 264
    context "skip tag if there is no build for it" do
      it "creates commit if there is appropriate job" do
265
        expect(execute_service).to be_persisted
266 267 268 269 270 271
      end

      it "creates commit if there is no appropriate job but deploy job has right ref setting" do
        config = YAML.dump({ deploy: { script: "ls", only: ["master"] } })
        stub_ci_pipeline_yaml_file(config)

272
        expect(execute_service).to be_persisted
273 274 275 276 277 278
      end
    end

    it 'skips creating pipeline for refs without .gitlab-ci.yml' do
      stub_ci_pipeline_yaml_file(nil)

279
      expect(execute_service).not_to be_persisted
280 281 282
      expect(Ci::Pipeline.count).to eq(0)
    end

283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308
    shared_examples 'a failed pipeline' do
      it 'creates failed pipeline' do
        stub_ci_pipeline_yaml_file(ci_yaml)

        pipeline = execute_service(message: message)

        expect(pipeline).to be_persisted
        expect(pipeline.builds.any?).to be false
        expect(pipeline.status).to eq('failed')
        expect(pipeline.yaml_errors).not_to be_nil
      end
    end

    context 'when yaml is invalid' do
      let(:ci_yaml) { 'invalid: file: fiile' }
      let(:message) { 'Message' }

      it_behaves_like 'a failed pipeline'

      context 'when receive git commit' do
        before do
          allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { message }
        end

        it_behaves_like 'a failed pipeline'
      end
309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358

      context 'when config has ports' do
        context 'in the main image' do
          let(:ci_yaml) do
            <<-EOS
              image:
                name: ruby:2.2
                ports:
                  - 80
            EOS
          end

          it_behaves_like 'a failed pipeline'
        end

        context 'in the job image' do
          let(:ci_yaml) do
            <<-EOS
              image: ruby:2.2

              test:
                script: rspec
                image:
                  name: ruby:2.2
                  ports:
                    - 80
            EOS
          end

          it_behaves_like 'a failed pipeline'
        end

        context 'in the service' do
          let(:ci_yaml) do
            <<-EOS
              image: ruby:2.2

              test:
                script: rspec
                image: ruby:2.2
                services:
                  - name: test
                    ports:
                      - 80
            EOS
          end

          it_behaves_like 'a failed pipeline'
        end
      end
359 360 361 362
    end

    context 'when commit contains a [ci skip] directive' do
      let(:message) { "some message[ci skip]" }
363 364 365 366 367 368 369 370 371 372 373

      ci_messages = [
        "some message[ci skip]",
        "some message[skip ci]",
        "some message[CI SKIP]",
        "some message[SKIP CI]",
        "some message[ci_skip]",
        "some message[skip_ci]",
        "some message[ci-skip]",
        "some message[skip-ci]"
      ]
374 375 376 377 378

      before do
        allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { message }
      end

379 380
      ci_messages.each do |ci_message|
        it "skips builds creation if the commit message is #{ci_message}" do
381
          pipeline = execute_service(message: ci_message)
382 383 384 385 386

          expect(pipeline).to be_persisted
          expect(pipeline.builds.any?).to be false
          expect(pipeline.status).to eq("skipped")
        end
387 388
      end

389
      shared_examples 'creating a pipeline' do
R
Rydkin Maxim 已提交
390
        it 'does not skip pipeline creation' do
391
          allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { commit_message }
392

393
          pipeline = execute_service(message: commit_message)
394

395 396 397
          expect(pipeline).to be_persisted
          expect(pipeline.builds.first.name).to eq("rspec")
        end
398 399
      end

400 401
      context 'when commit message does not contain [ci skip] nor [skip ci]' do
        let(:commit_message) { 'some message' }
402

403
        it_behaves_like 'creating a pipeline'
404 405
      end

406 407
      context 'when commit message is nil' do
        let(:commit_message) { nil }
408

409
        it_behaves_like 'creating a pipeline'
410 411
      end

412 413 414 415 416
      context 'when there is [ci skip] tag in commit message and yaml is invalid' do
        let(:ci_yaml) { 'invalid: file: fiile' }

        it_behaves_like 'a failed pipeline'
      end
417 418
    end

419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
    context 'when push options contain ci.skip' do
      let(:push_options) do
        ['ci.skip',
         'another push option']
      end

      it 'creates a pipline in the skipped state' do
        pipeline = execute_service(push_options: push_options)

        # TODO: DRY these up with "skips builds creation if the commit message"
        expect(pipeline).to be_persisted
        expect(pipeline.builds.any?).to be false
        expect(pipeline.status).to eq("skipped")
      end
    end

435 436 437 438 439 440 441
    context 'when there are no jobs for this pipeline' do
      before do
        config = YAML.dump({ test: { script: 'ls', only: ['feature'] } })
        stub_ci_pipeline_yaml_file(config)
      end

      it 'does not create a new pipeline' do
442
        result = execute_service
443 444 445 446 447 448 449 450 451 452 453 454 455 456

        expect(result).not_to be_persisted
        expect(Ci::Build.all).to be_empty
        expect(Ci::Pipeline.count).to eq(0)
      end
    end

    context 'with manual actions' do
      before do
        config = YAML.dump({ deploy: { script: 'ls', when: 'manual' } })
        stub_ci_pipeline_yaml_file(config)
      end

      it 'does not create a new pipeline' do
457
        result = execute_service
458 459 460 461 462

        expect(result).to be_persisted
        expect(result.manual_actions).not_to be_empty
      end
    end
463 464 465

    context 'with environment' do
      before do
K
Kamil Trzciński 已提交
466 467 468 469 470 471 472
        config = YAML.dump(
          deploy: {
            environment: { name: "review/$CI_COMMIT_REF_NAME" },
            script: 'ls',
            tags: ['hello']
          })

473 474 475
        stub_ci_pipeline_yaml_file(config)
      end

K
Kamil Trzciński 已提交
476
      it 'creates the environment with tags' do
477
        result = execute_service
478 479

        expect(result).to be_persisted
480
        expect(Environment.find_by(name: "review/master")).to be_present
K
Kamil Trzciński 已提交
481
        expect(result.builds.first.tag_list).to contain_exactly('hello')
K
Kamil Trzciński 已提交
482 483
        expect(result.builds.first.deployment).to be_persisted
        expect(result.builds.first.deployment.deployable).to be_a(Ci::Build)
K
Kamil Trzciński 已提交
484
      end
485 486 487 488 489 490 491
    end

    context 'with environment name including persisted variables' do
      before do
        config = YAML.dump(
          deploy: {
            environment: { name: "review/id1$CI_PIPELINE_ID/id2$CI_BUILD_ID" },
492 493
            script: 'ls'
          }
494 495 496 497 498 499 500 501 502 503
        )

        stub_ci_pipeline_yaml_file(config)
      end

      it 'skipps persisted variables in environment name' do
        result = execute_service

        expect(result).to be_persisted
        expect(Environment.find_by(name: "review/id1/id2")).to be_present
504 505
      end
    end
506 507 508 509 510 511 512 513 514 515 516 517 518 519 520

    context 'when environment with invalid name' do
      before do
        config = YAML.dump(deploy: { environment: { name: 'name,with,commas' }, script: 'ls' })
        stub_ci_pipeline_yaml_file(config)
      end

      it 'does not create an environment' do
        expect do
          result = execute_service

          expect(result).to be_persisted
        end.not_to change { Environment.count }
      end
    end
521

522
    context 'when builds with auto-retries are configured' do
523 524 525 526 527 528 529 530 531 532 533 534 535
      context 'as an integer' do
        before do
          config = YAML.dump(rspec: { script: 'rspec', retry: 2 })
          stub_ci_pipeline_yaml_file(config)
        end

        it 'correctly creates builds with auto-retry value configured' do
          pipeline = execute_service

          expect(pipeline).to be_persisted
          expect(pipeline.builds.find_by(name: 'rspec').retries_max).to eq 2
          expect(pipeline.builds.find_by(name: 'rspec').retry_when).to eq ['always']
        end
536 537
      end

538 539 540 541 542
      context 'as hash' do
        before do
          config = YAML.dump(rspec: { script: 'rspec', retry: { max: 2, when: 'runner_system_failure' } })
          stub_ci_pipeline_yaml_file(config)
        end
543

544 545 546 547 548 549 550
        it 'correctly creates builds with auto-retry value configured' do
          pipeline = execute_service

          expect(pipeline).to be_persisted
          expect(pipeline.builds.find_by(name: 'rspec').retries_max).to eq 2
          expect(pipeline.builds.find_by(name: 'rspec').retry_when).to eq ['runner_system_failure']
        end
551 552
      end
    end
553

554 555 556 557 558 559 560 561 562 563 564 565 566 567
    shared_examples 'when ref is protected' do
      let(:user) { create(:user) }

      context 'when user is developer' do
        before do
          project.add_developer(user)
        end

        it 'does not create a pipeline' do
          expect(execute_service).not_to be_persisted
          expect(Ci::Pipeline.count).to eq(0)
        end
      end

568
      context 'when user is maintainer' do
S
Shinya Maeda 已提交
569 570
        let(:pipeline) { execute_service }

571
        before do
572
          project.add_maintainer(user)
573 574
        end

S
Shinya Maeda 已提交
575 576 577
        it 'creates a protected pipeline' do
          expect(pipeline).to be_persisted
          expect(pipeline).to be_protected
578 579 580
          expect(Ci::Pipeline.count).to eq(1)
        end
      end
581 582 583 584 585 586 587 588 589 590 591 592 593

      context 'when trigger belongs to no one' do
        let(:user) {}
        let(:trigger_request) { create(:ci_trigger_request) }

        it 'does not create a pipeline' do
          expect(execute_service(trigger_request: trigger_request))
            .not_to be_persisted
          expect(Ci::Pipeline.count).to eq(0)
        end
      end

      context 'when trigger belongs to a developer' do
S
Shinya Maeda 已提交
594 595 596
        let(:user) { create(:user) }
        let(:trigger) { create(:ci_trigger, owner: user) }
        let(:trigger_request) { create(:ci_trigger_request, trigger: trigger) }
597

S
Shinya Maeda 已提交
598 599
        before do
          project.add_developer(user)
600 601 602 603 604 605 606 607 608
        end

        it 'does not create a pipeline' do
          expect(execute_service(trigger_request: trigger_request))
            .not_to be_persisted
          expect(Ci::Pipeline.count).to eq(0)
        end
      end

609
      context 'when trigger belongs to a maintainer' do
S
Shinya Maeda 已提交
610 611 612
        let(:user) { create(:user) }
        let(:trigger) { create(:ci_trigger, owner: user) }
        let(:trigger_request) { create(:ci_trigger_request, trigger: trigger) }
613

S
Shinya Maeda 已提交
614
        before do
615
          project.add_maintainer(user)
616 617
        end

S
Shinya Maeda 已提交
618
        it 'creates a pipeline' do
619 620 621 622 623
          expect(execute_service(trigger_request: trigger_request))
            .to be_persisted
          expect(Ci::Pipeline.count).to eq(1)
        end
      end
624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642
    end

    context 'when ref is a protected branch' do
      before do
        create(:protected_branch, project: project, name: 'master')
      end

      it_behaves_like 'when ref is protected'
    end

    context 'when ref is a protected tag' do
      let(:ref_name) { 'refs/tags/v1.0.0' }

      before do
        create(:protected_tag, project: project, name: '*')
      end

      it_behaves_like 'when ref is protected'
    end
643 644 645 646

    context 'when ref is not protected' do
      context 'when trigger belongs to no one' do
        let(:user) {}
647 648
        let(:trigger) { create(:ci_trigger, owner: nil) }
        let(:trigger_request) { create(:ci_trigger_request, trigger: trigger) }
S
Shinya Maeda 已提交
649
        let(:pipeline) { execute_service(trigger_request: trigger_request) }
650

S
Shinya Maeda 已提交
651 652 653
        it 'creates an unprotected pipeline' do
          expect(pipeline).to be_persisted
          expect(pipeline).not_to be_protected
654
          expect(Ci::Pipeline.count).to eq(1)
655 656 657
        end
      end
    end
658

K
Kamil Trzcinski 已提交
659
    context 'when pipeline is running for a tag' do
660 661
      before do
        config = YAML.dump(test: { script: 'test', only: ['branches'] },
K
Kamil Trzcinski 已提交
662
                           deploy: { script: 'deploy', only: ['tags'] })
663 664 665 666 667

        stub_ci_pipeline_yaml_file(config)
      end

      it 'creates a tagged pipeline' do
K
Kamil Trzcinski 已提交
668
        pipeline = execute_service(ref: 'v1.0.0')
669 670 671 672

        expect(pipeline.tag?).to be true
      end
    end
673 674

    context 'when pipeline variables are specified' do
675
      let(:variables_attributes) do
676 677 678 679
        [{ key: 'first', secret_value: 'world' },
         { key: 'second', secret_value: 'second_world' }]
      end

680
      subject { execute_service(variables_attributes: variables_attributes) }
681 682

      it 'creates a pipeline with specified variables' do
M
Matija Čupić 已提交
683 684
        expect(subject.variables.map { |var| var.slice(:key, :secret_value) })
          .to eq variables_attributes.map(&:with_indifferent_access)
685 686
      end
    end
687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734

    context 'when pipeline has a job with environment' do
      let(:pipeline) { execute_service }

      before do
        stub_ci_pipeline_yaml_file(YAML.dump(config))
      end

      context 'when environment name is valid' do
        let(:config) do
          {
            review_app: {
              script: 'deploy',
              environment: {
                name: 'review/${CI_COMMIT_REF_NAME}',
                url: 'http://${CI_COMMIT_REF_SLUG}-staging.example.com'
              }
            }
          }
        end

        it 'has a job with environment' do
          expect(pipeline.builds.count).to eq(1)
          expect(pipeline.builds.first.persisted_environment.name).to eq('review/master')
          expect(pipeline.builds.first.deployment).to be_created
        end
      end

      context 'when environment name is invalid' do
        let(:config) do
          {
            'job:deploy-to-test-site': {
              script: 'deploy',
              environment: {
                name: '${CI_JOB_NAME}',
                url: 'https://$APP_URL'
              }
            }
          }
        end

        it 'has a job without environment' do
          expect(pipeline.builds.count).to eq(1)
          expect(pipeline.builds.first.persisted_environment).to be_nil
          expect(pipeline.builds.first.deployment).to be_nil
        end
      end
    end
S
Shinya Maeda 已提交
735 736 737

    describe 'Merge request pipelines' do
      let(:pipeline) do
738 739 740 741 742
        execute_service(source: source,
                        merge_request: merge_request,
                        ref: ref_name,
                        source_sha: source_sha,
                        target_sha: target_sha)
S
Shinya Maeda 已提交
743 744 745 746 747 748
      end

      before do
        stub_ci_pipeline_yaml_file(YAML.dump(config))
      end

749
      let(:ref_name) { 'refs/heads/feature' }
750 751
      let(:source_sha) { project.commit(ref_name).id }
      let(:target_sha) { nil }
S
Shinya Maeda 已提交
752 753

      context 'when source is merge request' do
754
        let(:source) { :merge_request_event }
S
Shinya Maeda 已提交
755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779

        context "when config has merge_requests keywords" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo'
              },
              test: {
                stage: 'test',
                script: 'echo',
                only: ['merge_requests']
              },
              pages: {
                stage: 'deploy',
                script: 'echo',
                except: ['merge_requests']
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
780
                source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
781 782 783 784 785 786
                target_project: project,
                target_branch: 'master')
            end

            it 'creates a merge request pipeline' do
              expect(pipeline).to be_persisted
787
              expect(pipeline).to be_merge_request_event
S
Shinya Maeda 已提交
788 789 790 791
              expect(pipeline.merge_request).to eq(merge_request)
              expect(pipeline.builds.order(:stage_id).map(&:name)).to eq(%w[test])
            end

792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807
            it 'persists the specified source sha' do
              expect(pipeline.source_sha).to eq(source_sha)
            end

            it 'does not persist target sha for detached merge request pipeline' do
              expect(pipeline.target_sha).to be_nil
            end

            context 'when target sha is specified' do
              let(:target_sha) { merge_request.target_branch_sha }

              it 'persists the target sha' do
                expect(pipeline.target_sha).to eq(target_sha)
              end
            end

S
Shinya Maeda 已提交
808
            context 'when ref is tag' do
809
              let(:ref_name) { 'refs/tags/v1.1.0' }
S
Shinya Maeda 已提交
810 811 812 813 814 815 816 817 818 819 820

              it 'does not create a merge request pipeline' do
                expect(pipeline).not_to be_persisted
                expect(pipeline.errors[:tag]).to eq(["is not included in the list"])
              end
            end

            context 'when merge request is created from a forked project' do
              let(:merge_request) do
                create(:merge_request,
                  source_project: project,
821
                  source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
822 823 824 825 826 827 828 829 830
                  target_project: target_project,
                  target_branch: 'master')
              end

              let!(:project) { fork_project(target_project, nil, repository: true) }
              let!(:target_project) { create(:project, :repository) }

              it 'creates a merge request pipeline in the forked project' do
                expect(pipeline).to be_persisted
831 832
                expect(project.ci_pipelines).to eq([pipeline])
                expect(target_project.ci_pipelines).to be_empty
S
Shinya Maeda 已提交
833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885
              end
            end

            context "when there are no matched jobs" do
              let(:config) do
                {
                  test: {
                    stage: 'test',
                    script: 'echo',
                    except: ['merge_requests']
                  }
                }
              end

              it 'does not create a merge request pipeline' do
                expect(pipeline).not_to be_persisted
                expect(pipeline.errors[:base]).to eq(["No stages / jobs for this pipeline."])
              end
            end
          end

          context 'when merge request is not specified' do
            let(:merge_request) { nil }

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted
              expect(pipeline.errors[:merge_request]).to eq(["can't be blank"])
            end
          end
        end

        context "when config does not have merge_requests keywords" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo'
              },
              test: {
                stage: 'test',
                script: 'echo'
              },
              pages: {
                stage: 'deploy',
                script: 'echo'
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
886
                source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end

          context 'when merge request is not specified' do
            let(:merge_request) { nil }

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end
S
Shinya Maeda 已提交
910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939

        context "when config uses regular expression for only keyword" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo',
                only: ["/^#{ref_name}$/"]
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
                source_branch: ref_name,
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end

940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970
        context "when config uses variables for only keyword" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo',
                only: {
                  variables: %w($CI)
                }
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
                source_branch: ref_name,
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end

S
Shinya Maeda 已提交
971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998
        context "when config has 'except: [tags]'" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo',
                except: ['tags']
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
                source_branch: ref_name,
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted

              expect(pipeline.errors[:base])
                .to eq(['No stages / jobs for this pipeline.'])
            end
          end
        end
S
Shinya Maeda 已提交
999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027
      end

      context 'when source is web' do
        let(:source) { :web }

        context "when config has merge_requests keywords" do
          let(:config) do
            {
              build: {
                stage: 'build',
                script: 'echo'
              },
              test: {
                stage: 'test',
                script: 'echo',
                only: ['merge_requests']
              },
              pages: {
                stage: 'deploy',
                script: 'echo',
                except: ['merge_requests']
              }
            }
          end

          context 'when merge request is specified' do
            let(:merge_request) do
              create(:merge_request,
                source_project: project,
1028
                source_branch: Gitlab::Git.ref_name(ref_name),
S
Shinya Maeda 已提交
1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051
                target_project: project,
                target_branch: 'master')
            end

            it 'does not create a merge request pipeline' do
              expect(pipeline).not_to be_persisted
              expect(pipeline.errors[:merge_request]).to eq(["must be blank"])
            end
          end

          context 'when merge request is not specified' do
            let(:merge_request) { nil }

            it 'creates a branch pipeline' do
              expect(pipeline).to be_persisted
              expect(pipeline).to be_web
              expect(pipeline.merge_request).to be_nil
              expect(pipeline.builds.order(:stage_id).map(&:name)).to eq(%w[build pages])
            end
          end
        end
      end
    end
1052
  end
S
Shinya Maeda 已提交
1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085

  describe '#execute!' do
    subject { service.execute!(*args) }

    let(:service) { described_class.new(project, user, ref: ref_name) }
    let(:args) { [:push] }

    context 'when user has a permission to create a pipeline' do
      let(:user) { create(:user) }

      before do
        project.add_developer(user)
      end

      it 'does not raise an error' do
        expect { subject }.not_to raise_error
      end

      it 'creates a pipeline' do
        expect { subject }.to change { Ci::Pipeline.count }.by(1)
      end
    end

    context 'when user does not have a permission to create a pipeline' do
      let(:user) { create(:user) }

      it 'raises an error' do
        expect { subject }
          .to raise_error(described_class::CreateError)
          .with_message('Insufficient permissions to create a new pipeline')
      end
    end
  end
1086
end