encoding_helper.rb 2.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13
module Gitlab
  module EncodingHelper
    extend self

    # This threshold is carefully tweaked to prevent usage of encodings detected
    # by CharlockHolmes with low confidence. If CharlockHolmes confidence is low,
    # we're better off sticking with utf8 encoding.
    # Reason: git diff can return strings with invalid utf8 byte sequences if it
    # truncates a diff in the middle of a multibyte character. In this case
    # CharlockHolmes will try to guess the encoding and will likely suggest an
    # obscure encoding with low confidence.
    # There is a lot more info with this merge request:
    # https://gitlab.com/gitlab-org/gitlab_git/merge_requests/77#note_4754193
14
    ENCODING_CONFIDENCE_THRESHOLD = 50
15

M
micael.bergeron 已提交
16 17
    #
    # 
18 19 20 21 22 23 24 25 26
    def encode!(message)
      return nil unless message.respond_to? :force_encoding

      # if message is utf-8 encoding, just return it
      message.force_encoding("UTF-8")
      return message if message.valid_encoding?

      # return message if message type is binary
      detect = CharlockHolmes::EncodingDetector.detect(message)
27
      return message.force_encoding("BINARY") if all_binary?(message, detect)
28 29

      if detect && detect[:encoding] && detect[:confidence] > ENCODING_CONFIDENCE_THRESHOLD
M
micael.bergeron 已提交
30
        # force detected encoding if we have sufficient confidence.
31 32 33 34 35
        message.force_encoding(detect[:encoding])
      end

      # encode and clean the bad chars
      message.replace clean(message)
M
micael.bergeron 已提交
36
    rescue => e
37 38 39 40
      encoding = detect ? detect[:encoding] : "unknown"
      "--broken encoding: #{encoding}"
    end

41 42 43 44 45 46 47 48 49 50 51
    def all_binary?(data, detect=nil)
      detect ||= CharlockHolmes::EncodingDetector.detect(data)
      detect && detect[:type] == :binary
    end

    def libgit2_binary?(data)
      # EncodingDetector checks the first 1024 * 1024 bytes for NUL byte, libgit2 checks
      # only the first 8000 (https://github.com/libgit2/libgit2/blob/2ed855a9e8f9af211e7274021c2264e600c0f86b/src/filter.h#L15),
      # which is what we use below to keep a consistent behavior.
      detect = CharlockHolmes::EncodingDetector.new(8000).detect(data)
      all_binary?(data, detect)
M
micael.bergeron 已提交
52 53
    end

54 55
    def encode_utf8(message)
      detect = CharlockHolmes::EncodingDetector.detect(message)
56
      if detect && detect[:encoding]
57 58 59 60 61 62 63 64 65 66 67
        begin
          CharlockHolmes::Converter.convert(message, detect[:encoding], 'UTF-8')
        rescue ArgumentError => e
          Rails.logger.warn("Ignoring error converting #{detect[:encoding]} into UTF8: #{e.message}")

          ''
        end
      else
        clean(message)
      end
    end
M
micael.bergeron 已提交
68
      
69 70 71 72 73 74 75 76 77
    private

    def clean(message)
      message.encode("UTF-16BE", undef: :replace, invalid: :replace, replace: "")
        .encode("UTF-8")
        .gsub("\0".encode("UTF-8"), "")
    end
  end
end