project_wiki_spec.rb 13.0 KB
Newer Older
S
Stan Hu 已提交
1
# coding: utf-8
2 3
require "spec_helper"

4
describe ProjectWiki do
N
Nick Thomas 已提交
5 6
  let(:user) { create(:user, :commit_email) }
  let(:project) { create(:project, :wiki_repo, namespace: user.namespace) }
7 8
  let(:repository) { project.repository }
  let(:gitlab_shell) { Gitlab::Shell.new }
9
  let(:project_wiki) { described_class.new(project, user) }
10
  let(:raw_repository) { Gitlab::Git::Repository.new(project.repository_storage, subject.disk_path + '.git', 'foo') }
N
Nick Thomas 已提交
11
  let(:commit) { project_wiki.repository.head_commit }
12

13
  subject { project_wiki }
14

15
  it { is_expected.to delegate_method(:repository_storage).to :project }
16 17
  it { is_expected.to delegate_method(:hashed_storage?).to :project }

18
  describe "#full_path" do
19
    it "returns the project path with namespace with the .wiki extension" do
20
      expect(subject.full_path).to eq(project.full_path + '.wiki')
21 22 23
    end

    it 'returns the same value as #full_path' do
24
      expect(subject.full_path).to eq(subject.full_path)
25 26 27
    end
  end

28 29
  describe '#web_url' do
    it 'returns the full web URL to the wiki' do
30
      expect(subject.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.full_path}/wikis/home")
31 32 33
    end
  end

34 35
  describe "#url_to_repo" do
    it "returns the correct ssh url to the repo" do
36
      expect(subject.url_to_repo).to eq(gitlab_shell.url_to_repo(subject.full_path))
37 38 39 40 41
    end
  end

  describe "#ssh_url_to_repo" do
    it "equals #url_to_repo" do
42
      expect(subject.ssh_url_to_repo).to eq(subject.url_to_repo)
43 44 45 46
    end
  end

  describe "#http_url_to_repo" do
47
    let(:project) { create :project }
48

49
    it 'returns the full http url to the repo' do
50
      expected_url = "#{Gitlab.config.gitlab.url}/#{subject.full_path}.git"
51

52 53
      expect(project_wiki.http_url_to_repo).to eq(expected_url)
      expect(project_wiki.http_url_to_repo).not_to include('@')
54 55 56
    end
  end

57 58
  describe "#wiki_base_path" do
    it "returns the wiki base path" do
59
      wiki_base_path = "#{Gitlab.config.gitlab.relative_url_root}/#{project.full_path}/wikis"
60

61 62 63 64
      expect(subject.wiki_base_path).to eq(wiki_base_path)
    end
  end

65
  describe "#wiki" do
66 67
    it "contains a Gitlab::Git::Wiki instance" do
      expect(subject.wiki).to be_a Gitlab::Git::Wiki
68 69 70
    end

    it "creates a new wiki repo if one does not yet exist" do
71
      expect(project_wiki.create_page("index", "test content")).to be_truthy
72 73 74
    end

    it "raises CouldNotCreateWikiError if it can't create the wiki repository" do
75 76 77
      # Create a fresh project which will not have a wiki
      project_wiki = described_class.new(create(:project), user)
      gitlab_shell = double(:gitlab_shell)
78
      allow(gitlab_shell).to receive(:create_repository)
79 80 81
      allow(project_wiki).to receive(:gitlab_shell).and_return(gitlab_shell)

      expect { project_wiki.send(:wiki) }.to raise_exception(ProjectWiki::CouldNotCreateWikiError)
82 83 84
    end
  end

J
Jacob Vosmaer 已提交
85 86
  describe "#empty?" do
    context "when the wiki repository is empty" do
87 88 89 90
      describe '#empty?' do
        subject { super().empty? }
        it { is_expected.to be_truthy }
      end
J
Jacob Vosmaer 已提交
91 92 93 94
    end

    context "when the wiki has pages" do
      before do
95
        project_wiki.create_page("index", "This is an awesome new Gollum Wiki")
S
Stan Hu 已提交
96
        project_wiki.create_page("another-page", "This is another page")
J
Jacob Vosmaer 已提交
97 98
      end

99 100 101
      describe '#empty?' do
        subject { super().empty? }
        it { is_expected.to be_falsey }
S
Stan Hu 已提交
102 103 104 105 106 107 108

        # Re-enable this when https://gitlab.com/gitlab-org/gitaly/issues/1204 is fixed
        xit 'only instantiates a Wiki page once' do
          expect(WikiPage).to receive(:new).once.and_call_original

          subject
        end
109
      end
J
Jacob Vosmaer 已提交
110 111 112
    end
  end

113 114 115 116 117 118 119 120 121 122 123
  describe "#pages" do
    before do
      create_page("index", "This is an awesome new Gollum Wiki")
      @pages = subject.pages
    end

    after do
      destroy_page(@pages.first.page)
    end

    it "returns an array of WikiPage instances" do
124
      expect(@pages.first).to be_a WikiPage
125 126 127
    end

    it "returns the correct number of pages" do
128
      expect(@pages.count).to eq(1)
129 130 131 132
    end
  end

  describe "#find_page" do
133 134 135 136
    shared_examples 'finding a wiki page' do
      before do
        create_page("index page", "This is an awesome Gollum Wiki")
      end
137

138
      after do
139
        subject.pages.each { |page| destroy_page(page.page) }
140
      end
141

142 143 144 145 146 147 148 149
      it "returns the latest version of the page if it exists" do
        page = subject.find_page("index page")
        expect(page.title).to eq("index page")
      end

      it "returns nil if the page does not exist" do
        expect(subject.find_page("non-existant")).to eq(nil)
      end
150

151 152 153 154 155 156 157 158 159
      it "can find a page by slug" do
        page = subject.find_page("index-page")
        expect(page.title).to eq("index page")
      end

      it "returns a WikiPage instance" do
        page = subject.find_page("index page")
        expect(page).to be_a WikiPage
      end
160 161 162 163 164 165 166 167 168 169 170

      context 'pages with multibyte-character title' do
        before do
          create_page("autre pagé", "C'est un génial Gollum Wiki")
        end

        it "can find a page by slug" do
          page = subject.find_page("autre pagé")
          expect(page.title).to eq("autre pagé")
        end
      end
171 172 173 174 175 176 177 178 179 180 181

      context 'pages with invalidly-encoded content' do
        before do
          create_page("encoding is fun", "f\xFCr".b)
        end

        it "can find the page" do
          page = subject.find_page("encoding is fun")
          expect(page.content).to eq("fr")
        end
      end
182 183
    end

184 185
    context 'when Gitaly wiki_find_page is enabled' do
      it_behaves_like 'finding a wiki page'
186 187
    end

188 189
    context 'when Gitaly wiki_find_page is disabled', :skip_gitaly_mock do
      it_behaves_like 'finding a wiki page'
190 191 192
    end
  end

193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208
  describe '#find_sidebar' do
    before do
      create_page(described_class::SIDEBAR, 'This is an awesome Sidebar')
    end

    after do
      subject.pages.each { |page| destroy_page(page.page) }
    end

    it 'finds the page defined as _sidebar' do
      page = subject.find_page('_sidebar')

      expect(page.content).to eq('This is an awesome Sidebar')
    end
  end

209
  describe '#find_file' do
210
    shared_examples 'finding a wiki file' do
211 212
      let(:image) { File.open(Rails.root.join('spec', 'fixtures', 'big-image.png')) }

213 214
      before do
        subject.wiki # Make sure the wiki repo exists
215

216 217 218 219 220
        repo_path = Gitlab::GitalyClient::StorageSettings.allow_disk_access do
          subject.repository.path_to_repo
        end

        BareRepoOperations.new(repo_path).commit_file(image, 'image.png')
221
      end
222

223 224 225 226 227 228 229 230 231 232 233 234 235
      it 'returns the latest version of the file if it exists' do
        file = subject.find_file('image.png')
        expect(file.mime_type).to eq('image/png')
      end

      it 'returns nil if the page does not exist' do
        expect(subject.find_file('non-existant')).to eq(nil)
      end

      it 'returns a Gitlab::Git::WikiFile instance' do
        file = subject.find_file('image.png')
        expect(file).to be_a Gitlab::Git::WikiFile
      end
236 237 238 239 240 241 242

      it 'returns the whole file' do
        file = subject.find_file('image.png')
        image.rewind

        expect(file.raw_data.b).to eq(image.read.b)
      end
243 244
    end

245 246
    context 'when Gitaly wiki_find_file is enabled' do
      it_behaves_like 'finding a wiki file'
247 248
    end

249 250
    context 'when Gitaly wiki_find_file is disabled', :skip_gitaly_mock do
      it_behaves_like 'finding a wiki file'
251 252 253
    end
  end

254
  describe "#create_page" do
255 256 257 258
    shared_examples 'creating a wiki page' do
      after do
        destroy_page(subject.pages.first.page)
      end
259

260 261 262 263
      it "creates a new wiki page" do
        expect(subject.create_page("test page", "this is content")).not_to eq(false)
        expect(subject.pages.count).to eq(1)
      end
264

265 266 267 268
      it "returns false when a duplicate page exists" do
        subject.create_page("test page", "content")
        expect(subject.create_page("test page", "content")).to eq(false)
      end
269

270 271 272 273
      it "stores an error message when a duplicate page exists" do
        2.times { subject.create_page("test page", "content") }
        expect(subject.error_message).to match(/Duplicate page:/)
      end
274

275 276 277 278 279
      it "sets the correct commit message" do
        subject.create_page("test page", "some content", :markdown, "commit message")
        expect(subject.pages.first.page.version.message).to eq("commit message")
      end

N
Nick Thomas 已提交
280 281 282
      it 'sets the correct commit email' do
        subject.create_page('test page', 'content')

283
        expect(user.commit_email).not_to eq(user.email)
N
Nick Thomas 已提交
284 285 286 287
        expect(commit.author_email).to eq(user.commit_email)
        expect(commit.committer_email).to eq(user.commit_email)
      end

288 289
      it 'updates project activity' do
        subject.create_page('Test Page', 'This is content')
290

291
        project.reload
292

293 294 295 296 297 298 299 300
        expect(project.last_activity_at).to be_within(1.minute).of(Time.now)
        expect(project.last_repository_updated_at).to be_within(1.minute).of(Time.now)
      end
    end

    context 'when Gitaly wiki_write_page is enabled' do
      it_behaves_like 'creating a wiki page'
    end
301

302 303
    context 'when Gitaly wiki_write_page is disabled', :skip_gitaly_mock do
      it_behaves_like 'creating a wiki page'
304
    end
305 306 307 308 309
  end

  describe "#update_page" do
    before do
      create_page("update-page", "some content")
310
      @gitlab_git_wiki_page = subject.wiki.page(title: "update-page")
311
      subject.update_page(
312
        @gitlab_git_wiki_page,
313 314 315 316
        content: "some other content",
        format: :markdown,
        message: "updated page"
      )
317 318 319 320 321 322 323 324
      @page = subject.pages.first.page
    end

    after do
      destroy_page(@page)
    end

    it "updates the content of the page" do
325
      expect(@page.raw_data).to eq("some other content")
326 327 328
    end

    it "sets the correct commit message" do
329
      expect(@page.version.message).to eq("updated page")
330
    end
331

N
Nick Thomas 已提交
332
    it 'sets the correct commit email' do
333
      expect(user.commit_email).not_to eq(user.email)
N
Nick Thomas 已提交
334 335 336 337
      expect(commit.author_email).to eq(user.commit_email)
      expect(commit.committer_email).to eq(user.commit_email)
    end

338
    it 'updates project activity' do
339
      subject.update_page(
340
        @gitlab_git_wiki_page,
341 342 343 344
        content: 'Yet more content',
        format: :markdown,
        message: 'Updated page again'
      )
345 346 347 348 349

      project.reload

      expect(project.last_activity_at).to be_within(1.minute).of(Time.now)
      expect(project.last_repository_updated_at).to be_within(1.minute).of(Time.now)
350
    end
351 352 353
  end

  describe "#delete_page" do
354 355 356 357 358
    shared_examples 'deleting a wiki page' do
      before do
        create_page("index", "some content")
        @page = subject.wiki.page(title: "index")
      end
359

360 361 362 363
      it "deletes the page" do
        subject.delete_page(@page)
        expect(subject.pages.count).to eq(0)
      end
364

N
Nick Thomas 已提交
365 366 367
      it 'sets the correct commit email' do
        subject.delete_page(@page)

368
        expect(user.commit_email).not_to eq(user.email)
N
Nick Thomas 已提交
369 370 371 372
        expect(commit.author_email).to eq(user.commit_email)
        expect(commit.committer_email).to eq(user.commit_email)
      end

373 374
      it 'updates project activity' do
        subject.delete_page(@page)
375

376
        project.reload
377

378 379 380 381 382 383 384 385 386 387 388
        expect(project.last_activity_at).to be_within(1.minute).of(Time.now)
        expect(project.last_repository_updated_at).to be_within(1.minute).of(Time.now)
      end
    end

    context 'when Gitaly wiki_delete_page is enabled' do
      it_behaves_like 'deleting a wiki page'
    end

    context 'when Gitaly wiki_delete_page is disabled', :skip_gitaly_mock do
      it_behaves_like 'deleting a wiki page'
389
    end
390 391
  end

392
  describe '#create_repo!' do
Z
Zeger-Jan van de Weg 已提交
393 394
    let(:project) { create(:project) }

395
    it 'creates a repository' do
396
      expect(raw_repository.exists?).to eq(false)
397 398
      expect(subject.repository).to receive(:after_create)

399 400 401
      subject.send(:create_repo!, raw_repository)

      expect(raw_repository.exists?).to eq(true)
402 403 404
    end
  end

405
  describe '#ensure_repository' do
Z
Zeger-Jan van de Weg 已提交
406 407
    let(:project) { create(:project) }

408
    it 'creates the repository if it not exist' do
409
      expect(raw_repository.exists?).to eq(false)
410

411
      expect(subject).to receive(:create_repo!).and_call_original
412
      subject.ensure_repository
413 414

      expect(raw_repository.exists?).to eq(true)
415 416 417
    end

    it 'does not create the repository if it exists' do
418 419
      subject.wiki
      expect(raw_repository.exists?).to eq(true)
420 421 422 423 424 425 426

      expect(subject).not_to receive(:create_repo!)

      subject.ensure_repository
    end
  end

427 428 429 430 431 432 433
  describe '#hook_attrs' do
    it 'returns a hash with values' do
      expect(subject.hook_attrs).to be_a Hash
      expect(subject.hook_attrs.keys).to contain_exactly(:web_url, :git_ssh_url, :git_http_url, :path_with_namespace, :default_branch)
    end
  end

434 435 436 437
  private

  def create_temp_repo(path)
    FileUtils.mkdir_p path
438
    system(*%W(#{Gitlab.config.git.bin_path} init --quiet --bare -- #{path}))
439 440 441 442 443 444 445
  end

  def remove_temp_repo(path)
    FileUtils.rm_rf path
  end

  def commit_details
N
Nick Thomas 已提交
446
    Gitlab::Git::Wiki::CommitDetails.new(user.id, user.username, user.name, user.commit_email, "test commit")
447 448 449 450 451 452 453
  end

  def create_page(name, content)
    subject.wiki.write_page(name, :markdown, content, commit_details)
  end

  def destroy_page(page)
454
    subject.delete_page(page, "test commit")
455
  end
456
end