build_spec.rb 95.6 KB
Newer Older
1 2
require 'spec_helper'

3
describe Ci::Build do
4
  set(:user) { create(:user) }
5 6
  set(:group) { create(:group, :access_requestable) }
  set(:project) { create(:project, :repository, group: group) }
7

8
  set(:pipeline) do
9 10 11 12 13 14
    create(:ci_pipeline, project: project,
                         sha: project.commit.id,
                         ref: project.default_branch,
                         status: 'success')
  end

15 16
  let(:build) { create(:ci_build, pipeline: pipeline) }

17 18 19
  it { is_expected.to belong_to(:runner) }
  it { is_expected.to belong_to(:trigger_request) }
  it { is_expected.to belong_to(:erased_by) }
20
  it { is_expected.to have_many(:trace_sections)}
S
Shinya Maeda 已提交
21
  it { is_expected.to have_one(:deployment) }
F
Francisco Javier López 已提交
22
  it { is_expected.to have_one(:runner_session)}
23 24 25
  it { is_expected.to validate_presence_of(:ref) }
  it { is_expected.to respond_to(:has_trace?) }
  it { is_expected.to respond_to(:trace) }
26

Z
Zeger-Jan van de Weg 已提交
27 28
  it { is_expected.to be_a(ArtifactMigratable) }

29 30 31 32 33 34 35
  describe 'associations' do
    it 'has a bidirectional relationship with projects' do
      expect(described_class.reflect_on_association(:project).has_inverse?).to eq(:builds)
      expect(Project.reflect_on_association(:builds).has_inverse?).to eq(:project)
    end
  end

36 37 38 39 40 41 42 43 44 45
  describe 'callbacks' do
    context 'when running after_create callback' do
      it 'triggers asynchronous build hooks worker' do
        expect(BuildHooksWorker).to receive(:perform_async)

        create(:ci_build)
      end
    end
  end

F
Francisco Javier López 已提交
46 47 48 49 50 51 52 53 54 55 56 57 58 59
  describe 'status' do
    context 'when transitioning to any state from running' do
      it 'removes runner_session' do
        %w(success drop cancel).each do |event|
          build = FactoryBot.create(:ci_build, :running, :with_runner_session, pipeline: pipeline)

          build.fire_events!(event)

          expect(build.reload.runner_session).to be_nil
        end
      end
    end
  end

60 61 62 63 64 65 66 67 68 69 70 71
  describe '.manual_actions' do
    let!(:manual_but_created) { create(:ci_build, :manual, status: :created, pipeline: pipeline) }
    let!(:manual_but_succeeded) { create(:ci_build, :manual, status: :success, pipeline: pipeline) }
    let!(:manual_action) { create(:ci_build, :manual, pipeline: pipeline) }

    subject { described_class.manual_actions }

    it { is_expected.to include(manual_action) }
    it { is_expected.to include(manual_but_succeeded) }
    it { is_expected.not_to include(manual_but_created) }
  end

72 73
  describe '.ref_protected' do
    subject { described_class.ref_protected }
S
Shinya Maeda 已提交
74

75 76 77 78 79 80 81
    context 'when protected is true' do
      let!(:job) { create(:ci_build, :protected) }

      it { is_expected.to include(job) }
    end

    context 'when protected is false' do
S
Shinya Maeda 已提交
82
      let!(:job) { create(:ci_build) }
83 84 85 86

      it { is_expected.not_to include(job) }
    end

S
Shinya Maeda 已提交
87
    context 'when protected is nil' do
88 89 90 91 92
      let!(:job) { create(:ci_build) }

      before do
        job.update_attribute(:protected, nil)
      end
93 94 95

      it { is_expected.not_to include(job) }
    end
S
Shinya Maeda 已提交
96 97
  end

98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133
  describe '.with_artifacts_archive' do
    subject { described_class.with_artifacts_archive }

    context 'when job does not have an archive' do
      let!(:job) { create(:ci_build) }

      it 'does not return the job' do
        is_expected.not_to include(job)
      end
    end

    context 'when job has a legacy archive' do
      let!(:job) { create(:ci_build, :legacy_artifacts) }

      it 'returns the job' do
        is_expected.to include(job)
      end
    end

    context 'when job has a job artifact archive' do
      let!(:job) { create(:ci_build, :artifacts) }

      it 'returns the job' do
        is_expected.to include(job)
      end
    end

    context 'when job has a job artifact trace' do
      let!(:job) { create(:ci_build, :trace_artifact) }

      it 'does not return the job' do
        is_expected.not_to include(job)
      end
    end
  end

134 135 136 137 138 139 140 141 142 143 144 145 146 147
  describe '.with_live_trace' do
    subject { described_class.with_live_trace }

    context 'when build has live trace' do
      let!(:build) { create(:ci_build, :success, :trace_live) }

      it 'selects the build' do
        is_expected.to eq([build])
      end
    end

    context 'when build does not have live trace' do
      let!(:build) { create(:ci_build, :success, :trace_artifact) }

S
Shinya Maeda 已提交
148
      it 'does not select the build' do
149 150 151 152 153
        is_expected.to be_empty
      end
    end
  end

S
Shinya Maeda 已提交
154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178
  describe '.with_test_reports' do
    subject { described_class.with_test_reports }

    context 'when build has a test report' do
      let!(:build) { create(:ci_build, :success, :test_reports) }

      it 'selects the build' do
        is_expected.to eq([build])
      end
    end

    context 'when build does not have test reports' do
      let!(:build) { create(:ci_build, :success, :trace_artifact) }

      it 'does not select the build' do
        is_expected.to be_empty
      end
    end

    context 'when there are multiple builds with test reports' do
      let!(:builds) { create_list(:ci_build, 5, :success, :test_reports) }

      it 'does not execute a query for selecting job artifact one by one' do
        recorded = ActiveRecord::QueryRecorder.new do
          subject.each do |build|
179
            build.job_artifacts.map { |a| a.file.exists? }
S
Shinya Maeda 已提交
180 181 182 183 184 185 186 187
          end
        end

        expect(recorded.count).to eq(2)
      end
    end
  end

188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211
  describe '#actionize' do
    context 'when build is a created' do
      before do
        build.update_column(:status, :created)
      end

      it 'makes build a manual action' do
        expect(build.actionize).to be true
        expect(build.reload).to be_manual
      end
    end

    context 'when build is not created' do
      before do
        build.update_column(:status, :pending)
      end

      it 'does not change build status' do
        expect(build.actionize).to be false
        expect(build.reload).to be_pending
      end
    end
  end

212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237
  describe '#schedulable?' do
    subject { build.schedulable? }

    context 'when build is schedulable' do
      let(:build) { create(:ci_build, :created, :schedulable, project: project) }

      it { expect(subject).to be_truthy }
    end

    context 'when build is not schedulable' do
      let(:build) { create(:ci_build, :created, project: project) }

      it { expect(subject).to be_falsy }
    end
  end

  describe '#schedule' do
    subject { build.schedule }

    before do
      project.add_developer(user)
    end

    let(:build) { create(:ci_build, :created, :schedulable, user: user, project: project) }

    it 'transits to scheduled' do
S
Shinya Maeda 已提交
238 239
      allow(Ci::BuildScheduleWorker).to receive(:perform_at)

240 241 242 243 244 245
      subject

      expect(build).to be_scheduled
    end

    it 'updates scheduled_at column' do
S
Shinya Maeda 已提交
246 247
      allow(Ci::BuildScheduleWorker).to receive(:perform_at)

248 249 250 251 252 253 254 255
      subject

      expect(build.scheduled_at).not_to be_nil
    end

    it 'schedules BuildScheduleWorker at the right time' do
      Timecop.freeze do
        expect(Ci::BuildScheduleWorker)
256
          .to receive(:perform_at).with(be_like_time(1.minute.since), build.id)
257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348

        subject
      end
    end
  end

  describe '#unschedule' do
    subject { build.unschedule }

    context 'when build is scheduled' do
      let(:build) { create(:ci_build, :scheduled, pipeline: pipeline) }

      it 'cleans scheduled_at column' do
        subject

        expect(build.scheduled_at).to be_nil
      end

      it 'transits to manual' do
        subject

        expect(build).to be_manual
      end
    end

    context 'when build is not scheduled' do
      let(:build) { create(:ci_build, :created, pipeline: pipeline) }

      it 'does not transit status' do
        subject

        expect(build).to be_created
      end
    end
  end

  describe '#options_scheduled_at' do
    subject { build.options_scheduled_at }

    let(:build) { build_stubbed(:ci_build, options: option) }

    context 'when start_in is 1 day' do
      let(:option) { { start_in: '1 day' } }

      it 'returns date after 1 day' do
        Timecop.freeze do
          is_expected.to eq(1.day.since)
        end
      end
    end

    context 'when start_in is 1 week' do
      let(:option) { { start_in: '1 week' } }

      it 'returns date after 1 week' do
        Timecop.freeze do
          is_expected.to eq(1.week.since)
        end
      end
    end
  end

  describe '#enqueue_scheduled' do
    subject { build.enqueue_scheduled }

    context 'when build is scheduled and the right time has not come yet' do
      let(:build) { create(:ci_build, :scheduled, pipeline: pipeline) }

      it 'does not transits the status' do
        subject

        expect(build).to be_scheduled
      end
    end

    context 'when build is scheduled and the right time has already come' do
      let(:build) { create(:ci_build, :expired_scheduled, pipeline: pipeline) }

      it 'cleans scheduled_at column' do
        subject

        expect(build.scheduled_at).to be_nil
      end

      it 'transits to pending' do
        subject

        expect(build).to be_pending
      end
    end
  end

349 350 351 352 353 354 355 356
  describe '#any_runners_online?' do
    subject { build.any_runners_online? }

    context 'when no runners' do
      it { is_expected.to be_falsey }
    end

    context 'when there are runners' do
357
      let(:runner) { create(:ci_runner, :project, projects: [build.project]) }
358 359

      before do
L
Lin Jen-Shin 已提交
360
        runner.update(contacted_at: 1.second.ago)
361 362 363 364 365
      end

      it { is_expected.to be_truthy }

      it 'that is inactive' do
L
Lin Jen-Shin 已提交
366
        runner.update(active: false)
367 368 369 370
        is_expected.to be_falsey
      end

      it 'that is not online' do
L
Lin Jen-Shin 已提交
371
        runner.update(contacted_at: nil)
372 373 374 375 376 377 378 379 380 381 382
        is_expected.to be_falsey
      end

      it 'that cannot handle build' do
        expect_any_instance_of(Ci::Runner).to receive(:can_pick?).and_return(false)
        is_expected.to be_falsey
      end
    end
  end

  describe '#artifacts?' do
383
    subject { build.artifacts? }
384

385
    context 'when new artifacts are used' do
386 387
      context 'artifacts archive does not exist' do
        let(:build) { create(:ci_build) }
388

389 390 391 392
        it { is_expected.to be_falsy }
      end

      context 'artifacts archive exists' do
393 394
        let(:build) { create(:ci_build, :artifacts) }

395 396 397
        it { is_expected.to be_truthy }

        context 'is expired' do
398
          let(:build) { create(:ci_build, :artifacts, :expired) }
399 400 401 402

          it { is_expected.to be_falsy }
        end
      end
403 404
    end

405 406 407 408
    context 'when legacy artifacts are used' do
      let(:build) { create(:ci_build, :legacy_artifacts) }

      subject { build.artifacts? }
409

M
Micaël Bergeron 已提交
410 411 412 413 414 415
      context 'is expired' do
        let(:build) { create(:ci_build, :legacy_artifacts, :expired) }

        it { is_expected.to be_falsy }
      end

416 417
      context 'artifacts archive does not exist' do
        let(:build) { create(:ci_build) }
418

419 420 421
        it { is_expected.to be_falsy }
      end

422
      context 'artifacts archive exists' do
423 424
        let(:build) { create(:ci_build, :legacy_artifacts) }

425 426 427 428
        it { is_expected.to be_truthy }
      end
    end
  end
429

430 431
  describe '#browsable_artifacts?' do
    subject { build.browsable_artifacts? }
432

433 434
    context 'artifacts metadata does not exist' do
      before do
L
Lin Jen-Shin 已提交
435
        build.update(legacy_artifacts_metadata: nil)
436
      end
437 438 439 440 441 442 443 444

      it { is_expected.to be_falsy }
    end

    context 'artifacts metadata does exists' do
      let(:build) { create(:ci_build, :artifacts) }

      it { is_expected.to be_truthy }
445 446 447 448 449 450 451
    end
  end

  describe '#artifacts_expired?' do
    subject { build.artifacts_expired? }

    context 'is expired' do
452 453 454
      before do
        build.update(artifacts_expire_at: Time.now - 7.days)
      end
455 456 457 458 459

      it { is_expected.to be_truthy }
    end

    context 'is not expired' do
460 461 462
      before do
        build.update(artifacts_expire_at: Time.now + 7.days)
      end
463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486

      it { is_expected.to be_falsey }
    end
  end

  describe '#artifacts_metadata?' do
    subject { build.artifacts_metadata? }
    context 'artifacts metadata does not exist' do
      it { is_expected.to be_falsy }
    end

    context 'artifacts archive is a zip file and metadata exists' do
      let(:build) { create(:ci_build, :artifacts) }
      it { is_expected.to be_truthy }
    end
  end

  describe '#artifacts_expire_in' do
    subject { build.artifacts_expire_in }
    it { is_expected.to be_nil }

    context 'when artifacts_expire_at is specified' do
      let(:expire_at) { Time.now + 7.days }

487 488 489
      before do
        build.artifacts_expire_at = expire_at
      end
490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508

      it { is_expected.to be_within(5).of(expire_at - Time.now) }
    end
  end

  describe '#artifacts_expire_in=' do
    subject { build.artifacts_expire_in }

    it 'when assigning valid duration' do
      build.artifacts_expire_in = '7 days'

      is_expected.to be_within(10).of(7.days.to_i)
    end

    it 'when assigning invalid duration' do
      expect { build.artifacts_expire_in = '7 elephants' }.to raise_error(ChronicDuration::DurationParseError)
      is_expected.to be_nil
    end

509
    it 'when resetting value' do
510 511
      build.artifacts_expire_in = nil

512 513 514 515 516 517
      is_expected.to be_nil
    end

    it 'when setting to 0' do
      build.artifacts_expire_in = '0'

518 519 520 521 522 523 524 525 526 527
      is_expected.to be_nil
    end
  end

  describe '#commit' do
    it 'returns commit pipeline has been created for' do
      expect(build.commit).to eq project.commit
    end
  end

528 529 530 531 532 533 534 535 536 537
  describe '#cache' do
    let(:options) { { cache: { key: "key", paths: ["public"], policy: "pull-push" } } }

    subject { build.cache }

    context 'when build has cache' do
      before do
        allow(build).to receive(:options).and_return(options)
      end

538
      context 'when project has jobs_cache_index' do
539
        before do
540
          allow_any_instance_of(Project).to receive(:jobs_cache_index).and_return(1)
541 542
        end

543
        it { is_expected.to be_an(Array).and all(include(key: "key-1")) }
544 545
      end

546
      context 'when project does not have jobs_cache_index' do
547
        before do
548
          allow_any_instance_of(Project).to receive(:jobs_cache_index).and_return(nil)
549 550 551 552 553 554 555 556 557 558 559 560 561 562 563
        end

        it { is_expected.to eq([options[:cache]]) }
      end
    end

    context 'when build does not have cache' do
      before do
        allow(build).to receive(:options).and_return({})
      end

      it { is_expected.to eq([nil]) }
    end
  end

564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582
  describe '#depends_on_builds' do
    let!(:build) { create(:ci_build, pipeline: pipeline, name: 'build', stage_idx: 0, stage: 'build') }
    let!(:rspec_test) { create(:ci_build, pipeline: pipeline, name: 'rspec', stage_idx: 1, stage: 'test') }
    let!(:rubocop_test) { create(:ci_build, pipeline: pipeline, name: 'rubocop', stage_idx: 1, stage: 'test') }
    let!(:staging) { create(:ci_build, pipeline: pipeline, name: 'staging', stage_idx: 2, stage: 'deploy') }

    it 'expects to have no dependents if this is first build' do
      expect(build.depends_on_builds).to be_empty
    end

    it 'expects to have one dependent if this is test' do
      expect(rspec_test.depends_on_builds.map(&:id)).to contain_exactly(build.id)
    end

    it 'expects to have all builds from build and test stage if this is last' do
      expect(staging.depends_on_builds.map(&:id)).to contain_exactly(build.id, rspec_test.id, rubocop_test.id)
    end

    it 'expects to have retried builds instead the original ones' do
583
      project.add_developer(user)
584

585
      retried_rspec = described_class.retry(rspec_test, user)
586 587 588

      expect(staging.depends_on_builds.map(&:id))
        .to contain_exactly(build.id, retried_rspec.id, rubocop_test.id)
589 590 591
    end
  end

592 593
  describe '#triggered_by?' do
    subject { build.triggered_by?(user) }
S
Shinya Maeda 已提交
594 595 596 597 598 599 600 601 602 603 604 605 606 607 608

    context 'when user is owner' do
      let(:build) { create(:ci_build, pipeline: pipeline, user: user) }

      it { is_expected.to be_truthy }
    end

    context 'when user is not owner' do
      let(:another_user) { create(:user) }
      let(:build) { create(:ci_build, pipeline: pipeline, user: another_user) }

      it { is_expected.to be_falsy }
    end
  end

609 610 611 612 613 614 615
  describe '#detailed_status' do
    it 'returns a detailed status' do
      expect(build.detailed_status(user))
        .to be_a Gitlab::Ci::Status::Build::Cancelable
    end
  end

616
  describe '#coverage_regex' do
617 618
    subject { build.coverage_regex }

619
    context 'when project has build_coverage_regex set' do
620 621
      let(:project_regex) { '\(\d+\.\d+\) covered' }

622
      before do
G
Grzegorz Bizon 已提交
623
        project.update_column(:build_coverage_regex, project_regex)
624
      end
625 626

      context 'and coverage_regex attribute is not set' do
627
        it { is_expected.to eq(project_regex) }
628 629 630
      end

      context 'but coverage_regex attribute is also set' do
631
        let(:build_regex) { 'Code coverage: \d+\.\d+' }
632

633 634 635 636
        before do
          build.coverage_regex = build_regex
        end

637
        it { is_expected.to eq(build_regex) }
638 639 640 641 642 643 644 645 646
      end
    end

    context 'when neither project nor build has coverage regex set' do
      it { is_expected.to be_nil }
    end
  end

  describe '#update_coverage' do
647
    context "regarding coverage_regex's value," do
648
      before do
649
        build.coverage_regex = '\(\d+.\d+\%\) covered'
650 651 652 653 654 655 656 657 658 659
        build.trace.set('Coverage 1033 / 1051 LOC (98.29%) covered')
      end

      it "saves the correct extracted coverage value" do
        expect(build.update_coverage).to be(true)
        expect(build.coverage).to eq(98.29)
      end
    end
  end

660
  describe '#parse_trace_sections!' do
661 662 663 664 665
    it 'calls ExtractSectionsFromBuildTraceService' do
      expect(Ci::ExtractSectionsFromBuildTraceService)
          .to receive(:new).with(project, build.user).once.and_call_original
      expect_any_instance_of(Ci::ExtractSectionsFromBuildTraceService)
        .to receive(:execute).with(build).once
666

667
      build.parse_trace_sections!
668 669 670
    end
  end

671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687
  describe '#trace' do
    subject { build.trace }

    it { is_expected.to be_a(Gitlab::Ci::Trace) }
  end

  describe '#has_trace?' do
    subject { build.has_trace? }

    it "expect to call exist? method" do
      expect_any_instance_of(Gitlab::Ci::Trace).to receive(:exist?)
        .and_return(true)

      is_expected.to be(true)
    end
  end

688 689
  describe '#has_job_artifacts?' do
    subject { build.has_job_artifacts? }
S
Shinya Maeda 已提交
690

691 692
    context 'when build has a job artifact' do
      let(:build) { create(:ci_build, :artifacts) }
S
Shinya Maeda 已提交
693 694 695 696

      it { is_expected.to be_truthy }
    end

697 698
    context 'when build does not have job artifacts' do
      let(:build) { create(:ci_build, :legacy_artifacts) }
S
Shinya Maeda 已提交
699 700 701 702 703

      it { is_expected.to be_falsy }
    end
  end

S
Shinya Maeda 已提交
704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719
  describe '#has_old_trace?' do
    subject { build.has_old_trace? }

    context 'when old trace exists' do
      before do
        build.update_column(:trace, 'old trace')
      end

      it { is_expected.to be_truthy }
    end

    context 'when old trace does not exist' do
      it { is_expected.to be_falsy }
    end
  end

720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738
  describe '#trace=' do
    it "expect to fail trace=" do
      expect { build.trace = "new" }.to raise_error(NotImplementedError)
    end
  end

  describe '#old_trace' do
    subject { build.old_trace }

    before do
      build.update_column(:trace, 'old trace')
    end

    it "expect to receive data from database" do
      is_expected.to eq('old trace')
    end
  end

  describe '#erase_old_trace!' do
S
Shinya Maeda 已提交
739
    subject { build.erase_old_trace! }
740

S
Shinya Maeda 已提交
741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756
    context 'when old trace exists' do
      before do
        build.update_column(:trace, 'old trace')
      end

      it "erases old trace" do
        subject

        expect(build.old_trace).to be_nil
      end

      it "executes UPDATE query" do
        recorded = ActiveRecord::QueryRecorder.new { subject }

        expect(recorded.log.select { |l| l.match?(/UPDATE.*ci_builds/) }.count).to eq(1)
      end
757 758
    end

S
Shinya Maeda 已提交
759 760 761
    context 'when old trace does not exist' do
      it 'does not execute UPDATE query' do
        recorded = ActiveRecord::QueryRecorder.new { subject }
762

S
Shinya Maeda 已提交
763 764
        expect(recorded.log.select { |l| l.match?(/UPDATE.*ci_builds/) }.count).to eq(0)
      end
765 766 767 768 769 770 771 772 773 774 775
    end
  end

  describe '#hide_secrets' do
    let(:subject) { build.hide_secrets(data) }

    context 'hide runners token' do
      let(:data) { 'new token data'}

      before do
        build.project.update(runners_token: 'token')
776
      end
777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795

      it { is_expected.to eq('new xxxxx data') }
    end

    context 'hide build token' do
      let(:data) { 'new token data'}

      before do
        build.update(token: 'token')
      end

      it { is_expected.to eq('new xxxxx data') }
    end

    context 'hide build token' do
      let(:data) { 'new token data'}

      before do
        build.update(token: 'token')
796
      end
797 798

      it { is_expected.to eq('new xxxxx data') }
799 800 801
    end
  end

S
Shinya Maeda 已提交
802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
  describe 'state transition as a deployable' do
    let!(:build) { create(:ci_build, :start_review_app) }
    let(:deployment) { build.deployment }
    let(:environment) { deployment.environment }

    it 'has deployments record with created status' do
      expect(deployment).to be_created
      expect(environment.name).to eq('review/master')
    end

    context 'when transits to running' do
      before do
        build.run!
      end

      it 'transits deployment status to running' do
        expect(deployment).to be_running
      end
    end

    context 'when transits to success' do
      before do
        allow(Deployments::SuccessWorker).to receive(:perform_async)
        build.success!
      end

      it 'transits deployment status to success' do
        expect(deployment).to be_success
      end
    end

    context 'when transits to failed' do
      before do
        build.drop!
      end

      it 'transits deployment status to failed' do
        expect(deployment).to be_failed
      end
    end

    context 'when transits to skipped' do
      before do
        build.skip!
      end

      it 'transits deployment status to canceled' do
        expect(deployment).to be_canceled
      end
    end

    context 'when transits to canceled' do
      before do
        build.cancel!
      end

      it 'transits deployment status to canceled' do
        expect(deployment).to be_canceled
      end
    end
  end

  describe '#on_stop' do
    subject { build.on_stop }

    context 'when a job has a specification that it can be stopped from the other job' do
      let(:build) { create(:ci_build, :start_review_app) }

      it 'returns the other job name' do
        is_expected.to eq('stop_review_app')
      end
    end

    context 'when a job does not have environment information' do
      let(:build) { create(:ci_build) }

      it 'returns nil' do
        is_expected.to be_nil
      end
    end
  end

884
  describe 'deployment' do
S
Shinya Maeda 已提交
885 886 887 888 889
    describe '#has_deployment?' do
      subject { build.has_deployment? }

      context 'when build has a deployment' do
        let!(:deployment) { create(:deployment, deployable: build) }
890

S
Shinya Maeda 已提交
891 892
        it { is_expected.to be_truthy }
      end
893

S
Shinya Maeda 已提交
894 895
      context 'when build does not have a deployment' do
        it { is_expected.to be_falsy }
896 897 898 899 900 901 902 903
      end
    end

    describe '#outdated_deployment?' do
      subject { build.outdated_deployment? }

      context 'when build succeeded' do
        let(:build) { create(:ci_build, :success) }
S
Shinya Maeda 已提交
904
        let!(:deployment) { create(:deployment, :success, deployable: build) }
905 906 907 908 909 910

        context 'current deployment is latest' do
          it { is_expected.to be_falsey }
        end

        context 'current deployment is not latest on environment' do
S
Shinya Maeda 已提交
911
          let!(:deployment2) { create(:deployment, :success, environment: deployment.environment) }
912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948

          it { is_expected.to be_truthy }
        end
      end

      context 'when build failed' do
        let(:build) { create(:ci_build, :failed) }

        it { is_expected.to be_falsey }
      end
    end
  end

  describe 'environment' do
    describe '#has_environment?' do
      subject { build.has_environment? }

      context 'when environment is defined' do
        before do
          build.update(environment: 'review')
        end

        it { is_expected.to be_truthy }
      end

      context 'when environment is not defined' do
        before do
          build.update(environment: nil)
        end

        it { is_expected.to be_falsey }
      end
    end

    describe '#expanded_environment_name' do
      subject { build.expanded_environment_name }

949
      context 'when environment uses $CI_COMMIT_REF_NAME' do
950 951 952
        let(:build) do
          create(:ci_build,
                 ref: 'master',
953
                 environment: 'review/$CI_COMMIT_REF_NAME')
954 955 956 957 958 959 960 961 962 963 964 965 966 967
        end

        it { is_expected.to eq('review/master') }
      end

      context 'when environment uses yaml_variables containing symbol keys' do
        let(:build) do
          create(:ci_build,
                 yaml_variables: [{ key: :APP_HOST, value: 'host' }],
                 environment: 'review/$APP_HOST')
        end

        it { is_expected.to eq('review/host') }
      end
968 969 970 971 972 973 974 975

      context 'when using persisted variables' do
        let(:build) do
          create(:ci_build, environment: 'review/x$CI_BUILD_ID')
        end

        it { is_expected.to eq('review/x') }
      end
976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048
    end

    describe '#starts_environment?' do
      subject { build.starts_environment? }

      context 'when environment is defined' do
        before do
          build.update(environment: 'review')
        end

        context 'no action is defined' do
          it { is_expected.to be_truthy }
        end

        context 'and start action is defined' do
          before do
            build.update(options: { environment: { action: 'start' } } )
          end

          it { is_expected.to be_truthy }
        end
      end

      context 'when environment is not defined' do
        before do
          build.update(environment: nil)
        end

        it { is_expected.to be_falsey }
      end
    end

    describe '#stops_environment?' do
      subject { build.stops_environment? }

      context 'when environment is defined' do
        before do
          build.update(environment: 'review')
        end

        context 'no action is defined' do
          it { is_expected.to be_falsey }
        end

        context 'and stop action is defined' do
          before do
            build.update(options: { environment: { action: 'stop' } } )
          end

          it { is_expected.to be_truthy }
        end
      end

      context 'when environment is not defined' do
        before do
          build.update(environment: nil)
        end

        it { is_expected.to be_falsey }
      end
    end
  end

  describe 'erasable build' do
    shared_examples 'erasable' do
      it 'removes artifact file' do
        expect(build.artifacts_file.exists?).to be_falsy
      end

      it 'removes artifact metadata file' do
        expect(build.artifacts_metadata.exists?).to be_falsy
      end

1049 1050
      it 'removes all job_artifacts' do
        expect(build.job_artifacts.count).to eq(0)
S
Shinya Maeda 已提交
1051 1052
      end

1053
      it 'erases build trace in trace file' do
1054
        expect(build).not_to have_trace
1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
      end

      it 'sets erased to true' do
        expect(build.erased?).to be true
      end

      it 'sets erase date' do
        expect(build.erased_at).not_to be_falsy
      end
    end

    context 'build is not erasable' do
      let!(:build) { create(:ci_build) }

      describe '#erase' do
        subject { build.erase }

        it { is_expected.to be false }
      end

      describe '#erasable?' do
        subject { build.erasable? }
1077

1078 1079 1080 1081 1082
        it { is_expected.to eq false }
      end
    end

    context 'build is erasable' do
1083
      context 'new artifacts' do
S
Shinya Maeda 已提交
1084
        let!(:build) { create(:ci_build, :test_reports, :trace_artifact, :success, :artifacts) }
1085

1086 1087
        describe '#erase' do
          before do
1088
            build.erase(erased_by: erased_by)
1089
          end
1090

1091
          context 'erased by user' do
1092
            let!(:erased_by) { create(:user, username: 'eraser') }
1093

1094
            include_examples 'erasable'
1095

1096
            it 'records user who erased a build' do
1097
              expect(build.erased_by).to eq erased_by
1098
            end
1099 1100
          end

1101
          context 'erased by system' do
1102
            let(:erased_by) { nil }
1103

1104
            include_examples 'erasable'
1105

1106 1107 1108
            it 'does not set user who erased a build' do
              expect(build.erased_by).to be_nil
            end
1109 1110 1111
          end
        end

1112 1113 1114 1115
        describe '#erasable?' do
          subject { build.erasable? }
          it { is_expected.to be_truthy }
        end
1116

1117
        describe '#erased?' do
1118
          let!(:build) { create(:ci_build, :trace_artifact, :success, :artifacts) }
1119
          subject { build.erased? }
1120

1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131
          context 'job has not been erased' do
            it { is_expected.to be_falsey }
          end

          context 'job has been erased' do
            before do
              build.erase
            end

            it { is_expected.to be_truthy }
          end
1132 1133
        end

1134 1135 1136
        context 'metadata and build trace are not available' do
          let!(:build) { create(:ci_build, :success, :artifacts) }

1137
          before do
1138
            build.remove_artifacts_metadata!
1139 1140
          end

1141 1142 1143 1144 1145
          describe '#erase' do
            it 'does not raise error' do
              expect { build.erase }.not_to raise_error
            end
          end
1146 1147
        end
      end
1148
    end
1149

1150 1151 1152
    context 'old artifacts' do
      context 'build is erasable' do
        context 'new artifacts' do
1153
          let!(:build) { create(:ci_build, :trace_artifact, :success, :legacy_artifacts) }
1154

1155 1156
          describe '#erase' do
            before do
1157
              build.erase(erased_by: erased_by)
1158
            end
1159

1160
            context 'erased by user' do
1161
              let!(:erased_by) { create(:user, username: 'eraser') }
1162 1163 1164 1165

              include_examples 'erasable'

              it 'records user who erased a build' do
1166
                expect(build.erased_by).to eq erased_by
1167 1168 1169 1170
              end
            end

            context 'erased by system' do
1171
              let(:erased_by) { nil }
1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186

              include_examples 'erasable'

              it 'does not set user who erased a build' do
                expect(build.erased_by).to be_nil
              end
            end
          end

          describe '#erasable?' do
            subject { build.erasable? }
            it { is_expected.to be_truthy }
          end

          describe '#erased?' do
1187
            let!(:build) { create(:ci_build, :trace_artifact, :success, :legacy_artifacts) }
1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214
            subject { build.erased? }

            context 'job has not been erased' do
              it { is_expected.to be_falsey }
            end

            context 'job has been erased' do
              before do
                build.erase
              end

              it { is_expected.to be_truthy }
            end
          end

          context 'metadata and build trace are not available' do
            let!(:build) { create(:ci_build, :success, :legacy_artifacts) }

            before do
              build.remove_artifacts_metadata!
            end

            describe '#erase' do
              it 'does not raise error' do
                expect { build.erase }.not_to raise_error
              end
            end
1215 1216 1217 1218 1219 1220
          end
        end
      end
    end
  end

1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246
  describe '#erase_erasable_artifacts!' do
    let!(:build) { create(:ci_build, :success) }

    subject { build.erase_erasable_artifacts! }

    before do
      Ci::JobArtifact.file_types.keys.each do |file_type|
        create(:ci_job_artifact, job: build, file_type: file_type, file_format: Ci::JobArtifact::TYPE_AND_FORMAT_PAIRS[file_type.to_sym])
      end
    end

    it "erases erasable artifacts" do
      subject

      expect(build.job_artifacts.erasable).to be_empty
    end

    it "keeps non erasable artifacts" do
      subject

      Ci::JobArtifact::NON_ERASABLE_FILE_TYPES.each do |file_type|
        expect(build.send("job_artifacts_#{file_type}")).not_to be_nil
      end
    end
  end

1247 1248 1249
  describe '#first_pending' do
    let!(:first) { create(:ci_build, pipeline: pipeline, status: 'pending', created_at: Date.yesterday) }
    let!(:second) { create(:ci_build, pipeline: pipeline, status: 'pending') }
1250
    subject { described_class.first_pending }
1251

1252
    it { is_expected.to be_a(described_class) }
1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293
    it('returns with the first pending build') { is_expected.to eq(first) }
  end

  describe '#failed_but_allowed?' do
    subject { build.failed_but_allowed? }

    context 'when build is not allowed to fail' do
      before do
        build.allow_failure = false
      end

      context 'and build.status is success' do
        before do
          build.status = 'success'
        end

        it { is_expected.to be_falsey }
      end

      context 'and build.status is failed' do
        before do
          build.status = 'failed'
        end

        it { is_expected.to be_falsey }
      end
    end

    context 'when build is allowed to fail' do
      before do
        build.allow_failure = true
      end

      context 'and build.status is success' do
        before do
          build.status = 'success'
        end

        it { is_expected.to be_falsey }
      end

1294
      context 'and build status is failed' do
1295 1296 1297 1298 1299 1300
        before do
          build.status = 'failed'
        end

        it { is_expected.to be_truthy }
      end
1301 1302 1303 1304 1305 1306 1307 1308

      context 'when build is a manual action' do
        before do
          build.status = 'manual'
        end

        it { is_expected.to be_falsey }
      end
1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327
    end
  end

  describe 'flags' do
    describe '#cancelable?' do
      subject { build }

      context 'when build is cancelable' do
        context 'when build is pending' do
          it { is_expected.to be_cancelable }
        end

        context 'when build is running' do
          before do
            build.run!
          end

          it { is_expected.to be_cancelable }
        end
J
Jacopo 已提交
1328 1329 1330 1331 1332 1333

        context 'when build is created' do
          let(:build) { create(:ci_build, :created) }

          it { is_expected.to be_cancelable }
        end
1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399
      end

      context 'when build is not cancelable' do
        context 'when build is successful' do
          before do
            build.success!
          end

          it { is_expected.not_to be_cancelable }
        end

        context 'when build is failed' do
          before do
            build.drop!
          end

          it { is_expected.not_to be_cancelable }
        end
      end
    end

    describe '#retryable?' do
      subject { build }

      context 'when build is retryable' do
        context 'when build is successful' do
          before do
            build.success!
          end

          it { is_expected.to be_retryable }
        end

        context 'when build is failed' do
          before do
            build.drop!
          end

          it { is_expected.to be_retryable }
        end

        context 'when build is canceled' do
          before do
            build.cancel!
          end

          it { is_expected.to be_retryable }
        end
      end

      context 'when build is not retryable' do
        context 'when build is running' do
          before do
            build.run!
          end

          it { is_expected.not_to be_retryable }
        end

        context 'when build is skipped' do
          before do
            build.skip!
          end

          it { is_expected.not_to be_retryable }
        end
1400 1401 1402 1403 1404 1405 1406 1407

        context 'when build is degenerated' do
          before do
            build.degenerate!
          end

          it { is_expected.not_to be_retryable }
        end
1408 1409 1410
      end
    end

1411
    describe '#action?' do
1412 1413 1414 1415
      before do
        build.update(when: value)
      end

1416
      subject { build.action? }
1417 1418 1419 1420 1421 1422 1423

      context 'when is set to manual' do
        let(:value) { 'manual' }

        it { is_expected.to be_truthy }
      end

1424 1425 1426 1427 1428 1429
      context 'when is set to delayed' do
        let(:value) { 'delayed' }

        it { is_expected.to be_truthy }
      end

1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440
      context 'when set to something else' do
        let(:value) { 'something else' }

        it { is_expected.to be_falsey }
      end
    end
  end

  describe '#has_tags?' do
    context 'when build has tags' do
      subject { create(:ci_build, tag_list: ['tag']) }
1441

1442 1443 1444 1445 1446
      it { is_expected.to have_tags }
    end

    context 'when build does not have tags' do
      subject { create(:ci_build, tag_list: []) }
1447

1448 1449 1450 1451
      it { is_expected.not_to have_tags }
    end
  end

1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474
  describe 'build auto retry feature' do
    describe '#retries_count' do
      subject { create(:ci_build, name: 'test', pipeline: pipeline) }

      context 'when build has been retried several times' do
        before do
          create(:ci_build, :retried, name: 'test', pipeline: pipeline)
          create(:ci_build, :retried, name: 'test', pipeline: pipeline)
        end

        it 'reports a correct retry count value' do
          expect(subject.retries_count).to eq 2
        end
      end

      context 'when build has not been retried' do
        it 'returns zero' do
          expect(subject.retries_count).to eq 0
        end
      end
    end

    describe '#retries_max' do
M
Markus Doits 已提交
1475
      context 'with retries max config option' do
M
Markus Doits 已提交
1476 1477
        subject { create(:ci_build, options: { retry: { max: 1 } }) }

M
Markus Doits 已提交
1478
        it 'returns the number of configured max retries' do
M
Markus Doits 已提交
1479 1480 1481 1482
          expect(subject.retries_max).to eq 1
        end
      end

M
Markus Doits 已提交
1483
      context 'without retries max config option' do
1484 1485 1486 1487 1488 1489
        subject { create(:ci_build) }

        it 'returns zero' do
          expect(subject.retries_max).to eq 0
        end
      end
1490 1491 1492 1493 1494 1495 1496 1497

      context 'when build is degenerated' do
        subject { create(:ci_build, :degenerated) }

        it 'returns zero' do
          expect(subject.retries_max).to eq 0
        end
      end
1498
    end
1499 1500

    describe '#retry_when' do
M
Markus Doits 已提交
1501 1502
      context 'with retries when config option' do
        subject { create(:ci_build, options: { retry: { when: ['some_reason'] } }) }
1503

M
Markus Doits 已提交
1504 1505
        it 'returns the configured when' do
          expect(subject.retry_when).to eq ['some_reason']
1506 1507 1508
        end
      end

M
Markus Doits 已提交
1509
      context 'without retries when config option' do
1510 1511
        subject { create(:ci_build) }

M
Markus Doits 已提交
1512
        it 'returns always array' do
1513
          expect(subject.retry_when).to eq ['always']
1514 1515 1516
        end
      end
    end
1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549

    describe '#retry_failure?' do
      subject { create(:ci_build) }

      context 'when retries max is zero' do
        before do
          expect(subject).to receive(:retries_max).at_least(:once).and_return(0)
        end

        it 'returns false' do
          expect(subject.retry_failure?).to eq false
        end
      end

      context 'when retries max equals retries count' do
        before do
          expect(subject).to receive(:retries_max).at_least(:once).and_return(1)
          expect(subject).to receive(:retries_count).at_least(:once).and_return(1)
        end

        it 'returns false' do
          expect(subject.retry_failure?).to eq false
        end
      end

      context 'when retries max is higher than retries count' do
        before do
          expect(subject).to receive(:retries_max).at_least(:once).and_return(2)
          expect(subject).to receive(:retries_count).at_least(:once).and_return(1)
        end

        context 'and retry when is always' do
          before do
M
Markus Doits 已提交
1550
            expect(subject).to receive(:retry_when).at_least(:once).and_return(['always'])
1551 1552 1553 1554 1555 1556 1557
          end

          it 'returns true' do
            expect(subject.retry_failure?).to eq true
          end
        end

1558
        context 'and retry when includes the failure_reason' do
1559
          before do
1560 1561
            expect(subject).to receive(:failure_reason).at_least(:once).and_return('some_reason')
            expect(subject).to receive(:retry_when).at_least(:once).and_return(['some_reason'])
1562 1563
          end

1564 1565
          it 'returns true' do
            expect(subject.retry_failure?).to eq true
1566 1567 1568
          end
        end

1569
        context 'and retry when does not include failure_reason' do
1570
          before do
1571 1572
            expect(subject).to receive(:failure_reason).at_least(:once).and_return('some_reason')
            expect(subject).to receive(:retry_when).at_least(:once).and_return(['some', 'other failure'])
1573 1574
          end

1575 1576
          it 'returns false' do
            expect(subject.retry_failure?).to eq false
1577 1578 1579 1580
          end
        end
      end
    end
1581 1582
  end

1583 1584 1585
  describe '#keep_artifacts!' do
    let(:build) { create(:ci_build, artifacts_expire_at: Time.now + 7.days) }

1586 1587
    subject { build.keep_artifacts! }

1588
    it 'to reset expire_at' do
1589
      subject
1590 1591 1592

      expect(build.artifacts_expire_at).to be_nil
    end
1593 1594 1595 1596 1597 1598 1599 1600 1601 1602

    context 'when having artifacts files' do
      let!(:artifact) { create(:ci_job_artifact, job: build, expire_in: '7 days') }

      it 'to reset dependent objects' do
        subject

        expect(artifact.reload.expire_at).to be_nil
      end
    end
1603 1604
  end

1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617
  describe '#artifacts_file_for_type' do
    let(:build) { create(:ci_build, :artifacts) }
    let(:file_type) { :archive }

    subject { build.artifacts_file_for_type(file_type) }

    it 'queries artifacts for type' do
      expect(build).to receive_message_chain(:job_artifacts, :find_by).with(file_type: Ci::JobArtifact.file_types[file_type])

      subject
    end
  end

1618 1619
  describe '#merge_request' do
    def create_mr(build, pipeline, factory: :merge_request, created_at: Time.now)
K
Kamil Trzciński 已提交
1620
      create(factory, source_project: pipeline.project,
1621 1622 1623
                      target_project: pipeline.project,
                      source_branch: build.ref,
                      created_at: created_at)
1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644
    end

    context 'when a MR has a reference to the pipeline' do
      before do
        @merge_request = create_mr(build, pipeline, factory: :merge_request)

        commits = [double(id: pipeline.sha)]
        allow(@merge_request).to receive(:commits).and_return(commits)
        allow(MergeRequest).to receive_message_chain(:includes, :where, :reorder).and_return([@merge_request])
      end

      it 'returns the single associated MR' do
        expect(build.merge_request.id).to eq(@merge_request.id)
      end
    end

    context 'when there is not a MR referencing the pipeline' do
      it 'returns nil' do
        expect(build.merge_request).to be_nil
      end
    end
1645

1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661
    context 'when more than one MR have a reference to the pipeline' do
      before do
        @merge_request = create_mr(build, pipeline, factory: :merge_request)
        @merge_request.close!
        @merge_request2 = create_mr(build, pipeline, factory: :merge_request)

        commits = [double(id: pipeline.sha)]
        allow(@merge_request).to receive(:commits).and_return(commits)
        allow(@merge_request2).to receive(:commits).and_return(commits)
        allow(MergeRequest).to receive_message_chain(:includes, :where, :reorder).and_return([@merge_request, @merge_request2])
      end

      it 'returns the first MR' do
        expect(build.merge_request.id).to eq(@merge_request.id)
      end
    end
1662

1663 1664 1665 1666 1667 1668
    context 'when a Build is created after the MR' do
      before do
        @merge_request = create_mr(build, pipeline, factory: :merge_request_with_diffs)
        pipeline2 = create(:ci_pipeline, project: project)
        @build2 = create(:ci_build, pipeline: pipeline2)

1669
        allow(@merge_request).to receive(:commit_shas)
1670
          .and_return([pipeline.sha, pipeline2.sha])
1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694
        allow(MergeRequest).to receive_message_chain(:includes, :where, :reorder).and_return([@merge_request])
      end

      it 'returns the current MR' do
        expect(@build2.merge_request.id).to eq(@merge_request.id)
      end
    end
  end

  describe '#options' do
    let(:options) do
      {
        image: "ruby:2.1",
        services: [
          "postgres"
        ]
      }
    end

    it 'contains options' do
      expect(build.options).to eq(options)
    end
  end

S
Shinya Maeda 已提交
1695
  describe '#other_manual_actions' do
1696 1697 1698
    let(:build) { create(:ci_build, :manual, pipeline: pipeline) }
    let!(:other_build) { create(:ci_build, :manual, pipeline: pipeline, name: 'other action') }

S
Shinya Maeda 已提交
1699
    subject { build.other_manual_actions }
1700

1701
    before do
1702
      project.add_developer(user)
1703 1704
    end

1705 1706 1707 1708 1709
    it 'returns other actions' do
      is_expected.to contain_exactly(other_build)
    end

    context 'when build is retried' do
1710
      let!(:new_build) { described_class.retry(build, user) }
1711 1712 1713 1714 1715 1716 1717

      it 'does not return any of them' do
        is_expected.not_to include(build, new_build)
      end
    end

    context 'when other build is retried' do
1718
      let!(:retried_build) { described_class.retry(other_build, user) }
1719

1720 1721 1722 1723
      before do
        retried_build.success
      end

1724 1725 1726 1727 1728 1729
      it 'returns a retried build' do
        is_expected.to contain_exactly(retried_build)
      end
    end
  end

S
Shinya Maeda 已提交
1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771
  describe '#other_scheduled_actions' do
    let(:build) { create(:ci_build, :scheduled, pipeline: pipeline) }

    subject { build.other_scheduled_actions }

    before do
      project.add_developer(user)
    end

    context "when other build's status is success" do
      let!(:other_build) { create(:ci_build, :schedulable, :success, pipeline: pipeline, name: 'other action') }

      it 'returns other actions' do
        is_expected.to contain_exactly(other_build)
      end
    end

    context "when other build's status is failed" do
      let!(:other_build) { create(:ci_build, :schedulable, :failed, pipeline: pipeline, name: 'other action') }

      it 'returns other actions' do
        is_expected.to contain_exactly(other_build)
      end
    end

    context "when other build's status is running" do
      let!(:other_build) { create(:ci_build, :schedulable, :running, pipeline: pipeline, name: 'other action') }

      it 'does not return other actions' do
        is_expected.to be_empty
      end
    end

    context "when other build's status is scheduled" do
      let!(:other_build) { create(:ci_build, :scheduled, pipeline: pipeline, name: 'other action') }

      it 'does not return other actions' do
        is_expected.to contain_exactly(other_build)
      end
    end
  end

1772
  describe '#persisted_environment' do
1773 1774
    let!(:environment) do
      create(:environment, project: project, name: "foo-#{project.default_branch}")
1775 1776 1777 1778
    end

    subject { build.persisted_environment }

1779 1780 1781 1782
    context 'when referenced literally' do
      let(:build) do
        create(:ci_build, pipeline: pipeline, environment: "foo-#{project.default_branch}")
      end
1783

1784
      it { is_expected.to eq(environment) }
1785 1786
    end

1787
    context 'when referenced with a variable' do
1788 1789 1790
      let(:build) do
        create(:ci_build, pipeline: pipeline, environment: "foo-$CI_COMMIT_REF_NAME")
      end
1791

1792
      it { is_expected.to eq(environment) }
1793
    end
1794

L
Lin Jen-Shin 已提交
1795
    context 'when there is no environment' do
1796 1797 1798 1799
      it { is_expected.to be_nil }
    end
  end

1800 1801 1802
  describe '#play' do
    let(:build) { create(:ci_build, :manual, pipeline: pipeline) }

1803
    before do
1804
      project.add_developer(user)
1805 1806
    end

1807 1808
    it 'enqueues the build' do
      expect(build.play(user)).to be_pending
1809 1810 1811
    end
  end

1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842
  describe '#playable?' do
    context 'when build is a manual action' do
      context 'when build has been skipped' do
        subject { build_stubbed(:ci_build, :manual, status: :skipped) }

        it { is_expected.not_to be_playable }
      end

      context 'when build has been canceled' do
        subject { build_stubbed(:ci_build, :manual, status: :canceled) }

        it { is_expected.to be_playable }
      end

      context 'when build is successful' do
        subject { build_stubbed(:ci_build, :manual, status: :success) }

        it { is_expected.to be_playable }
      end

      context 'when build has failed' do
        subject { build_stubbed(:ci_build, :manual, status: :failed) }

        it { is_expected.to be_playable }
      end

      context 'when build is a manual untriggered action' do
        subject { build_stubbed(:ci_build, :manual, status: :manual) }

        it { is_expected.to be_playable }
      end
1843 1844 1845 1846 1847 1848

      context 'when build is a manual and degenerated' do
        subject { build_stubbed(:ci_build, :manual, :degenerated, status: :manual) }

        it { is_expected.not_to be_playable }
      end
1849 1850
    end

1851 1852 1853 1854 1855 1856
    context 'when build is scheduled' do
      subject { build_stubbed(:ci_build, :scheduled) }

      it { is_expected.to be_playable }
    end

1857 1858 1859 1860 1861 1862 1863
    context 'when build is not a manual action' do
      subject { build_stubbed(:ci_build, :success) }

      it { is_expected.not_to be_playable }
    end
  end

1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891
  describe 'project settings' do
    describe '#allow_git_fetch' do
      it 'return project allow_git_fetch configuration' do
        expect(build.allow_git_fetch).to eq(project.build_allow_git_fetch)
      end
    end
  end

  describe '#project' do
    subject { build.project }

    it { is_expected.to eq(pipeline.project) }
  end

  describe '#project_id' do
    subject { build.project_id }

    it { is_expected.to eq(pipeline.project_id) }
  end

  describe '#project_name' do
    subject { build.project_name }

    it { is_expected.to eq(project.name) }
  end

  describe '#ref_slug' do
    {
S
Shinya Maeda 已提交
1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902
      'master'                => 'master',
      '1-foo'                 => '1-foo',
      'fix/1-foo'             => 'fix-1-foo',
      'fix-1-foo'             => 'fix-1-foo',
      'a' * 63                => 'a' * 63,
      'a' * 64                => 'a' * 63,
      'FOO'                   => 'foo',
      '-' + 'a' * 61 + '-'    => 'a' * 61,
      '-' + 'a' * 62 + '-'    => 'a' * 62,
      '-' + 'a' * 63 + '-'    => 'a' * 62,
      'a' * 62 + ' '          => 'a' * 62
1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933
    }.each do |ref, slug|
      it "transforms #{ref} to #{slug}" do
        build.ref = ref

        expect(build.ref_slug).to eq(slug)
      end
    end
  end

  describe '#repo_url' do
    subject { build.repo_url }

    it { is_expected.to be_a(String) }
    it { is_expected.to end_with(".git") }
    it { is_expected.to start_with(project.web_url[0..6]) }
    it { is_expected.to include(build.token) }
    it { is_expected.to include('gitlab-ci-token') }
    it { is_expected.to include(project.web_url[7..-1]) }
  end

  describe '#stuck?' do
    subject { build.stuck? }

    context "when commit_status.status is pending" do
      before do
        build.status = 'pending'
      end

      it { is_expected.to be_truthy }

      context "and there are specific runner" do
1934
        let!(:runner) { create(:ci_runner, :project, projects: [build.project], contacted_at: 1.second.ago) }
1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949

        it { is_expected.to be_falsey }
      end
    end

    %w[success failed canceled running].each do |state|
      context "when commit_status.status is #{state}" do
        before do
          build.status = state
        end

        it { is_expected.to be_falsey }
      end
    end
  end
1950

1951 1952
  describe '#has_expiring_artifacts?' do
    context 'when artifacts have expiration date set' do
1953 1954 1955
      before do
        build.update(artifacts_expire_at: 1.day.from_now)
      end
1956 1957 1958 1959 1960 1961 1962

      it 'has expiring artifacts' do
        expect(build).to have_expiring_artifacts
      end
    end

    context 'when artifacts do not have expiration date set' do
1963 1964 1965
      before do
        build.update(artifacts_expire_at: nil)
      end
1966 1967 1968 1969 1970

      it 'does not have expiring artifacts' do
        expect(build).not_to have_expiring_artifacts
      end
    end
1971
  end
T
Tomasz Maczukin 已提交
1972

1973 1974
  context 'when updating the build' do
    let(:build) { create(:ci_build, artifacts_size: 23) }
M
Markus Koller 已提交
1975

1976
    it 'updates project statistics' do
M
Markus Koller 已提交
1977
      build.artifacts_size = 42
1978 1979 1980 1981 1982 1983

      expect(build).to receive(:update_project_statistics_after_save).and_call_original

      expect { build.save! }
        .to change { build.project.statistics.reload.build_artifacts_size }
        .by(19)
M
Markus Koller 已提交
1984 1985
    end

1986 1987 1988
    context 'when the artifact size stays the same' do
      it 'does not update project statistics' do
        build.name = 'changed'
M
Markus Koller 已提交
1989

1990 1991 1992 1993
        expect(build).not_to receive(:update_project_statistics_after_save)

        build.save!
      end
M
Markus Koller 已提交
1994
    end
1995
  end
M
Markus Koller 已提交
1996

1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013
  context 'when destroying the build' do
    let!(:build) { create(:ci_build, artifacts_size: 23) }

    it 'updates project statistics' do
      expect(ProjectStatistics)
        .to receive(:increment_statistic)
        .and_call_original

      expect { build.destroy! }
        .to change { build.project.statistics.reload.build_artifacts_size }
        .by(-23)
    end

    context 'when the build is destroyed due to the project being destroyed' do
      it 'does not update the project statistics' do
        expect(ProjectStatistics)
          .not_to receive(:increment_statistic)
M
Markus Koller 已提交
2014

L
Lin Jen-Shin 已提交
2015
        build.project.update(pending_delete: true)
2016 2017
        build.project.destroy!
      end
M
Markus Koller 已提交
2018 2019
    end
  end
2020 2021 2022 2023 2024 2025 2026

  describe '#when' do
    subject { build.when }

    context 'when `when` is undefined' do
      before do
        build.when = nil
2027
      end
2028 2029

      context 'use from gitlab-ci.yml' do
2030 2031
        let(:pipeline) { create(:ci_pipeline) }

2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044
        before do
          stub_ci_pipeline_yaml_file(config)
        end

        context 'when config is not found' do
          let(:config) { nil }

          it { is_expected.to eq('on_success') }
        end

        context 'when config does not have a questioned job' do
          let(:config) do
            YAML.dump({
2045 2046 2047 2048
              test_other: {
                script: 'Hello World'
              }
            })
2049 2050 2051 2052 2053 2054 2055 2056
          end

          it { is_expected.to eq('on_success') }
        end

        context 'when config has `when`' do
          let(:config) do
            YAML.dump({
2057 2058 2059 2060 2061
              test: {
                script: 'Hello World',
                when: 'always'
              }
            })
2062 2063 2064 2065 2066 2067
          end

          it { is_expected.to eq('always') }
        end
      end
    end
2068
  end
2069 2070 2071

  describe '#variables' do
    let(:container_registry_enabled) { false }
2072
    let(:gitlab_version_info) { Gitlab::VersionInfo.parse(Gitlab::VERSION) }
2073 2074
    let(:predefined_variables) do
      [
2075
        { key: 'CI_PIPELINE_ID', value: pipeline.id.to_s, public: true },
K
Kamil Trzciński 已提交
2076
        { key: 'CI_PIPELINE_URL', value: project.web_url + "/pipelines/#{pipeline.id}", public: true },
2077
        { key: 'CI_JOB_ID', value: build.id.to_s, public: true },
K
Kamil Trzciński 已提交
2078
        { key: 'CI_JOB_URL', value: project.web_url + "/-/jobs/#{build.id}", public: true },
2079 2080 2081 2082 2083 2084
        { key: 'CI_JOB_TOKEN', value: build.token, public: false },
        { key: 'CI_BUILD_ID', value: build.id.to_s, public: true },
        { key: 'CI_BUILD_TOKEN', value: build.token, public: false },
        { key: 'CI_REGISTRY_USER', value: 'gitlab-ci-token', public: true },
        { key: 'CI_REGISTRY_PASSWORD', value: build.token, public: false },
        { key: 'CI_REPOSITORY_URL', value: build.repo_url, public: false },
2085 2086
        { key: 'CI', value: 'true', public: true },
        { key: 'GITLAB_CI', value: 'true', public: true },
2087
        { key: 'GITLAB_FEATURES', value: project.licensed_features.join(','), public: true },
2088 2089
        { key: 'CI_SERVER_NAME', value: 'GitLab', public: true },
        { key: 'CI_SERVER_VERSION', value: Gitlab::VERSION, public: true },
2090 2091 2092
        { key: 'CI_SERVER_VERSION_MAJOR', value: gitlab_version_info.major.to_s, public: true },
        { key: 'CI_SERVER_VERSION_MINOR', value: gitlab_version_info.minor.to_s, public: true },
        { key: 'CI_SERVER_VERSION_PATCH', value: gitlab_version_info.patch.to_s, public: true },
2093
        { key: 'CI_SERVER_REVISION', value: Gitlab.revision, public: true },
2094 2095
        { key: 'CI_JOB_NAME', value: 'test', public: true },
        { key: 'CI_JOB_STAGE', value: 'test', public: true },
Z
Z.J. van de Weg 已提交
2096
        { key: 'CI_COMMIT_SHA', value: build.sha, public: true },
2097
        { key: 'CI_COMMIT_BEFORE_SHA', value: build.before_sha, public: true },
2098 2099
        { key: 'CI_COMMIT_REF_NAME', value: build.ref, public: true },
        { key: 'CI_COMMIT_REF_SLUG', value: build.ref_slug, public: true },
2100
        { key: 'CI_NODE_TOTAL', value: '1', public: true },
2101 2102 2103 2104 2105 2106
        { key: 'CI_BUILD_REF', value: build.sha, public: true },
        { key: 'CI_BUILD_BEFORE_SHA', value: build.before_sha, public: true },
        { key: 'CI_BUILD_REF_NAME', value: build.ref, public: true },
        { key: 'CI_BUILD_REF_SLUG', value: build.ref_slug, public: true },
        { key: 'CI_BUILD_NAME', value: 'test', public: true },
        { key: 'CI_BUILD_STAGE', value: 'test', public: true },
2107 2108
        { key: 'CI_PROJECT_ID', value: project.id.to_s, public: true },
        { key: 'CI_PROJECT_NAME', value: project.path, public: true },
2109
        { key: 'CI_PROJECT_PATH', value: project.full_path, public: true },
V
vanadium23 已提交
2110
        { key: 'CI_PROJECT_PATH_SLUG', value: project.full_path_slug, public: true },
2111
        { key: 'CI_PROJECT_NAMESPACE', value: project.namespace.full_path, public: true },
2112
        { key: 'CI_PROJECT_URL', value: project.web_url, public: true },
M
Matija Čupić 已提交
2113
        { key: 'CI_PROJECT_VISIBILITY', value: 'private', public: true },
2114
        { key: 'CI_PIPELINE_IID', value: pipeline.iid.to_s, public: true },
2115
        { key: 'CI_CONFIG_PATH', value: pipeline.ci_yaml_file_path, public: true },
2116 2117 2118 2119
        { key: 'CI_PIPELINE_SOURCE', value: pipeline.source, public: true },
        { key: 'CI_COMMIT_MESSAGE', value: pipeline.git_commit_message, public: true },
        { key: 'CI_COMMIT_TITLE', value: pipeline.git_commit_title, public: true },
        { key: 'CI_COMMIT_DESCRIPTION', value: pipeline.git_commit_description, public: true }
2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133
      ]
    end

    before do
      stub_container_registry_config(enabled: container_registry_enabled, host_port: 'registry.example.com')
    end

    subject { build.variables }

    context 'returns variables' do
      before do
        build.yaml_variables = []
      end

2134
      it { is_expected.to include(*predefined_variables) }
2135 2136 2137 2138
    end

    context 'when build has user' do
      let(:user_variables) do
2139 2140 2141
        [
          { key: 'GITLAB_USER_ID', value: user.id.to_s, public: true },
          { key: 'GITLAB_USER_EMAIL', value: user.email, public: true },
2142
          { key: 'GITLAB_USER_LOGIN', value: user.username, public: true },
2143 2144
          { key: 'GITLAB_USER_NAME', value: user.name, public: true }
        ]
2145 2146 2147
      end

      before do
L
Lin Jen-Shin 已提交
2148
        build.update(user: user)
2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161
      end

      it { user_variables.each { |v| is_expected.to include(v) } }
    end

    context 'when build has an environment' do
      let(:environment_variables) do
        [
          { key: 'CI_ENVIRONMENT_NAME', value: 'production', public: true },
          { key: 'CI_ENVIRONMENT_SLUG', value: 'prod-slug',  public: true }
        ]
      end

2162 2163
      let!(:environment) do
        create(:environment,
2164 2165 2166 2167
               project: build.project,
               name: 'production',
               slug: 'prod-slug',
               external_url: '')
2168 2169
      end

L
Lin Jen-Shin 已提交
2170 2171 2172 2173
      before do
        build.update(environment: 'production')
      end

2174
      shared_examples 'containing environment variables' do
L
Lin Jen-Shin 已提交
2175
        it { environment_variables.each { |v| is_expected.to include(v) } }
2176 2177 2178 2179
      end

      context 'when no URL was set' do
        it_behaves_like 'containing environment variables'
L
Lin Jen-Shin 已提交
2180 2181 2182 2183 2184 2185 2186 2187 2188

        it 'does not have CI_ENVIRONMENT_URL' do
          keys = subject.map { |var| var[:key] }

          expect(keys).not_to include('CI_ENVIRONMENT_URL')
        end
      end

      context 'when an URL was set' do
2189
        let(:url) { 'http://host/test' }
L
Lin Jen-Shin 已提交
2190

2191
        before do
L
Lin Jen-Shin 已提交
2192
          environment_variables <<
2193
            { key: 'CI_ENVIRONMENT_URL', value: url, public: true }
L
Lin Jen-Shin 已提交
2194 2195
        end

2196 2197
        context 'when the URL was set from the job' do
          before do
2198
            build.update(options: { environment: { url: url } })
2199 2200 2201
          end

          it_behaves_like 'containing environment variables'
2202 2203 2204 2205 2206 2207 2208 2209 2210 2211

          context 'when variables are used in the URL, it does not expand' do
            let(:url) { 'http://$CI_PROJECT_NAME-$CI_ENVIRONMENT_SLUG' }

            it_behaves_like 'containing environment variables'

            it 'puts $CI_ENVIRONMENT_URL in the last so all other variables are available to be used when runners are trying to expand it' do
              expect(subject.last).to eq(environment_variables.last)
            end
          end
2212 2213 2214 2215 2216 2217 2218 2219 2220
        end

        context 'when the URL was not set from the job, but environment' do
          before do
            environment.update(external_url: url)
          end

          it_behaves_like 'containing environment variables'
        end
L
Lin Jen-Shin 已提交
2221
      end
2222 2223 2224 2225
    end

    context 'when build started manually' do
      before do
L
Lin Jen-Shin 已提交
2226
        build.update(when: :manual)
2227 2228 2229
      end

      let(:manual_variable) do
2230
        { key: 'CI_JOB_MANUAL', value: 'true', public: true }
2231 2232 2233 2234 2235 2236 2237
      end

      it { is_expected.to include(manual_variable) }
    end

    context 'when build is for tag' do
      let(:tag_variable) do
2238
        { key: 'CI_COMMIT_TAG', value: 'master', public: true }
2239 2240 2241
      end

      before do
L
Lin Jen-Shin 已提交
2242
        build.update(tag: true)
2243 2244 2245 2246 2247
      end

      it { is_expected.to include(tag_variable) }
    end

2248 2249
    context 'when CI variable is defined' do
      let(:ci_variable) do
2250 2251 2252 2253
        { key: 'SECRET_KEY', value: 'secret_value', public: false }
      end

      before do
2254
        create(:ci_variable,
2255
               ci_variable.slice(:key, :value).merge(project: project))
2256 2257
      end

2258
      it { is_expected.to include(ci_variable) }
2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273
    end

    context 'when protected variable is defined' do
      let(:protected_variable) do
        { key: 'PROTECTED_KEY', value: 'protected_value', public: false }
      end

      before do
        create(:ci_variable,
               :protected,
               protected_variable.slice(:key, :value).merge(project: project))
      end

      context 'when the branch is protected' do
        before do
2274
          allow(build.project).to receive(:protected_for?).with(build.ref).and_return(true)
2275 2276 2277 2278 2279 2280 2281
        end

        it { is_expected.to include(protected_variable) }
      end

      context 'when the tag is protected' do
        before do
2282
          allow(build.project).to receive(:protected_for?).with(build.ref).and_return(true)
2283 2284 2285 2286 2287 2288 2289 2290
        end

        it { is_expected.to include(protected_variable) }
      end

      context 'when the ref is not protected' do
        it { is_expected.not_to include(protected_variable) }
      end
2291 2292
    end

2293 2294
    context 'when group CI variable is defined' do
      let(:ci_variable) do
S
Shinya Maeda 已提交
2295 2296 2297 2298 2299
        { key: 'SECRET_KEY', value: 'secret_value', public: false }
      end

      before do
        create(:ci_group_variable,
2300
               ci_variable.slice(:key, :value).merge(group: group))
S
Shinya Maeda 已提交
2301 2302
      end

2303
      it { is_expected.to include(ci_variable) }
S
Shinya Maeda 已提交
2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318
    end

    context 'when group protected variable is defined' do
      let(:protected_variable) do
        { key: 'PROTECTED_KEY', value: 'protected_value', public: false }
      end

      before do
        create(:ci_group_variable,
               :protected,
               protected_variable.slice(:key, :value).merge(group: group))
      end

      context 'when the branch is protected' do
        before do
2319
          allow(build.project).to receive(:protected_for?).with(build.ref).and_return(true)
S
Shinya Maeda 已提交
2320 2321 2322 2323 2324 2325
        end

        it { is_expected.to include(protected_variable) }
      end

      context 'when the tag is protected' do
2326
        before do
2327
          allow(build.project).to receive(:protected_for?).with(build.ref).and_return(true)
2328 2329 2330 2331 2332 2333
        end

        it { is_expected.to include(protected_variable) }
      end

      context 'when the ref is not protected' do
2334 2335 2336 2337
        before do
          build.update_column(:ref, 'some/feature')
        end

2338 2339
        it { is_expected.not_to include(protected_variable) }
      end
2340 2341 2342 2343
    end

    context 'when build is for triggers' do
      let(:trigger) { create(:ci_trigger, project: project) }
2344 2345
      let(:trigger_request) { create(:ci_trigger_request, pipeline: pipeline, trigger: trigger) }

2346
      let(:user_trigger_variable) do
2347
        { key: 'TRIGGER_KEY_1', value: 'TRIGGER_VALUE_1', public: false }
2348
      end
2349

2350
      let(:predefined_trigger_variable) do
2351
        { key: 'CI_PIPELINE_TRIGGERED', value: 'true', public: true }
2352 2353 2354 2355 2356 2357
      end

      before do
        build.trigger_request = trigger_request
      end

2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377
      shared_examples 'returns variables for triggers' do
        it { is_expected.to include(user_trigger_variable) }
        it { is_expected.to include(predefined_trigger_variable) }
      end

      context 'when variables are stored in trigger_request' do
        before do
          trigger_request.update_attribute(:variables, { 'TRIGGER_KEY_1' => 'TRIGGER_VALUE_1' } )
        end

        it_behaves_like 'returns variables for triggers'
      end

      context 'when variables are stored in pipeline_variables' do
        before do
          create(:ci_pipeline_variable, pipeline: pipeline, key: 'TRIGGER_KEY_1', value: 'TRIGGER_VALUE_1')
        end

        it_behaves_like 'returns variables for triggers'
      end
2378 2379
    end

S
init  
Shinya Maeda 已提交
2380 2381 2382 2383 2384 2385
    context 'when pipeline has a variable' do
      let!(:pipeline_variable) { create(:ci_pipeline_variable, pipeline: pipeline) }

      it { is_expected.to include(pipeline_variable.to_runner_variable) }
    end

S
Shinya Maeda 已提交
2386
    context 'when a job was triggered by a pipeline schedule' do
2387
      let(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project) }
2388

S
Shinya Maeda 已提交
2389
      let!(:pipeline_schedule_variable) do
2390
        create(:ci_pipeline_schedule_variable,
2391 2392
               key: 'SCHEDULE_VARIABLE_KEY',
               pipeline_schedule: pipeline_schedule)
S
Shinya Maeda 已提交
2393
      end
2394

2395 2396
      before do
        pipeline_schedule.pipelines << pipeline
S
Shinya Maeda 已提交
2397
        pipeline_schedule.reload
2398 2399
      end

S
Shinya Maeda 已提交
2400
      it { is_expected.to include(pipeline_schedule_variable.to_runner_variable) }
2401 2402
    end

2403
    context 'when yaml_variables are undefined' do
2404 2405 2406 2407 2408
      let(:pipeline) do
        create(:ci_pipeline, project: project,
                             sha: project.commit.id,
                             ref: project.default_branch)
      end
2409

2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421
      before do
        build.yaml_variables = nil
      end

      context 'use from gitlab-ci.yml' do
        before do
          stub_ci_pipeline_yaml_file(config)
        end

        context 'when config is not found' do
          let(:config) { nil }

2422
          it { is_expected.to include(*predefined_variables) }
2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433
        end

        context 'when config does not have a questioned job' do
          let(:config) do
            YAML.dump({
              test_other: {
                script: 'Hello World'
              }
            })
          end

2434
          it { is_expected.to include(*predefined_variables) }
2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451
        end

        context 'when config has variables' do
          let(:config) do
            YAML.dump({
              test: {
                script: 'Hello World',
                variables: {
                  KEY: 'value'
                }
              }
            })
          end
          let(:variables) do
            [{ key: 'KEY', value: 'value', public: true }]
          end

2452 2453
          it { is_expected.to include(*predefined_variables) }
          it { is_expected.to include(*variables) }
2454 2455 2456 2457 2458 2459 2460 2461 2462 2463
        end
      end
    end

    context 'when container registry is enabled' do
      let(:container_registry_enabled) { true }
      let(:ci_registry) do
        { key: 'CI_REGISTRY',  value: 'registry.example.com',  public: true }
      end
      let(:ci_registry_image) do
A
Andre Guedes 已提交
2464
        { key: 'CI_REGISTRY_IMAGE',  value: project.container_registry_url, public: true }
2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486
      end

      context 'and is disabled for project' do
        before do
          project.update(container_registry_enabled: false)
        end

        it { is_expected.to include(ci_registry) }
        it { is_expected.not_to include(ci_registry_image) }
      end

      context 'and is enabled for project' do
        before do
          project.update(container_registry_enabled: true)
        end

        it { is_expected.to include(ci_registry) }
        it { is_expected.to include(ci_registry_image) }
      end
    end

    context 'when runner is assigned to build' do
D
Douwe Maan 已提交
2487
      let(:runner) { create(:ci_runner, description: 'description', tag_list: %w(docker linux)) }
2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502

      before do
        build.update(runner: runner)
      end

      it { is_expected.to include({ key: 'CI_RUNNER_ID', value: runner.id.to_s, public: true }) }
      it { is_expected.to include({ key: 'CI_RUNNER_DESCRIPTION', value: 'description', public: true }) }
      it { is_expected.to include({ key: 'CI_RUNNER_TAGS', value: 'docker, linux', public: true }) }
    end

    context 'when build is for a deployment' do
      let(:deployment_variable) { { key: 'KUBERNETES_TOKEN', value: 'TOKEN', public: false } }

      before do
        build.environment = 'production'
2503 2504 2505 2506

        allow_any_instance_of(Project)
          .to receive(:deployment_variables)
          .and_return([deployment_variable])
2507 2508 2509 2510 2511
      end

      it { is_expected.to include(deployment_variable) }
    end

L
Lin Jen-Shin 已提交
2512 2513 2514 2515
    context 'when project has custom CI config path' do
      let(:ci_config_path) { { key: 'CI_CONFIG_PATH', value: 'custom', public: true } }

      before do
2516
        project.update(ci_config_path: 'custom')
L
Lin Jen-Shin 已提交
2517 2518 2519 2520 2521
      end

      it { is_expected.to include(ci_config_path) }
    end

2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544
    context 'when using auto devops' do
      context 'and is enabled' do
        before do
          project.create_auto_devops!(enabled: true, domain: 'example.com')
        end

        it "includes AUTO_DEVOPS_DOMAIN" do
          is_expected.to include(
            { key: 'AUTO_DEVOPS_DOMAIN', value: 'example.com', public: true })
        end
      end

      context 'and is disabled' do
        before do
          project.create_auto_devops!(enabled: false, domain: 'example.com')
        end

        it "includes AUTO_DEVOPS_DOMAIN" do
          is_expected.not_to include(
            { key: 'AUTO_DEVOPS_DOMAIN', value: 'example.com', public: true })
        end
      end
    end
2545 2546 2547 2548 2549 2550 2551 2552

    context 'when pipeline variable overrides build variable' do
      before do
        build.yaml_variables = [{ key: 'MYVAR', value: 'myvar', public: true }]
        pipeline.variables.build(key: 'MYVAR', value: 'pipeline value')
      end

      it 'overrides YAML variable using a pipeline variable' do
2553 2554 2555 2556 2557 2558
        variables = subject.reverse.uniq { |variable| variable[:key] }.reverse

        expect(variables)
          .not_to include(key: 'MYVAR', value: 'myvar', public: true)
        expect(variables)
          .to include(key: 'MYVAR', value: 'pipeline value', public: false)
2559 2560 2561
      end
    end

2562 2563 2564 2565 2566 2567
    context 'when build is parallelized' do
      let(:total) { 5 }
      let(:index) { 3 }

      before do
        build.options[:parallel] = total
2568
        build.options[:instance] = index
2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584
        build.name = "#{build.name} #{index}/#{total}"
      end

      it 'includes CI_NODE_INDEX' do
        is_expected.to include(
          { key: 'CI_NODE_INDEX', value: index.to_s, public: true }
        )
      end

      it 'includes correct CI_NODE_TOTAL' do
        is_expected.to include(
          { key: 'CI_NODE_TOTAL', value: total.to_s, public: true }
        )
      end
    end

2585 2586
    describe 'variables ordering' do
      context 'when variables hierarchy is stubbed' do
2587 2588 2589 2590
        let(:build_pre_var) { { key: 'build', value: 'value', public: true } }
        let(:project_pre_var) { { key: 'project', value: 'value', public: true } }
        let(:pipeline_pre_var) { { key: 'pipeline', value: 'value', public: true } }
        let(:build_yaml_var) { { key: 'yaml', value: 'value', public: true } }
2591 2592 2593 2594

        before do
          allow(build).to receive(:predefined_variables) { [build_pre_var] }
          allow(build).to receive(:yaml_variables) { [build_yaml_var] }
2595
          allow(build).to receive(:persisted_variables) { [] }
2596 2597 2598 2599 2600

          allow_any_instance_of(Project)
            .to receive(:predefined_variables) { [project_pre_var] }

          allow_any_instance_of(Project)
2601
            .to receive(:ci_variables_for)
2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622
            .with(ref: 'master', environment: nil) do
            [create(:ci_variable, key: 'secret', value: 'value')]
          end

          allow_any_instance_of(Ci::Pipeline)
            .to receive(:predefined_variables) { [pipeline_pre_var] }
        end

        it 'returns variables in order depending on resource hierarchy' do
          is_expected.to eq(
            [build_pre_var,
             project_pre_var,
             pipeline_pre_var,
             build_yaml_var,
             { key: 'secret', value: 'value', public: false }])
        end
      end

      context 'when build has environment and user-provided variables' do
        let(:expected_variables) do
          predefined_variables.map { |variable| variable.fetch(:key) } +
2623 2624
            %w[YAML_VARIABLE CI_ENVIRONMENT_NAME CI_ENVIRONMENT_SLUG
               CI_ENVIRONMENT_URL]
2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643
        end

        before do
          create(:environment, project: build.project,
                               name: 'staging')

          build.yaml_variables = [{ key: 'YAML_VARIABLE',
                                    value: 'var',
                                    public: true }]
          build.environment = 'staging'
        end

        it 'matches explicit variables ordering' do
          received_variables = subject.map { |variable| variable.fetch(:key) }

          expect(received_variables).to eq expected_variables
        end
      end
    end
2644

2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662
    context 'when build has not been persisted yet' do
      let(:build) do
        described_class.new(
          name: 'rspec',
          stage: 'test',
          ref: 'feature',
          project: project,
          pipeline: pipeline
        )
      end

      it 'returns static predefined variables' do
        expect(build.variables.size).to be >= 28
        expect(build.variables)
          .to include(key: 'CI_COMMIT_REF_NAME', value: 'feature', public: true)
        expect(build).not_to be_persisted
      end
    end
2663 2664 2665 2666 2667 2668

    context 'for deploy tokens' do
      let(:deploy_token) { create(:deploy_token, :gitlab_deploy_token) }

      let(:deploy_token_variables) do
        [
2669
          { key: 'CI_DEPLOY_USER', value: deploy_token.username, public: true },
2670
          { key: 'CI_DEPLOY_PASSWORD', value: deploy_token.token, public: false }
2671 2672 2673
        ]
      end

2674
      context 'when gitlab-deploy-token exists' do
2675 2676 2677 2678 2679
        before do
          project.deploy_tokens << deploy_token
        end

        it 'should include deploy token variables' do
2680
          is_expected.to include(*deploy_token_variables)
2681 2682 2683 2684 2685
        end
      end

      context 'when gitlab-deploy-token does not exist' do
        it 'should not include deploy token variables' do
2686 2687
          expect(subject.find { |v| v[:key] == 'CI_DEPLOY_USER'}).to be_nil
          expect(subject.find { |v| v[:key] == 'CI_DEPLOY_PASSWORD'}).to be_nil
2688 2689 2690
        end
      end
    end
2691 2692
  end

2693
  describe '#scoped_variables' do
2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708
    context 'when build has not been persisted yet' do
      let(:build) do
        described_class.new(
          name: 'rspec',
          stage: 'test',
          ref: 'feature',
          project: project,
          pipeline: pipeline
        )
      end

      it 'does not persist the build' do
        expect(build).to be_valid
        expect(build).not_to be_persisted

2709
        build.scoped_variables
2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720

        expect(build).not_to be_persisted
      end

      it 'returns static predefined variables' do
        keys = %w[CI_JOB_NAME
                  CI_COMMIT_SHA
                  CI_COMMIT_REF_NAME
                  CI_COMMIT_REF_SLUG
                  CI_JOB_STAGE]

2721
        variables = build.scoped_variables
2722 2723

        variables.map { |env| env[:key] }.tap do |names|
2724 2725 2726
          expect(names).to include(*keys)
        end

2727 2728
        expect(variables)
          .to include(key: 'CI_COMMIT_REF_NAME', value: 'feature', public: true)
2729 2730 2731 2732
      end

      it 'does not return prohibited variables' do
        keys = %w[CI_JOB_ID
K
Kamil Trzciński 已提交
2733
                  CI_JOB_URL
2734 2735 2736 2737 2738 2739
                  CI_JOB_TOKEN
                  CI_BUILD_ID
                  CI_BUILD_TOKEN
                  CI_REGISTRY_USER
                  CI_REGISTRY_PASSWORD
                  CI_REPOSITORY_URL
2740 2741 2742
                  CI_ENVIRONMENT_URL
                  CI_DEPLOY_USER
                  CI_DEPLOY_PASSWORD]
2743

2744
        build.scoped_variables.map { |env| env[:key] }.tap do |names|
2745 2746 2747 2748
          expect(names).not_to include(*keys)
        end
      end
    end
2749
  end
K
Kamil Trzcinski 已提交
2750

2751
  describe '#scoped_variables_hash' do
2752
    context 'when overriding CI variables' do
2753 2754 2755 2756 2757 2758
      before do
        project.variables.create!(key: 'MY_VAR', value: 'my value 1')
        pipeline.variables.create!(key: 'MY_VAR', value: 'my value 2')
      end

      it 'returns a regular hash created using valid ordering' do
2759 2760
        expect(build.scoped_variables_hash).to include('MY_VAR': 'my value 2')
        expect(build.scoped_variables_hash).not_to include('MY_VAR': 'my value 1')
2761
      end
2762 2763
    end

2764 2765 2766 2767 2768 2769 2770
    context 'when overriding user-provided variables' do
      before do
        pipeline.variables.build(key: 'MY_VAR', value: 'pipeline value')
        build.yaml_variables = [{ key: 'MY_VAR', value: 'myvar', public: true }]
      end

      it 'returns a hash including variable with higher precedence' do
2771 2772
        expect(build.scoped_variables_hash).to include('MY_VAR': 'pipeline value')
        expect(build.scoped_variables_hash).not_to include('MY_VAR': 'myvar')
2773
      end
2774 2775 2776
    end
  end

2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794
  describe '#yaml_variables' do
    before do
      build.update_attribute(:yaml_variables, variables)
    end

    context 'when serialized valu is a symbolized hash' do
      let(:variables) do
        [{ key: :VARIABLE, value: 'my value 1' }]
      end

      it 'keeps symbolizes keys and stringifies variables names' do
        expect(build.yaml_variables)
          .to eq [{ key: 'VARIABLE', value: 'my value 1' }]
      end
    end

    context 'when serialized value is a hash with string keys' do
      let(:variables) do
2795
        [{ 'key' => :VARIABLE, 'value' => 'my value 2' }]
2796 2797 2798 2799 2800 2801 2802 2803 2804
      end

      it 'symblizes variables hash' do
        expect(build.yaml_variables)
          .to eq [{ key: 'VARIABLE', value: 'my value 2' }]
      end
    end
  end

2805
  describe 'state transition: any => [:pending]' do
K
Kamil Trzcinski 已提交
2806 2807 2808 2809 2810 2811 2812 2813
    let(:build) { create(:ci_build, :created) }

    it 'queues BuildQueueWorker' do
      expect(BuildQueueWorker).to receive(:perform_async).with(build.id)

      build.enqueue
    end
  end
2814

2815 2816 2817 2818 2819
  describe 'state transition: pending: :running' do
    let(:runner) { create(:ci_runner) }
    let(:job) { create(:ci_build, :pending, runner: runner) }

    before do
2820
      job.project.update_attribute(:build_timeout, 1800)
2821 2822
    end

2823 2824 2825 2826 2827
    def run_job_without_exception
      job.run!
    rescue StateMachines::InvalidTransition
    end

2828
    shared_examples 'saves data on transition' do
T
Tomasz Maczukin 已提交
2829
      it 'saves timeout' do
2830
        expect { job.run! }.to change { job.reload.ensure_metadata.timeout }.from(nil).to(expected_timeout)
T
Tomasz Maczukin 已提交
2831
      end
2832

T
Tomasz Maczukin 已提交
2833
      it 'saves timeout_source' do
2834
        expect { job.run! }.to change { job.reload.ensure_metadata.timeout_source }.from('unknown_timeout_source').to(expected_timeout_source)
2835
      end
2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849

      context 'when Ci::BuildMetadata#update_timeout_state fails update' do
        before do
          allow_any_instance_of(Ci::BuildMetadata).to receive(:update_timeout_state).and_return(false)
        end

        it "doesn't save timeout" do
          expect { run_job_without_exception }.not_to change { job.reload.ensure_metadata.timeout_source }
        end

        it "doesn't save timeout_source" do
          expect { run_job_without_exception }.not_to change { job.reload.ensure_metadata.timeout_source }
        end
      end
2850 2851 2852 2853
    end

    context 'when runner timeout overrides project timeout' do
      let(:expected_timeout) { 900 }
T
Tomasz Maczukin 已提交
2854
      let(:expected_timeout_source) { 'runner_timeout_source' }
2855 2856

      before do
2857
        runner.update_attribute(:maximum_timeout, 900)
2858 2859 2860 2861 2862 2863 2864
      end

      it_behaves_like 'saves data on transition'
    end

    context "when runner timeout doesn't override project timeout" do
      let(:expected_timeout) { 1800 }
T
Tomasz Maczukin 已提交
2865
      let(:expected_timeout_source) { 'project_timeout_source' }
2866 2867

      before do
2868
        runner.update_attribute(:maximum_timeout, 3600)
2869 2870 2871 2872 2873 2874
      end

      it_behaves_like 'saves data on transition'
    end
  end

K
Kamil Trzciński 已提交
2875
  describe '#has_valid_build_dependencies?' do
2876 2877
    shared_examples 'validation is active' do
      context 'when depended job has not been completed yet' do
2878
        let!(:pre_stage_job) { create(:ci_build, :manual, pipeline: pipeline, name: 'test', stage_idx: 0) }
S
Shinya Maeda 已提交
2879

K
Kamil Trzciński 已提交
2880
        it { expect(job).to have_valid_build_dependencies }
2881
      end
2882

2883 2884
      context 'when artifacts of depended job has been expired' do
        let!(:pre_stage_job) { create(:ci_build, :success, :expired, pipeline: pipeline, name: 'test', stage_idx: 0) }
2885

K
Kamil Trzciński 已提交
2886
        it { expect(job).not_to have_valid_build_dependencies }
2887
      end
2888

2889 2890
      context 'when artifacts of depended job has been erased' do
        let!(:pre_stage_job) { create(:ci_build, :success, pipeline: pipeline, name: 'test', stage_idx: 0, erased_at: 1.minute.ago) }
2891

2892 2893 2894 2895
        before do
          pre_stage_job.erase
        end

K
Kamil Trzciński 已提交
2896
        it { expect(job).not_to have_valid_build_dependencies }
2897
      end
2898 2899
    end

2900 2901
    shared_examples 'validation is not active' do
      context 'when depended job has not been completed yet' do
2902
        let!(:pre_stage_job) { create(:ci_build, :manual, pipeline: pipeline, name: 'test', stage_idx: 0) }
2903

K
Kamil Trzciński 已提交
2904
        it { expect(job).to have_valid_build_dependencies }
2905
      end
K
Kamil Trzciński 已提交
2906

2907 2908 2909
      context 'when artifacts of depended job has been expired' do
        let!(:pre_stage_job) { create(:ci_build, :success, :expired, pipeline: pipeline, name: 'test', stage_idx: 0) }

K
Kamil Trzciński 已提交
2910
        it { expect(job).to have_valid_build_dependencies }
2911
      end
2912

2913 2914
      context 'when artifacts of depended job has been erased' do
        let!(:pre_stage_job) { create(:ci_build, :success, pipeline: pipeline, name: 'test', stage_idx: 0, erased_at: 1.minute.ago) }
2915

2916 2917
        before do
          pre_stage_job.erase
2918
        end
2919

K
Kamil Trzciński 已提交
2920
        it { expect(job).to have_valid_build_dependencies }
2921 2922
      end
    end
S
Shinya Maeda 已提交
2923

2924
    let!(:job) { create(:ci_build, :pending, pipeline: pipeline, stage_idx: 1, options: options) }
S
Shinya Maeda 已提交
2925

2926 2927 2928 2929
    context 'when validates for dependencies is enabled' do
      before do
        stub_feature_flags(ci_disable_validates_dependencies: false)
      end
S
Shinya Maeda 已提交
2930

2931
      let!(:pre_stage_job) { create(:ci_build, :success, pipeline: pipeline, name: 'test', stage_idx: 0) }
S
Shinya Maeda 已提交
2932

2933 2934
      context 'when "dependencies" keyword is not defined' do
        let(:options) { {} }
S
Shinya Maeda 已提交
2935

K
Kamil Trzciński 已提交
2936
        it { expect(job).to have_valid_build_dependencies }
2937
      end
S
Shinya Maeda 已提交
2938

2939 2940 2941
      context 'when "dependencies" keyword is empty' do
        let(:options) { { dependencies: [] } }

K
Kamil Trzciński 已提交
2942
        it { expect(job).to have_valid_build_dependencies }
2943 2944 2945 2946 2947 2948
      end

      context 'when "dependencies" keyword is specified' do
        let(:options) { { dependencies: ['test'] } }

        it_behaves_like 'validation is active'
2949 2950
      end
    end
2951 2952 2953 2954 2955 2956 2957 2958 2959 2960

    context 'when validates for dependencies is disabled' do
      let(:options) { { dependencies: ['test'] } }

      before do
        stub_feature_flags(ci_disable_validates_dependencies: true)
      end

      it_behaves_like 'validation is not active'
    end
2961 2962
  end

2963
  describe 'state transition when build fails' do
2964 2965 2966 2967 2968 2969 2970
    let(:service) { MergeRequests::AddTodoWhenBuildFailsService.new(project, user) }

    before do
      allow(MergeRequests::AddTodoWhenBuildFailsService).to receive(:new).and_return(service)
      allow(service).to receive(:close)
    end

2971
    context 'when build is configured to be retried' do
M
Markus Doits 已提交
2972
      subject { create(:ci_build, :running, options: { retry: { max: 3 } }, project: project, user: user) }
2973

2974
      it 'retries build and assigns the same user to it' do
2975
        expect(described_class).to receive(:retry)
2976 2977 2978 2979 2980 2981 2982 2983 2984
          .with(subject, user)

        subject.drop!
      end

      it 'does not try to create a todo' do
        project.add_developer(user)

        expect(service).not_to receive(:commit_status_merge_requests)
2985 2986 2987

        subject.drop!
      end
2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016

      context 'when retry service raises Gitlab::Access::AccessDeniedError exception' do
        let(:retry_service) { Ci::RetryBuildService.new(subject.project, subject.user) }

        before do
          allow_any_instance_of(Ci::RetryBuildService)
            .to receive(:execute)
            .with(subject)
            .and_raise(Gitlab::Access::AccessDeniedError)
          allow(Rails.logger).to receive(:error)
        end

        it 'handles raised exception' do
          expect { subject.drop! }.not_to raise_exception(Gitlab::Access::AccessDeniedError)
        end

        it 'logs the error' do
          subject.drop!

          expect(Rails.logger)
            .to have_received(:error)
            .with(a_string_matching("Unable to auto-retry job #{subject.id}"))
        end

        it 'fails the job' do
          subject.drop!
          expect(subject.failed?).to be_truthy
        end
      end
3017 3018 3019
    end

    context 'when build is not configured to be retried' do
3020
      subject { create(:ci_build, :running, project: project, user: user) }
3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034

      it 'does not retry build' do
        expect(described_class).not_to receive(:retry)

        subject.drop!
      end

      it 'does not count retries when not necessary' do
        expect(described_class).not_to receive(:retry)
        expect_any_instance_of(described_class)
          .not_to receive(:retries_count)

        subject.drop!
      end
3035 3036 3037 3038 3039 3040 3041 3042

      it 'creates a todo' do
        project.add_developer(user)

        expect(service).to receive(:commit_status_merge_requests)

        subject.drop!
      end
3043 3044
    end
  end
3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117

  describe '.matches_tag_ids' do
    set(:build) { create(:ci_build, project: project, user: user) }
    let(:tag_ids) { ::ActsAsTaggableOn::Tag.named_any(tag_list).ids }

    subject { described_class.where(id: build).matches_tag_ids(tag_ids) }

    before do
      build.update(tag_list: build_tag_list)
    end

    context 'when have different tags' do
      let(:build_tag_list) { %w(A B) }
      let(:tag_list) { %w(C D) }

      it "does not match a build" do
        is_expected.not_to contain_exactly(build)
      end
    end

    context 'when have a subset of tags' do
      let(:build_tag_list) { %w(A B) }
      let(:tag_list) { %w(A B C D) }

      it "does match a build" do
        is_expected.to contain_exactly(build)
      end
    end

    context 'when build does not have tags' do
      let(:build_tag_list) { [] }
      let(:tag_list) { %w(C D) }

      it "does match a build" do
        is_expected.to contain_exactly(build)
      end
    end

    context 'when does not have a subset of tags' do
      let(:build_tag_list) { %w(A B C) }
      let(:tag_list) { %w(C D) }

      it "does not match a build" do
        is_expected.not_to contain_exactly(build)
      end
    end
  end

  describe '.matches_tags' do
    set(:build) { create(:ci_build, project: project, user: user) }

    subject { described_class.where(id: build).with_any_tags }

    before do
      build.update(tag_list: tag_list)
    end

    context 'when does have tags' do
      let(:tag_list) { %w(A B) }

      it "does match a build" do
        is_expected.to contain_exactly(build)
      end
    end

    context 'when does not have tags' do
      let(:tag_list) { [] }

      it "does not match a build" do
        is_expected.not_to contain_exactly(build)
      end
    end
  end
3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156

  describe 'pages deployments' do
    set(:build) { create(:ci_build, project: project, user: user) }

    context 'when job is "pages"' do
      before do
        build.name = 'pages'
      end

      context 'when pages are enabled' do
        before do
          allow(Gitlab.config.pages).to receive_messages(enabled: true)
        end

        it 'is marked as pages generator' do
          expect(build).to be_pages_generator
        end

        context 'job succeeds' do
          it "calls pages worker" do
            expect(PagesWorker).to receive(:perform_async).with(:deploy, build.id)

            build.success!
          end
        end

        context 'job fails' do
          it "does not call pages worker" do
            expect(PagesWorker).not_to receive(:perform_async)

            build.drop!
          end
        end
      end

      context 'when pages are disabled' do
        before do
          allow(Gitlab.config.pages).to receive_messages(enabled: false)
        end
3157

3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189
        it 'is not marked as pages generator' do
          expect(build).not_to be_pages_generator
        end

        context 'job succeeds' do
          it "does not call pages worker" do
            expect(PagesWorker).not_to receive(:perform_async)

            build.success!
          end
        end
      end
    end

    context 'when job is not "pages"' do
      before do
        build.name = 'other-job'
      end

      it 'is not marked as pages generator' do
        expect(build).not_to be_pages_generator
      end

      context 'job succeeds' do
        it "does not call pages worker" do
          expect(PagesWorker).not_to receive(:perform_async)

          build.success
        end
      end
    end
  end
F
Francisco Javier López 已提交
3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224

  describe '#has_terminal?' do
    let(:states) { described_class.state_machines[:status].states.keys - [:running] }

    subject { build.has_terminal? }

    it 'returns true if the build is running and it has a runner_session_url' do
      build.build_runner_session(url: 'whatever')
      build.status = :running

      expect(subject).to be_truthy
    end

    context 'returns false' do
      it 'when runner_session_url is empty' do
        build.status = :running

        expect(subject).to be_falsey
      end

      context 'unless the build is running' do
        before do
          build.build_runner_session(url: 'whatever')
        end

        it do
          states.each do |state|
            build.status = state

            is_expected.to be_falsey
          end
        end
      end
    end
  end
3225

S
Shinya Maeda 已提交
3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267
  describe '#collect_test_reports!' do
    subject { build.collect_test_reports!(test_reports) }

    let(:test_reports) { Gitlab::Ci::Reports::TestReports.new }

    it { expect(test_reports.get_suite(build.name).total_count).to eq(0) }

    context 'when build has a test report' do
      context 'when there is a JUnit test report from rspec test suite' do
        before do
          create(:ci_job_artifact, :junit, job: build, project: build.project)
        end

        it 'parses blobs and add the results to the test suite' do
          expect { subject }.not_to raise_error

          expect(test_reports.get_suite(build.name).total_count).to eq(4)
          expect(test_reports.get_suite(build.name).success_count).to be(2)
          expect(test_reports.get_suite(build.name).failed_count).to be(2)
        end
      end

      context 'when there is a JUnit test report from java ant test suite' do
        before do
          create(:ci_job_artifact, :junit_with_ant, job: build, project: build.project)
        end

        it 'parses blobs and add the results to the test suite' do
          expect { subject }.not_to raise_error

          expect(test_reports.get_suite(build.name).total_count).to eq(3)
          expect(test_reports.get_suite(build.name).success_count).to be(3)
          expect(test_reports.get_suite(build.name).failed_count).to be(0)
        end
      end

      context 'when there is a corrupted JUnit test report' do
        before do
          create(:ci_job_artifact, :junit_with_corrupted_data, job: build, project: build.project)
        end

        it 'raises an error' do
3268
          expect { subject }.to raise_error(Gitlab::Ci::Parsers::Test::Junit::JunitParserError)
S
Shinya Maeda 已提交
3269 3270 3271 3272 3273
        end
      end
    end
  end

3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326
  describe '#artifacts_metadata_entry' do
    set(:build) { create(:ci_build, project: project) }
    let(:path) { 'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif' }

    before do
      stub_artifacts_object_storage
    end

    subject { build.artifacts_metadata_entry(path) }

    context 'when using local storage' do
      let!(:metadata) { create(:ci_job_artifact, :metadata, job: build) }

      context 'for existing file' do
        it 'does exist' do
          is_expected.to be_exists
        end
      end

      context 'for non-existing file' do
        let(:path) { 'invalid-file' }

        it 'does not exist' do
          is_expected.not_to be_exists
        end
      end
    end

    context 'when using remote storage' do
      include HttpIOHelpers

      let!(:metadata) { create(:ci_job_artifact, :remote_store, :metadata, job: build) }
      let(:file_path) { expand_fixture_path('ci_build_artifacts_metadata.gz') }

      before do
        stub_remote_url_206(metadata.file.url, file_path)
      end

      context 'for existing file' do
        it 'does exist' do
          is_expected.to be_exists
        end
      end

      context 'for non-existing file' do
        let(:path) { 'invalid-file' }

        it 'does not exist' do
          is_expected.not_to be_exists
        end
      end
    end
  end
3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398

  describe '#publishes_artifacts_reports?' do
    let(:build) { create(:ci_build, options: options) }

    subject { build.publishes_artifacts_reports? }

    context 'when artifacts reports are defined' do
      let(:options) do
        { artifacts: { reports: { junit: "junit.xml" } } }
      end

      it { is_expected.to be_truthy }
    end

    context 'when artifacts reports missing defined' do
      let(:options) do
        { artifacts: { paths: ["file.txt"] } }
      end

      it { is_expected.to be_falsey }
    end

    context 'when options are missing' do
      let(:options) { nil }

      it { is_expected.to be_falsey }
    end
  end

  describe '#runner_required_feature_names' do
    let(:build) { create(:ci_build, options: options) }

    subject { build.runner_required_feature_names }

    context 'when artifacts reports are defined' do
      let(:options) do
        { artifacts: { reports: { junit: "junit.xml" } } }
      end

      it { is_expected.to include(:upload_multiple_artifacts) }
    end
  end

  describe '#supported_runner?' do
    set(:build) { create(:ci_build) }

    subject { build.supported_runner?(runner_features) }

    context 'when feature is required by build' do
      before do
        expect(build).to receive(:runner_required_feature_names) do
          [:upload_multiple_artifacts]
        end
      end

      context 'when runner provides given feature' do
        let(:runner_features) do
          { upload_multiple_artifacts: true }
        end

        it { is_expected.to be_truthy }
      end

      context 'when runner does not provide given feature' do
        let(:runner_features) do
          {}
        end

        it { is_expected.to be_falsey }
      end
    end
  end
3399 3400

  describe '#deployment_status' do
S
Shinya Maeda 已提交
3401 3402 3403 3404
    before do
      allow_any_instance_of(described_class).to receive(:create_deployment)
    end

3405 3406 3407
    context 'when build is a last deployment' do
      let(:build) { create(:ci_build, :success, environment: 'production') }
      let(:environment) { create(:environment, name: 'production', project: build.project) }
S
Shinya Maeda 已提交
3408
      let!(:deployment) { create(:deployment, :success, environment: environment, project: environment.project, deployable: build) }
3409 3410 3411 3412 3413 3414 3415

      it { expect(build.deployment_status).to eq(:last) }
    end

    context 'when there is a newer build with deployment' do
      let(:build) { create(:ci_build, :success, environment: 'production') }
      let(:environment) { create(:environment, name: 'production', project: build.project) }
S
Shinya Maeda 已提交
3416 3417
      let!(:deployment) { create(:deployment, :success, environment: environment, project: environment.project, deployable: build) }
      let!(:last_deployment) { create(:deployment, :success, environment: environment, project: environment.project) }
3418 3419 3420 3421 3422 3423 3424

      it { expect(build.deployment_status).to eq(:out_of_date) }
    end

    context 'when build with deployment has failed' do
      let(:build) { create(:ci_build, :failed, environment: 'production') }
      let(:environment) { create(:environment, name: 'production', project: build.project) }
S
Shinya Maeda 已提交
3425
      let!(:deployment) { create(:deployment, :success, environment: environment, project: environment.project, deployable: build) }
3426 3427 3428 3429 3430 3431 3432

      it { expect(build.deployment_status).to eq(:failed) }
    end

    context 'when build with deployment is running' do
      let(:build) { create(:ci_build, environment: 'production') }
      let(:environment) { create(:environment, name: 'production', project: build.project) }
S
Shinya Maeda 已提交
3433
      let!(:deployment) { create(:deployment, :success, environment: environment, project: environment.project, deployable: build) }
3434 3435 3436 3437

      it { expect(build.deployment_status).to eq(:creating) }
    end
  end
3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487

  describe '#degenerated?' do
    context 'when build is degenerated' do
      subject { create(:ci_build, :degenerated) }

      it { is_expected.to be_degenerated }
    end

    context 'when build is valid' do
      subject { create(:ci_build) }

      it { is_expected.not_to be_degenerated }

      context 'and becomes degenerated' do
        before do
          subject.degenerate!
        end

        it { is_expected.to be_degenerated }
      end
    end
  end

  describe '#archived?' do
    context 'when build is degenerated' do
      subject { create(:ci_build, :degenerated) }

      it { is_expected.to be_archived }
    end

    context 'for old build' do
      subject { create(:ci_build, created_at: 1.day.ago) }

      context 'when archive_builds_in is set' do
        before do
          stub_application_setting(archive_builds_in_seconds: 3600)
        end

        it { is_expected.to be_archived }
      end

      context 'when archive_builds_in is not set' do
        before do
          stub_application_setting(archive_builds_in_seconds: nil)
        end

        it { is_expected.not_to be_archived }
      end
    end
  end
3488
end