blob_controller_spec.rb 6.7 KB
Newer Older
1 2 3
require 'rails_helper'

describe Projects::BlobController do
4
  let(:project) { create(:project, :public, :repository) }
5

S
Sean McGivern 已提交
6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37
  describe "GET show" do
    render_views

    context 'with file path' do
      before do
        get(:show,
            namespace_id: project.namespace,
            project_id: project,
            id: id)
      end

      context "valid branch, valid file" do
        let(:id) { 'master/README.md' }
        it { is_expected.to respond_with(:success) }
      end

      context "valid branch, invalid file" do
        let(:id) { 'master/invalid-path.rb' }
        it { is_expected.to respond_with(:not_found) }
      end

      context "invalid branch, valid file" do
        let(:id) { 'invalid-branch/README.md' }
        it { is_expected.to respond_with(:not_found) }
      end

      context "binary file" do
        let(:id) { 'binary-encoding/encoding/binary-1.bin' }
        it { is_expected.to respond_with(:success) }
      end
    end

38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57
    context 'with file path and JSON format' do
      context "valid branch, valid file" do
        let(:id) { 'master/README.md' }

        before do
          get(:show,
              namespace_id: project.namespace,
              project_id: project,
              id: id,
              format: :json)
        end

        it do
          expect(response).to be_ok
          expect(json_response).to have_key 'html'
          expect(json_response).to have_key 'plain'
        end
      end
    end

S
Sean McGivern 已提交
58 59 60 61 62 63 64 65 66 67 68 69
    context 'with tree path' do
      before do
        get(:show,
            namespace_id: project.namespace,
            project_id: project,
            id: id)
        controller.instance_variable_set(:@blob, nil)
      end

      context 'redirect to tree' do
        let(:id) { 'markdown/doc' }
        it 'redirects' do
70
          expect(subject)
71
            .to redirect_to("/#{project.full_path}/tree/markdown/doc")
S
Sean McGivern 已提交
72 73 74 75 76
        end
      end
    end
  end

77
  describe 'GET diff' do
E
Eric Eastwood 已提交
78 79
    let(:user) { create(:user) }

80 81 82
    render_views

    def do_get(opts = {})
83 84
      params = { namespace_id: project.namespace,
                 project_id: project,
85 86 87 88
                 id: 'master/CHANGELOG' }
      get :diff, params.merge(opts)
    end

E
Eric Eastwood 已提交
89 90 91 92 93 94
    before do
      project.team << [user, :master]

      sign_in(user)
    end

95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110
    context 'when essential params are missing' do
      it 'renders nothing' do
        do_get

        expect(response.body).to be_blank
      end
    end

    context 'when essential params are present' do
      it 'renders the diff content' do
        do_get(since: 1, to: 5, offset: 10)

        expect(response.body).to be_present
      end
    end
  end
111

E
Eric Eastwood 已提交
112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139
  describe 'GET edit' do
    let(:default_params) do
      {
        namespace_id: project.namespace,
        project_id: project,
        id: 'master/CHANGELOG'
      }
    end

    context 'anonymous' do
      before do
        get :edit, default_params
      end

      it 'redirects to sign in and returns' do
        expect(response).to redirect_to(new_user_session_path)
      end
    end

    context 'as guest' do
      let(:guest) { create(:user) }

      before do
        sign_in(guest)
        get :edit, default_params
      end

      it 'redirects to blob show' do
140
        expect(response).to redirect_to(project_blob_path(project, 'master/CHANGELOG'))
E
Eric Eastwood 已提交
141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172
      end
    end

    context 'as developer' do
      let(:developer) { create(:user) }

      before do
        project.team << [developer, :developer]
        sign_in(developer)
        get :edit, default_params
      end

      it 'redirects to blob show' do
        expect(response).to have_http_status(200)
      end
    end

    context 'as master' do
      let(:master) { create(:user) }

      before do
        project.team << [master, :master]
        sign_in(master)
        get :edit, default_params
      end

      it 'redirects to blob show' do
        expect(response).to have_http_status(200)
      end
    end
  end

173
  describe 'PUT update' do
E
Eric Eastwood 已提交
174
    let(:user) { create(:user) }
175 176
    let(:default_params) do
      {
177 178
        namespace_id: project.namespace,
        project_id: project,
179
        id: 'master/CHANGELOG',
D
Douwe Maan 已提交
180
        branch_name: 'master',
181 182 183 184 185 186
        content: 'Added changes',
        commit_message: 'Update CHANGELOG'
      }
    end

    def blob_after_edit_path
187
      project_blob_path(project, 'master/CHANGELOG')
188 189
    end

E
Eric Eastwood 已提交
190 191 192 193 194 195
    before do
      project.team << [user, :master]

      sign_in(user)
    end

196 197 198 199 200 201 202 203 204 205 206 207 208
    it 'redirects to blob' do
      put :update, default_params

      expect(response).to redirect_to(blob_after_edit_path)
    end

    context '?from_merge_request_iid' do
      let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
      let(:mr_params) { default_params.merge(from_merge_request_iid: merge_request.iid) }

      it 'redirects to MR diff' do
        put :update, mr_params

209
        after_edit_path = diffs_project_merge_request_path(project, merge_request)
210
        file_anchor = "##{Digest::SHA1.hexdigest('CHANGELOG')}"
211 212 213 214 215
        expect(response).to redirect_to(after_edit_path + file_anchor)
      end

      context "when user doesn't have access" do
        before do
216
          other_project = create(:project, :repository)
217 218 219 220 221 222 223 224 225 226
          merge_request.update!(source_project: other_project, target_project: other_project)
        end

        it "it redirect to blob" do
          put :update, mr_params

          expect(response).to redirect_to(blob_after_edit_path)
        end
      end
    end
227 228

    context 'when user has forked project' do
229 230 231
      let(:forked_project_link) { create(:forked_project_link, forked_from_project: project) }
      let!(:forked_project) { forked_project_link.forked_to_project }
      let(:guest) { forked_project.owner }
232

233 234 235
      before do
        sign_in(guest)
      end
236

237 238
      context 'when editing on the fork' do
        before do
239 240
          default_params[:namespace_id] = forked_project.namespace
          default_params[:project_id] = forked_project
241 242 243 244 245
        end

        it 'redirects to blob' do
          put :update, default_params

246
          expect(response).to redirect_to(project_blob_path(forked_project, 'master/CHANGELOG'))
247 248 249 250 251
        end
      end

      context 'when editing on the original repository' do
        it "redirects to forked project new merge request" do
D
Douwe Maan 已提交
252
          default_params[:branch_name] = "fork-test-1"
253 254 255 256 257
          default_params[:create_merge_request] = 1

          put :update, default_params

          expect(response).to redirect_to(
258
            project_new_merge_request_path(
259 260 261 262 263 264 265 266
              forked_project,
              merge_request: {
                source_project_id: forked_project.id,
                target_project_id: project.id,
                source_branch: "fork-test-1",
                target_branch: "master"
              }
            )
267
          )
268
        end
269 270
      end
    end
271
  end
272
end