project_spec.rb 15.2 KB
Newer Older
1 2 3 4
# == Schema Information
#
# Table name: projects
#
D
Dmitriy Zaporozhets 已提交
5
#  id                     :integer          not null, primary key
6 7 8
#  name                   :string(255)
#  path                   :string(255)
#  description            :text
D
Dmitriy Zaporozhets 已提交
9 10
#  created_at             :datetime
#  updated_at             :datetime
D
Dmitriy Zaporozhets 已提交
11
#  creator_id             :integer
D
Dmitriy Zaporozhets 已提交
12 13 14 15
#  issues_enabled         :boolean          default(TRUE), not null
#  wall_enabled           :boolean          default(TRUE), not null
#  merge_requests_enabled :boolean          default(TRUE), not null
#  wiki_enabled           :boolean          default(TRUE), not null
D
Dmitriy Zaporozhets 已提交
16
#  namespace_id           :integer
D
Dmitriy Zaporozhets 已提交
17
#  issues_tracker         :string(255)      default("gitlab"), not null
D
Dmitriy Zaporozhets 已提交
18
#  issues_tracker_id      :string(255)
D
Dmitriy Zaporozhets 已提交
19
#  snippets_enabled       :boolean          default(TRUE), not null
20
#  last_activity_at       :datetime
D
Dmitriy Zaporozhets 已提交
21
#  import_url             :string(255)
22
#  visibility_level       :integer          default(0), not null
23
#  archived               :boolean          default(FALSE), not null
A
Atsushi Ishida 已提交
24
#  avatar                 :string(255)
D
Dmitriy Zaporozhets 已提交
25
#  import_status          :string(255)
D
Dmitriy Zaporozhets 已提交
26 27
#  repository_size        :float            default(0.0)
#  star_count             :integer          default(0), not null
D
Dmitriy Zaporozhets 已提交
28 29
#  import_type            :string(255)
#  import_source          :string(255)
A
Atsushi Ishida 已提交
30
#  commit_count           :integer          default(0)
31 32
#

G
gitlabhq 已提交
33 34 35
require 'spec_helper'

describe Project do
36
  describe 'associations' do
37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
G
gitlabhq 已提交
56 57
  end

58 59 60 61 62 63 64 65
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
66 67
  end

68
  describe 'validation' do
69 70
    let!(:project) { create(:project) }

71 72
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
73
    it { is_expected.to validate_length_of(:name).is_within(0..255) }
74

75 76
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
77 78
    it { is_expected.to validate_length_of(:path).is_within(0..255) }
    it { is_expected.to validate_length_of(:description).is_within(0..2000) }
79
    it { is_expected.to validate_presence_of(:creator) }
80
    it { is_expected.to validate_length_of(:issues_tracker_id).is_within(0..255) }
81
    it { is_expected.to validate_presence_of(:namespace) }
82

83
    it 'should not allow new projects beyond user limits' do
84
      project2 = build(:project)
85 86 87
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
      expect(project2.errors[:limit_reached].first).to match(/Your project limit is 0/)
88
    end
G
gitlabhq 已提交
89 90
  end

91
  describe 'Respond to' do
92 93 94 95 96 97 98
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:update_merge_requests) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:name_with_namespace) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
G
gitlabhq 已提交
99 100
  end

101 102 103 104 105 106 107 108
  describe '#to_reference' do
    let(:project) { create(:empty_project) }

    it 'returns a String reference to the object' do
      expect(project.to_reference).to eq project.path_with_namespace
    end
  end

109 110
  it 'should return valid url to repo' do
    project = Project.new(path: 'somewhere')
111
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
112 113
  end

D
Douwe Maan 已提交
114 115 116 117 118 119
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.path}/somewhere")
    end
A
Ariejan de Vroom 已提交
120 121
  end

D
Douwe Maan 已提交
122 123 124 125 126 127
  describe "#web_url_without_protocol" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the web URL without the protocol for this repo' do
      expect(project.web_url_without_protocol).to eq("#{Gitlab.config.gitlab.url.split('://')[1]}/#{project.namespace.path}/somewhere")
    end
128 129
  end

130
  describe 'last_activity methods' do
I
Izaak Alpert 已提交
131
    let(:project) { create(:project) }
132
    let(:last_event) { double(created_at: Time.now) }
G
gitlabhq 已提交
133

134 135
    describe 'last_activity' do
      it 'should alias last_activity to last_event' do
136
        allow(project).to receive(:last_event).and_return(last_event)
137
        expect(project.last_activity).to eq(last_event)
138
      end
G
gitlabhq 已提交
139 140
    end

141 142
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
143
        create(:event, project: project)
144
        expect(project.last_activity_at.to_i).to eq(last_event.created_at.to_i)
145
      end
146

147
      it 'returns the project\'s last update date if it has no events' do
148
        expect(project.last_activity_date).to eq(project.updated_at)
149
      end
150 151
    end
  end
152

153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
    let(:issue)   { create(:issue, project: project) }

    context 'with default issues tracker' do
      it 'returns an issue' do
        expect(project.get_issue(issue.iid)).to eq issue
      end

      it 'returns nil when no issue found' do
        expect(project.get_issue(999)).to be_nil
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
        issue = project.get_issue('FOO-1234')
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

195
  describe :update_merge_requests do
D
Dmitriy Zaporozhets 已提交
196
    let(:project) { create(:project) }
197 198 199 200
    let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
    let(:key) { create(:key, user_id: project.owner.id) }
    let(:prev_commit_id) { merge_request.commits.last.id }
    let(:commit_id) { merge_request.commits.first.id }
201

202
    it 'should close merge request if last commit from source branch was pushed to target branch' do
203 204
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.target_branch}", key.user)
      merge_request.reload
205
      expect(merge_request.merged?).to be_truthy
206 207
    end

208
    it 'should update merge request commits with new one if pushed to source branch' do
209 210
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.source_branch}", key.user)
      merge_request.reload
211
      expect(merge_request.last_commit.id).to eq(commit_id)
212 213
    end
  end
214 215 216 217 218

  describe :find_with_namespace do
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
219
        @project = create(:project, name: 'gitlabhq', namespace: @group)
220 221
      end

222
      it { expect(Project.find_with_namespace('gitlab/gitlabhq')).to eq(@project) }
223
      it { expect(Project.find_with_namespace('GitLab/GitlabHQ')).to eq(@project) }
224
      it { expect(Project.find_with_namespace('gitlab-ci')).to be_nil }
225 226 227 228 229 230 231
    end
  end

  describe :to_param do
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
232
        @project = create(:project, name: 'gitlabhq', namespace: @group)
233 234
      end

V
Vinnie Okada 已提交
235
      it { expect(@project.to_param).to eq('gitlabhq') }
236 237
    end
  end
D
Dmitriy Zaporozhets 已提交
238

239
  describe :repository do
D
Dmitriy Zaporozhets 已提交
240 241
    let(:project) { create(:project) }

242
    it 'should return valid repo' do
243
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
244 245
    end
  end
246

247
  describe :default_issues_tracker? do
248 249 250 251
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

    it "should be true if used internal tracker" do
252
      expect(project.default_issues_tracker?).to be_truthy
253 254 255
    end

    it "should be false if used other tracker" do
256
      expect(ext_project.default_issues_tracker?).to be_falsey
257 258 259
    end
  end

A
Andrew8xx8 已提交
260 261 262 263
  describe :can_have_issues_tracker_id? do
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

264
    it 'should be true for projects with external issues tracker if issues enabled' do
265
      expect(ext_project.can_have_issues_tracker_id?).to be_truthy
266
    end
A
Andrew8xx8 已提交
267

268
    it 'should be false for projects with internal issue tracker if issues enabled' do
269
      expect(project.can_have_issues_tracker_id?).to be_falsey
A
Andrew8xx8 已提交
270 271
    end

272
    it 'should be always false if issues disabled' do
A
Andrew8xx8 已提交
273 274 275
      project.issues_enabled = false
      ext_project.issues_enabled = false

276 277
      expect(project.can_have_issues_tracker_id?).to be_falsey
      expect(ext_project.can_have_issues_tracker_id?).to be_falsey
A
Andrew8xx8 已提交
278 279
    end
  end
280 281

  describe :open_branches do
D
Dmitriy Zaporozhets 已提交
282
    let(:project) { create(:project) }
283 284 285 286 287

    before do
      project.protected_branches.create(name: 'master')
    end

288 289
    it { expect(project.open_branches.map(&:name)).to include('feature') }
    it { expect(project.open_branches.map(&:name)).not_to include('master') }
290
  end
C
Ciro Santilli 已提交
291

292 293
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
294 295 296 297 298
      user1 = create :user
      user2 = create :user
      project = create :project, :public

      expect(project.star_count).to eq(0)
299

C
Ciro Santilli 已提交
300
      user1.toggle_star(project)
301 302
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
303
      user2.toggle_star(project)
304 305 306
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
307
      user1.toggle_star(project)
308 309 310
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
311
      user2.toggle_star(project)
312 313 314 315
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

316
    it 'counts stars on the right project' do
317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
347
    end
348 349 350 351 352 353 354 355 356 357 358

    it 'is decremented when an upvoter account is deleted' do
      user = create :user
      project = create :project, :public
      user.toggle_star(project)
      project.reload
      expect(project.star_count).to eq(1)
      user.destroy
      project.reload
      expect(project.star_count).to eq(0)
    end
C
Ciro Santilli 已提交
359
  end
360 361 362 363 364 365

  describe :avatar_type do
    let(:project) { create(:project) }

    it 'should be true if avatar is image' do
      project.update_attribute(:avatar, 'uploads/avatar.png')
366
      expect(project.avatar_type).to be_truthy
367 368 369 370
    end

    it 'should be false if avatar is html page' do
      project.update_attribute(:avatar, 'uploads/avatar.html')
371
      expect(project.avatar_type).to eq(['only images allowed'])
372 373
    end
  end
S
sue445 已提交
374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404

  describe :avatar_url do
    subject { project.avatar_url }

    let(:project) { create(:project) }

    context 'When avatar file is uploaded' do
      before do
        project.update_columns(avatar: 'uploads/avatar.png')
        allow(project.avatar).to receive(:present?) { true }
      end

      let(:avatar_path) do
        "/uploads/project/avatar/#{project.id}/uploads/avatar.png"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

      let(:avatar_path) do
        "/#{project.namespace.name}/#{project.path}/avatar"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end
  end
405 406 407

  describe :ci_commit do
    let(:project) { create :project }
K
Kamil Trzcinski 已提交
408
    let(:commit) { create :ci_commit, gl_project: project }
409

K
Kamil Trzcinski 已提交
410
    before do
411
      project.ensure_gitlab_ci_project
K
Kamil Trzcinski 已提交
412 413
      project.create_gitlab_ci_service(active: true)
    end
414 415 416

    it { expect(project.ci_commit(commit.sha)).to eq(commit) }
  end
417

418
  describe :builds_enabled do
419 420
    let(:project) { create :project }

421
    before { project.builds_enabled = true }
422

423 424 425 426
    subject { project.builds_enabled }

    it { is_expected.to eq(project.gitlab_ci_service.active) }
    it { expect(project.builds_enabled?).to be_truthy }
427 428
    it { expect(project.gitlab_ci_project).to be_a(Ci::Project) }
  end
Y
Yorick Peterse 已提交
429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466

  describe '.trending' do
    let(:group)    { create(:group) }
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)
    end

    describe 'without an explicit start date' do
      subject { described_class.trending.to_a }

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project1, project2])
      end
    end

    describe 'with an explicit start date' do
      let(:date) { 2.months.ago }

      subject { described_class.trending(date).to_a }

      before do
        2.times do
          create(:note_on_commit, project: project2, created_at: date)
        end
      end

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project2, project1])
      end
    end
  end
G
gitlabhq 已提交
467
end