user_uses_quick_actions_spec.rb 7.1 KB
Newer Older
1 2
require 'rails_helper'

3
describe 'Merge request > User uses quick actions', :js do
4
  include Spec::Support::Helpers::Features::NotesHelpers
5

6 7 8 9 10 11
  let(:project) { create(:project, :public, :repository) }
  let(:user) { project.creator }
  let(:guest) { create(:user) }
  let(:merge_request) { create(:merge_request, source_project: project) }
  let!(:milestone) { create(:milestone, project: project, title: 'ASAP') }

12
  it_behaves_like 'issuable record that supports quick actions in its description and notes', :merge_request do
13
    let(:issuable) { create(:merge_request, source_project: project) }
14
    let(:new_url_opts) { { merge_request: { source_branch: 'feature', target_branch: 'master' } } }
15 16
  end

T
Thomas Balthazar 已提交
17
  describe 'merge-request-only commands' do
18 19 20 21 22
    let(:user) { create(:user) }
    let(:project) { create(:project, :public, :repository) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let!(:milestone) { create(:milestone, project: project, title: 'ASAP') }

23
    before do
24
      project.add_maintainer(user)
25
    end
26

27
    describe 'time tracking' do
F
Felipe Artur 已提交
28 29 30 31 32
      before do
        sign_in(user)
        visit project_merge_request_path(project, merge_request)
      end

33 34 35
      it_behaves_like 'issuable time tracker'
    end

T
Thomas Balthazar 已提交
36 37
    describe 'toggling the WIP prefix in the title from note' do
      context 'when the current user can toggle the WIP prefix' do
F
Felipe Artur 已提交
38 39 40 41 42
        before do
          sign_in(user)
          visit project_merge_request_path(project, merge_request)
        end

T
Thomas Balthazar 已提交
43
        it 'adds the WIP: prefix to the title' do
44
          add_note("/wip")
T
Thomas Balthazar 已提交
45 46

          expect(page).not_to have_content '/wip'
47
          expect(page).to have_content 'Commands applied'
T
Thomas Balthazar 已提交
48 49

          expect(merge_request.reload.work_in_progress?).to eq true
50
        end
T
Thomas Balthazar 已提交
51 52 53 54

        it 'removes the WIP: prefix from the title' do
          merge_request.title = merge_request.wip_title
          merge_request.save
55
          add_note("/wip")
T
Thomas Balthazar 已提交
56 57

          expect(page).not_to have_content '/wip'
58
          expect(page).to have_content 'Commands applied'
T
Thomas Balthazar 已提交
59 60

          expect(merge_request.reload.work_in_progress?).to eq false
61
        end
T
Thomas Balthazar 已提交
62 63 64 65
      end

      context 'when the current user cannot toggle the WIP prefix' do
        before do
66
          project.add_guest(guest)
67
          sign_in(guest)
68
          visit project_merge_request_path(project, merge_request)
T
Thomas Balthazar 已提交
69 70 71
        end

        it 'does not change the WIP prefix' do
72
          add_note("/wip")
T
Thomas Balthazar 已提交
73 74

          expect(page).not_to have_content '/wip'
75
          expect(page).not_to have_content 'Commands applied'
T
Thomas Balthazar 已提交
76 77 78 79 80 81

          expect(merge_request.reload.work_in_progress?).to eq false
        end
      end
    end

82 83
    describe 'merging the MR from the note' do
      context 'when the current user can merge the MR' do
F
Felipe Artur 已提交
84 85 86 87 88
        before do
          sign_in(user)
          visit project_merge_request_path(project, merge_request)
        end

89
        it 'merges the MR' do
90
          add_note("/merge")
91

J
Jarka Kadlecova 已提交
92
          expect(page).to have_content 'Commands applied'
93 94 95 96 97 98 99

          expect(merge_request.reload).to be_merged
        end
      end

      context 'when the head diff changes in the meanwhile' do
        before do
J
Jarka Kadlecova 已提交
100 101
          merge_request.source_branch = 'another_branch'
          merge_request.save
F
Felipe Artur 已提交
102 103
          sign_in(user)
          visit project_merge_request_path(project, merge_request)
104 105 106
        end

        it 'does not merge the MR' do
107
          add_note("/merge")
108 109 110 111 112 113 114 115 116

          expect(page).not_to have_content 'Your commands have been executed!'

          expect(merge_request.reload).not_to be_merged
        end
      end

      context 'when the current user cannot merge the MR' do
        before do
117
          project.add_guest(guest)
118
          sign_in(guest)
119
          visit project_merge_request_path(project, merge_request)
120 121 122
        end

        it 'does not merge the MR' do
123
          add_note("/merge")
124 125 126 127 128 129 130 131

          expect(page).not_to have_content 'Your commands have been executed!'

          expect(merge_request.reload).not_to be_merged
        end
      end
    end

T
Thomas Balthazar 已提交
132
    describe 'adding a due date from note' do
F
Felipe Artur 已提交
133 134 135 136 137
      before do
        sign_in(user)
        visit project_merge_request_path(project, merge_request)
      end

T
Thomas Balthazar 已提交
138
      it 'does not recognize the command nor create a note' do
139
        add_note('/due 2016-08-28')
140

T
Thomas Balthazar 已提交
141 142
        expect(page).not_to have_content '/due 2016-08-28'
      end
143
    end
144 145

    describe '/target_branch command in merge request' do
146
      let(:another_project) { create(:project, :public, :repository) }
B
blackst0ne 已提交
147
      let(:new_url_opts) { { merge_request_source_branch: 'feature' } }
148 149

      before do
150
        another_project.add_maintainer(user)
151
        sign_in(user)
152 153 154
      end

      it 'changes target_branch in new merge_request' do
155
        visit project_new_merge_request_path(another_project, new_url_opts)
C
Clement Ho 已提交
156

157 158 159 160 161 162 163 164 165 166 167 168
        fill_in "merge_request_title", with: 'My brand new feature'
        fill_in "merge_request_description", with: "le feature \n/target_branch fix\nFeature description:"
        click_button "Submit merge request"

        merge_request = another_project.merge_requests.first
        expect(merge_request.description).to eq "le feature \nFeature description:"
        expect(merge_request.target_branch).to eq 'fix'
      end

      it 'does not change target branch when merge request is edited' do
        new_merge_request = create(:merge_request, source_project: another_project)

169
        visit edit_project_merge_request_path(another_project, new_merge_request)
170 171 172 173 174 175 176 177 178 179 180
        fill_in "merge_request_description", with: "Want to update target branch\n/target_branch fix\n"
        click_button "Save changes"

        new_merge_request = another_project.merge_requests.first
        expect(new_merge_request.description).to include('/target_branch')
        expect(new_merge_request.target_branch).not_to eq('fix')
      end
    end

    describe '/target_branch command from note' do
      context 'when the current user can change target branch' do
F
Felipe Artur 已提交
181 182 183 184 185
        before do
          sign_in(user)
          visit project_merge_request_path(project, merge_request)
        end

186
        it 'changes target branch from a note' do
187
          add_note("message start \n/target_branch merge-test\n message end.")
188

189
          wait_for_requests
190 191 192 193 194 195 196 197
          expect(page).not_to have_content('/target_branch')
          expect(page).to have_content('message start')
          expect(page).to have_content('message end.')

          expect(merge_request.reload.target_branch).to eq 'merge-test'
        end

        it 'does not fail when target branch does not exists' do
198
          add_note('/target_branch totally_not_existing_branch')
199 200 201 202 203 204 205 206 207

          expect(page).not_to have_content('/target_branch')

          expect(merge_request.target_branch).to eq 'feature'
        end
      end

      context 'when current user can not change target branch' do
        before do
208
          project.add_guest(guest)
209
          sign_in(guest)
210
          visit project_merge_request_path(project, merge_request)
211 212 213
        end

        it 'does not change target branch' do
214
          add_note('/target_branch merge-test')
215 216 217 218 219 220 221

          expect(page).not_to have_content '/target_branch merge-test'

          expect(merge_request.target_branch).to eq 'feature'
        end
      end
    end
222 223
  end
end