user_spec.rb 16.1 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2 3 4
# == Schema Information
#
# Table name: users
#
D
Dmitriy Zaporozhets 已提交
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46
#  id                       :integer          not null, primary key
#  email                    :string(255)      default(""), not null
#  encrypted_password       :string(255)      default(""), not null
#  reset_password_token     :string(255)
#  reset_password_sent_at   :datetime
#  remember_created_at      :datetime
#  sign_in_count            :integer          default(0)
#  current_sign_in_at       :datetime
#  last_sign_in_at          :datetime
#  current_sign_in_ip       :string(255)
#  last_sign_in_ip          :string(255)
#  created_at               :datetime
#  updated_at               :datetime
#  name                     :string(255)
#  admin                    :boolean          default(FALSE), not null
#  projects_limit           :integer          default(10)
#  skype                    :string(255)      default(""), not null
#  linkedin                 :string(255)      default(""), not null
#  twitter                  :string(255)      default(""), not null
#  authentication_token     :string(255)
#  theme_id                 :integer          default(1), not null
#  bio                      :string(255)
#  failed_attempts          :integer          default(0)
#  locked_at                :datetime
#  extern_uid               :string(255)
#  provider                 :string(255)
#  username                 :string(255)
#  can_create_group         :boolean          default(TRUE), not null
#  can_create_team          :boolean          default(TRUE), not null
#  state                    :string(255)
#  color_scheme_id          :integer          default(1), not null
#  notification_level       :integer          default(1), not null
#  password_expires_at      :datetime
#  created_by_id            :integer
#  last_credential_check_at :datetime
#  avatar                   :string(255)
#  confirmation_token       :string(255)
#  confirmed_at             :datetime
#  confirmation_sent_at     :datetime
#  unconfirmed_email        :string(255)
#  hide_no_ssh_key          :boolean          default(FALSE)
#  website_url              :string(255)      default(""), not null
D
Dmitriy Zaporozhets 已提交
47 48
#

G
gitlabhq 已提交
49 50 51 52
require 'spec_helper'

describe User do
  describe "Associations" do
53
    it { should have_one(:namespace) }
54
    it { should have_many(:snippets).class_name('Snippet').dependent(:destroy) }
55
    it { should have_many(:project_members).dependent(:destroy) }
56
    it { should have_many(:groups) }
57 58 59
    it { should have_many(:keys).dependent(:destroy) }
    it { should have_many(:events).class_name('Event').dependent(:destroy) }
    it { should have_many(:recent_events).class_name('Event') }
60
    it { should have_many(:issues).dependent(:destroy) }
61
    it { should have_many(:notes).dependent(:destroy) }
62 63 64
    it { should have_many(:assigned_issues).dependent(:destroy) }
    it { should have_many(:merge_requests).dependent(:destroy) }
    it { should have_many(:assigned_merge_requests).dependent(:destroy) }
65
    it { should have_many(:identities).dependent(:destroy) }
66 67
  end

68 69 70
  describe "Mass assignment" do
  end

71
  describe 'validations' do
72
    it { should validate_presence_of(:username) }
73 74 75 76 77 78
    it { should validate_presence_of(:projects_limit) }
    it { should validate_numericality_of(:projects_limit) }
    it { should allow_value(0).for(:projects_limit) }
    it { should_not allow_value(-1).for(:projects_limit) }

    it { should ensure_length_of(:bio).is_within(0..255) }
79 80 81 82 83 84

    describe 'email' do
      it 'accepts info@example.com' do
        user = build(:user, email: 'info@example.com')
        expect(user).to be_valid
      end
85

86 87 88 89 90
      it 'accepts info+test@example.com' do
        user = build(:user, email: 'info+test@example.com')
        expect(user).to be_valid
      end

91 92 93 94 95
      it "accepts o'reilly@example.com" do
        user = build(:user, email: "o'reilly@example.com")
        expect(user).to be_valid
      end

96 97 98 99 100 101 102 103 104
      it 'rejects test@test@example.com' do
        user = build(:user, email: 'test@test@example.com')
        expect(user).to be_invalid
      end

      it 'rejects mailto:test@example.com' do
        user = build(:user, email: 'mailto:test@example.com')
        expect(user).to be_invalid
      end
105 106 107 108 109

      it "rejects lol!'+=?><#$%^&*()@gmail.com" do
        user = build(:user, email: "lol!'+=?><#$%^&*()@gmail.com")
        expect(user).to be_invalid
      end
110
    end
G
gitlabhq 已提交
111 112 113 114 115
  end

  describe "Respond to" do
    it { should respond_to(:is_admin?) }
    it { should respond_to(:name) }
N
Nihad Abbasov 已提交
116
    it { should respond_to(:private_token) }
G
gitlabhq 已提交
117 118
  end

119 120 121 122 123 124 125 126
  describe '#generate_password' do
    it "should execute callback when force_random_password specified" do
      user = build(:user, force_random_password: true)
      user.should_receive(:generate_password)
      user.save
    end

    it "should not generate password by default" do
127 128
      user = create(:user, password: 'abcdefghe')
      user.password.should == 'abcdefghe'
129
    end
130

131 132 133 134 135
    it "should generate password when forcing random password" do
      Devise.stub(:friendly_token).and_return('123456789')
      user = create(:user, password: 'abcdefg', force_random_password: true)
      user.password.should == '12345678'
    end
136 137
  end

138 139
  describe 'authentication token' do
    it "should have authentication token" do
140
      user = create(:user)
141 142
      user.authentication_token.should_not be_blank
    end
N
Nihad Abbasov 已提交
143
  end
144 145 146 147 148

  describe 'projects' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
D
Dmitriy Zaporozhets 已提交
149 150
      @project_2 = create :project, group: create(:group) # Grant MASTER access to the user
      @project_3 = create :project, group: create(:group) # Grant DEVELOPER access to the user
151

152 153
      @project_2.team << [@user, :master]
      @project_3.team << [@user, :developer]
154 155 156
    end

    it { @user.authorized_projects.should include(@project) }
157 158
    it { @user.authorized_projects.should include(@project_2) }
    it { @user.authorized_projects.should include(@project_3) }
159
    it { @user.owned_projects.should include(@project) }
160 161
    it { @user.owned_projects.should_not include(@project_2) }
    it { @user.owned_projects.should_not include(@project_3) }
162
    it { @user.personal_projects.should include(@project) }
163 164
    it { @user.personal_projects.should_not include(@project_2) }
    it { @user.personal_projects.should_not include(@project_3) }
165 166 167 168 169
  end

  describe 'groups' do
    before do
      @user = create :user
170 171
      @group = create :group
      @group.add_owner(@user)
172 173 174 175 176 177 178
    end

    it { @user.several_namespaces?.should be_true }
    it { @user.authorized_groups.should == [@group] }
    it { @user.owned_groups.should == [@group] }
  end

179 180 181 182
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
183 184
      @group = create :group
      @group.add_owner(@user)
185

186
      @group.add_user(@user2, GroupMember::OWNER)
187 188 189 190 191
    end

    it { @user2.several_namespaces?.should be_true }
  end

192 193 194 195 196 197 198 199 200 201 202 203 204 205
  describe 'namespaced' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
    end

    it { @user.several_namespaces?.should be_false }
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

    it "should block user" do
      user.block
206
      user.blocked?.should be_true
207 208 209 210 211
    end
  end

  describe 'filter' do
    before do
212
      User.delete_all
213 214
      @user = create :user
      @admin = create :user, admin: true
215
      @blocked = create :user, state: :blocked
216 217 218 219
    end

    it { User.filter("admins").should == [@admin] }
    it { User.filter("blocked").should == [@blocked] }
220 221
    it { User.filter("wop").should include(@user, @admin, @blocked) }
    it { User.filter(nil).should include(@user, @admin) }
222 223 224 225
  end

  describe :not_in_project do
    before do
226
      User.delete_all
227 228 229 230
      @user = create :user
      @project = create :project
    end

231
    it { User.not_in_project(@project).should include(@user, @project.owner) }
232
  end
D
Dmitriy Zaporozhets 已提交
233

234 235 236
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
237

238 239 240 241 242 243
      it { user.is_admin?.should be_false }
      it { user.require_ssh_key?.should be_true }
      it { user.can_create_group?.should be_true }
      it { user.can_create_project?.should be_true }
      it { user.first_name.should == 'John' }
    end
244

D
Dmitriy Zaporozhets 已提交
245
    describe 'with defaults' do
246
      let(:user) { User.new }
D
Dmitriy Zaporozhets 已提交
247

D
Dmitriy Zaporozhets 已提交
248 249 250 251
      it "should apply defaults to user" do
        user.projects_limit.should == Gitlab.config.gitlab.default_projects_limit
        user.can_create_group.should == Gitlab.config.gitlab.default_can_create_group
        user.theme_id.should == Gitlab.config.gitlab.default_theme
252 253 254
      end
    end

D
Dmitriy Zaporozhets 已提交
255 256
    describe 'with default overrides' do
      let(:user) { User.new(projects_limit: 123, can_create_group: false, can_create_team: true, theme_id: Gitlab::Theme::BASIC) }
D
Dmitriy Zaporozhets 已提交
257

D
Dmitriy Zaporozhets 已提交
258 259 260 261
      it "should apply defaults to user" do
        user.projects_limit.should == 123
        user.can_create_group.should be_false
        user.theme_id.should == Gitlab::Theme::BASIC
262
      end
263 264
    end
  end
265

M
Marin Jankovski 已提交
266 267 268 269 270 271 272 273 274
  describe 'search' do
    let(:user1) { create(:user, username: 'James', email: 'james@testing.com') }
    let(:user2) { create(:user, username: 'jameson', email: 'jameson@example.com') }

    it "should be case insensitive" do
      User.search(user1.username.upcase).to_a.should == [user1]
      User.search(user1.username.downcase).to_a.should == [user1]
      User.search(user2.username.upcase).to_a.should == [user2]
      User.search(user2.username.downcase).to_a.should == [user2]
M
Marin Jankovski 已提交
275 276
      User.search(user1.username.downcase).to_a.count.should == 2
      User.search(user2.username.downcase).to_a.count.should == 1
M
Marin Jankovski 已提交
277 278 279
    end
  end

280
  describe 'by_username_or_id' do
D
Dmitriy Zaporozhets 已提交
281 282
    let(:user1) { create(:user, username: 'foo') }

283 284 285 286 287 288 289
    it "should get the correct user" do
      User.by_username_or_id(user1.id).should == user1
      User.by_username_or_id('foo').should == user1
      User.by_username_or_id(-1).should be_nil
      User.by_username_or_id('bar').should be_nil
    end
  end
G
GitLab 已提交
290

291 292 293 294 295 296 297 298 299 300 301 302 303 304
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

    it 'should get the correct user' do
      expect(User.by_login(user.email.upcase)).to eq user
      expect(User.by_login(user.email)).to eq user
      expect(User.by_login(username.downcase)).to eq user
      expect(User.by_login(username)).to eq user
      expect(User.by_login(nil)).to be_nil
      expect(User.by_login('')).to be_nil
    end
  end

G
GitLab 已提交
305 306 307 308 309 310 311 312 313
  describe 'all_ssh_keys' do
    it { should have_many(:keys).dependent(:destroy) }

    it "should have all ssh keys" do
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

      user.all_ssh_keys.should include(key.key)
    end
G
GitLab 已提交
314
  end
315

D
Dmitriy Zaporozhets 已提交
316 317 318 319 320 321 322 323 324 325 326 327 328
  describe :avatar_type do
    let(:user) { create(:user) }

    it "should be true if avatar is image" do
      user.update_attribute(:avatar, 'uploads/avatar.png')
      user.avatar_type.should be_true
    end

    it "should be false if avatar is html page" do
      user.update_attribute(:avatar, 'uploads/avatar.html')
      user.avatar_type.should == ["only images allowed"]
    end
  end
J
Jerome Dalbert 已提交
329

330 331 332
  describe :requires_ldap_check? do
    let(:user) { User.new }

333 334 335 336
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
      user.stub(ldap_user?: true)
      user.last_credential_check_at = nil
337 338 339
      expect(user.requires_ldap_check?).to be_false
    end

340 341
    context 'when LDAP is enabled' do
      before { Gitlab.config.ldap.stub(enabled: true) }
342

343 344 345
      it 'is false for non-LDAP users' do
        user.stub(ldap_user?: false)
        expect(user.requires_ldap_check?).to be_false
346 347
      end

348 349 350 351 352 353 354 355 356 357 358 359
      context 'and when the user is an LDAP user' do
        before { user.stub(ldap_user?: true) }

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
          expect(user.requires_ldap_check?).to be_true
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
          expect(user.requires_ldap_check?).to be_true
        end
360 361 362 363
      end
    end
  end

364 365
  describe :ldap_user? do
    it "is true if provider name starts with ldap" do
366
      user = create(:omniauth_user, provider: 'ldapmain')
367 368 369 370
      expect( user.ldap_user? ).to be_true
    end

    it "is false for other providers" do
371
      user = create(:omniauth_user, provider: 'other-provider')
372 373 374 375
      expect( user.ldap_user? ).to be_false
    end

    it "is false if no extern_uid is provided" do
376
      user = create(:omniauth_user, extern_uid: nil)
377 378 379 380
      expect( user.ldap_user? ).to be_false
    end
  end

381 382 383 384 385 386 387
  describe :ldap_identity do
    it "returns ldap identity" do
      user = create :omniauth_user
      user.ldap_identity.provider.should_not be_empty
    end
  end

J
Jerome Dalbert 已提交
388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
427

J
Jerome Dalbert 已提交
428 429
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
430
  end
C
Ciro Santilli 已提交
431

432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458
  describe "#starred?" do
    it "determines if user starred a project" do
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

      expect(user.starred?(project1)).to be_false
      expect(user.starred?(project2)).to be_false

      star1 = UsersStarProject.create!(project: project1, user: user)
      expect(user.starred?(project1)).to be_true
      expect(user.starred?(project2)).to be_false

      star2 = UsersStarProject.create!(project: project2, user: user)
      expect(user.starred?(project1)).to be_true
      expect(user.starred?(project2)).to be_true

      star1.destroy
      expect(user.starred?(project1)).to be_false
      expect(user.starred?(project2)).to be_true

      star2.destroy
      expect(user.starred?(project1)).to be_false
      expect(user.starred?(project2)).to be_false
    end
  end

C
Ciro Santilli 已提交
459 460 461 462 463 464 465 466 467 468 469 470
  describe "#toggle_star" do
    it "toggles stars" do
      user = create :user
      project = create :project, :public

      expect(user.starred?(project)).to be_false
      user.toggle_star(project)
      expect(user.starred?(project)).to be_true
      user.toggle_star(project)
      expect(user.starred?(project)).to be_false
    end
  end
V
Valery Sizov 已提交
471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498

  describe "#sort" do
    before do
      User.delete_all
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
    end
    
    it "sorts users as recently_signed_in" do
      User.sort('recent_sign_in').first.should == @user
    end

    it "sorts users as late_signed_in" do
      User.sort('oldest_sign_in').first.should == @user1
    end

    it "sorts users as recently_created" do
      User.sort('recently_created').first.should == @user
    end

    it "sorts users as late_created" do
      User.sort('late_created').first.should == @user1
    end

    it "sorts users by name when nil is passed" do
      User.sort(nil).first.should == @user
    end
  end
G
gitlabhq 已提交
499
end