pipelines_controller_spec.rb 7.3 KB
Newer Older
1 2 3
require 'spec_helper'

describe Projects::PipelinesController do
4 5
  include ApiHelpers

6 7
  set(:user) { create(:user) }
  set(:project) { create(:project, :public, :repository) }
K
Kamil Trzcinski 已提交
8
  let(:feature) { ProjectFeature::DISABLED }
9 10

  before do
11 12
    stub_not_protect_default_branch
    project.add_developer(user)
13
    project.project_feature.update(builds_access_level: feature)
14

15 16 17
    sign_in(user)
  end

18 19
  describe 'GET index.json' do
    before do
20 21 22 23
      %w(pending running created success).each_with_index do |status, index|
        sha = project.commit("HEAD~#{index}")
        create(:ci_empty_pipeline, status: status, project: project, sha: sha)
      end
24 25 26 27
    end

    subject do
      get :index, namespace_id: project.namespace, project_id: project, format: :json
28 29 30
    end

    it 'returns JSON with serialized pipelines' do
31 32
      subject

33
      expect(response).to have_gitlab_http_status(:ok)
34
      expect(response).to match_response_schema('pipeline')
35 36

      expect(json_response).to include('pipelines')
37
      expect(json_response['pipelines'].count).to eq 4
38 39 40 41
      expect(json_response['count']['all']).to eq '4'
      expect(json_response['count']['running']).to eq '1'
      expect(json_response['count']['pending']).to eq '1'
      expect(json_response['count']['finished']).to eq '1'
42
    end
43 44 45

    context 'when performing gitaly calls', :request_store do
      it 'limits the Gitaly requests' do
46
        expect { subject }.to change { Gitlab::GitalyClient.get_request_count }.by(3)
47 48
      end
    end
49 50
  end

51
  describe 'GET show JSON' do
52
    let(:pipeline) { create(:ci_pipeline_with_one_job, project: project) }
53 54 55 56

    it 'returns the pipeline' do
      get_pipeline_json

57
      expect(response).to have_gitlab_http_status(:ok)
58 59 60 61 62
      expect(json_response).not_to be_an(Array)
      expect(json_response['id']).to be(pipeline.id)
      expect(json_response['details']).to have_key 'stages'
    end

63
    context 'when the pipeline has multiple stages and groups', :request_store do
64 65 66 67 68 69 70
      before do
        create_build('build', 0, 'build')
        create_build('test', 1, 'rspec 0')
        create_build('deploy', 2, 'production')
        create_build('post deploy', 3, 'pages 0')
      end

71
      let(:project) { create(:project, :repository) }
72 73 74 75
      let(:pipeline) do
        create(:ci_empty_pipeline, project: project, user: user, sha: project.commit.id)
      end

76 77 78
      it 'does not perform N + 1 queries' do
        control_count = ActiveRecord::QueryRecorder.new { get_pipeline_json }.count

79 80 81 82 83 84
        create_build('test', 1, 'rspec 1')
        create_build('test', 1, 'spinach 0')
        create_build('test', 1, 'spinach 1')
        create_build('test', 1, 'audit')
        create_build('post deploy', 3, 'pages 1')
        create_build('post deploy', 3, 'pages 2')
85

86 87
        new_count = ActiveRecord::QueryRecorder.new { get_pipeline_json }.count
        expect(new_count).to be_within(12).of(control_count)
88 89 90 91 92 93
      end
    end

    def get_pipeline_json
      get :show, namespace_id: project.namespace, project_id: project, id: pipeline, format: :json
    end
94 95 96 97

    def create_build(stage, stage_idx, name)
      create(:ci_build, pipeline: pipeline, stage: stage, stage_idx: stage_idx, name: name)
    end
98 99
  end

100
  describe 'GET stages.json' do
101 102
    let(:pipeline) { create(:ci_pipeline, project: project) }

103 104 105 106 107 108 109 110
    context 'when accessing existing stage' do
      before do
        create(:ci_build, pipeline: pipeline, stage: 'build')

        get_stage('build')
      end

      it 'returns html source for stage dropdown' do
111
        expect(response).to have_gitlab_http_status(:ok)
112
        expect(response).to match_response_schema('pipeline_stage')
113 114 115 116 117 118 119 120
      end
    end

    context 'when accessing unknown stage' do
      before do
        get_stage('test')
      end

121
      it 'responds with not found' do
122
        expect(response).to have_gitlab_http_status(:not_found)
123
      end
124 125
    end

126
    def get_stage(name)
127 128
      get :stage, namespace_id: project.namespace,
                  project_id: project,
129 130 131 132
                  id: pipeline.id,
                  stage: name,
                  format: :json
    end
133
  end
S
Shinya Maeda 已提交
134

135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163
  describe 'GET stages_ajax.json' do
    let(:pipeline) { create(:ci_pipeline, project: project) }

    context 'when accessing existing stage' do
      before do
        create(:ci_build, pipeline: pipeline, stage: 'build')

        get_stage_ajax('build')
      end

      it 'returns html source for stage dropdown' do
        expect(response).to have_gitlab_http_status(:ok)
        expect(response).to render_template('projects/pipelines/_stage')
        expect(json_response).to include('html')
      end
    end

    context 'when accessing unknown stage' do
      before do
        get_stage_ajax('test')
      end

      it 'responds with not found' do
        expect(response).to have_gitlab_http_status(:not_found)
      end
    end

    def get_stage_ajax(name)
      get :stage_ajax, namespace_id: project.namespace,
164 165 166 167
                       project_id: project,
                       id: pipeline.id,
                       stage: name,
                       format: :json
168 169 170
    end
  end

S
Shinya Maeda 已提交
171
  describe 'GET status.json' do
172 173
    let(:pipeline) { create(:ci_pipeline, project: project) }
    let(:status) { pipeline.detailed_status(double('user')) }
S
Shinya Maeda 已提交
174

175 176 177 178 179 180
    before do
      get :status, namespace_id: project.namespace,
                   project_id: project,
                   id: pipeline.id,
                   format: :json
    end
S
Shinya Maeda 已提交
181

182
    it 'return a detailed pipeline status in json' do
183
      expect(response).to have_gitlab_http_status(:ok)
184 185 186
      expect(json_response['text']).to eq status.text
      expect(json_response['label']).to eq status.label
      expect(json_response['icon']).to eq status.icon
187
      expect(json_response['favicon']).to match_asset_path("/assets/ci_favicons/#{status.favicon}.ico")
S
Shinya Maeda 已提交
188 189
    end
  end
190 191 192 193 194 195 196 197 198 199 200 201

  describe 'POST retry.json' do
    let!(:pipeline) { create(:ci_pipeline, :failed, project: project) }
    let!(:build) { create(:ci_build, :failed, pipeline: pipeline) }

    before do
      post :retry, namespace_id: project.namespace,
                   project_id: project,
                   id: pipeline.id,
                   format: :json
    end

K
Kamil Trzcinski 已提交
202 203
    context 'when builds are enabled' do
      let(:feature) { ProjectFeature::ENABLED }
204

K
Kamil Trzcinski 已提交
205
      it 'retries a pipeline without returning any content' do
206
        expect(response).to have_gitlab_http_status(:no_content)
K
Kamil Trzcinski 已提交
207 208 209 210 211 212
        expect(build.reload).to be_retried
      end
    end

    context 'when builds are disabled' do
      it 'fails to retry pipeline' do
213
        expect(response).to have_gitlab_http_status(:not_found)
K
Kamil Trzcinski 已提交
214
      end
215 216 217 218 219 220
    end
  end

  describe 'POST cancel.json' do
    let!(:pipeline) { create(:ci_pipeline, project: project) }
    let!(:build) { create(:ci_build, :running, pipeline: pipeline) }
221

222 223 224 225 226 227 228
    before do
      post :cancel, namespace_id: project.namespace,
                    project_id: project,
                    id: pipeline.id,
                    format: :json
    end

K
Kamil Trzcinski 已提交
229 230
    context 'when builds are enabled' do
      let(:feature) { ProjectFeature::ENABLED }
231

K
Kamil Trzcinski 已提交
232
      it 'cancels a pipeline without returning any content' do
233
        expect(response).to have_gitlab_http_status(:no_content)
K
Kamil Trzcinski 已提交
234 235 236 237 238 239
        expect(pipeline.reload).to be_canceled
      end
    end

    context 'when builds are disabled' do
      it 'fails to retry pipeline' do
240
        expect(response).to have_gitlab_http_status(:not_found)
K
Kamil Trzcinski 已提交
241
      end
242 243
    end
  end
244
end