gitlab_ci_yaml_processor_spec.rb 25.7 KB
Newer Older
D
Douwe Maan 已提交
1 2
require 'spec_helper'

V
Valery Sizov 已提交
3
module Ci
D
Douwe Maan 已提交
4
  describe GitlabCiYamlProcessor, lib: true do
5 6
    let(:path) { 'path' }
    
V
Valery Sizov 已提交
7 8 9 10 11 12 13 14 15
    describe "#builds_for_ref" do
      let(:type) { 'test' }

      it "returns builds if no branch specified" do
        config = YAML.dump({
          before_script: ["pwd"],
          rspec: { script: "rspec" }
        })

16
        config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
17 18 19 20

        expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref(type, "master").first).to eq({
          stage: "test",
21
          stage_idx: 1,
V
Valery Sizov 已提交
22 23 24
          except: nil,
          name: :rspec,
          only: nil,
K
Kamil Trzcinski 已提交
25 26
          commands: "pwd\nrspec",
          tag_list: [],
V
Valery Sizov 已提交
27
          options: {},
K
Kamil Trzcinski 已提交
28 29
          allow_failure: false,
          when: "on_success"
V
Valery Sizov 已提交
30 31
        })
      end
32 33 34 35 36 37 38
      
      describe :only do
        it "does not return builds if only has another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", only: ["deploy"] }
                             })
V
Valery Sizov 已提交
39

40
          config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
41

42 43
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(0)
        end
V
Valery Sizov 已提交
44

45 46 47 48 49
        it "does not return builds if only has regexp with another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", only: ["/^deploy$/"] }
                             })
V
Valery Sizov 已提交
50

51
          config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
52

53 54
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(0)
        end
V
Valery Sizov 已提交
55

56 57 58 59 60
        it "returns builds if only has specified this branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", only: ["master"] }
                             })
V
Valery Sizov 已提交
61

62
          config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
63

64 65
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        end
V
Valery Sizov 已提交
66

67 68 69 70 71
        it "returns builds if only has a list of branches including specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["master", "deploy"] }
                             })
V
Valery Sizov 已提交
72

73
          config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
74

75 76
          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end
V
Valery Sizov 已提交
77

78 79 80 81 82
        it "returns builds if only has a branches keyword specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["branches"] }
                             })
V
Valery Sizov 已提交
83

84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "does not return builds if only has a tags keyword" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["tags"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns builds if only has current repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["branches@path"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "does not return builds if only has different repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["branches@fork"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns build only for specified type" do

          config = YAML.dump({
                               before_script: ["pwd"],
K
Kamil Trzcinski 已提交
126
                               rspec: { script: "rspec", type: "test", only: ["master", "deploy"] },
127 128 129
                               staging: { script: "deploy", type: "deploy", only: ["master", "deploy"] },
                               production: { script: "deploy", type: "deploy", only: ["master@path", "deploy"] },
                             })
V
Valery Sizov 已提交
130

K
Kamil Trzcinski 已提交
131
          config_processor = GitlabCiYamlProcessor.new(config, 'fork')
V
Valery Sizov 已提交
132

133
          expect(config_processor.builds_for_stage_and_ref("deploy", "deploy").size).to eq(2)
K
Kamil Trzcinski 已提交
134 135
          expect(config_processor.builds_for_stage_and_ref("test", "deploy").size).to eq(1)
          expect(config_processor.builds_for_stage_and_ref("deploy", "master").size).to eq(1)
136
        end
V
Valery Sizov 已提交
137 138
      end

139 140 141 142 143 144
      describe :except do
        it "returns builds if except has another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", except: ["deploy"] }
                             })
V
Valery Sizov 已提交
145

146
          config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
147

148 149 150 151 152 153 154 155 156 157 158 159 160
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        end

        it "returns builds if except has regexp with another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", except: ["/^deploy$/"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        end
V
Valery Sizov 已提交
161

162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230
        it "does not return builds if except has specified this branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", except: ["master"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(0)
        end

        it "does not return builds if except has a list of branches including specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["master", "deploy"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "does not return builds if except has a branches keyword specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["branches"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns builds if except has a tags keyword" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["tags"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "does not return builds if except has current repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["branches@path"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns builds if except has different repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["branches@fork"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "returns build except specified type" do
          config = YAML.dump({
                               before_script: ["pwd"],
K
Kamil Trzcinski 已提交
231 232 233
                               rspec: { script: "rspec", type: "test", except: ["master", "deploy", "test@fork"] },
                               staging: { script: "deploy", type: "deploy", except: ["master"] },
                               production: { script: "deploy", type: "deploy", except: ["master@fork"] },
234 235
                             })

K
Kamil Trzcinski 已提交
236
          config_processor = GitlabCiYamlProcessor.new(config, 'fork')
237

K
Kamil Trzcinski 已提交
238 239 240
          expect(config_processor.builds_for_stage_and_ref("deploy", "deploy").size).to eq(2)
          expect(config_processor.builds_for_stage_and_ref("test", "test").size).to eq(0)
          expect(config_processor.builds_for_stage_and_ref("deploy", "master").size).to eq(0)
241
        end
V
Valery Sizov 已提交
242
      end
243

D
Douwe Maan 已提交
244 245
    end

V
Valery Sizov 已提交
246 247 248 249 250 251 252 253 254
    describe "Image and service handling" do
      it "returns image and service when defined" do
        config = YAML.dump({
                             image: "ruby:2.1",
                             services: ["mysql"],
                             before_script: ["pwd"],
                             rspec: { script: "rspec" }
                           })

255
        config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
256 257 258 259 260

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first).to eq({
          except: nil,
          stage: "test",
261
          stage_idx: 1,
V
Valery Sizov 已提交
262 263
          name: :rspec,
          only: nil,
K
Kamil Trzcinski 已提交
264 265
          commands: "pwd\nrspec",
          tag_list: [],
V
Valery Sizov 已提交
266 267 268 269
          options: {
            image: "ruby:2.1",
            services: ["mysql"]
          },
270 271
          allow_failure: false,
          when: "on_success"
V
Valery Sizov 已提交
272 273 274 275 276 277 278 279 280 281 282
        })
      end

      it "returns image and service when overridden for job" do
        config = YAML.dump({
                             image:         "ruby:2.1",
                             services:      ["mysql"],
                             before_script: ["pwd"],
                             rspec:         { image: "ruby:2.5", services: ["postgresql"], script: "rspec" }
                           })

283
        config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
284 285 286 287 288

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first).to eq({
          except: nil,
          stage: "test",
289
          stage_idx: 1,
V
Valery Sizov 已提交
290 291
          name: :rspec,
          only: nil,
K
Kamil Trzcinski 已提交
292 293
          commands: "pwd\nrspec",
          tag_list: [],
V
Valery Sizov 已提交
294 295 296 297
          options: {
            image: "ruby:2.5",
            services: ["postgresql"]
          },
298 299
          allow_failure: false,
          when: "on_success"
V
Valery Sizov 已提交
300 301
        })
      end
D
Douwe Maan 已提交
302 303
    end

V
Valery Sizov 已提交
304 305 306 307 308 309 310 311 312 313 314 315
    describe "Variables" do
      it "returns variables when defined" do
        variables = {
          var1: "value1",
          var2: "value2",
        }
        config = YAML.dump({
                             variables: variables,
                             before_script: ["pwd"],
                             rspec: { script: "rspec" }
                           })

316
        config_processor = GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
317 318
        expect(config_processor.variables).to eq(variables)
      end
D
Douwe Maan 已提交
319 320
    end

321 322 323 324 325 326 327
    describe "When" do
      %w(on_success on_failure always).each do |when_state|
        it "returns #{when_state} when defined" do
          config = YAML.dump({
                               rspec: { script: "rspec", when: when_state }
                             })

328
          config_processor = GitlabCiYamlProcessor.new(config, path)
329 330 331 332 333 334 335
          builds = config_processor.builds_for_stage_and_ref("test", "master")
          expect(builds.size).to eq(1)
          expect(builds.first[:when]).to eq(when_state)
        end
      end
    end

336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
    describe "Caches" do
      it "returns cache when defined globally" do
        config = YAML.dump({
                             cache: { paths: ["logs/", "binaries/"], untracked: true },
                             rspec: {
                               script: "rspec"
                             }
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first[:options][:cache]).to eq(
          paths: ["logs/", "binaries/"],
          untracked: true,
        )
      end

      it "returns cache when defined in a job" do
        config = YAML.dump({
                             rspec: {
                               cache: { paths: ["logs/", "binaries/"], untracked: true },
                               script: "rspec"
                             }
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first[:options][:cache]).to eq(
          paths: ["logs/", "binaries/"],
          untracked: true,
        )
      end

      it "overwrite cache when defined for a job and globally" do
        config = YAML.dump({
                             cache: { paths: ["logs/", "binaries/"], untracked: true },
                             rspec: {
                               script: "rspec",
                               cache: { paths: ["test/"], untracked: false },
                             }
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first[:options][:cache]).to eq(
          paths: ["test/"],
          untracked: false,
        )
      end
    end

K
Kamil Trzcinski 已提交
390 391 392 393 394 395
    describe "Artifacts" do
      it "returns artifacts when defined" do
        config = YAML.dump({
                             image:         "ruby:2.1",
                             services:      ["mysql"],
                             before_script: ["pwd"],
396 397 398 399
                             rspec:         {
                               artifacts: { paths: ["logs/", "binaries/"], untracked: true },
                               script: "rspec"
                             }
K
Kamil Trzcinski 已提交
400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first).to eq({
          except: nil,
          stage: "test",
          stage_idx: 1,
          name: :rspec,
          only: nil,
          commands: "pwd\nrspec",
          tag_list: [],
          options: {
            image: "ruby:2.1",
            services: ["mysql"],
416 417 418 419
            artifacts: {
              paths: ["logs/", "binaries/"],
              untracked: true
            }
K
Kamil Trzcinski 已提交
420 421 422 423 424 425 426
          },
          when: "on_success",
          allow_failure: false
        })
      end
    end

V
Valery Sizov 已提交
427
    describe "Error handling" do
428 429 430 431
      it "fails to parse YAML" do
        expect{GitlabCiYamlProcessor.new("invalid: yaml: test")}.to raise_error(Psych::SyntaxError)
      end

V
Valery Sizov 已提交
432
      it "indicates that object is invalid" do
433
        expect{GitlabCiYamlProcessor.new("invalid_yaml")}.to raise_error(GitlabCiYamlProcessor::ValidationError)
V
Valery Sizov 已提交
434 435 436 437 438
      end

      it "returns errors if tags parameter is invalid" do
        config = YAML.dump({ rspec: { script: "test", tags: "mysql" } })
        expect do
439
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
440 441 442 443 444 445
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: tags parameter should be an array of strings")
      end

      it "returns errors if before_script parameter is invalid" do
        config = YAML.dump({ before_script: "bundle update", rspec: { script: "test" } })
        expect do
446
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
447 448 449 450 451 452
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "before_script should be an array of strings")
      end

      it "returns errors if image parameter is invalid" do
        config = YAML.dump({ image: ["test"], rspec: { script: "test" } })
        expect do
453
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
454 455 456
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "image should be a string")
      end

K
Kamil Trzcinski 已提交
457 458 459
      it "returns errors if job name is blank" do
        config = YAML.dump({ '' => { script: "test" } })
        expect do
460
          GitlabCiYamlProcessor.new(config, path)
K
Kamil Trzcinski 已提交
461 462 463 464 465 466
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "job name should be non-empty string")
      end

      it "returns errors if job name is non-string" do
        config = YAML.dump({ 10 => { script: "test" } })
        expect do
467
          GitlabCiYamlProcessor.new(config, path)
K
Kamil Trzcinski 已提交
468 469 470
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "job name should be non-empty string")
      end

V
Valery Sizov 已提交
471 472 473
      it "returns errors if job image parameter is invalid" do
        config = YAML.dump({ rspec: { script: "test", image: ["test"] } })
        expect do
474
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
475 476 477 478 479 480
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: image should be a string")
      end

      it "returns errors if services parameter is not an array" do
        config = YAML.dump({ services: "test", rspec: { script: "test" } })
        expect do
481
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
482 483 484 485 486 487
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "services should be an array of strings")
      end

      it "returns errors if services parameter is not an array of strings" do
        config = YAML.dump({ services: [10, "test"], rspec: { script: "test" } })
        expect do
488
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
489 490 491 492 493 494
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "services should be an array of strings")
      end

      it "returns errors if job services parameter is not an array" do
        config = YAML.dump({ rspec: { script: "test", services: "test" } })
        expect do
495
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
496 497 498 499 500 501
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: services should be an array of strings")
      end

      it "returns errors if job services parameter is not an array of strings" do
        config = YAML.dump({ rspec: { script: "test", services: [10, "test"] } })
        expect do
502
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
503 504 505 506 507 508
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: services should be an array of strings")
      end

      it "returns errors if there are unknown parameters" do
        config = YAML.dump({ extra: "bundle update" })
        expect do
509
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
510 511 512 513 514 515
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "Unknown parameter: extra")
      end

      it "returns errors if there are unknown parameters that are hashes, but doesn't have a script" do
        config = YAML.dump({ extra: { services: "test" } })
        expect do
516
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
517 518 519 520 521 522
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "Unknown parameter: extra")
      end

      it "returns errors if there is no any jobs defined" do
        config = YAML.dump({ before_script: ["bundle update"] })
        expect do
523
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
524 525 526 527 528 529
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "Please define at least one job")
      end

      it "returns errors if job allow_failure parameter is not an boolean" do
        config = YAML.dump({ rspec: { script: "test", allow_failure: "string" } })
        expect do
530
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
531 532 533 534
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: allow_failure parameter should be an boolean")
      end

      it "returns errors if job stage is not a string" do
535
        config = YAML.dump({ rspec: { script: "test", type: 1 } })
V
Valery Sizov 已提交
536
        expect do
537
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
538 539 540 541
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: stage parameter should be build, test, deploy")
      end

      it "returns errors if job stage is not a pre-defined stage" do
542
        config = YAML.dump({ rspec: { script: "test", type: "acceptance" } })
V
Valery Sizov 已提交
543
        expect do
544
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
545 546 547 548
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: stage parameter should be build, test, deploy")
      end

      it "returns errors if job stage is not a defined stage" do
549
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", type: "acceptance" } })
V
Valery Sizov 已提交
550
        expect do
551
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
552 553 554 555 556 557
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: stage parameter should be build, test")
      end

      it "returns errors if stages is not an array" do
        config = YAML.dump({ types: "test", rspec: { script: "test" } })
        expect do
558
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
559 560 561 562 563 564
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "stages should be an array of strings")
      end

      it "returns errors if stages is not an array of strings" do
        config = YAML.dump({ types: [true, "test"], rspec: { script: "test" } })
        expect do
565
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
566 567 568 569 570 571
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "stages should be an array of strings")
      end

      it "returns errors if variables is not a map" do
        config = YAML.dump({ variables: "test", rspec: { script: "test" } })
        expect do
572
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
573 574 575 576 577 578
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "variables should be a map of key-valued strings")
      end

      it "returns errors if variables is not a map of key-valued strings" do
        config = YAML.dump({ variables: { test: false }, rspec: { script: "test" } })
        expect do
579
          GitlabCiYamlProcessor.new(config, path)
V
Valery Sizov 已提交
580 581
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "variables should be a map of key-valued strings")
      end
582 583

      it "returns errors if job when is not on_success, on_failure or always" do
K
Kamil Trzcinski 已提交
584
        config = YAML.dump({ rspec: { script: "test", when: 1 } })
585
        expect do
586
          GitlabCiYamlProcessor.new(config, path)
587 588
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: when parameter should be on_success, on_failure or always")
      end
K
Kamil Trzcinski 已提交
589

590 591
      it "returns errors if job artifacts:untracked is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", artifacts: { untracked: "string" } } })
K
Kamil Trzcinski 已提交
592 593
        expect do
          GitlabCiYamlProcessor.new(config)
594 595 596 597 598 599 600 601
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: artifacts:untracked parameter should be an boolean")
      end

      it "returns errors if job artifacts:paths is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", artifacts: { paths: "string" } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: artifacts:paths parameter should be an array of strings")
K
Kamil Trzcinski 已提交
602
      end
603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630

      it "returns errors if cache:untracked is not an array of strings" do
        config = YAML.dump({ cache: { untracked: "string" }, rspec: { script: "test" } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "cache:untracked parameter should be an boolean")
      end

      it "returns errors if cache:paths is not an array of strings" do
        config = YAML.dump({ cache: { paths: "string" }, rspec: { script: "test" } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "cache:paths parameter should be an array of strings")
      end

      it "returns errors if job cache:untracked is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", cache: { untracked: "string" } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: cache:untracked parameter should be an boolean")
      end

      it "returns errors if job cache:paths is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", cache: { paths: "string" } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: cache:paths parameter should be an array of strings")
      end
D
Douwe Maan 已提交
631 632 633
    end
  end
end