workhorse_spec.rb 14.4 KB
Newer Older
1 2
require 'spec_helper'

3
describe Gitlab::Workhorse do
4
  let(:project)    { create(:project, :repository) }
N
Nick Thomas 已提交
5 6 7 8 9 10 11 12 13
  let(:repository) { project.repository }

  def decode_workhorse_header(array)
    key, value = array
    command, encoded_params = value.split(":")
    params = JSON.parse(Base64.urlsafe_decode64(encoded_params))

    [key, command, params]
  end
14

15
  describe ".send_git_archive" do
16 17 18 19 20 21 22 23 24 25 26 27 28
    let(:ref) { 'master' }
    let(:format) { 'zip' }
    let(:storage_path) { Gitlab.config.gitlab.repository_downloads_path }
    let(:base_params) { repository.archive_metadata(ref, storage_path, format) }
    let(:gitaly_params) do
      base_params.merge(
        'GitalyServer' => {
          'address' => Gitlab::GitalyClient.address(project.repository_storage),
          'token' => Gitlab::GitalyClient.token(project.repository_storage)
        },
        'GitalyRepository' => repository.gitaly_repository.to_h.deep_stringify_keys
      )
    end
29
    let(:cache_disabled) { false }
30 31 32 33 34

    subject do
      described_class.send_git_archive(repository, ref: ref, format: format)
    end

35 36 37 38
    before do
      allow(described_class).to receive(:git_archive_cache_disabled?).and_return(cache_disabled)
    end

39
    context 'when Gitaly workhorse_archive feature is enabled' do
40 41 42 43 44 45 46
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq('Gitlab-Workhorse-Send-Data')
        expect(command).to eq('git-archive')
        expect(params).to include(gitaly_params)
      end
47 48 49 50 51 52 53 54 55

      context 'when archive caching is disabled' do
        let(:cache_disabled) { true }

        it 'tells workhorse not to use the cache' do
          _, _, params = decode_workhorse_header(subject)
          expect(params).to include({ 'DisableCache' => true })
        end
      end
56 57
    end

58
    context 'when Gitaly workhorse_archive feature is disabled', :skip_gitaly_mock do
59 60 61 62 63 64 65 66 67
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq('Gitlab-Workhorse-Send-Data')
        expect(command).to eq('git-archive')
        expect(params).to eq(base_params)
      end
    end

68 69 70 71 72 73
    context "when the repository doesn't have an archive file path" do
      before do
        allow(project.repository).to receive(:archive_metadata).and_return(Hash.new)
      end

      it "raises an error" do
74
        expect { subject }.to raise_error(RuntimeError)
75 76 77
      end
    end
  end
78

N
Nick Thomas 已提交
79 80 81 82
  describe '.send_git_patch' do
    let(:diff_refs) { double(base_sha: "base", head_sha: "head") }
    subject { described_class.send_git_patch(repository, diff_refs) }

83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101
    context 'when Gitaly workhorse_send_git_patch feature is enabled' do
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq("Gitlab-Workhorse-Send-Data")
        expect(command).to eq("git-format-patch")
        expect(params).to eq({
          'GitalyServer' => {
            address: Gitlab::GitalyClient.address(project.repository_storage),
            token: Gitlab::GitalyClient.token(project.repository_storage)
          },
          'RawPatchRequest' => Gitaly::RawPatchRequest.new(
            repository: repository.gitaly_repository,
            left_commit_id: 'base',
            right_commit_id: 'head'
          ).to_json
        }.deep_stringify_keys)
      end
    end
N
Nick Thomas 已提交
102

103
    context 'when Gitaly workhorse_send_git_patch feature is disabled', :skip_gitaly_mock do
104 105 106 107 108 109 110
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq("Gitlab-Workhorse-Send-Data")
        expect(command).to eq("git-format-patch")
        expect(params).to eq("RepoPath" => repository.path_to_repo, "ShaFrom" => "base", "ShaTo" => "head")
      end
N
Nick Thomas 已提交
111 112 113
    end
  end

114 115 116 117 118
  describe '.terminal_websocket' do
    def terminal(ca_pem: nil)
      out = {
        subprotocols: ['foo'],
        url: 'wss://example.com/terminal.ws',
119 120
        headers: { 'Authorization' => ['Token x'] },
        max_session_time: 600
121 122 123 124 125 126 127 128 129 130
      }
      out[:ca_pem] = ca_pem if ca_pem
      out
    end

    def workhorse(ca_pem: nil)
      out = {
        'Terminal' => {
          'Subprotocols' => ['foo'],
          'Url' => 'wss://example.com/terminal.ws',
131 132
          'Header' => { 'Authorization' => ['Token x'] },
          'MaxSessionTime' => 600
133 134 135 136 137 138 139
        }
      }
      out['Terminal']['CAPem'] = ca_pem if ca_pem
      out
    end

    context 'without ca_pem' do
140
      subject { described_class.terminal_websocket(terminal) }
141 142 143 144 145

      it { is_expected.to eq(workhorse) }
    end

    context 'with ca_pem' do
146
      subject { described_class.terminal_websocket(terminal(ca_pem: "foo")) }
147 148 149 150 151

      it { is_expected.to eq(workhorse(ca_pem: "foo")) }
    end
  end

N
Nick Thomas 已提交
152 153
  describe '.send_git_diff' do
    let(:diff_refs) { double(base_sha: "base", head_sha: "head") }
154
    subject { described_class.send_git_diff(repository, diff_refs) }
N
Nick Thomas 已提交
155

156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174
    context 'when Gitaly workhorse_send_git_diff feature is enabled' do
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq("Gitlab-Workhorse-Send-Data")
        expect(command).to eq("git-diff")
        expect(params).to eq({
          'GitalyServer' => {
            address: Gitlab::GitalyClient.address(project.repository_storage),
            token: Gitlab::GitalyClient.token(project.repository_storage)
          },
          'RawDiffRequest' => Gitaly::RawDiffRequest.new(
            repository: repository.gitaly_repository,
            left_commit_id: 'base',
            right_commit_id: 'head'
          ).to_json
        }.deep_stringify_keys)
      end
    end
N
Nick Thomas 已提交
175

176
    context 'when Gitaly workhorse_send_git_diff feature is disabled', :skip_gitaly_mock do
177 178 179 180 181 182 183
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq("Gitlab-Workhorse-Send-Data")
        expect(command).to eq("git-diff")
        expect(params).to eq("RepoPath" => repository.path_to_repo, "ShaFrom" => "base", "ShaTo" => "head")
      end
N
Nick Thomas 已提交
184 185 186
    end
  end

187 188 189 190 191 192 193 194 195 196 197 198 199 200
  describe ".secret" do
    subject { described_class.secret }

    before do
      described_class.instance_variable_set(:@secret, nil)
      described_class.write_secret
    end

    it 'returns 32 bytes' do
      expect(subject).to be_a(String)
      expect(subject.length).to eq(32)
      expect(subject.encoding).to eq(Encoding::ASCII_8BIT)
    end

201 202 203 204 205
    it 'accepts a trailing newline' do
      open(described_class.secret_path, 'a') { |f| f.write "\n" }
      expect(subject.length).to eq(32)
    end

206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238
    it 'raises an exception if the secret file cannot be read' do
      File.delete(described_class.secret_path)
      expect { subject }.to raise_exception(Errno::ENOENT)
    end

    it 'raises an exception if the secret file contains the wrong number of bytes' do
      File.truncate(described_class.secret_path, 0)
      expect { subject }.to raise_exception(RuntimeError)
    end
  end

  describe ".write_secret" do
    let(:secret_path) { described_class.secret_path }
    before do
      begin
        File.delete(secret_path)
      rescue Errno::ENOENT
      end

      described_class.write_secret
    end

    it 'uses mode 0600' do
      expect(File.stat(secret_path).mode & 0777).to eq(0600)
    end

    it 'writes base64 data' do
      bytes = Base64.strict_decode64(File.read(secret_path))
      expect(bytes).not_to be_empty
    end
  end

  describe '#verify_api_request!' do
J
Jacob Vosmaer 已提交
239
    let(:header_key) { described_class::INTERNAL_API_REQUEST_HEADER }
240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274
    let(:payload) { { 'iss' => 'gitlab-workhorse' } }

    it 'accepts a correct header' do
      headers = { header_key => JWT.encode(payload, described_class.secret, 'HS256') }
      expect { call_verify(headers) }.not_to raise_error
    end

    it 'raises an error when the header is not set' do
      expect { call_verify({}) }.to raise_jwt_error
    end

    it 'raises an error when the header is not signed' do
      headers = { header_key => JWT.encode(payload, nil, 'none') }
      expect { call_verify(headers) }.to raise_jwt_error
    end

    it 'raises an error when the header is signed with the wrong key' do
      headers = { header_key => JWT.encode(payload, 'wrongkey', 'HS256') }
      expect { call_verify(headers) }.to raise_jwt_error
    end

    it 'raises an error when the issuer is incorrect' do
      payload['iss'] = 'somebody else'
      headers = { header_key => JWT.encode(payload, described_class.secret, 'HS256') }
      expect { call_verify(headers) }.to raise_jwt_error
    end

    def raise_jwt_error
      raise_error(JWT::DecodeError)
    end

    def call_verify(headers)
      described_class.verify_api_request!(headers)
    end
  end
275 276 277

  describe '.git_http_ok' do
    let(:user) { create(:user) }
278
    let(:repo_path) { repository.path_to_repo }
279
    let(:action) { 'info_refs' }
280
    let(:params) do
281 282 283 284
      {
        GL_ID: "user-#{user.id}",
        GL_USERNAME: user.username,
        GL_REPOSITORY: "project-#{project.id}",
285 286
        RepoPath: repo_path,
        ShowAllRefs: false
287
      }
288 289 290 291 292
    end

    subject { described_class.git_http_ok(repository, false, user, action) }

    it { expect(subject).to include(params) }
293

294 295
    context 'when is_wiki' do
      let(:params) do
296 297 298 299
        {
          GL_ID: "user-#{user.id}",
          GL_USERNAME: user.username,
          GL_REPOSITORY: "wiki-#{project.id}",
300 301
          RepoPath: repo_path,
          ShowAllRefs: false
302
        }
303 304 305
      end

      subject { described_class.git_http_ok(repository, true, user, action) }
306

307 308
      it { expect(subject).to include(params) }
    end
309

310
    context 'when Gitaly is enabled' do
311 312
      let(:gitaly_params) do
        {
313 314 315 316
          GitalyServer: {
            address: Gitlab::GitalyClient.address('default'),
            token: Gitlab::GitalyClient.token('default')
          }
317 318 319
        }
      end

320
      before do
321
        allow(Gitlab.config.gitaly).to receive(:enabled).and_return(true)
322 323
      end

324
      it 'includes a Repository param' do
J
Jacob Vosmaer 已提交
325
        repo_param = {
326
          storage_name: 'default',
327 328
          relative_path: project.full_path + '.git',
          gl_repository: "project-#{project.id}"
J
Jacob Vosmaer 已提交
329
        }
330

J
Jacob Vosmaer 已提交
331
        expect(subject[:Repository]).to include(repo_param)
332 333
      end

334 335 336 337
      context "when git_upload_pack action is passed" do
        let(:action) { 'git_upload_pack' }
        let(:feature_flag) { :post_upload_pack }

338 339
        it 'includes Gitaly params in the returned value' do
          allow(Gitlab::GitalyClient).to receive(:feature_enabled?).with(feature_flag).and_return(true)
340

341
          expect(subject).to include(gitaly_params)
342
        end
343 344 345 346 347 348

        context 'show_all_refs enabled' do
          subject { described_class.git_http_ok(repository, false, user, action, show_all_refs: true) }

          it { is_expected.to include(ShowAllRefs: true) }
        end
349 350
      end

351 352 353
      context "when git_receive_pack action is passed" do
        let(:action) { 'git_receive_pack' }

354
        it { expect(subject).to include(gitaly_params) }
355 356
      end

357 358 359 360
      context "when info_refs action is passed" do
        let(:action) { 'info_refs' }

        it { expect(subject).to include(gitaly_params) }
361 362 363 364 365 366

        context 'show_all_refs enabled' do
          subject { described_class.git_http_ok(repository, false, user, action, show_all_refs: true) }

          it { is_expected.to include(ShowAllRefs: true) }
        end
367 368 369 370 371 372
      end

      context 'when action passed is not supported by Gitaly' do
        let(:action) { 'download' }

        it { expect { subject }.to raise_exception('Unsupported action: download') }
373 374 375
      end
    end
  end
K
Kamil Trzcinski 已提交
376

K
Kamil Trzcinski 已提交
377
  describe '.set_key_and_notify' do
K
Kamil Trzcinski 已提交
378 379 380
    let(:key) { 'test-key' }
    let(:value) { 'test-value' }

K
Kamil Trzcinski 已提交
381
    subject { described_class.set_key_and_notify(key, value, overwrite: overwrite) }
K
Kamil Trzcinski 已提交
382 383 384 385 386 387 388

    shared_examples 'set and notify' do
      it 'set and return the same value' do
        is_expected.to eq(value)
      end

      it 'set and notify' do
389
        expect_any_instance_of(::Redis).to receive(:publish)
K
Kamil Trzcinski 已提交
390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
          .with(described_class::NOTIFICATION_CHANNEL, "test-key=test-value")

        subject
      end
    end

    context 'when we set a new key' do
      let(:overwrite) { true }

      it_behaves_like 'set and notify'
    end

    context 'when we set an existing key' do
      let(:old_value) { 'existing-key' }

      before do
K
Kamil Trzcinski 已提交
406
        described_class.set_key_and_notify(key, old_value, overwrite: true)
K
Kamil Trzcinski 已提交
407 408 409 410 411 412 413 414 415 416 417 418 419 420 421
      end

      context 'and overwrite' do
        let(:overwrite) { true }

        it_behaves_like 'set and notify'
      end

      context 'and do not overwrite' do
        let(:overwrite) { false }

        it 'try to set but return the previous value' do
          is_expected.to eq(old_value)
        end

K
Kamil Trzcinski 已提交
422
        it 'does not notify' do
423
          expect_any_instance_of(::Redis).not_to receive(:publish)
K
Kamil Trzcinski 已提交
424 425 426 427 428 429

          subject
        end
      end
    end
  end
430 431 432 433 434 435 436 437

  describe '.send_git_blob' do
    include FakeBlobHelpers

    let(:blob) { fake_blob }

    subject { described_class.send_git_blob(repository, blob) }

438
    context 'when Gitaly workhorse_raw_show feature is enabled' do
439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq('Gitlab-Workhorse-Send-Data')
        expect(command).to eq('git-blob')
        expect(params).to eq({
          'GitalyServer' => {
            address: Gitlab::GitalyClient.address(project.repository_storage),
            token: Gitlab::GitalyClient.token(project.repository_storage)
          },
          'GetBlobRequest' => {
            repository: repository.gitaly_repository.to_h,
            oid: blob.id,
            limit: -1
          }
        }.deep_stringify_keys)
      end
    end

458
    context 'when Gitaly workhorse_raw_show feature is disabled', :skip_gitaly_mock do
459 460 461 462 463 464 465 466 467
      it 'sets the header correctly' do
        key, command, params = decode_workhorse_header(subject)

        expect(key).to eq('Gitlab-Workhorse-Send-Data')
        expect(command).to eq('git-blob')
        expect(params).to eq('RepoPath' => repository.path_to_repo, 'BlobId' => blob.id)
      end
    end
  end
468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484

  describe '.send_url' do
    let(:url) { 'http://example.com' }

    subject { described_class.send_url(url) }

    it 'sets the header correctly' do
      key, command, params = decode_workhorse_header(subject)

      expect(key).to eq("Gitlab-Workhorse-Send-Data")
      expect(command).to eq("send-url")
      expect(params).to eq({
        'URL' => url,
        'AllowRedirects' => false
      }.deep_stringify_keys)
    end
  end
485
end