merge_request.rb 15.4 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1
class MergeRequest < ActiveRecord::Base
2
  include InternalId
3 4
  include Issuable
  include Referable
5
  include Sortable
6
  include Taskable
7
  include Importable
8

9 10
  belongs_to :target_project, foreign_key: :target_project_id, class_name: "Project"
  belongs_to :source_project, foreign_key: :source_project_id, class_name: "Project"
Z
Zeger-Jan van de Weg 已提交
11
  belongs_to :merge_user, class_name: "User"
12

13
  has_one :merge_request_diff, dependent: :destroy
D
Dmitriy Zaporozhets 已提交
14

15 16
  has_many :events, as: :target, dependent: :destroy

Z
Zeger-Jan van de Weg 已提交
17 18
  serialize :merge_params, Hash

19
  after_create :create_merge_request_diff, unless: :importing
D
Dmitriy Zaporozhets 已提交
20
  after_update :update_merge_request_diff
21

J
Jacob Vosmaer 已提交
22
  delegate :commits, :diffs, :real_size, to: :merge_request_diff, prefix: nil
I
Izaak Alpert 已提交
23

D
Dmitriy Zaporozhets 已提交
24 25 26 27
  # When this attribute is true some MR validation is ignored
  # It allows us to close or modify broken merge requests
  attr_accessor :allow_broken

D
Dmitriy Zaporozhets 已提交
28 29
  # Temporary fields to store compare vars
  # when creating new merge request
J
Jacob Vosmaer 已提交
30
  attr_accessor :can_be_created, :compare_commits, :compare
D
Dmitriy Zaporozhets 已提交
31

32 33 34 35
  # Temporary fields to store target_sha, and base_sha to
  # compare when importing pull requests from GitHub
  attr_accessor :base_target_sha, :head_source_sha

A
Andrew8xx8 已提交
36
  state_machine :state, initial: :opened do
A
Andrew8xx8 已提交
37 38 39 40
    event :close do
      transition [:reopened, :opened] => :closed
    end

41
    event :mark_as_merged do
D
Dmitriy Zaporozhets 已提交
42
      transition [:reopened, :opened, :locked] => :merged
A
Andrew8xx8 已提交
43 44 45
    end

    event :reopen do
A
Andrew8xx8 已提交
46
      transition closed: :reopened
A
Andrew8xx8 已提交
47 48
    end

49
    event :lock_mr do
D
Dmitriy Zaporozhets 已提交
50 51 52
      transition [:reopened, :opened] => :locked
    end

53
    event :unlock_mr do
D
Dmitriy Zaporozhets 已提交
54 55 56
      transition locked: :reopened
    end

57 58 59 60 61
    after_transition any => :locked do |merge_request, transition|
      merge_request.locked_at = Time.now
      merge_request.save
    end

62
    after_transition locked: (any - :locked) do |merge_request, transition|
63 64 65 66
      merge_request.locked_at = nil
      merge_request.save
    end

A
Andrew8xx8 已提交
67 68 69 70
    state :opened
    state :reopened
    state :closed
    state :merged
D
Dmitriy Zaporozhets 已提交
71
    state :locked
A
Andrew8xx8 已提交
72 73
  end

74 75 76 77 78 79
  state_machine :merge_status, initial: :unchecked do
    event :mark_as_unchecked do
      transition [:can_be_merged, :cannot_be_merged] => :unchecked
    end

    event :mark_as_mergeable do
80
      transition [:unchecked, :cannot_be_merged] => :can_be_merged
81 82 83
    end

    event :mark_as_unmergeable do
84
      transition [:unchecked, :can_be_merged] => :cannot_be_merged
85 86
    end

87
    state :unchecked
88 89
    state :can_be_merged
    state :cannot_be_merged
90 91 92 93 94 95 96 97 98

    around_transition do |merge_request, transition, block|
      merge_request.record_timestamps = false
      begin
        block.call
      ensure
        merge_request.record_timestamps = true
      end
    end
99
  end
100

101
  validates :source_project, presence: true, unless: [:allow_broken, :importing?]
A
Andrey Kumanyaev 已提交
102
  validates :source_branch, presence: true
I
Izaak Alpert 已提交
103
  validates :target_project, presence: true
A
Andrey Kumanyaev 已提交
104
  validates :target_branch, presence: true
Z
Zeger-Jan van de Weg 已提交
105
  validates :merge_user, presence: true, if: :merge_when_build_succeeds?
106
  validate :validate_branches, unless: [:allow_broken, :importing?]
107
  validate :validate_fork
D
Dmitriy Zaporozhets 已提交
108

I
Izaak Alpert 已提交
109
  scope :by_branch, ->(branch_name) { where("(source_branch LIKE :branch) OR (target_branch LIKE :branch)", branch: branch_name) }
A
Andrew8xx8 已提交
110
  scope :cared, ->(user) { where('assignee_id = :user OR author_id = :user', user: user.id) }
111
  scope :by_milestone, ->(milestone) { where(milestone_id: milestone) }
112
  scope :of_projects, ->(ids) { where(target_project_id: ids) }
113
  scope :from_project, ->(project) { where(source_project_id: project.id) }
114 115
  scope :merged, -> { with_state(:merged) }
  scope :closed_and_merged, -> { with_states(:closed, :merged) }
116

117 118 119
  scope :join_project, -> { joins(:target_project) }
  scope :references_project, -> { references(:target_project) }

120 121 122 123
  def self.reference_prefix
    '!'
  end

124 125 126 127
  # Pattern used to extract `!123` merge request references from text
  #
  # This pattern supports cross-project references.
  def self.reference_pattern
128
    @reference_pattern ||= %r{
129
      (#{Project.reference_pattern})?
130 131 132 133
      #{Regexp.escape(reference_prefix)}(?<merge_request>\d+)
    }x
  end

134
  def self.link_reference_pattern
135
    @link_reference_pattern ||= super("merge_requests", /(?<merge_request>\d+)/)
136 137
  end

138 139 140 141
  def self.reference_valid?(reference)
    reference.to_i > 0 && reference.to_i <= Gitlab::Database::MAX_INT_VALUE
  end

142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159
  # Returns all the merge requests from an ActiveRecord:Relation.
  #
  # This method uses a UNION as it usually operates on the result of
  # ProjectsFinder#execute. PostgreSQL in particular doesn't always like queries
  # using multiple sub-queries especially when combined with an OR statement.
  # UNIONs on the other hand perform much better in these cases.
  #
  # relation - An ActiveRecord::Relation that returns a list of Projects.
  #
  # Returns an ActiveRecord::Relation.
  def self.in_projects(relation)
    source = where(source_project_id: relation).select(:id)
    target = where(target_project_id: relation).select(:id)
    union  = Gitlab::SQL::Union.new([source, target])

    where("merge_requests.id IN (#{union.to_sql})")
  end

160 161 162 163 164 165 166 167 168 169
  def to_reference(from_project = nil)
    reference = "#{self.class.reference_prefix}#{iid}"

    if cross_project_reference?(from_project)
      reference = project.to_reference + reference
    end

    reference
  end

170 171
  def last_commit
    merge_request_diff ? merge_request_diff.last_commit : compare_commits.last
172
  end
173 174 175

  def first_commit
    merge_request_diff ? merge_request_diff.first_commit : compare_commits.first
176
  end
177

J
Jacob Vosmaer 已提交
178 179 180 181
  def diff_size
    merge_request_diff.size
  end

182 183 184
  def diff_base_commit
    if merge_request_diff
      merge_request_diff.base_commit
D
Douwe Maan 已提交
185
    elsif source_sha
186
      self.target_project.merge_base_commit(self.source_sha, self.target_branch)
187 188 189
    end
  end

190 191 192 193
  def last_commit_short_sha
    last_commit.short_id
  end

194
  def validate_branches
195
    if target_project == source_project && target_branch == source_branch
I
Izaak Alpert 已提交
196
      errors.add :branch_conflict, "You can not use same project/branch for source and target"
197
    end
198

199
    if opened? || reopened?
200
      similar_mrs = self.target_project.merge_requests.where(source_branch: source_branch, target_branch: target_branch, source_project_id: source_project.try(:id)).opened
201 202
      similar_mrs = similar_mrs.where('id not in (?)', self.id) if self.id
      if similar_mrs.any?
J
jubianchi 已提交
203
        errors.add :validate_branches,
G
Gabriel Mazetto 已提交
204
                   "Cannot Create: This merge request already exists: #{similar_mrs.pluck(:title)}"
205
      end
206
    end
207 208
  end

209
  def validate_fork
210 211 212
    return true unless target_project && source_project

    if target_project == source_project
213 214 215 216 217 218 219
      true
    else
      # If source and target projects are different
      # we should check if source project is actually a fork of target project
      if source_project.forked_from?(target_project)
        true
      else
J
jubianchi 已提交
220 221
        errors.add :validate_fork,
                   'Source project is not a fork of target project'
222 223 224 225
      end
    end
  end

D
Dmitriy Zaporozhets 已提交
226 227 228 229 230 231
  def update_merge_request_diff
    if source_branch_changed? || target_branch_changed?
      reload_code
    end
  end

232
  def reload_code
233
    if merge_request_diff && open?
234 235
      merge_request_diff.reload_content
    end
236 237
  end

238
  def check_if_can_be_merged
239 240
    return unless unchecked?

241
    can_be_merged =
242
      !broken? && project.repository.can_be_merged?(source_sha, target_branch)
243 244

    if can_be_merged
245 246 247 248
      mark_as_mergeable
    else
      mark_as_unmergeable
    end
249 250
  end

D
Dmitriy Zaporozhets 已提交
251
  def merge_event
I
Izaak Alpert 已提交
252
    self.target_project.events.where(target_id: self.id, target_type: "MergeRequest", action: Event::MERGED).last
D
Dmitriy Zaporozhets 已提交
253 254
  end

255
  def closed_event
I
Izaak Alpert 已提交
256
    self.target_project.events.where(target_id: self.id, target_type: "MergeRequest", action: Event::CLOSED).last
257 258
  end

259
  WIP_REGEX = /\A\s*(\[WIP\]\s*|WIP:\s*|WIP\s+)+\s*/i.freeze
260

261
  def work_in_progress?
262
    !!(title =~ WIP_REGEX)
263 264 265 266
  end

  def wipless_title
    self.title.sub(WIP_REGEX, "")
267 268
  end

269 270
  def mergeable?(skip_ci_check: false)
    return false unless mergeable_state?(skip_ci_check: skip_ci_check)
271 272 273 274

    check_if_can_be_merged

    can_be_merged?
275 276
  end

277
  def mergeable_state?(skip_ci_check: false)
278 279 280
    return false unless open?
    return false if work_in_progress?
    return false if broken?
281
    return false unless skip_ci_check || mergeable_ci_state?
282 283

    true
284 285
  end

286 287
  def can_cancel_merge_when_build_succeeds?(current_user)
    can_be_merged_by?(current_user) || self.author == current_user
288 289
  end

290 291 292
  def can_remove_source_branch?(current_user)
    !source_project.protected_branch?(source_branch) &&
      !source_project.root_ref?(source_branch) &&
293 294
      Ability.abilities.allowed?(current_user, :push_code, source_project) &&
      last_commit == source_project.commit(source_branch)
295 296
  end

297 298 299 300 301 302 303 304 305 306 307 308
  def should_remove_source_branch?
    merge_params['should_remove_source_branch'].present?
  end

  def force_remove_source_branch?
    merge_params['force_remove_source_branch'].present?
  end

  def remove_source_branch?
    should_remove_source_branch? || force_remove_source_branch?
  end

309
  def mr_and_commit_notes
310 311 312 313
    # Fetch comments only from last 100 commits
    commits_for_notes_limit = 100
    commit_ids = commits.last(commits_for_notes_limit).map(&:id)

314 315
    Note.where(
      "(project_id = :target_project_id AND noteable_type = 'MergeRequest' AND noteable_id = :mr_id) OR" +
316
      "((project_id = :source_project_id OR project_id = :target_project_id) AND noteable_type = 'Commit' AND commit_id IN (:commit_ids))",
317
      mr_id: id,
318 319 320
      commit_ids: commit_ids,
      target_project_id: target_project_id,
      source_project_id: source_project_id
321
    )
322
  end
323

K
Kirill Zaitsev 已提交
324 325
  def hook_attrs
    attrs = {
326
      source: source_project.try(:hook_attrs),
K
Kirill Zaitsev 已提交
327
      target: target_project.hook_attrs,
328 329
      last_commit: nil,
      work_in_progress: work_in_progress?
K
Kirill Zaitsev 已提交
330 331
    }

V
Valery Sizov 已提交
332
    if last_commit
333
      attrs.merge!(last_commit: last_commit.hook_attrs)
K
Kirill Zaitsev 已提交
334 335 336 337 338
    end

    attributes.merge!(attrs)
  end

I
Izaak Alpert 已提交
339 340 341 342
  def for_fork?
    target_project != source_project
  end

343 344 345 346
  def project
    target_project
  end

347 348 349 350
  def closes_issue?(issue)
    closes_issues.include?(issue)
  end

351
  # Return the set of issues that will be closed if this merge request is accepted.
352
  def closes_issues(current_user = self.author)
353
    if target_branch == project.default_branch
354 355 356 357
      messages = commits.map(&:safe_message) << description

      Gitlab::ClosingIssueExtractor.new(project, current_user).
        closed_by_message(messages.join("\n"))
358 359 360 361 362
    else
      []
    end
  end

363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
  def target_project_path
    if target_project
      target_project.path_with_namespace
    else
      "(removed)"
    end
  end

  def source_project_path
    if source_project
      source_project.path_with_namespace
    else
      "(removed)"
    end
  end

379 380 381 382 383 384 385 386
  def source_project_namespace
    if source_project && source_project.namespace
      source_project.namespace.path
    else
      "(removed)"
    end
  end

387 388 389 390 391 392 393 394
  def target_project_namespace
    if target_project && target_project.namespace
      target_project.namespace.path
    else
      "(removed)"
    end
  end

395 396 397 398 399 400 401 402 403 404 405 406
  def source_branch_exists?
    return false unless self.source_project

    self.source_project.repository.branch_names.include?(self.source_branch)
  end

  def target_branch_exists?
    return false unless self.target_project

    self.target_project.repository.branch_names.include?(self.target_branch)
  end

D
Drew Blessing 已提交
407 408 409 410 411 412 413 414 415
  # Reset merge request events cache
  #
  # Since we do cache @event we need to reset cache in special cases:
  # * when a merge request is updated
  # Events cache stored like  events/23-20130109142513.
  # The cache key includes updated_at timestamp.
  # Thus it will automatically generate a new fragment
  # when the event is updated because the key changes.
  def reset_events_cache
416
    Event.reset_event_cache_for(self)
D
Drew Blessing 已提交
417 418
  end

419 420 421
  def merge_commit_message
    message = "Merge branch '#{source_branch}' into '#{target_branch}'"
    message << "\n\n"
D
Dmitriy Zaporozhets 已提交
422
    message << title.to_s
423
    message << "\n\n"
D
Dmitriy Zaporozhets 已提交
424
    message << description.to_s
425 426
    message << "\n\n"
    message << "See merge request !#{iid}"
D
Dmitriy Zaporozhets 已提交
427
    message
428
  end
429

Z
Zeger-Jan van de Weg 已提交
430 431
  def reset_merge_when_build_succeeds
    return unless merge_when_build_succeeds?
432

Z
Zeger-Jan van de Weg 已提交
433 434
    self.merge_when_build_succeeds = false
    self.merge_user = nil
435 436 437 438
    if merge_params
      merge_params.delete('should_remove_source_branch')
      merge_params.delete('commit_message')
    end
Z
Zeger-Jan van de Weg 已提交
439 440 441 442

    self.save
  end

443
  # Return array of possible target branches
S
Steven Burgart 已提交
444
  # depends on target project of MR
445 446 447 448 449 450 451 452 453
  def target_branches
    if target_project.nil?
      []
    else
      target_project.repository.branch_names
    end
  end

  # Return array of possible source branches
S
Steven Burgart 已提交
454
  # depends on source project of MR
455 456 457 458 459 460 461
  def source_branches
    if source_project.nil?
      []
    else
      source_project.repository.branch_names
    end
  end
462 463

  def locked_long_ago?
B
Ben Bodenmiller 已提交
464 465 466
    return false unless locked?

    locked_at.nil? || locked_at < (Time.now - 1.day)
467
  end
468 469 470 471 472 473 474 475

  def has_ci?
    source_project.ci_service && commits.any?
  end

  def branch_missing?
    !source_branch_exists? || !target_branch_exists?
  end
476

477 478 479 480
  def broken?
    self.commits.blank? || branch_missing? || cannot_be_merged?
  end

481 482 483
  def can_be_merged_by?(user)
    ::Gitlab::GitAccess.new(user, project).can_push_to_branch?(target_branch)
  end
484

485 486
  def mergeable_ci_state?
    return true unless project.only_allow_merge_if_build_succeeds?
487

R
Rémy Coutable 已提交
488
    !pipeline || pipeline.success?
489 490
  end

491 492 493 494 495 496 497 498 499
  def state_human_name
    if merged?
      "Merged"
    elsif closed?
      "Closed"
    else
      "Open"
    end
  end
500

501 502 503 504 505 506 507 508 509 510
  def state_icon_name
    if merged?
      "check"
    elsif closed?
      "times"
    else
      "circle-o"
    end
  end

511
  def target_sha
512 513 514
    return @base_target_sha if defined?(@base_target_sha)

    target_project.repository.commit(target_branch).try(:sha)
515 516 517
  end

  def source_sha
518 519
    return @head_source_sha if defined?(@head_source_sha)

520 521 522 523 524
    last_commit.try(:sha) || source_tip.try(:sha)
  end

  def source_tip
    source_branch && source_project.repository.commit(source_branch)
525 526 527 528 529 530
  end

  def fetch_ref
    target_project.repository.fetch_ref(
      source_project.repository.path_to_repo,
      "refs/heads/#{source_branch}",
531
      ref_path
532 533 534
    )
  end

535 536 537 538 539
  def ref_path
    "refs/merge-requests/#{iid}/head"
  end

  def ref_is_fetched?
540
    File.exist?(File.join(project.repository.path_to_repo, ref_path))
541 542 543 544 545 546
  end

  def ensure_ref_fetched
    fetch_ref unless ref_is_fetched?
  end

547 548 549 550 551 552 553 554
  def in_locked_state
    begin
      lock_mr
      yield
    ensure
      unlock_mr if locked?
    end
  end
555

556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
  def diverged_commits_count
    cache = Rails.cache.read(:"merge_request_#{id}_diverged_commits")

    if cache.blank? || cache[:source_sha] != source_sha || cache[:target_sha] != target_sha
      cache = {
        source_sha: source_sha,
        target_sha: target_sha,
        diverged_commits_count: compute_diverged_commits_count
      }
      Rails.cache.write(:"merge_request_#{id}_diverged_commits", cache)
    end

    cache[:diverged_commits_count]
  end

  def compute_diverged_commits_count
572 573
    return 0 unless source_sha && target_sha

574 575
    Gitlab::Git::Commit.between(target_project.repository.raw_repository, source_sha, target_sha).size
  end
576
  private :compute_diverged_commits_count
577 578 579 580 581

  def diverged_from_target_branch?
    diverged_commits_count > 0
  end

582 583
  def pipeline
    @pipeline ||= source_project.pipeline(last_commit.id, source_branch) if last_commit && source_project
584
  end
585

D
Douwe Maan 已提交
586
  def diff_refs
587 588 589
    return nil unless diff_base_commit

    [diff_base_commit, last_commit]
590
  end
591 592 593 594 595

  def merge_commit
    @merge_commit ||= project.commit(merge_commit_sha) if merge_commit_sha
  end

596 597
  def can_be_reverted?(current_user = nil)
    merge_commit && !merge_commit.has_been_reverted?(current_user, self)
598
  end
599 600 601 602

  def can_be_cherry_picked?
    merge_commit
  end
D
Dmitriy Zaporozhets 已提交
603
end