Skip to content

G
git

李少辉-开发者 / git
与 Fork 源项目一致

从无法访问的项目Fork

通知 2
Star 1
Fork 0
G
git

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 20 1月, 2011 7 次提交
  3. 13 1月, 2011 1 次提交
  5. 11 1月, 2011 5 次提交
  7. 09 1月, 2011 1 次提交
  9. 06 1月, 2011 1 次提交
  11. 05 1月, 2011 1 次提交
  13. 30 12月, 2010 1 次提交
  15. 29 12月, 2010 7 次提交
  17. 27 12月, 2010 2 次提交
  19. 23 12月, 2010 2 次提交
  21. 22 12月, 2010 3 次提交
  23. 21 12月, 2010 2 次提交
    • J
      commit: die before asking to edit the log message · 4c28e4ad
      由 Junio C Hamano 提交于 
      When determine_author_info() returns to the calling prepare_to_commit(),
we already know the pieces of information necessary to determine what
author ident will be used in the final message, but deferred making a call
to fmt_ident() before the final commit_tree().  Most importantly, we would
open the editor to ask the user to compose the log message before it.

As one important side effect of fmt_ident() is to error out when the given
information is malformed, this resulted in us spawning the editor first
and then refusing to commit due to error, even though we had enough
information to detect the error before starting the editor, which was
annoying.

Move the fmt_ident() call to the end of determine_author_info() where we
have final determination of author info to rectify this.
Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      4c28e4ad
    • J
      ident: die on bogus date format · 4579bb41
      由 Jeff King 提交于 
      If the user gives "git commit --date=foobar", we silently
ignore the --date flag. We should note the error.

This patch puts the fix at the lowest level of fmt_ident,
which means it also handles GIT_AUTHOR_DATE=foobar, as well.

There are two down-sides to this approach:

  1. Technically this breaks somebody doing something like
     "git commit --date=now", which happened to work because
     bogus data is the same as "now". Though we do
     explicitly handle the empty string, so anybody passing
     an empty variable through the environment will still
     work.

     If the error is too much, perhaps it can be downgraded
     to a warning?

  2. The error checking happens _after_ the commit message
     is written, which can be annoying to the user. We can
     put explicit checks closer to the beginning of
     git-commit, but that feels a little hack-ish; suddenly
     git-commit has to care about how fmt_ident works. Maybe
     we could simply call fmt_ident earlier?
Signed-off-by: NJeff King <peff@peff.net>
Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      4579bb41
  25. 20 12月, 2010 2 次提交
  27. 19 12月, 2010 3 次提交
  29. 18 12月, 2010 2 次提交