1. 07 3月, 2012 12 次提交
  2. 06 3月, 2012 7 次提交
  3. 05 3月, 2012 16 次提交
  4. 03 3月, 2012 5 次提交
    • M
      t0300: work around bug in dash 0.5.6 · 78ed1d2d
      Michael J Gruber 提交于
      The construct 'while IFS== read' makes dash 0.5.6 execute
      read without changing IFS, which results in test breakages
      all over the place in t0300.  Neither dash 0.5.5.1 and older
      nor dash 0.5.7 and newer are affected: The problem was
      introduded resp. fixed by the commits
      
        55c46b7 ([BUILTIN] Honor tab as IFS whitespace when
                 splitting fields in readcmd, 2009-08-11)
      
        1d806ac ([VAR] Do not poplocalvars prematurely on regular
                 utilities, 2010-05-27)
      
      in http://git.kernel.org/?p=utils/dash/dash.git
      
      Putting 'IFS==' before that line makes all versions of dash
      work.
      
      This looks like a dash bug, not a misinterpretation of the
      standard. However, it's worth working around for two
      reasons. One, this version of dash was released in Fedora
      14-16, so the bug is found in the wild. And two, at least
      one other shell, Solaris /bin/sh, choked on this by
      persisting IFS after the read invocation. That is not a
      shell we usually care about, and I think this use of IFS is
      acceptable by POSIX (which allows other behavior near
      "special builtins", but "read" is not one of those). But it
      seems that this may be a subtle, not-well-tested case for
      some shells. Given that the workaround is so simple, it's
      worth just being defensive.
      Signed-off-by: NMichael J Gruber <git@drmicha.warpmail.net>
      Signed-off-by: NJeff King <peff@peff.net>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      78ed1d2d
    • T
      t5512 (ls-remote): modernize style · fe6c64ab
      Tom Grennan 提交于
      Prepare expected output inside test_expect_success that uses it.
      Also remove excess blank lines.
      Signed-off-by: NTom Grennan <tmgrennan@gmail.com>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      fe6c64ab
    • J
      gitweb: Fix passing parameters to git_project_search_form · b22939a2
      Jakub Narebski 提交于
      The git_project_search_form() subroutine, introduced in a1e1b2d7
      (gitweb: improve usability of projects search form, 2012-01-31) didn't
      get its arguments from caller correctly.  Gitweb worked correctly
      thanks to sticky-ness of form fields in CGI.pm... but it make UTF-8
      fix for project search not working.
      Signed-off-by: NJakub Narebski <jnareb@gmail.com>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      b22939a2
    • S
      t0000: modernise style · 1b5b2b64
      Stefano Lattarini 提交于
      Match the style to more modern test scripts, namely:
      
       - Prefer tabs for indentation.
      
       - The first line of each test has prereq, title and opening sq for the
         script body.
      
       - Move cleanup or initialization of data used by a test inside the test
         itself.
      
       - Put a newline before the closing sq for each test.
      
       - Don't conclude the test descriptions with a full stop.
      
       - Prefer 'test_line_count = COUNT FILE' over 'test $(wc -l <FILE) = COUNT'
      
       - Prefer 'test_line_count = 0 FILE' over 'cmp -s /dev/null FILE'
      
       - Use '<<-EOF' style for here documents, so that they can be indented
         as well.  Bot don't do that in case the resulting lines would be too
         long.  Also when there is no $variable_substitution in the body of a
         here document, quote \EOF.
      
       - Don't redirect the output of commands to /dev/null unconditionally,
         the git testing framework should already take care of handling test
         verbosity transparently and uniformly.
      Signed-off-by: NStefano Lattarini <stefano.lattarini@gmail.com>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      1b5b2b64
    • S
      tests: fix spurious error when run directly with Solaris /usr/xpg4/bin/sh · 661bfd13
      Stefano Lattarini 提交于
      If any test script is run directly with Solaris 10 /usr/xpg4/bin/sh or
      /bin/ksh, it fails spuriously with a message like:
      
        t0000-basic.sh[31]: unset: bad argument count
      
      This happens because those shells bail out when encountering a call to
      "unset" with no arguments, and such unset call could take place in
      'test-lib.sh'.  Fix that issue, and add a proper comment to ensure we
      don't regress in this respect.
      Signed-off-by: NStefano Lattarini <stefano.lattarini@gmail.com>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      661bfd13