1. 16 3月, 2010 1 次提交
    • J
      refs: ref entry with NULL sha1 is can be a dangling symref · e01de1c9
      Junio C Hamano 提交于
      Brandon Casey noticed that t5505 had accidentally broken its && chain,
      hiding inconsistency between the code that writes the warning to the
      standard output and the test that expects to see the warning on the
      standard error, which was introduced by f8948e2f (remote prune: warn
      dangling symrefs, 2009-02-08).
      
      It turns out that the issue is deeper than that.  After f8948e2f, a symref
      that is dangling is marked with a NULL sha1, and the idea of using NULL
      sha1 to mean a deleted ref was scrapped, but somehow a follow-up eafb4526
      (do_one_ref(): null_sha1 check is not about broken ref, 2009-07-22)
      incorrectly reorganized do_one_ref(), still thinking NULL sha1 is never
      used in the code.
      
      Fix this by:
      
       - adopt Brandon's fix to t5505 test;
      
       - introduce REF_BROKEN flag to mark a ref that fails to resolve (dangling
         symref);
      
       - move the check for broken ref back inside the "if we are skipping
         dangling refs" code block.
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      e01de1c9
  2. 19 1月, 2010 1 次提交
    • J
      Merge branch 'maint-1.6.2' into maint-1.6.3 · 011c181c
      Junio C Hamano 提交于
      * maint-1.6.2:
        base85: Make the code more obvious instead of explaining the non-obvious
        base85: encode_85() does not use the decode table
        base85 debug code: Fix length byte calculation
        checkout -m: do not try to fall back to --merge from an unborn branch
        branch: die explicitly why when calling "git branch [-a|-r] branchname".
        textconv: stop leaking file descriptors
        commit: --cleanup is a message option
        git count-objects: handle packs bigger than 4G
        t7102: make the test fail if one of its check fails
      
      Conflicts:
      	diff.c
      011c181c
  3. 10 1月, 2010 5 次提交
  4. 07 1月, 2010 1 次提交
  5. 01 1月, 2010 1 次提交
  6. 30 12月, 2009 5 次提交
  7. 04 9月, 2009 2 次提交
  8. 03 9月, 2009 2 次提交
    • G
      git-cvsserver: no longer use deprecated 'git-subcommand' commands · d2feb01a
      Gerrit Pape 提交于
      git-cvsserver still references git commands like 'git-config', which
      is depcrecated.  This commit changes git-cvsserver to use the
      'git subcommand' form.
      
      Sylvain Beucler reported the problem through
       http://bugs.debian.org/536067Signed-off-by: NGerrit Pape <pape@smarden.org>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      d2feb01a
    • J
      clone: disconnect transport after fetching · 12d49966
      Jeff King 提交于
      The current code just leaves the transport in whatever state
      it was in after performing the fetch.  For a non-empty clone
      over the git protocol, the transport code already
      disconnects at the end of the fetch.
      
      But for an empty clone, we leave the connection hanging, and
      eventually close the socket when clone exits. This causes
      the remote upload-pack to complain "the remote end hung up
      unexpectedly". While this message is harmless to the clone
      itself, it is unnecessarily scary for a user to see and may
      pollute git-daemon logs.
      
      This patch just explicitly calls disconnect after we are
      done with the remote end, which sends a flush packet to
      upload-pack and cleanly disconnects, avoiding the error
      message.
      
      Other transports are unaffected or slightly improved:
      
       - for a non-empty repo over the git protocol, the second
         disconnect is a no-op (since we are no longer connected)
      
       - for "walker" transports (like HTTP or FTP), we actually
         free some used memory (which previously just sat until
         the clone process exits)
      
       - for "rsync", disconnect is always a no-op anyway
      Signed-off-by: NJeff King <peff@peff.net>
      Acked-by: NDaniel Barkalow <barkalow@iabervon.org>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      12d49966
  9. 28 8月, 2009 7 次提交
  10. 27 8月, 2009 1 次提交
  11. 16 8月, 2009 2 次提交
    • T
      add -p: do not attempt to coalesce mode changes · 3d792161
      Thomas Rast 提交于
      In 0392513f (add-interactive: refactor mode hunk handling, 2009-04-16),
      we merged the interaction loops for mode changes and hunk staging.
      This was fine at the time, because 0beee4c6 (git-add--interactive:
      remove hunk coalescing, 2008-07-02) removed hunk coalescing.
      
      However, in 7a26e653 (Revert "git-add--interactive: remove hunk
      coalescing", 2009-05-16), we resurrected it.  Since then, the code
      would attempt in vain to merge mode changes with diff hunks,
      corrupting both in the process.
      
      We add a check to the coalescing loop to ensure it only looks at diff
      hunks, thus skipping mode changes.
      Noticed-by: NKirill Smelkov <kirr@mns.spb.ru>
      Signed-off-by: NThomas Rast <trast@student.ethz.ch>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      3d792161
    • K
      git add -p: demonstrate failure when staging both mode and hunk · 87ca2eaa
      Kirill Smelkov 提交于
      When trying to stage changes to file which has also pending `chmod +x`,
      `git add -p` produces lots of 'Use of uninitialized value ...' warnings
      and fails to do the job:
      
          $ echo content >> file
          $ chmod +x file
          $ git add -p
          diff --git a/file b/file
          index e69de29..d95f3ad
          --- a/file
          +++ b/file
          old mode 100644
          new mode 100755
          Stage mode change [y,n,q,a,d,/,j,J,g,?]? y
          @@ -0,0 +1 @@
          +content
          Stage this hunk [y,n,q,a,d,/,K,g,e,?]? y
          Use of uninitialized value $o_ofs in addition (+) at .../git-add--interactive line 776.
          Use of uninitialized value $ofs in numeric le (<=) at .../git-add--interactive line 806.
          Use of uninitialized value $o0_ofs in concatenation (.) or string at .../git-add--interactive line 830.
          Use of uninitialized value $n0_ofs in concatenation (.) or string at .../git-add--interactive line 830.
          Use of uninitialized value $o_ofs in addition (+) at .../git-add--interactive line 776.
          fatal: corrupt patch at line 5
          diff --git a/file b/file
          index e69de29..d95f3ad
          --- a/file
          +++ b/file
          @@ -,0 + @@
          +content
      Signed-off-by: NKirill Smelkov <kirr@mns.spb.ru>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      87ca2eaa
  12. 13 8月, 2009 3 次提交
  13. 11 8月, 2009 1 次提交
  14. 08 8月, 2009 5 次提交
  15. 06 8月, 2009 1 次提交
  16. 05 8月, 2009 2 次提交