Skip to content

G
git

李少辉-开发者 / git
与 Fork 源项目一致

从无法访问的项目Fork

通知 2
Star 1
Fork 0
G
git

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 06 1月, 2009 1 次提交
  3. 04 1月, 2009 3 次提交
  5. 03 1月, 2009 2 次提交
    • J
      builtin-apply: prevent non-explicit permission changes · 1f7903a3
      由 Junio C Hamano 提交于 
      A git patch that does not change the executable bit records the mode bits
on its "index" line.  "git apply" used to interpret this mode exactly the
same way as it interprets the mode recorded on "new mode" line, as the
wish by the patch submitter to set the mode to the one recorded on the
line.

The reason the mode does not agree between the submitter and the receiver
in the first place is because there is _another_ commit that only appears
on one side but not the other since their histories diverged, and that
commit changes the mode.  The patch has "index" line but not "new mode"
line because its change is about updating the contents without affecting
the mode.  The application of such a patch is an explicit wish by the
submitter to only cherry-pick the commit that updates the contents without
cherry-picking the commit that modifies the mode.  Viewed this way, the
current behaviour is problematic, even though the command does warn when
the mode of the path being patched does not match this mode, and a careful
user could detect this inconsistencies between the patch submitter and the
patch receiver.

This changes the semantics of the mode recorded on the "index" line;
instead of interpreting it as the submitter's wish to set the mode to the
recorded value, it merely informs what the mode submitter happened to
have, and the presense of the "index" line is taken as submitter's wish to
keep whatever the mode is on the receiving end.

This is based on the patch originally done by Alexander Potashev with a
minor fix; the tests are mine.
Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      1f7903a3
    • J
      git wrapper: Make while loop more reader-friendly · cca17048
      由 Johannes Schindelin 提交于 
      It is not a good practice to prefer performance over readability in
something as performance uncritical as finding the trailing slash
of argv[0].

So avoid head-scratching by making the loop user-readable, and not
hyper-performance-optimized.
Signed-off-by: NJohannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      cca17048
  7. 01 1月, 2009 3 次提交
  9. 29 12月, 2008 7 次提交
  11. 28 12月, 2008 11 次提交
  13. 27 12月, 2008 5 次提交
  15. 25 12月, 2008 1 次提交
  17. 24 12月, 2008 2 次提交
  19. 23 12月, 2008 1 次提交
  21. 22 12月, 2008 4 次提交